[{"id":1775096,"web_url":"http://patchwork.ozlabs.org/comment/1775096/","msgid":"<59C9BAA8.5040906@samsung.com>","list_archive_url":null,"date":"2017-09-26T02:25:44","subject":"Re: [PATCH 8/8] extcon: gpio: Always check state on resume","submitter":{"id":46832,"url":"http://patchwork.ozlabs.org/api/people/46832/","name":"Chanwoo Choi","email":"cw00.choi@samsung.com"},"content":"Hi Linus,\n\nOn 2017년 09월 24일 23:56, Linus Walleij wrote:\n> It makes most sense to always check the state of the GPIO external\n> connector at system resume so just do this by default. Add a TODO\n> if people turn out to desire to parameterize this.\n> \n> Signed-off-by: Linus Walleij \n> ---\n> drivers/extcon/extcon-gpio.c | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n\nLooks good to me.\nAcked-by: Chanwoo Choi \n\n> \n> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c\n> index b7353f5018b5..4f0ad5ad2722 100644\n> --- a/drivers/extcon/extcon-gpio.c\n> +++ b/drivers/extcon/extcon-gpio.c\n> @@ -83,6 +83,15 @@ static int gpio_extcon_probe(struct platform_device *pdev)\n> \tif (!data)\n> \t\treturn -ENOMEM;\n> \n> +\t/*\n> +\t * Always checking connector state on resume makes most sense so do this\n> +\t * by default.\n> +\t *\n> +\t * TODO: if parameterization is needed, augment this to use proper device\n> +\t * properties or set it up from PM core.\n> +\t */\n> +\tdata->check_on_resume = true;\n> +\n> \tdata->gpiod = devm_gpiod_get(dev, \"extcon\", GPIOD_IN);\n> \tif (IS_ERR(data->gpiod))\n> \t\treturn PTR_ERR(data->gpiod);\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1PvJ6pf1z9sPk\n\tfor ;\n\tTue, 26 Sep 2017 12:25:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S966363AbdIZCZr (ORCPT );\n\tMon, 25 Sep 2017 22:25:47 -0400","from mailout4.samsung.com ([203.254.224.34]:64684 \"EHLO\n\tmailout4.samsung.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S965067AbdIZCZq (ORCPT\n\t); Mon, 25 Sep 2017 22:25:46 -0400","from epcas1p1.samsung.com (unknown [182.195.41.45])\n\tby mailout4.samsung.com (KnoxPortal) with ESMTP id\n\t20170926022544epoutp0417e4356f34465be8e797e8812f624f8f~nyDhHpKwl3079830798epoutp04H;\n\tTue, 26 Sep 2017 02:25:44 +0000 (GMT)","from epsmges2p4.samsung.com (unknown [182.195.40.69]) by\n\tepcas1p4.samsung.com (KnoxPortal) with ESMTP id\n\t20170926022544epcas1p4a1a4dcb7523a1117b783fc60e16b4859~nyDg0MW2U1059710597epcas1p4Q;\n\tTue, 26 Sep 2017 02:25:44 +0000 (GMT)","from epcas2p1.samsung.com ( [182.195.41.53]) by\n\tepsmges2p4.samsung.com (Symantec Messaging Gateway) with SMTP id\n\tA5.66.04101.8AAB9C95; Tue, 26 Sep 2017 11:25:44 +0900 (KST)","from epsmgms2p2new.samsung.com (unknown [182.195.42.143]) by\n\tepcas2p1.samsung.com (KnoxPortal) with ESMTP id\n\t20170926022543epcas2p1615a41fe2b4ceb37bb15b6d8716cbc1f~nyDgBgPPl2730827308epcas2p1B;\n\tTue, 26 Sep 2017 02:25:43 +0000 (GMT)","from epmmp2 ( [203.254.227.17]) by epsmgms2p2new.samsung.com\n\t(Symantec Messaging Gateway) with SMTP id 14.16.06856.7AAB9C95;\n\tTue, 26 Sep 2017 11:25:43 +0900 (KST)","from [10.113.62.212] by mmp2.samsung.com (Oracle Communications\n\tMessaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id\n\t<0OWV006EG82UDA40@mmp2.samsung.com>;\n\tTue, 26 Sep 2017 11:25:43 +0900 (KST)"],"X-AuditID":"b6c32a48-c0fff70000001005-9a-59c9baa85ca8","MIME-version":"1.0","Content-transfer-encoding":"8BIT","Content-type":"text/plain; charset=\"UTF-8\"","Message-id":"<59C9BAA8.5040906@samsung.com>","Date":"Tue, 26 Sep 2017 11:25:44 +0900","From":"Chanwoo Choi ","Organization":"Samsung Electronics","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101\n\tThunderbird/31.6.0","To":"Linus Walleij ,\n\tMyungJoo Ham ","Cc":"linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,\n\tJohn Stultz , Guenter Roeck ","Subject":"Re: [PATCH 8/8] extcon: gpio: Always check state on resume","In-reply-to":"<20170924145622.4031-9-linus.walleij@linaro.org>","X-Brightmail-Tracker":["H4sIAAAAAAAAA+NgFvrEKsWRmVeSWpSXmKPExsWy7bCmqe6KXScjDZauY7E481vXYsqf5UwW\n\tm+f/YbS4vGsOm8WThWeYLG43rmBzYPO4c20Pm8fO7w3sHn1bVjF6fN4kF8ASlWqTkZqYklqk\n\tkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RbSaEsMacUKBSQWFys\n\tpG9nU5RfWpKqkJFfXGKrFG1oaKRnaGCuZ2RkpGdiHGtlZApUkpCasePdZpaC/5wVb5tusjUw\n\t/mLvYuTkkBAwkbiz9zJTFyMXh5DADkaJPfdXsEE43xklDi2bzQZTdeDKUSYQW0hgA6PEjf3h\n\tIDavgKDEj8n3WLoYOTiYBeQljlzKBgkzC2hKbN29nh1izj1GiSfrPzJC1GtJvHz+EWwOi4Cq\n\txOYnJ8BsNqD4/hc3wHbxCyhKXP3xGKxeVCBCYuf8b2CXigiES+w7doAZZCizQAejxJsdEAlh\n\tAWeJ7vsbwZo5BWwlrqz4zApSJCFwgE3i3/SDUH+6SDw7do4RwhaWeHV8C1RcWuLZqo2MEA3t\n\tjBKb54C8A+IArbi/spEVospY4lRXIxPEc3wSHYf/soP8LCHAK9HRJgRR4iFx9yzEaxICjhKz\n\tp+1jhvj/MKPEv6P/WScwys1CCrJZiCCbhRRkCxiZVzGKpRYU56anFhsVmOgVJ+YWl+al6yXn\n\t525iBKc3LY8djAfO+RxiFOBgVOLhbWA6GSnEmlhWXJl7iFGCg1lJhPf6dqAQb0piZVVqUX58\n\tUWlOavEhRlNgiE9klhJNzgem3rySeEMTSwMTMzMjczMLYBIT563bdi1CSCA9sSQ1OzW1ILUI\n\tpo+Jg1OqgfGk3eF3Mft/BDVfybfnU1I4EW39gt1tp7lJ/f7dAU8F/ZbumltZtCH89/nqq4rv\n\tzvDOVOjRDAn1EmreI//y46mfiof2vK1I0HwbqC/OECjmvmd1C1Ph+YS/2x5sPmLByTfP44XQ\n\thszPW+drP17bEfZZ5R1/Em/9axtp9uvFK7JXGMSt/f3/pKISS3FGoqEWc1FxIgD9nqkXhQMA\n\tAA==","H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t9jQd3lu05GGsw/zW1x5reuxZQ/y5ks\n\tNs//w2hxedccNosnC88wWdxuXMHmwOZx59oeNo+d3xvYPfq2rGL0+LxJLoAlissmJTUnsyy1\n\tSN8ugStjx7vNLAX/OSveNt1ka2D8xd7FyMkhIWAiceDKUaYuRi4OIYF1jBLreh6zgiR4BQQl\n\tfky+x9LFyMHBLCAvceRSNkiYWUBdYtK8RcwQ9Q8YJba8vc8OUa8l8fL5RyYQm0VAVWLzkxNg\n\tNhtQfP+LG2wgNr+AosTVH48ZQWaKCkRIdJ+oBAmLCIRLzF7wnhlifgejxOTNmiC2sICzRPf9\n\tjWCtQgKHGSW6zqiB2JwCthJXVnxmncAoMAvJpbMQLp2F5NIFjMyrGCVTC4pz03OLjQqM8lLL\n\t9YoTc4tL89L1kvNzNzECQ3rbYa3+HYyPl8QfYhTgYFTi4b3BcjJSiDWxrLgy9xCjBAezkgjv\n\t9e1AId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rz8+ccihQTSE0tSs1NTC1KLYLJMHJxSDYzGorki\n\tFr+vv359ccWzOserhzor1toE/Wo7wMWVsXDrmqoMDRHvyRr/dCK5n9vLfpqiOk3uXIBr9ty1\n\tX0VYW6e3X/35zyXmtnfh7fhGUb7D0Z6R0wJ817ZJH7M9+XXuvRs2gqXie55Pd/YVr8pmupOX\n\tLKR6mGNqV4Fi7DGxM89VBcvS96RdvafEUpyRaKjFXFScCABNTXwfZQIAAA=="],"X-CMS-MailID":"20170926022543epcas2p1615a41fe2b4ceb37bb15b6d8716cbc1f","X-Msg-Generator":"CA","X-Sender-IP":"182.195.42.143","X-Local-Sender":"=?utf-8?b?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1c=?=\n\t=?utf-8?b?7IS87YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?=","X-Global-Sender":"=?utf-8?q?Chanwoo_Choi=1BTizen_Platform_Lab=2E=1BSamsung?=\n\t=?utf-8?q?_Electronics=1BSenior_Engineer?=","X-Sender-Code":"=?utf-8?q?C10=1BTELE=1BC10V8111?=","CMS-TYPE":"102P","DLP-Filter":"Pass","X-CFilter-Loop":"Reflected","X-CMS-RootMailID":"20170924150247epcas2p337f9a12744c23967dbdc0c79042553b5","X-RootMTR":"20170924150247epcas2p337f9a12744c23967dbdc0c79042553b5","References":"<20170924145622.4031-1-linus.walleij@linaro.org>\n\t\n\t<20170924145622.4031-9-linus.walleij@linaro.org>","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]