[{"id":1775089,"web_url":"http://patchwork.ozlabs.org/comment/1775089/","msgid":"<59C9B592.5030209@samsung.com>","list_archive_url":null,"date":"2017-09-26T02:04:02","subject":"Re: [PATCH 2/8] extcon: gpio: Localize platform data","submitter":{"id":46832,"url":"http://patchwork.ozlabs.org/api/people/46832/","name":"Chanwoo Choi","email":"cw00.choi@samsung.com"},"content":"Hi Linus,\n\nOn 2017년 09월 24일 23:56, Linus Walleij wrote:\n> Nothing in the entire kernel #includes \n> so move the platform data declaration inside of the driver.\n> \n> Signed-off-by: Linus Walleij \n> ---\n> drivers/extcon/extcon-gpio.c | 22 +++++++++++++++++-\n> include/linux/extcon/extcon-gpio.h | 47 --------------------------------------\n> 2 files changed, 21 insertions(+), 48 deletions(-)\n> delete mode 100644 include/linux/extcon/extcon-gpio.h\n> \n> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c\n> index ebed22f22d75..6abf5f70fdbf 100644\n> --- a/drivers/extcon/extcon-gpio.c\n> +++ b/drivers/extcon/extcon-gpio.c\n> @@ -18,7 +18,6 @@\n\nActually, extcon-gpio.h defines the 'struct gpio_extcon_pdata'\nin order to get the gpio and interrupt data from platform_data\nbefore device-tree binding method. But, as you mentioned,\nit is not used on kernel with platform_data method.\n\nLooks good to me.\nAcked-by: Chanwoo Choi \n\n[snip]","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1PQX0x7dz9ryv\n\tfor ;\n\tTue, 26 Sep 2017 12:04:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S965883AbdIZCEH (ORCPT );\n\tMon, 25 Sep 2017 22:04:07 -0400","from mailout3.samsung.com ([203.254.224.33]:52345 \"EHLO\n\tmailout3.samsung.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S967106AbdIZCED (ORCPT\n\t); Mon, 25 Sep 2017 22:04:03 -0400","from epcas1p3.samsung.com (unknown [182.195.41.47])\n\tby mailout3.samsung.com (KnoxPortal) with ESMTP id\n\t20170926020401epoutp0351664a183f8e94158675714828109d60~nxwkDXhVQ2125621256epoutp03H;\n\tTue, 26 Sep 2017 02:04:01 +0000 (GMT)","from epsmges1p5.samsung.com (unknown [182.195.40.64]) by\n\tepcas1p4.samsung.com (KnoxPortal) with ESMTP id\n\t20170926020401epcas1p4db0a148f1a23495f1a878ee5e218a3a0~nxwjrvXv11275112751epcas1p4j;\n\tTue, 26 Sep 2017 02:04:01 +0000 (GMT)","from epcas1p3.samsung.com ( [182.195.41.47]) by\n\tepsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id\n\t52.E2.04255.195B9C95; Tue, 26 Sep 2017 11:04:01 +0900 (KST)","from epsmgms2p1new.samsung.com (unknown [182.195.42.142]) by\n\tepcas1p4.samsung.com (KnoxPortal) with ESMTP id\n\t20170926020401epcas1p44cfc91a3a699ed34bc4480bb8be29371~nxwjScfsl0148901489epcas1p4X;\n\tTue, 26 Sep 2017 02:04:01 +0000 (GMT)","from epmmp2 ( [203.254.227.17]) by epsmgms2p1new.samsung.com\n\t(Symantec Messaging Gateway) with SMTP id 10.B4.06995.095B9C95;\n\tTue, 26 Sep 2017 11:04:01 +0900 (KST)","from [10.113.62.212] by mmp2.samsung.com (Oracle Communications\n\tMessaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id\n\t<0OWV00LK072OXTA0@mmp2.samsung.com>;\n\tTue, 26 Sep 2017 11:04:00 +0900 (KST)"],"X-AuditID":"b6c32a39-a6fff7000000109f-4c-59c9b5917309","MIME-version":"1.0","Content-transfer-encoding":"8BIT","Content-type":"text/plain; charset=\"UTF-8\"","Message-id":"<59C9B592.5030209@samsung.com>","Date":"Tue, 26 Sep 2017 11:04:02 +0900","From":"Chanwoo Choi ","Organization":"Samsung Electronics","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101\n\tThunderbird/31.6.0","To":"Linus Walleij ,\n\tMyungJoo Ham ","Cc":"linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,\n\tJohn Stultz , Guenter Roeck ","Subject":"Re: [PATCH 2/8] extcon: gpio: Localize platform data","In-reply-to":"<20170924145622.4031-3-linus.walleij@linaro.org>","X-Brightmail-Tracker":["H4sIAAAAAAAAA+NgFvrIKsWRmVeSWpSXmKPExsWy7bCmvu7ErScjDdbvkLU481vXYsqf5UwW\n\tm+f/YbS4vGsOm8WThWeYLG43rmBzYPO4c20Pm8fO7w3sHn1bVjF6fN4kF8ASlWqTkZqYklqk\n\tkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RbSaEsMacUKBSQWFys\n\tpG9nU5RfWpKqkJFfXGKrFG1oaKRnaGCuZ2RkpGdiHGtlZApUkpCa0XZsAWvBM46K5v03WRoY\n\tN7B3MXJySAiYSGy4cIixi5GLQ0hgB6PE6vkzWSGc74wSPfPmwVWtvtHLApHYwCgxZ/5isASv\n\tgKDEj8n3gBIcHMwC8hJHLmWDhJkFNCW27l7PDlF/j1Fi29nPTBD1WhJHp8xgAbFZBFQlPt74\n\tBxZnA4rvf3GDDcTmF1CUuPrjMSOILSoQIbFz/jewXSIC4RL7jh1gBhnKLNDBKPFmB0RCWMBW\n\t4t2O+0wgR3AC2S3/rUBqJAT2sEk8v3uEFeIDF4kvS45DfSMs8er4FnaQegkBaYlLR20h6tsZ\n\tJTbPuccC4QAtuL+yEarZWOJUVyMTxGt8Eu++9rBCNPNKdLQJQZR4SLw49wFqvqPEl52T2SC+\n\tP8wo8aX3A9MERrlZSAE2CxFgs5ACbAEj8ypGsdSC4tz01GLDAlO94sTc4tK8dL3k/NxNjODk\n\tpmW5g/HYOZ9DjAIcjEo8vA1MJyOFWBPLiitzDzFKcDArifDKbwYK8aYkVlalFuXHF5XmpBYf\n\tYjQFhvdEZinR5Hxg4s0riTc0sTQwMTMCpi9LQ0MlcV7R9dcihATSE0tSs1NTC1KLYPqYODil\n\tGhhtH7VM3yCierX2d4G+4/prs/YmKip170nTT9N/eyqfKX6lFNfl45e+zHqwP4xxqVPSZ+6T\n\t9amnsqe+ypi+3a8uy2zr/Ueb1nZMrlvXVCisnrtlvalHueeDpQqBpXvSpk5vLp8pKf289L38\n\t5Ha/sjm1K/6vabhbIl4fvqPtr87myTLH1//5XeqmxFKckWioxVxUnAgArkM644QDAAA=","H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t9jQd2JW09GGtybyWxx5reuxZQ/y5ks\n\tNs//w2hxedccNosnC88wWdxuXMHmwOZx59oeNo+d3xvYPfq2rGL0+LxJLoAlissmJTUnsyy1\n\tSN8ugSuj7dgC1oJnHBXN+2+yNDBuYO9i5OSQEDCRWH2jl6WLkYtDSGAdo8SaBZvAErwCghI/\n\tJt8DSnBwMAvISxy5lA0SZhZQl5g0bxEzRP0DRomtM24xQ9RrSRydMoMFxGYRUJX4eOMfE4jN\n\tBhTf/+IGG4jNL6AocfXHY0aQmaICERLdJypBwiIC4RKzF7xnhpjfwSgxebMmiC0sYCvxbsd9\n\tJohdhxklnky6xg7SywmUaPlvNYFRYBaSS2chXDoLyaULGJlXMUqmFhTnpucWGxUY5qWW6xUn\n\t5haX5qXrJefnbmIEhvS2w1p9OxjvL4k/xCjAwajEw9vAdDJSiDWxrLgy9xCjBAezkgiv/Gag\n\tEG9KYmVValF+fFFpTmrxIUZpDhYlcd7beccihQTSE0tSs1NTC1KLYLJMHJxSDYx8rw7K/hFe\n\t4rr63bVdPlFz3M5O2awRdi5KwfRTr9FR595/1mF6Vqlvrlw6oBe75X1ay/xXnDLHZ4mpCLyO\n\tbFfed3cZj82OgyafghnuV6wzts7OXPeukn+2u66B5NQHMjmN0yW/uq/b+mqvddLNIw/6Io3m\n\tXZXhLChOOO3p7vP7H9+KzI0Sz1cqsRRnJBpqMRcVJwIAq6A3zWUCAAA="],"X-CMS-MailID":"20170926020401epcas1p44cfc91a3a699ed34bc4480bb8be29371","X-Msg-Generator":"CA","X-Sender-IP":"182.195.42.142","X-Local-Sender":"=?utf-8?b?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1c=?=\n\t=?utf-8?b?7IS87YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?=","X-Global-Sender":"=?utf-8?q?Chanwoo_Choi=1BTizen_Platform_Lab=2E=1BSamsung?=\n\t=?utf-8?q?_Electronics=1BSenior_Engineer?=","X-Sender-Code":"=?utf-8?q?C10=1BTELE=1BC10V8111?=","CMS-TYPE":"101P","DLP-Filter":"Pass","X-CFilter-Loop":"Reflected","X-CMS-RootMailID":"20170924145853epcas4p38c33944036eb5a07285eae475fb204a6","X-RootMTR":"20170924145853epcas4p38c33944036eb5a07285eae475fb204a6","References":"<20170924145622.4031-1-linus.walleij@linaro.org>\n\t\n\t<20170924145622.4031-3-linus.walleij@linaro.org>","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]