[{"id":1776616,"web_url":"http://patchwork.ozlabs.org/comment/1776616/","msgid":"<20170927210545.GG2903@scaer>","list_archive_url":null,"date":"2017-09-27T21:05:45","subject":"Re: [Buildroot] [PATCH v3 6/7] package/flex: disable reallocarray","submitter":{"id":13903,"url":"http://patchwork.ozlabs.org/api/people/13903/","name":"Yann E. MORIN","email":"yann.morin.1998@free.fr"},"content":"Romain, All,\n\nOn 2017-09-23 23:24 +0200, Romain Naour spake thusly:\n> This doesn't compile with glibc 2.26 where reallocarray() as been introduced.\n> \n> It's a nasty issue, when reallocarray() is available for the target, flex will\n> build a small tool called stage1flex for the host (using _FOR_BUILD) but with\n> the config.h generated for the target.\n> \n> When the host doesn't have a glibc >= 2.26, reallocarray() is never defined\n> while building stage1flex:\n> \n> misc.c:147:8: warning : implicit declaration of function « reallocarray »\n> [-Wimplicit-function-declaration]\n> mem = reallocarray(NULL, (size_t) size, element_size);\n> ^~~~~~~~~~~~\n> misc.c:147:6: warning : assignment makes pointer from integer without a cast\n> [-Wint-conversion]\n> mem = reallocarray(NULL, (size_t) size, element_size);\n> ^\n> \n> Disable reallocarray for now, reallocarray() support may be\n> enabled in a followup patch.\n\nWhat about https://patchwork.ozlabs.org/patch/813474/ which just\nbackports a fix from upstream (or I'm mislead)?\n\nRegards,\nYann E. MORIN.\n\n> Fixes:\n> stage1flex-misc.o: In function `allocate_array':\n> misc.c:(.text+0x38f): undefined reference to `reallocarray'\n> stage1flex-misc.o: In function `reallocate_array':\n> misc.c:(.text+0xc8a): undefined reference to `reallocarray'\n> collect2: error: ld returned 1 exit status\n> \n> Signed-off-by: Romain Naour \n> ---\n> package/flex/flex.mk | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/package/flex/flex.mk b/package/flex/flex.mk\n> index b782699..0196624 100644\n> --- a/package/flex/flex.mk\n> +++ b/package/flex/flex.mk\n> @@ -10,7 +10,8 @@ FLEX_INSTALL_STAGING = YES\n> FLEX_LICENSE = FLEX\n> FLEX_LICENSE_FILES = COPYING\n> FLEX_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) host-m4\n> -FLEX_CONF_ENV = ac_cv_path_M4=/usr/bin/m4\n> +FLEX_CONF_ENV = ac_cv_path_M4=/usr/bin/m4 \\\n> +\tac_cv_func_reallocarray=no\n> HOST_FLEX_DEPENDENCIES = host-m4\n> \n> define FLEX_DISABLE_PROGRAM\n> -- \n> 2.9.5\n> \n> _______________________________________________\n> buildroot mailing list\n> buildroot@busybox.net\n> http://lists.busybox.net/mailman/listinfo/buildroot","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Lqd46aKu\"; dkim-atps=neutral"],"Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2VjJ3Tgmz9t33\n\tfor ;\n\tThu, 28 Sep 2017 07:05:56 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A3C96884D4;\n\tWed, 27 Sep 2017 21:05:53 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BbcMc2--aJ4Q; Wed, 27 Sep 2017 21:05:52 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D654B88346;\n\tWed, 27 Sep 2017 21:05:51 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 882061C0526\n\tfor ;\n\tWed, 27 Sep 2017 21:05:49 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 80C3889624\n\tfor ;\n\tWed, 27 Sep 2017 21:05:49 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AiuK6nC7uYvI for ;\n\tWed, 27 Sep 2017 21:05:48 +0000 (UTC)","from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 783D689603\n\tfor ; Wed, 27 Sep 2017 21:05:48 +0000 (UTC)","by mail-wm0-f68.google.com with SMTP id m127so22217922wmm.1\n\tfor ; Wed, 27 Sep 2017 14:05:48 -0700 (PDT)","from ymorin.is-a-geek.org\n\t(2a01cb08861073006444a51dd1b45d96.ipv6.abo.wanadoo.fr.\n\t[2a01:cb08:8610:7300:6444:a51d:d1b4:5d96])\n\tby smtp.gmail.com with ESMTPSA id\n\tp1sm6710972wrf.88.2017.09.27.14.05.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 27 Sep 2017 14:05:46 -0700 (PDT)","by ymorin.is-a-geek.org (sSMTP sendmail emulation);\n\tWed, 27 Sep 2017 23:05:45 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=Mu64GAxM1PNfSDZtxZCqSH/LqWVkpG6aK+OZLCXAToU=;\n\tb=Lqd46aKuL3WrGQ6Hd2LW3CCAKmjHcK2550BCuxcCDSk5pvrqMA0vVn4hZdU6rZnqUW\n\tgS3iWjBitlUw3OWdmhQP3EUhxgYWoa5h1f/Zk7pbX0o4Zr1lCPstNg+mlHNgU/90NFLH\n\tXDed8lQpiGfYDNdlnAKjQBt3NVgCMf22gsHCe2gYeaf9qGUU4I+NuZ6d9MO18NJLNeBL\n\tqu6Mx+vtjKRF8++nW9haRI68283xJAt1ntjzT6VAuRSor8VcyO0mLqR2M8dJAv9nFWmt\n\twXpl0nbZ0Ew3hRWyO6gWn4DDKVS93c03b1vKtaHoHK/fesz6BCu6IQzB0J30pF22z3kr\n\tk9kQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition\n\t:content-transfer-encoding:in-reply-to:user-agent;\n\tbh=Mu64GAxM1PNfSDZtxZCqSH/LqWVkpG6aK+OZLCXAToU=;\n\tb=f98TQkiZni0C4TRCtHl2O5JukZGetifNIj8JGADBOxEcoA2ieoKFcMA8JTZ35/Xv9x\n\tCTIg2HSgh2y4MetdOqsPssbLQ16wsQC29lX2aZ7y2TPPT0BmuMnVL0iZCNP12gkphEuw\n\t0ov8kxdio6zsqYCEOxXYT1kFGEhe2fg1lwDwfkVdzvqPT6DCZUscv1XdkViS0Y3hDPB4\n\txsgjt+Scm53UFbD9DPuTBhqgoGeCBfxljG9dzuoe2cm7rJyxYIBmpr/VPxFFZaxg6bQd\n\tb5F28So2CHrERuA1m0g7WQFr9CbYpPtYDFnl6rcydKkXJtWWnQ25cbH0Q/YeesyAu15C\n\tNVrw==","X-Gm-Message-State":"AMCzsaUFVbwnjv/Yxd4xU0CjGy+ts1aPlIs6L2kh3a1nG9V192ZWW5Cd\n\tobT9RokOjXMpvkZ0EZHHrG8=","X-Google-Smtp-Source":"AOwi7QB40+vRaBWI8b6qvahoZZq1aJ/VLp1qdsesoFzaRHEvPhGPYbv4iqVdzxGLRMW4Y8LDuBvayg==","X-Received":"by 10.28.180.2 with SMTP id d2mr236885wmf.118.1506546347020;\n\tWed, 27 Sep 2017 14:05:47 -0700 (PDT)","Date":"Wed, 27 Sep 2017 23:05:45 +0200","From":"\"Yann E. MORIN\" ","To":"Romain Naour ","Message-ID":"<20170927210545.GG2903@scaer>","References":"<20170923212414.16744-1-romain.naour@gmail.com>\n\t<20170923212414.16744-7-romain.naour@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170923212414.16744-7-romain.naour@gmail.com>","User-Agent":"Mutt/1.5.22 (2013-10-16)","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v3 6/7] package/flex: disable reallocarray","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1776620,"web_url":"http://patchwork.ozlabs.org/comment/1776620/","msgid":"","list_archive_url":null,"date":"2017-09-27T21:11:54","subject":"Re: [Buildroot] [PATCH v3 6/7] package/flex: disable reallocarray","submitter":{"id":67942,"url":"http://patchwork.ozlabs.org/api/people/67942/","name":"Romain Naour","email":"romain.naour@gmail.com"},"content":"Le 27/09/2017 à 23:05, Yann E. MORIN a écrit :\n> Romain, All,\n> \n> On 2017-09-23 23:24 +0200, Romain Naour spake thusly:\n>> This doesn't compile with glibc 2.26 where reallocarray() as been introduced.\n>>\n>> It's a nasty issue, when reallocarray() is available for the target, flex will\n>> build a small tool called stage1flex for the host (using _FOR_BUILD) but with\n>> the config.h generated for the target.\n>>\n>> When the host doesn't have a glibc >= 2.26, reallocarray() is never defined\n>> while building stage1flex:\n>>\n>> misc.c:147:8: warning : implicit declaration of function « reallocarray »\n>> [-Wimplicit-function-declaration]\n>> mem = reallocarray(NULL, (size_t) size, element_size);\n>> ^~~~~~~~~~~~\n>> misc.c:147:6: warning : assignment makes pointer from integer without a cast\n>> [-Wint-conversion]\n>> mem = reallocarray(NULL, (size_t) size, element_size);\n>> ^\n>>\n>> Disable reallocarray for now, reallocarray() support may be\n>> enabled in a followup patch.\n> \n> What about https://patchwork.ozlabs.org/patch/813474/ which just\n> backports a fix from upstream (or I'm mislead)?\n\nNo, this patch is fixing host-flex (segfault). not flex (link issue).\n\nI haven't had the time to investigate further but stage1flex seems using the\nconfig result for the target while building a host tool. So the reallocarray()\ncode is used on a host machine where it is not in the host glibc.\n\nBest regards,\nRomain\n\n> \n> Regards,\n> Yann E. MORIN.\n> \n>> Fixes:\n>> stage1flex-misc.o: In function `allocate_array':\n>> misc.c:(.text+0x38f): undefined reference to `reallocarray'\n>> stage1flex-misc.o: In function `reallocate_array':\n>> misc.c:(.text+0xc8a): undefined reference to `reallocarray'\n>> collect2: error: ld returned 1 exit status\n>>\n>> Signed-off-by: Romain Naour \n>> ---\n>> package/flex/flex.mk | 3 ++-\n>> 1 file changed, 2 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/package/flex/flex.mk b/package/flex/flex.mk\n>> index b782699..0196624 100644\n>> --- a/package/flex/flex.mk\n>> +++ b/package/flex/flex.mk\n>> @@ -10,7 +10,8 @@ FLEX_INSTALL_STAGING = YES\n>> FLEX_LICENSE = FLEX\n>> FLEX_LICENSE_FILES = COPYING\n>> FLEX_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) host-m4\n>> -FLEX_CONF_ENV = ac_cv_path_M4=/usr/bin/m4\n>> +FLEX_CONF_ENV = ac_cv_path_M4=/usr/bin/m4 \\\n>> +\tac_cv_func_reallocarray=no\n>> HOST_FLEX_DEPENDENCIES = host-m4\n>> \n>> define FLEX_DISABLE_PROGRAM\n>> -- \n>> 2.9.5\n>>\n>> _______________________________________________\n>> buildroot mailing list\n>> buildroot@busybox.net\n>> http://lists.busybox.net/mailman/listinfo/buildroot\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"VfO5vXcF\"; dkim-atps=neutral"],"Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2VrX3JTtz9t33\n\tfor ;\n\tThu, 28 Sep 2017 07:12:11 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 498AB898BD;\n\tWed, 27 Sep 2017 21:12:09 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id boXndaLdawlo; Wed, 27 Sep 2017 21:12:08 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A29548997F;\n\tWed, 27 Sep 2017 21:12:08 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9261C1C0526\n\tfor ;\n\tWed, 27 Sep 2017 21:12:07 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8D1ED8997F\n\tfor ;\n\tWed, 27 Sep 2017 21:12:07 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aQEVtVDPRpVQ for ;\n\tWed, 27 Sep 2017 21:12:05 +0000 (UTC)","from mail-wm0-f66.google.com (mail-wm0-f66.google.com\n\t[74.125.82.66])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 776F9898BD\n\tfor ; Wed, 27 Sep 2017 21:12:05 +0000 (UTC)","by mail-wm0-f66.google.com with SMTP id q124so22657948wmb.0\n\tfor ; Wed, 27 Sep 2017 14:12:05 -0700 (PDT)","from ?IPv6:2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf?\n\t([2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf])\n\tby smtp.gmail.com with ESMTPSA id\n\tp78sm412066wma.11.2017.09.27.14.12.01\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Sep 2017 14:12:01 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=Gq/alfn4yTt/m7B4qRoKWYawg9UUgewzJQIkY6rjDJY=;\n\tb=VfO5vXcFony5B0zUXBmnKItdchkGG4fcuAmofE0u2mw8t6csggA8urFpRQ5u4cFEU3\n\twxOH4ozVCYknC4aTLUwFxDcVRAu47Oq50B8KCIE2PbllBymfQQTvvy+P6OFujzgljdSr\n\tJguXyv/vNG6Qlt1buUxE7XkLvtgqT8CwBQ9u085jbK0QjI6FPxXin3uO5LmQbjCV3DYx\n\t+DsKOuPhgW6W1w0lwgOGldvCjvfOFZdxMgpVPJ9ou8Yw2fvqoP8cpBND2Vo1+eHX5943\n\tfGKWQiIv3RnGNe2XnqdVgDSCWgiyX3Z3JnSIeELGxyk5Edl8NJX6XB9NaDkEltXjD76z\n\t3ySw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=Gq/alfn4yTt/m7B4qRoKWYawg9UUgewzJQIkY6rjDJY=;\n\tb=al9cI4P/sFu8mkb/ao05u87DXNdCLBN7ZoRLkk0bLoXjJFNCR2GSYLZhtWMeRQdEA7\n\tEMcAHoF1wh09ayp8s5ixtma6oFanj3/ydtT4JUQlf1QyA4llSA0SLNfeHgxaem8fv/Hy\n\thWB7qNwWa/D0+dOqQc01/y3eqaT2ISwSAQe3vLCAejpKOXwEQ7HK61txVYi7C5H0lDVH\n\tTFSLi+jVMs9ODxPVGzphVU0i1lNAor2tqVghs9uJi3AVqh9mEEr2x0p+ajE5A2I32vKq\n\tXSxNsnhlKo/Jh5tf9b/CYPXKbzdNU+m0UYMhZrxZVHGbulrH+Ygh3xGlQjkPoAD2UsFe\n\tsipQ==","X-Gm-Message-State":"AHPjjUg5tmOhwoH/M6yG5JmSFbFk+6Q36aNXRgk9z1eQR/11rdkK4xYg\n\tPN3mKlj0HlV6CefidqBOIQVY0KWI","X-Google-Smtp-Source":"AOwi7QCfogD7rIcG4JdZjwaCqZcCiOtM197tkCXF7ngHcB5k454ExI5q/nSFVN4B2QmDjcJQHcs01g==","X-Received":"by 10.28.86.67 with SMTP id k64mr1456427wmb.143.1506546722699;\n\tWed, 27 Sep 2017 14:12:02 -0700 (PDT)","To":"\"Yann E. MORIN\" ","References":"<20170923212414.16744-1-romain.naour@gmail.com>\n\t<20170923212414.16744-7-romain.naour@gmail.com>\n\t<20170927210545.GG2903@scaer>","From":"Romain Naour ","Message-ID":"","Date":"Wed, 27 Sep 2017 23:11:54 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170927210545.GG2903@scaer>","Content-Language":"en-US","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v3 6/7] package/flex: disable reallocarray","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]