[{"id":1776614,"web_url":"http://patchwork.ozlabs.org/comment/1776614/","msgid":"<20170927210112.GF2903@scaer>","list_archive_url":null,"date":"2017-09-27T21:01:12","subject":"Re: [Buildroot] [PATCH v3 5/7] package/diffutils: disable\n\tgetopt_long replacement with glibc","submitter":{"id":13903,"url":"http://patchwork.ozlabs.org/api/people/13903/","name":"Yann E. MORIN","email":"yann.morin.1998@free.fr"},"content":"Romain, All,\n\nOn 2017-09-23 23:24 +0200, Romain Naour spake thusly:\n> Since glibc >= 2.26, don't try to use getopt_long replacement bundled\n> with diffutils. It will conflict with the one from glibc.\n> The getopt copy bundled in glibc has been updated with the one from gnulib.\n\nYeah, because gnulib was such a bright idea... ;-)\n\n> After a lot of warnings...\n> Fixes:\n> xstrtol-error.c: In function 'xstrtol_error':\n> xstrtol-error.c:84:26: error: invalid use of undefined type 'struct rpl_option'\n> option = long_options[opt_idx].name;\n> ^\n> xstrtol-error.c:84:26: error: dereferencing pointer to incomplete type 'const struct rpl_option'\n> \n> [...]\n> \n> xstrtol-error.c:92:1: error: conflicting types for 'xstrtol_fatal'\n> xstrtol_fatal (enum strtol_error err,\n> ^~~~~~~~~~~~~\n> In file included from xstrtol-error.c:20:0:\n> xstrtol.h:69:16: note: previous declaration of 'xstrtol_fatal' was here\n> _Noreturn void xstrtol_fatal (enum strtol_error,\n> ^~~~~~~~~~~~~\n> \n> Signed-off-by: Romain Naour \n\nReviewed-by: \"Yann E. MORIN\" \n\nRegards,\nYann E. MORIN.\n\n> ---\n> package/diffutils/diffutils.mk | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/package/diffutils/diffutils.mk b/package/diffutils/diffutils.mk\n> index 6e5b9b6..79785d6 100644\n> --- a/package/diffutils/diffutils.mk\n> +++ b/package/diffutils/diffutils.mk\n> @@ -11,6 +11,12 @@ DIFFUTILS_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)\n> DIFFUTILS_LICENSE = GPL-3.0+\n> DIFFUTILS_LICENSE_FILES = COPYING\n> \n> +# Since glibc >= 2.26, don't try to use getopt_long replacement bundled\n> +# with diffutils. It will conflict with the one from glibc.\n> +ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)\n> +DIFFUTILS_CONF_ENV += gl_cv_func_getopt_gnu=yes\n> +endif\n> +\n> ifeq ($(BR2_PACKAGE_BUSYBOX),y)\n> DIFFUTILS_DEPENDENCIES += busybox\n> endif\n> -- \n> 2.9.5\n> \n> _______________________________________________\n> buildroot mailing list\n> buildroot@busybox.net\n> http://lists.busybox.net/mailman/listinfo/buildroot","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lKI6r/Dz\"; dkim-atps=neutral"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Vc20nbWz9sRm\n\tfor ;\n\tThu, 28 Sep 2017 07:01:22 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0D1D5307B1;\n\tWed, 27 Sep 2017 21:01:20 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xomN726OBWk6; Wed, 27 Sep 2017 21:01:19 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id F2C0E30544;\n\tWed, 27 Sep 2017 21:01:18 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id B19D51C025D\n\tfor ;\n\tWed, 27 Sep 2017 21:01:17 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id AB9F088797\n\tfor ;\n\tWed, 27 Sep 2017 21:01:17 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wCDwu5MSlySv for ;\n\tWed, 27 Sep 2017 21:01:17 +0000 (UTC)","from mail-wm0-f66.google.com (mail-wm0-f66.google.com\n\t[74.125.82.66])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id D38B68876B\n\tfor ; Wed, 27 Sep 2017 21:01:16 +0000 (UTC)","by mail-wm0-f66.google.com with SMTP id m72so22756422wmc.1\n\tfor ; Wed, 27 Sep 2017 14:01:16 -0700 (PDT)","from ymorin.is-a-geek.org\n\t(2a01cb0886107300f191dfc06988d97d.ipv6.abo.wanadoo.fr.\n\t[2a01:cb08:8610:7300:f191:dfc0:6988:d97d])\n\tby smtp.gmail.com with ESMTPSA id\n\ta19sm16335888wra.64.2017.09.27.14.01.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 27 Sep 2017 14:01:14 -0700 (PDT)","by ymorin.is-a-geek.org (sSMTP sendmail emulation);\n\tWed, 27 Sep 2017 23:01:12 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=m4x8lASCAF0yGKjzQ4HqFMY45Mr4ZJiuCXyii3vQyrQ=;\n\tb=lKI6r/Dzqw66mjOGH8kJ7WFaABsie6KYqzp7O9kotBH1wU3XfXVXuZrz6soBfImv/J\n\tpvN0mLXs3jFbvh+ZA/xVbAzQI61XXqiFHuSIn36N2EUGGquDosFLdknrNSagXWnn6l7c\n\tj8QNUlqNYlPLbgitXpma1WNUhIyIDvN0hFI2y4WMdpidxgCaMDCIGI0JFzEgDVfpqkkB\n\tr3m5Y4nLdGzcnzf9Qi49GUUvLfKXBQ8uTqYsiKOpEFm0KCapSMl4bRltDisurp3cSJOH\n\tVzgb9c0htgreVsE75ZIB9M+5DncT997a1OqI/e3EZYpR6mIUBXEWtVnpGwQTbwNbwrU/\n\t9EWQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition:in-reply-to:user-agent; \n\tbh=m4x8lASCAF0yGKjzQ4HqFMY45Mr4ZJiuCXyii3vQyrQ=;\n\tb=Wi9OaVjz5CX1Ygz1svmb9VVlX9wzcWutzI44mw2/H+rnfv6HPOQtl+NsrId1grtlqg\n\t8YoTd0fxLK6yxN0Ig0rYzNmHd16pI9bsav1ZyPL3/TtP3JqGlFzBOlPeXNgNDbIH7JJt\n\tDgTeNg13GxVxcnLpV2jLGvo1rIsxG+QwmmPpyaMrGWEA9n0iJ93MKN8gc4tybVMX6+9v\n\t0+GsxR2RrEPUrlGuOO0eJUIAX4wxITuliWNqZFLqa5KCapwFjtDX3s3bzzVO6dt0QXrT\n\t+5zfQanh4kdhxU/oTjqCPzmDbTW1JXAa5Py8kJk/IeskbbFrnlOj2B7z+ET/lhYAnk4A\n\tdrhA==","X-Gm-Message-State":"AHPjjUhdE5G9WylffdVSFk+ZBlRAB87ib9O7KRgNEUsX3K/QQahIEgwk\n\tHamUEKqymSrhxDZSTuposJQ=","X-Google-Smtp-Source":"AOwi7QBZsYyNcN9rtwVyUVGoAJzb4r03X7Gd/GgkFlOdurFEOgIqEBv08QjM6ah8KeFHY3Yqh96ynA==","X-Received":"by 10.28.98.5 with SMTP id w5mr1418834wmb.51.1506546075330;\n\tWed, 27 Sep 2017 14:01:15 -0700 (PDT)","Date":"Wed, 27 Sep 2017 23:01:12 +0200","From":"\"Yann E. MORIN\" ","To":"Romain Naour ","Message-ID":"<20170927210112.GF2903@scaer>","References":"<20170923212414.16744-1-romain.naour@gmail.com>\n\t<20170923212414.16744-6-romain.naour@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170923212414.16744-6-romain.naour@gmail.com>","User-Agent":"Mutt/1.5.22 (2013-10-16)","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v3 5/7] package/diffutils: disable\n\tgetopt_long replacement with glibc","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]