[{"id":1776604,"web_url":"http://patchwork.ozlabs.org/comment/1776604/","msgid":"<20170927204006.GE2903@scaer>","list_archive_url":null,"date":"2017-09-27T20:40:06","subject":"Re: [Buildroot] [PATCH v3 4/7] package/gcc: enable float128 on\n\tpowerpc64le with glibc >= 2.26 toolchains","submitter":{"id":13903,"url":"http://patchwork.ozlabs.org/api/people/13903/","name":"Yann E. MORIN","email":"yann.morin.1998@free.fr"},"content":"Romain, All,\n\nOn 2017-09-23 23:24 +0200, Romain Naour spake thusly:\n> float128 is now required on powerpc64le with glibc >= 2.26 toolchains.\n> \n> Fixes:\n> running configure fragment for sysdeps/gnu\n> running configure fragment for sysdeps/powerpc/powerpc64le\n> checking if [...]powerpc64le-buildroot-linux-gnu-gcc supports binary128 floating point type... no\n> checking if the target machine is at least POWER8... yes\n> configure: error: *** binary128 floating point type (GCC >= 6.2) is required on powerpc64le.\n> \n> In order to prepare the glibc bump to this version, we enable\n> binary128 floating point in gcc. This require at least gcc >= 6.2.\n> \n> Disable gcc 4.x and 5.x for internal toolchain.\n> \n> Signed-off-by: Romain Naour \n\nSmall nit below...\n\n> ---\n> v2: Disable gcc 4.x and 5.x for internal toolchain.\n> ---\n> package/gcc/Config.in.host | 4 ++++\n> package/gcc/gcc.mk | 8 ++++++++\n> 2 files changed, 12 insertions(+)\n> \n> diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host\n> index ec7b692..0926560 100644\n> --- a/package/gcc/Config.in.host\n> +++ b/package/gcc/Config.in.host\n> @@ -39,6 +39,8 @@ config BR2_GCC_VERSION_4_9_X\n> \tdepends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_powerpc64 || BR2_powerpc64le))\n> \t# musl mips64 unsupported\n> \tdepends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_mips64 || BR2_mips64el))\n> +\t# glibc >= 2.26 needs gcc >= 6.2\n> +\tdepends on !(BR2_TOOLCHAIN_USES_GLIBC && BR2_powerpc64le)\n> \tselect BR2_TOOLCHAIN_GCC_AT_LEAST_4_9\n> \n> config BR2_GCC_VERSION_5_X\n> @@ -53,6 +55,8 @@ config BR2_GCC_VERSION_5_X\n> \tdepends on !BR2_mips_interaptiv && !BR2_mips_m5150 && !BR2_mips_i6400\n> \t# musl mips64 unsupported\n> \tdepends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_mips64 || BR2_mips64el))\n> +\t# glibc >= 2.26 needs gcc >= 6.2\n> +\tdepends on !(BR2_TOOLCHAIN_USES_GLIBC && BR2_powerpc64le)\n> \tselect BR2_TOOLCHAIN_GCC_AT_LEAST_5\n> \n> config BR2_GCC_VERSION_6_X\n> diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk\n> index 49ccccf..54ef70c 100644\n> --- a/package/gcc/gcc.mk\n> +++ b/package/gcc/gcc.mk\n> @@ -254,6 +254,14 @@ HOST_GCC_COMMON_CONF_OPTS += \\\n> \t--without-long-double-128\n> endif\n> \n> +# Since glibc >= 2.26, poerpc64le requires double/long double which\n> +# requires at least gcc 6.2.\n> +# See sysdeps/powerpc/powerpc64le/configure.ac\n> +ifeq ($(BR2_TOOLCHAIN_USES_GLIBC)$(BR2_TOOLCHAIN_GCC_AT_LEAST_6)$(BR2_powerpc64le),yyy)\n> +HOST_GCC_COMMON_CONF_OPTS += \\\n> +\t--with-long-double-128\n\nCould very well have been on a single line.\n\nOtherwise:\n\nReviewed-by: \"Yann E. MORIN\" \n\nRegards,\nYann E. MORIN.\n\n> +endif\n> +\n> HOST_GCC_COMMON_TOOLCHAIN_WRAPPER_ARGS += -DBR_CROSS_PATH_SUFFIX='\".br_real\"'\n> ifeq ($(BR2_GCC_ARCH_HAS_CONFIGURABLE_DEFAULTS),)\n> ifeq ($(call qstrip,$(BR2_GCC_TARGET_CPU_REVISION)),)\n> -- \n> 2.9.5\n> \n> _______________________________________________\n> buildroot mailing list\n> buildroot@busybox.net\n> http://lists.busybox.net/mailman/listinfo/buildroot","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QFSbdAc3\"; dkim-atps=neutral"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2V7p158Rz9t66\n\tfor ;\n\tThu, 28 Sep 2017 06:40:22 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id ED2AF307BC;\n\tWed, 27 Sep 2017 20:40:18 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9CVYoNhJTqW0; Wed, 27 Sep 2017 20:40:15 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id C21D530519;\n\tWed, 27 Sep 2017 20:40:15 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9CFB51C143E\n\tfor ;\n\tWed, 27 Sep 2017 20:40:13 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9702A88768\n\tfor ;\n\tWed, 27 Sep 2017 20:40:13 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BEe_8wRvsuqR for ;\n\tWed, 27 Sep 2017 20:40:10 +0000 (UTC)","from mail-wr0-f193.google.com (mail-wr0-f193.google.com\n\t[209.85.128.193])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 5494B884D0\n\tfor ; Wed, 27 Sep 2017 20:40:10 +0000 (UTC)","by mail-wr0-f193.google.com with SMTP id u48so799914wrf.4\n\tfor ; Wed, 27 Sep 2017 13:40:10 -0700 (PDT)","from ymorin.is-a-geek.org\n\t(2a01cb0886107300e5df3ac67859b889.ipv6.abo.wanadoo.fr.\n\t[2a01:cb08:8610:7300:e5df:3ac6:7859:b889])\n\tby smtp.gmail.com with ESMTPSA id\n\tx70sm100442wmf.30.2017.09.27.13.40.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 27 Sep 2017 13:40:08 -0700 (PDT)","by ymorin.is-a-geek.org (sSMTP sendmail emulation);\n\tWed, 27 Sep 2017 22:40:06 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=dmVCwzoTWZz/yN7uVrYKgEYblCKxVKnM+PXnhZ386Cc=;\n\tb=QFSbdAc3y+42BtqUYGNqFSjCJA7EvNk/INUSgcZezDD+sEdCUALTpswONgvJzXqFWw\n\toLX2ckiRUfCVTVtFyPAT2QPRKqHQdIpFhC0OnSGYRVwD1Dw6/wuYXafs/cnt/mIn0gGb\n\t8+oYnGFkDaXuQFoNQsfq/QUP369Khi9vOBOVsn8lHYsWdXHjlrgrLWsjzhahMDjj4IOp\n\tvAP0fh0HlORerUEQJVjIaosBYbOig00VcFuszqj15kU/1nXFqpAGMH+GCkd2nxKB3gBz\n\tS0wb/v658aMiUdy31CawVvvm2cqHjeayOyVgWVOwBOrtjfk3Z8ml8AGZacyYkhzBGKvr\n\t8Evw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition:in-reply-to:user-agent; \n\tbh=dmVCwzoTWZz/yN7uVrYKgEYblCKxVKnM+PXnhZ386Cc=;\n\tb=FqdGBJ6HqjlWmtzsjYUgv0kv+zxUDAI70L+MKYY/We4+kaSxzrMZLXkRvyLY8kCZX2\n\tRf0PgjZgt/loVhqPfkRrHnbokWyrQk78Mw4J6tQ6VpShJcN3fOY9d04zs2gQIMULiIjY\n\tGhFi19AiQ3F34Nn70xsdtPZ8NHxoJp79M6vm2+nRlB/WdaxEuxWdkXlwfPJkXfnV3S9R\n\tinfuOSb2osAZY970ZrE3K5LCAb8IQ0aGGJ5tkyvoSUjlwXx00jBlAiE5VBllLE61Mr5h\n\tbqp+pkTMU6q5MHlXzhthjux4UrIMtQ7Bsrym4CM510LVdAmqdyEe30MV1jnJaJY+DwEJ\n\tpIuQ==","X-Gm-Message-State":"AHPjjUgK1dS0iKGrcrS9bXi6kI69/n/TkU9EfIwpJBT9VhobTPwfDEPE\n\tye4kCJUHpTMSe+79PyqzbquZJQ==","X-Google-Smtp-Source":"AOwi7QC8DgAkn75rg0gR17cxxvfbAMA3kZJp0zlltQJHO67eHuiSh2yD0iu+2MAtKBfxo/TRzo3sWg==","X-Received":"by 10.223.174.150 with SMTP id y22mr2606272wrc.29.1506544808876; \n\tWed, 27 Sep 2017 13:40:08 -0700 (PDT)","Date":"Wed, 27 Sep 2017 22:40:06 +0200","From":"\"Yann E. MORIN\" ","To":"Romain Naour ","Message-ID":"<20170927204006.GE2903@scaer>","References":"<20170923212414.16744-1-romain.naour@gmail.com>\n\t<20170923212414.16744-5-romain.naour@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170923212414.16744-5-romain.naour@gmail.com>","User-Agent":"Mutt/1.5.22 (2013-10-16)","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v3 4/7] package/gcc: enable float128 on\n\tpowerpc64le with glibc >= 2.26 toolchains","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1776622,"web_url":"http://patchwork.ozlabs.org/comment/1776622/","msgid":"<28b68e39-9fcb-93c8-340e-0368cd9dd826@mind.be>","list_archive_url":null,"date":"2017-09-27T21:14:23","subject":"Re: [Buildroot] [PATCH v3 4/7] package/gcc: enable float128 on\n\tpowerpc64le with glibc >= 2.26 toolchains","submitter":{"id":11809,"url":"http://patchwork.ozlabs.org/api/people/11809/","name":"Arnout Vandecappelle","email":"arnout@mind.be"},"content":"On 27-09-17 22:40, Yann E. MORIN wrote:\n> Romain, All,\n> \n> On 2017-09-23 23:24 +0200, Romain Naour spake thusly:\n\n[snip]\n>> @@ -254,6 +254,14 @@ HOST_GCC_COMMON_CONF_OPTS += \\\n>> \t--without-long-double-128\n>> endif\n>> \n>> +# Since glibc >= 2.26, poerpc64le requires double/long double which\n>> +# requires at least gcc 6.2.\n>> +# See sysdeps/powerpc/powerpc64le/configure.ac\n>> +ifeq ($(BR2_TOOLCHAIN_USES_GLIBC)$(BR2_TOOLCHAIN_GCC_AT_LEAST_6)$(BR2_powerpc64le),yyy)\n>> +HOST_GCC_COMMON_CONF_OPTS += \\\n>> +\t--with-long-double-128\n> \n> Could very well have been on a single line.\n\n I didn't change this, because the way it is now it's similar to the other 3\ninstances of --with-long-double-128 which makes it easier to spot the repetition.\n\n Regards,\n Arnout\n\n\n[snip]","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2VvV4kjpz9t33\n\tfor ;\n\tThu, 28 Sep 2017 07:14:46 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4FC1E307B1;\n\tWed, 27 Sep 2017 21:14:44 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VhYqHxTH5A8l; Wed, 27 Sep 2017 21:14:43 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 828ED306D4;\n\tWed, 27 Sep 2017 21:14:43 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id D16831C0526\n\tfor ;\n\tWed, 27 Sep 2017 21:14:41 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CB19189A5E\n\tfor ;\n\tWed, 27 Sep 2017 21:14:41 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0Yvwp7ZUKFSa for ;\n\tWed, 27 Sep 2017 21:14:38 +0000 (UTC)","from exchange.essensium.com (220.77.144.195.ipv4.evonet.be\n\t[195.144.77.220])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8F1D789A0F\n\tfor ; Wed, 27 Sep 2017 21:14:38 +0000 (UTC)","from [10.8.0.14] (10.3.7.11) by beleexch01.local.ess-mail.com\n\t(10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tWed, 27 Sep 2017 23:14:25 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","To":"\"Yann E. MORIN\" , Romain Naour\n\t","References":"<20170923212414.16744-1-romain.naour@gmail.com>\n\t<20170923212414.16744-5-romain.naour@gmail.com>\n\t<20170927204006.GE2903@scaer>","From":"Arnout Vandecappelle ","Organization":"Essensium/Mind","Message-ID":"<28b68e39-9fcb-93c8-340e-0368cd9dd826@mind.be>","Date":"Wed, 27 Sep 2017 23:14:23 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170927204006.GE2903@scaer>","Content-Language":"en-GB","X-Originating-IP":"[10.3.7.11]","X-ClientProxiedBy":"beleexch01.local.ess-mail.com (10.3.7.8) To\n\tbeleexch01.local.ess-mail.com (10.3.7.8)","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v3 4/7] package/gcc: enable float128 on\n\tpowerpc64le with glibc >= 2.26 toolchains","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]