[{"id":1774354,"web_url":"http://patchwork.ozlabs.org/comment/1774354/","msgid":"<20170925022755.GA22980@lemon.lan>","list_archive_url":null,"date":"2017-09-25T02:27:55","subject":"Re: [Qemu-devel] [PATCH v3 1/3] block: add bdrv_co_drain_end\n\tcallback","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Sat, 09/23 14:14, Manos Pitsidianakis wrote:\n> BlockDriverState has a bdrv_co_drain() callback but no equivalent for\n> the end of the drain. The throttle driver (block/throttle.c) needs a way\n> to mark the end of the drain in order to toggle io_limits_disabled\n> correctly, thus bdrv_co_drain_end is needed.\n> \n> Signed-off-by: Manos Pitsidianakis \n\nReviewed-by: Fam Zheng ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0p1331Zqz9sRq\n\tfor ;\n\tMon, 25 Sep 2017 12:28:34 +1000 (AEST)","from localhost ([::1]:40363 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwJ8J-0003Gv-CI\n\tfor incoming@patchwork.ozlabs.org; Sun, 24 Sep 2017 22:28:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40885)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwJ7v-0003F0-F6\n\tfor qemu-devel@nongnu.org; Sun, 24 Sep 2017 22:28:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwJ7u-00009f-Bk\n\tfor qemu-devel@nongnu.org; Sun, 24 Sep 2017 22:28:07 -0400","from mx1.redhat.com ([209.132.183.28]:57474)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwJ7q-00005I-0m; Sun, 24 Sep 2017 22:28:02 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D69DD129A;\n\tMon, 25 Sep 2017 02:28:00 +0000 (UTC)","from localhost (ovpn-12-91.pek2.redhat.com [10.72.12.91])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 810CB68D85;\n\tMon, 25 Sep 2017 02:27:56 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D69DD129A","Date":"Mon, 25 Sep 2017 10:27:55 +0800","From":"Fam Zheng ","To":"Manos Pitsidianakis ","Message-ID":"<20170925022755.GA22980@lemon.lan>","References":"<20170923111411.18626-1-el13635@mail.ntua.gr>\n\t<20170923111411.18626-2-el13635@mail.ntua.gr>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170923111411.18626-2-el13635@mail.ntua.gr>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tMon, 25 Sep 2017 02:28:01 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 1/3] block: add bdrv_co_drain_end\n\tcallback","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-devel , qemu-block ,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774604,"web_url":"http://patchwork.ozlabs.org/comment/1774604/","msgid":"<20170925100612.GI14140@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-09-25T10:06:12","subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/3] block: add\n\tbdrv_co_drain_end callback","submitter":{"id":2747,"url":"http://patchwork.ozlabs.org/api/people/2747/","name":"Stefan Hajnoczi","email":"stefanha@gmail.com"},"content":"On Sat, Sep 23, 2017 at 02:14:09PM +0300, Manos Pitsidianakis wrote:\n> BlockDriverState has a bdrv_co_drain() callback but no equivalent for\n> the end of the drain. The throttle driver (block/throttle.c) needs a way\n> to mark the end of the drain in order to toggle io_limits_disabled\n> correctly, thus bdrv_co_drain_end is needed.\n> \n> Signed-off-by: Manos Pitsidianakis \n> ---\n> include/block/block_int.h | 11 +++++++++--\n> block/io.c | 48 +++++++++++++++++++++++++++++++++--------------\n> 2 files changed, 43 insertions(+), 16 deletions(-)\n\nReviewed-by: Stefan Hajnoczi ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PnWUJjUb\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y109b28hSz9tX3\n\tfor ;\n\tMon, 25 Sep 2017 20:06:43 +1000 (AEST)","from localhost ([::1]:41566 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwQHh-0007Eb-EF\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 06:06:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43129)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwQHL-0007ES-NC\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:06:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwQHH-0004FI-Dk\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:06:19 -0400","from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:37117)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwQHH-0004Dw-6Q; Mon, 25 Sep 2017 06:06:15 -0400","by mail-wr0-x244.google.com with SMTP id u48so1683406wrf.4;\n\tMon, 25 Sep 2017 03:06:15 -0700 (PDT)","from localhost ([51.15.41.238]) by smtp.gmail.com with ESMTPSA id\n\tf43sm13210438wra.79.2017.09.25.03.06.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 25 Sep 2017 03:06:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=sxb0N5aEK0OPPCx79/MRXlZo/I6wZelTV/5Z4K7Ht2w=;\n\tb=PnWUJjUb8lHTBHN5Bpz2Zhh1Gh0imcaZib299GONr1PRIc6MX3HaVOW3c4HiD/bZau\n\t6mKkrLnDZ2OJqAmdhDdYQuuGZAIpMF335DRk35s30fmI5VSHh5q4ZrQuht/G4Hp8kB/r\n\t5ttBYZ2RrFwnjjv5sgaVmvS4Q2BOkWvMem5Td4UtMmRHHmIm9e1DnoFO/1HLkGCyT2UF\n\tK+KkKeME0symw3NobeqTsbKOaqLg5BnFjbRJ8E47G1i2cy4+uehDg6kFUPlTFn5NRT+l\n\tIXPBi2QnFtc6lSUNFHZzcQQuzORr2dWj1sPK+74BM4L4NLf1hyiJHSeeehLXk8SkHG1X\n\tgHnQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=sxb0N5aEK0OPPCx79/MRXlZo/I6wZelTV/5Z4K7Ht2w=;\n\tb=fIqAqSmstYh8JGY5yBBMMZQXMC5Wu1cZ9aMnn+Pg9f57CyYb2x8h16l7LdHgyT4/GW\n\tJKQn3nR5gYaG4niRtcTmzWJl+WvHTyFPgEioUndjmIH6qgoofrt4ZrqsHKsVlRZJIM3c\n\tDOxYKzeHAO9NOYPuDaeDx/uXc2eDLT9U+VcSyQgw6/eu+WVvAxyc4wklh6U6WYEGhCnj\n\tIzKuuou6e7o7qW2pfpBZJ+RP5Xpnl/gRunDcxqdIkEEHMR35R7vsHHQutF0js82ljYOr\n\tlhZ5Obn+oV2RTTmbMyRzE888P3169jR0rI+KEn1nqwCF18gxShP/dD/NgJs603JYxd+5\n\tJFvQ==","X-Gm-Message-State":"AHPjjUhR3GouK1YGB5r4PF8x6iSIw/3XJ1rrIyX4owR95neGA2czMFg1\n\tFtfE0AoD4YcpngPTqr1uy7M=","X-Google-Smtp-Source":"AOwi7QBeRc3GZN9nalbaOLVGuYyLJFwbM95JD6TowDLZbFC/AMf6/F/4XPkQKQ6xZ5/Vk/FMldtAdw==","X-Received":"by 10.223.196.228 with SMTP id o33mr5644715wrf.253.1506333974162;\n\tMon, 25 Sep 2017 03:06:14 -0700 (PDT)","Date":"Mon, 25 Sep 2017 11:06:12 +0100","From":"Stefan Hajnoczi ","To":"Manos Pitsidianakis ","Message-ID":"<20170925100612.GI14140@stefanha-x1.localdomain>","References":"<20170923111411.18626-1-el13635@mail.ntua.gr>\n\t<20170923111411.18626-2-el13635@mail.ntua.gr>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170923111411.18626-2-el13635@mail.ntua.gr>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::244","Subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/3] block: add\n\tbdrv_co_drain_end callback","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Fam Zheng ,\n\tqemu-block , qemu-devel ,\n\tMax Reitz , Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]