[{"id":1774405,"web_url":"http://patchwork.ozlabs.org/comment/1774405/","msgid":"<87h8vr75xt.fsf@kamboji.qca.qualcomm.com>","list_archive_url":null,"date":"2017-09-25T04:33:50","subject":"Re: [PATCH v4 1/9] brcmsmac: make some local variables 'static\n\tconst' to reduce stack size","submitter":{"id":65411,"url":"http://patchwork.ozlabs.org/api/people/65411/","name":"Kalle Valo","email":"kvalo@codeaurora.org"},"content":"Arnd Bergmann writes:\n\n> With KASAN and a couple of other patches applied, this driver is one\n> of the few remaining ones that actually use more than 2048 bytes of\n> kernel stack:\n>\n> broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy_gainctrl':\n> broadcom/brcm80211/brcmsmac/phy/phy_n.c:16065:1: warning: the frame size of 3264 bytes is larger than 2048 bytes [-Wframe-larger-than=]\n> broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy':\n> broadcom/brcm80211/brcmsmac/phy/phy_n.c:17138:1: warning: the frame size of 2864 bytes is larger than 2048 bytes [-Wframe-larger-than=]\n>\n> Here, I'm reducing the stack size by marking as many local variables as\n> 'static const' as I can without changing the actual code.\n>\n> This is the first of three patches to improve the stack usage in this\n> driver. It would be good to have this backported to stabl kernels\n> to get all drivers in 'allmodconfig' below the 2048 byte limit so\n> we can turn on the frame warning again globally, but I realize that\n> the patch is larger than the normal limit for stable backports.\n>\n> The other two patches do not need to be backported.\n>\n> Acked-by: Arend van Spriel \n> Signed-off-by: Arnd Bergmann \n\nI'll queue this and the two following brcmsmac patches for 4.14.\n\nAlso I'll add (only for this patch):\n\nCc: ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"lCLStNEg\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"cAku9C4p\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=kvalo@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0rns3Gt0z9t4Z\n\tfor ;\n\tMon, 25 Sep 2017 14:34:09 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932132AbdIYEeD (ORCPT );\n\tMon, 25 Sep 2017 00:34:03 -0400","from smtp.codeaurora.org ([198.145.29.96]:52692 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753650AbdIYEeA (ORCPT\n\t); Mon, 25 Sep 2017 00:34:00 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid C7A9C60AD5; Mon, 25 Sep 2017 04:33:59 +0000 (UTC)","from potku.adurom.net (a88-114-240-52.elisa-laajakaista.fi\n\t[88.114.240.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\t(Authenticated sender: kvalo@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id AA4E36044E;\n\tMon, 25 Sep 2017 04:33:52 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1506314039;\n\tbh=E5GV/P5l7HXsi9nVtH7C98Ihzwma+ERtxIPxogSJbvs=;\n\th=From:To:Cc:Subject:References:Date:In-Reply-To:From;\n\tb=lCLStNEg0cQmzM9/w/pC1fbvsBwzbZNZaGhoGLZHt/rSLLsb1rtkS8gV2nF6Djzkc\n\tgD9ssR5OXTYrVZ9vlNYTs5A/W+oORNq5Z/B8BkKLM47qNvLlNUUDgk3pXXTyaS6jrC\n\tXKNt+0dJ/W7It3l4kVhWbrCbSstphyOoCjxaUo4I=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1506314038;\n\tbh=E5GV/P5l7HXsi9nVtH7C98Ihzwma+ERtxIPxogSJbvs=;\n\th=From:To:Cc:Subject:References:Date:In-Reply-To:From;\n\tb=cAku9C4prYXxYwfkcar4h17q9Qe944nERFPwQh6zLqJsMUehluRz0N4D1hNMkaWu5\n\t99rgaSykkIoGChTWlf9p5KQ4AQGt+/0DwXFz0JmvyRJZ1BlpsWrS3izXrE0yoScAsJ\n\tlPG8BYAMfCbQLsO9cvnuRs9fhmSHet0QuV5IO/WE="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org AA4E36044E","From":"Kalle Valo ","To":"Arnd Bergmann ","Cc":"Arend van Spriel , Franky Lin\n\t, \n\tHante Meuleman , Chi-Hsien Lin\n\t, Wright Feng ,\n\tMauro Carvalho Chehab , \n\tJiri Pirko , \"David S. Miller\" , \n\tAndrey Ryabinin , Alexander Potapenko\n\t, Dmitry Vyukov ,\n\tMasahiro Yamada , \n\tMichal Marek ,\n\tAndrew Morton , Kees Cook\n\t, Geert Uytterhoeven ,\n\tGreg Kroah-Hartman , \n\tlinux-media@vger.kernel.org, linux-kernel@vger.kernel.org, \n\tnetdev@vger.kernel.org, linux-wireless@vger.kernel.org, \n\tbrcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com,\n\tkasan-dev@googlegroups.com, linux-kbuild@vger.kernel.org,\n\tJakub Jelinek , Martin =?utf-8?b?TGnFoWth?=\n\t","Subject":"Re: [PATCH v4 1/9] brcmsmac: make some local variables 'static\n\tconst' to reduce stack size","References":"<20170922212930.620249-1-arnd@arndb.de>\n\t<20170922212930.620249-2-arnd@arndb.de>","Date":"Mon, 25 Sep 2017 07:33:50 +0300","In-Reply-To":"<20170922212930.620249-2-arnd@arndb.de> (Arnd Bergmann's message\n\tof \"Fri, 22 Sep 2017 23:29:12 +0200\")","Message-ID":"<87h8vr75xt.fsf@kamboji.qca.qualcomm.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1778342,"web_url":"http://patchwork.ozlabs.org/comment/1778342/","msgid":"<20171002135348.7AFA560AFB@smtp.codeaurora.org>","list_archive_url":null,"date":"2017-10-02T13:53:48","subject":"Re: [v4,\n\t1/9] brcmsmac: make some local variables 'static const' to reduce\n\tstack size","submitter":{"id":65411,"url":"http://patchwork.ozlabs.org/api/people/65411/","name":"Kalle Valo","email":"kvalo@codeaurora.org"},"content":"Arnd Bergmann wrote:\n\n> With KASAN and a couple of other patches applied, this driver is one\n> of the few remaining ones that actually use more than 2048 bytes of\n> kernel stack:\n> \n> broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy_gainctrl':\n> broadcom/brcm80211/brcmsmac/phy/phy_n.c:16065:1: warning: the frame size of 3264 bytes is larger than 2048 bytes [-Wframe-larger-than=]\n> broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy':\n> broadcom/brcm80211/brcmsmac/phy/phy_n.c:17138:1: warning: the frame size of 2864 bytes is larger than 2048 bytes [-Wframe-larger-than=]\n> \n> Here, I'm reducing the stack size by marking as many local variables as\n> 'static const' as I can without changing the actual code.\n> \n> This is the first of three patches to improve the stack usage in this\n> driver. It would be good to have this backported to stabl kernels\n> to get all drivers in 'allmodconfig' below the 2048 byte limit so\n> we can turn on the frame warning again globally, but I realize that\n> the patch is larger than the normal limit for stable backports.\n> \n> The other two patches do not need to be backported.\n> \n> Cc: \n> Acked-by: Arend van Spriel \n> Signed-off-by: Arnd Bergmann \n\nPatch applied to wireless-drivers.git, thanks.\n\nc503dd38f850 brcmsmac: make some local variables 'static const' to reduce stack size","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"W8/UbxNb\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"ZlUSkKy0\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=kvalo@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5Ntj0NP8z9sRW\n\tfor ;\n\tTue, 3 Oct 2017 00:54:05 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751773AbdJBNxv (ORCPT );\n\tMon, 2 Oct 2017 09:53:51 -0400","from smtp.codeaurora.org ([198.145.29.96]:48782 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751357AbdJBNxt (ORCPT\n\t); Mon, 2 Oct 2017 09:53:49 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 7AFA560AFB; Mon, 2 Oct 2017 13:53:48 +0000 (UTC)","from [127.0.1.1] (85-76-48-161-nat.elisa-mobile.fi [85.76.48.161])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\t(Authenticated sender: kvalo@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id DAE80606DB;\n\tMon, 2 Oct 2017 13:53:39 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1506952428;\n\tbh=bDDYE3x2M2YtfIOvI+/1PF1a8j/jdoN2M6QbycTwsHI=;\n\th=Subject:From:In-Reply-To:References:To:Cc:Date:From;\n\tb=W8/UbxNbXwpEJ7PPrIqQaBD9R+9YISLSXQxfmwb/WWhcp2ffe++ePMLEYMkGs6iNW\n\te9RfjrhZg22Tnv3QJOUiIWHSJEy0y3Qm7Vi/6NUxIcnVKnrl9Z8Xm+XaWANCJUf8Fd\n\tKmIcnZoISHiyPNQJ2yJ5D/9o8Bgn0yMCGRNGnT24=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1506952427;\n\tbh=bDDYE3x2M2YtfIOvI+/1PF1a8j/jdoN2M6QbycTwsHI=;\n\th=Subject:From:In-Reply-To:References:To:Cc:From;\n\tb=ZlUSkKy0Se6Yzqek5CA+uOsWy8PRvUzCM/QicZRXu4D2H2j4tkqXdo2fGqepuUn6f\n\tyZE4gXQ/7QVpDcGBCx3umgR0D4F1w2flrFYxI7oddQZZKXtsmRGEANKlsIjHZN6GZ1\n\t3r+lGxJ36YJKjuHae0i38wBFHh7wZOPSX5wv09Yw="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no\n\tautolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org DAE80606DB","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"7bit","Subject":"Re: [v4,\n\t1/9] brcmsmac: make some local variables 'static const' to reduce\n\tstack size","From":"Kalle Valo ","In-Reply-To":"<20170922212930.620249-2-arnd@arndb.de>","References":"<20170922212930.620249-2-arnd@arndb.de>","To":"Arnd Bergmann ","Cc":"Arend van Spriel , Franky Lin\n\t, \n\tHante Meuleman , Chi-Hsien Lin\n\t, Wright Feng ,\n\tArnd Bergmann ,\n\tMauro Carvalho Chehab , Jiri Pirko\n\t, \"David S. Miller\" ,\n\tAndrey Ryabinin , \n\tAlexander Potapenko , Dmitry Vyukov\n\t, Masahiro Yamada ,\n\tMichal Marek , \n\tAndrew Morton , Kees Cook\n\t, Geert Uytterhoeven ,\n\tGreg Kroah-Hartman , \n\tlinux-media@vger.kernel.org, linux-kernel@vger.kernel.org, \n\tnetdev@vger.kernel.org, linux-wireless@vger.kernel.org, \n\tbrcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com,\n\tkasan-dev@googlegroups.com, linux-kbuild@vger.kernel.org,\n\tJakub Jelinek , =?utf-8?q?Martin_Li=C5=A1ka?=\n\t","User-Agent":"pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12","Message-Id":"<20171002135348.7AFA560AFB@smtp.codeaurora.org>","Date":"Mon, 2 Oct 2017 13:53:48 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]