[{"id":1778346,"web_url":"http://patchwork.ozlabs.org/comment/1778346/","msgid":"<20171002135556.82A7D60B7C@smtp.codeaurora.org>","list_archive_url":null,"date":"2017-10-02T13:55:56","subject":"Re: [v4,2/9] brcmsmac: split up wlc_phy_workarounds_nphy","submitter":{"id":65411,"url":"http://patchwork.ozlabs.org/api/people/65411/","name":"Kalle Valo","email":"kvalo@codeaurora.org"},"content":"Arnd Bergmann wrote:\n\n> The stack consumption in this driver is still relatively high, with one\n> remaining warning if the warning level is lowered to 1536 bytes:\n> \n> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:17135:1: error: the frame size of 1880 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]\n> \n> The affected function is actually a collection of three separate implementations,\n> and each of them is fairly large by itself. Splitting them up is done easily\n> and improves readability at the same time.\n> \n> I'm leaving the original indentation to make the review easier.\n> \n> Acked-by: Arend van Spriel \n> Signed-off-by: Arnd Bergmann \n\nI'll queue this for v4.15. Depends on:\n\nc503dd38f850 brcmsmac: make some local variables 'static const' to reduce stack size","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"f5HU1OBr\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"J3Avvxbn\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=kvalo@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5Nx671Krz9sRW\n\tfor ;\n\tTue, 3 Oct 2017 00:56:10 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751477AbdJBNz7 (ORCPT );\n\tMon, 2 Oct 2017 09:55:59 -0400","from smtp.codeaurora.org ([198.145.29.96]:49624 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750957AbdJBNz5 (ORCPT\n\t); Mon, 2 Oct 2017 09:55:57 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 82A7D60B7C; Mon, 2 Oct 2017 13:55:56 +0000 (UTC)","from [127.0.1.1] (85-76-48-161-nat.elisa-mobile.fi [85.76.48.161])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\t(Authenticated sender: kvalo@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id BE3526071B;\n\tMon, 2 Oct 2017 13:55:47 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1506952556;\n\tbh=+/2c+Ll7o20ZFphXgRnem8oVa2YswmI/N4gtlDGUZBo=;\n\th=Subject:From:In-Reply-To:References:To:Cc:Date:From;\n\tb=f5HU1OBrKGCcwVzx8diPbMvaS4eDpFnj9E8cDKWCQKd8V2BUCF8nbfWY2tFB+nsla\n\tFlGlsCHOb3XltsGwBWaoqAX3SMVHCT3uoAJWoW/4kQaVty6MgtBtPkExnLKBrG55Nn\n\tB1hdOtP1NBs2z7ZEefxlbL82g7U+teAMEhXbLApk=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1506952555;\n\tbh=+/2c+Ll7o20ZFphXgRnem8oVa2YswmI/N4gtlDGUZBo=;\n\th=Subject:From:In-Reply-To:References:To:Cc:From;\n\tb=J3AvvxbnNWohl00Yg31HVU6VEa/uScCG3bpuw5s6j6sQeiyC2CBCD8rpTI36Odk0i\n\tUQr16vguJ6iop7kP4eMqnsyi/ttPrU9zDhx4iKSUNYSSHSxJLusLYODwmVwJ88qrXq\n\tP23KejBhghb0NLFKPmVv/myHH0zGJZbt3JYIUcQ0="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no\n\tautolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org BE3526071B","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"7bit","Subject":"Re: [v4,2/9] brcmsmac: split up wlc_phy_workarounds_nphy","From":"Kalle Valo ","In-Reply-To":"<20170922212930.620249-3-arnd@arndb.de>","References":"<20170922212930.620249-3-arnd@arndb.de>","To":"Arnd Bergmann ","Cc":"Arend van Spriel , Franky Lin\n\t, \n\tHante Meuleman , Chi-Hsien Lin\n\t, Wright Feng ,\n\tArnd Bergmann ,\n\tMauro Carvalho Chehab , Jiri Pirko\n\t, \"David S. Miller\" ,\n\tAndrey Ryabinin , \n\tAlexander Potapenko , Dmitry Vyukov\n\t, Masahiro Yamada ,\n\tMichal Marek , \n\tAndrew Morton , Kees Cook\n\t, Geert Uytterhoeven ,\n\tGreg Kroah-Hartman , \n\tlinux-media@vger.kernel.org, linux-kernel@vger.kernel.org, \n\tnetdev@vger.kernel.org, linux-wireless@vger.kernel.org, \n\tbrcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com,\n\tkasan-dev@googlegroups.com, linux-kbuild@vger.kernel.org,\n\tJakub Jelinek , =?utf-8?q?Martin_Li=C5=A1ka?=\n\t","User-Agent":"pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12","Message-Id":"<20171002135556.82A7D60B7C@smtp.codeaurora.org>","Date":"Mon, 2 Oct 2017 13:55:56 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1794681,"web_url":"http://patchwork.ozlabs.org/comment/1794681/","msgid":"<20171027075109.6D3CE605A8@smtp.codeaurora.org>","list_archive_url":null,"date":"2017-10-27T07:51:09","subject":"Re: [v4,2/9] brcmsmac: split up wlc_phy_workarounds_nphy","submitter":{"id":65411,"url":"http://patchwork.ozlabs.org/api/people/65411/","name":"Kalle Valo","email":"kvalo@codeaurora.org"},"content":"Arnd Bergmann wrote:\n\n> The stack consumption in this driver is still relatively high, with one\n> remaining warning if the warning level is lowered to 1536 bytes:\n> \n> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:17135:1: error: the frame size of 1880 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]\n> \n> The affected function is actually a collection of three separate implementations,\n> and each of them is fairly large by itself. Splitting them up is done easily\n> and improves readability at the same time.\n> \n> I'm leaving the original indentation to make the review easier.\n> \n> Acked-by: Arend van Spriel \n> Signed-off-by: Arnd Bergmann \n\n2 patches applied to wireless-drivers-next.git, thanks.\n\n0425f079590c brcmsmac: split up wlc_phy_workarounds_nphy\nad1987d67392 brcmsmac: reindent split functions","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"a6Ntn5XR\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"JoCPfrjb\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=kvalo@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNbfm4V9Cz9s1h\n\tfor ;\n\tFri, 27 Oct 2017 18:51:28 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752058AbdJ0HvM (ORCPT );\n\tFri, 27 Oct 2017 03:51:12 -0400","from smtp.codeaurora.org ([198.145.29.96]:33826 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751599AbdJ0HvK (ORCPT\n\t); Fri, 27 Oct 2017 03:51:10 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 6D3CE605A8; Fri, 27 Oct 2017 07:51:09 +0000 (UTC)","from potku.adurom.net (a88-114-240-52.elisa-laajakaista.fi\n\t[88.114.240.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\t(Authenticated sender: kvalo@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id C3D536044E;\n\tFri, 27 Oct 2017 07:51:01 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1509090669;\n\tbh=Hm9Ll+C2LpA7ywwFd94leFlpl3rQ3hjql34xjDk3Jnc=;\n\th=Subject:From:In-Reply-To:References:To:Cc:Date:From;\n\tb=a6Ntn5XRO7hiHKOP0AhzmSLUNiwm3QCCHhJbhiTrFI0ucNU7/xIrY4PEZT7uSf3+r\n\tsPCo+4R0a2eyccDZYCo90kJBEsKofbf8jilKOdNKWDAHDgsruCN7zPKjS0P92bV3lh\n\tw7rfDVEMava3l408U1i0gYh7PWx85B1vxDNdmt48=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1509090667;\n\tbh=Hm9Ll+C2LpA7ywwFd94leFlpl3rQ3hjql34xjDk3Jnc=;\n\th=Subject:From:In-Reply-To:References:To:Cc:From;\n\tb=JoCPfrjbom/dv5/NbJHvB2Hqq2mgoZniYMzMjEZieTC1WmSdEB7obRFNZYw82EvNO\n\tigeOYCcDTdMPEaRqDigqO2dd3YH5rHLGqPzz01Qs94jDZlWtTBUDEtgNiKYxED7BjX\n\t/DxLz9SpOiUTIsmWX0P8cU+BBRR2RyHSxijoIYn0="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no\n\tautolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org C3D536044E","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"7bit","Subject":"Re: [v4,2/9] brcmsmac: split up wlc_phy_workarounds_nphy","From":"Kalle Valo ","In-Reply-To":"<20170922212930.620249-3-arnd@arndb.de>","References":"<20170922212930.620249-3-arnd@arndb.de>","To":"Arnd Bergmann ","Cc":"Arend van Spriel , Franky Lin\n\t, \n\tHante Meuleman , Chi-Hsien Lin\n\t, Wright Feng ,\n\tArnd Bergmann ,\n\tMauro Carvalho Chehab , Jiri Pirko\n\t, \"David S. Miller\" ,\n\tAndrey Ryabinin , \n\tAlexander Potapenko , Dmitry Vyukov\n\t, Masahiro Yamada ,\n\tMichal Marek , \n\tAndrew Morton , Kees Cook\n\t, Geert Uytterhoeven ,\n\tGreg Kroah-Hartman , \n\tlinux-media@vger.kernel.org, linux-kernel@vger.kernel.org, \n\tnetdev@vger.kernel.org, linux-wireless@vger.kernel.org, \n\tbrcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com,\n\tkasan-dev@googlegroups.com, linux-kbuild@vger.kernel.org,\n\tJakub Jelinek , =?utf-8?q?Martin_Li=C5=A1ka?=\n\t","User-Agent":"pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12","Message-Id":"<20171027075109.6D3CE605A8@smtp.codeaurora.org>","Date":"Fri, 27 Oct 2017 07:51:09 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]