[{"id":1775112,"web_url":"http://patchwork.ozlabs.org/comment/1775112/","msgid":"<20170925.201951.1512252559012166718.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-26T03:19:51","subject":"Re: [PATCH v4 8/9] netlink: fix nla_put_{u8,u16,u32} for KASAN","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Arnd Bergmann \nDate: Fri, 22 Sep 2017 23:29:19 +0200\n\n> When CONFIG_KASAN is enabled, the \"--param asan-stack=1\" causes rather large\n> stack frames in some functions. This goes unnoticed normally because\n> CONFIG_FRAME_WARN is disabled with CONFIG_KASAN by default as of commit\n> 3f181b4d8652 (\"lib/Kconfig.debug: disable -Wframe-larger-than warnings with\n> KASAN=y\").\n> \n> The kernelci.org build bot however has the warning enabled and that led\n> me to investigate it a little further, as every build produces these warnings:\n> \n> net/wireless/nl80211.c:4389:1: warning: the frame size of 2240 bytes is larger than 2048 bytes [-Wframe-larger-than=]\n> net/wireless/nl80211.c:1895:1: warning: the frame size of 3776 bytes is larger than 2048 bytes [-Wframe-larger-than=]\n> net/wireless/nl80211.c:1410:1: warning: the frame size of 2208 bytes is larger than 2048 bytes [-Wframe-larger-than=]\n> net/bridge/br_netlink.c:1282:1: warning: the frame size of 2544 bytes is larger than 2048 bytes [-Wframe-larger-than=]\n> \n> Most of this problem is now solved in gcc-8, which can consolidate\n> the stack slots for the inline function arguments. On older compilers\n> we can add a workaround by declaring a local variable in each function\n> to pass the inline function argument.\n> \n> Cc: stable@vger.kernel.org\n> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715\n> Signed-off-by: Arnd Bergmann \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1R5w3fy7z9t3F\n\tfor ;\n\tTue, 26 Sep 2017 13:20:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S965382AbdIZDTz (ORCPT );\n\tMon, 25 Sep 2017 23:19:55 -0400","from shards.monkeyblade.net ([184.105.139.130]:40262 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S964958AbdIZDTx (ORCPT\n\t); Mon, 25 Sep 2017 23:19:53 -0400","from localhost (74-93-104-102-Washington.hfc.comcastbusiness.net\n\t[74.93.104.102])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 4FEFC133F673A;\n\tMon, 25 Sep 2017 20:19:52 -0700 (PDT)"],"Date":"Mon, 25 Sep 2017 20:19:51 -0700 (PDT)","Message-Id":"<20170925.201951.1512252559012166718.davem@davemloft.net>","To":"arnd@arndb.de","Cc":"mchehab@kernel.org, jiri@resnulli.us, arend.vanspriel@broadcom.com,\n\tkvalo@codeaurora.org, aryabinin@virtuozzo.com, glider@google.com,\n\tdvyukov@google.com, yamada.masahiro@socionext.com, mmarek@suse.com,\n\takpm@linux-foundation.org, keescook@chromium.org,\n\tgeert@linux-m68k.org, gregkh@linuxfoundation.org,\n\tlinux-media@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tnetdev@vger.kernel.org, linux-wireless@vger.kernel.org,\n\tbrcm80211-dev-list.pdl@broadcom.com,\n\tbrcm80211-dev-list@cypress.com, kasan-dev@googlegroups.com,\n\tlinux-kbuild@vger.kernel.org, jakub@gcc.gnu.org,\n\tmarxin@gcc.gnu.org, stable@vger.kernel.org","Subject":"Re: [PATCH v4 8/9] netlink: fix nla_put_{u8,u16,u32} for KASAN","From":"David Miller ","In-Reply-To":"<20170922212930.620249-9-arnd@arndb.de>","References":"<20170922212930.620249-1-arnd@arndb.de>\n\t<20170922212930.620249-9-arnd@arndb.de>","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 25 Sep 2017 20:19:53 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]