[{"id":1775111,"web_url":"http://patchwork.ozlabs.org/comment/1775111/","msgid":"<20170925.201944.383866196624108211.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-26T03:19:44","subject":"Re: [PATCH v4 7/9] rocker: fix rocker_tlv_put_* functions for KASAN","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Arnd Bergmann \nDate: Fri, 22 Sep 2017 23:29:18 +0200\n\n> Inlining these functions creates lots of stack variables that each take\n> 64 bytes when KASAN is enabled, leading to this warning about potential\n> stack overflow:\n> \n> drivers/net/ethernet/rocker/rocker_ofdpa.c: In function 'ofdpa_cmd_flow_tbl_add':\n> drivers/net/ethernet/rocker/rocker_ofdpa.c:621:1: error: the frame size of 2752 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]\n> \n> gcc-8 can now consolidate the stack slots itself, but on older versions\n> we get the same behavior by using a temporary variable that holds a\n> copy of the inline function argument.\n> \n> Cc: stable@vger.kernel.org\n> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715\n> Signed-off-by: Arnd Bergmann \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1R5g5Qqxz9t3R\n\tfor ;\n\tTue, 26 Sep 2017 13:19:51 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S965350AbdIZDTt (ORCPT );\n\tMon, 25 Sep 2017 23:19:49 -0400","from shards.monkeyblade.net ([184.105.139.130]:40218 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S964958AbdIZDTr (ORCPT\n\t); Mon, 25 Sep 2017 23:19:47 -0400","from localhost (74-93-104-102-Washington.hfc.comcastbusiness.net\n\t[74.93.104.102])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 89EA6133F6537;\n\tMon, 25 Sep 2017 20:19:45 -0700 (PDT)"],"Date":"Mon, 25 Sep 2017 20:19:44 -0700 (PDT)","Message-Id":"<20170925.201944.383866196624108211.davem@davemloft.net>","To":"arnd@arndb.de","Cc":"jiri@resnulli.us, mchehab@kernel.org, arend.vanspriel@broadcom.com,\n\tkvalo@codeaurora.org, aryabinin@virtuozzo.com, glider@google.com,\n\tdvyukov@google.com, yamada.masahiro@socionext.com, mmarek@suse.com,\n\takpm@linux-foundation.org, keescook@chromium.org,\n\tgeert@linux-m68k.org, gregkh@linuxfoundation.org,\n\tlinux-media@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tnetdev@vger.kernel.org, linux-wireless@vger.kernel.org,\n\tbrcm80211-dev-list.pdl@broadcom.com,\n\tbrcm80211-dev-list@cypress.com, kasan-dev@googlegroups.com,\n\tlinux-kbuild@vger.kernel.org, jakub@gcc.gnu.org,\n\tmarxin@gcc.gnu.org, stable@vger.kernel.org","Subject":"Re: [PATCH v4 7/9] rocker: fix rocker_tlv_put_* functions for KASAN","From":"David Miller ","In-Reply-To":"<20170922212930.620249-8-arnd@arndb.de>","References":"<20170922212930.620249-1-arnd@arndb.de>\n\t<20170922212930.620249-8-arnd@arndb.de>","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 25 Sep 2017 20:19:46 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]