[{"id":1780116,"web_url":"http://patchwork.ozlabs.org/comment/1780116/","msgid":"<20171004205808.c66hjl6il463q4ka@rob-hp-laptop>","list_archive_url":null,"date":"2017-10-04T20:58:08","subject":"Re: [PATCH v3 1/6] dt-bindings: fsi: Add SBEFIFO documentation","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Fri, Sep 22, 2017 at 04:05:57PM -0500, Eddie James wrote:\n> From: \"Edward A. James\" \n> \n> Document the bindings for the SBE CFAM device. SBE devices are\n> located on a CFAM off an FSI bus.\n> \n> Signed-off-by: Edward A. James \n> ---\n> .../devicetree/bindings/fsi/ibm,p9-sbefifo.txt | 20 ++++++++++++++++++++\n> 1 file changed, 20 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt\n> \n> diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt\n> new file mode 100644\n> index 0000000..07fbf29\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt\n> @@ -0,0 +1,20 @@\n> +Device-tree bindings for P9 SBEFIFO CFAM device\n> +-----------------------------------------------\n> +\n> +Required properties:\n> + - reg = < address size >\t\t: FSI CFAM address for the SBE engine\n> +\t\t\t\t\t and address space size.\n\ncompatible? \n\n> +\n> +Optional properties:\n> + - \t\t\t: Devices that are accessible through\n> +\t\t\t\t\t the SBEFIFO.\n\nYou need some sort of definition what's in the child nodes.\n\n> +\n> +Examples:\n> +\n> + sbefifo@2400 {\n> + reg = < 0x2400 0x400 >;\n\nNeed #{address,size}-cells here.\n\n> +\n> + occ@1 {\n\nNeed a reg property here and you need to define what reg represents.\n\n> + ...\n> + };\n> + };\n> -- \n> 1.8.3.1\n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y6pC95xfPz9t3h\n\tfor ;\n\tThu, 5 Oct 2017 07:58:13 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751047AbdJDU6L (ORCPT\n\t);\n\tWed, 4 Oct 2017 16:58:11 -0400","from mail-oi0-f65.google.com ([209.85.218.65]:56741 \"EHLO\n\tmail-oi0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750797AbdJDU6K (ORCPT\n\t); Wed, 4 Oct 2017 16:58:10 -0400","by mail-oi0-f65.google.com with SMTP id v9so9455111oif.13;\n\tWed, 04 Oct 2017 13:58:10 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tq7sm563543oif.44.2017.10.04.13.58.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 04 Oct 2017 13:58:09 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=dxxI++rkbB6HeF+YWBb8+Ns1JVQNT1exJQ7pTqVhf5k=;\n\tb=uLSwmo032PJnLsp/JjMMf9PELqJqI82ExllBUjaxUV9tg87QXA/09SXBFbEmK37gNe\n\tPxI/T5Vo3ah6YDkYpMNmWWpvMfEq1KSUkcX8q/JsekHLLvOTtRxGIzWZXoIDNLs+oetq\n\thBojt6UHV9nkOri0WmeYTF19iNv2adzGhphPgwpNHJHi1esPppdckWVc+dudCEPzaPJl\n\tTCsFzPfF5RKTiKTzaa5YDFWVnn5vrxuxSU3ZD9JjDbX4jtvTFzuadiWbsa+YbcS2rfZr\n\tt3rECU7Af6OGohV6ArJYZgFEUNtZP6woXuhD738M515+O0s4ndywANPJ6sUKS1Lrc1qU\n\tQ1EQ==","X-Gm-Message-State":"AMCzsaWZjmHszWNgZeZHGYWZaHXB6KPnVDTJDx8VkBcXDsF3Fw035/On\n\tLrVgkefM03bQyDNSZOCKAg==","X-Google-Smtp-Source":"AOwi7QBCeOKxYHE8ACNeGpJQ2wx78gcyVGHM9WlvYHyDqGxsChpBxRzfjswaNj9yDyqmx3DXCX7qNg==","X-Received":"by 10.202.117.148 with SMTP id q142mr5563002oic.26.1507150689658;\n\tWed, 04 Oct 2017 13:58:09 -0700 (PDT)","Date":"Wed, 4 Oct 2017 15:58:08 -0500","From":"Rob Herring ","To":"Eddie James ","Cc":"linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,\n\tdevicetree@vger.kernel.org, mark.rutland@arm.com,\n\tbradleyb@fuzziesquirrel.com, jk@ozlabs.org,\n\tcbostic@linux.vnet.ibm.com, joel@jms.id.au, andrew@aj.id.au,\n\t\"Edward A. James\" ","Subject":"Re: [PATCH v3 1/6] dt-bindings: fsi: Add SBEFIFO documentation","Message-ID":"<20171004205808.c66hjl6il463q4ka@rob-hp-laptop>","References":"<1506114362-492-1-git-send-email-eajames@linux.vnet.ibm.com>\n\t<1506114362-492-2-git-send-email-eajames@linux.vnet.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1506114362-492-2-git-send-email-eajames@linux.vnet.ibm.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]