[{"id":1865287,"web_url":"http://patchwork.ozlabs.org/comment/1865287/","msgid":"<CAKmqyKMnvTe5xQ8vTH28voRh+K5jxjcPJ1X8MBSKX--HUhxA2g@mail.gmail.com>","list_archive_url":null,"date":"2018-02-27T22:33:17","subject":"Re: [Qemu-devel] [PATCH v5 3/7] hw/mdio: Generalize phy\n\tinitialization routine","submitter":{"id":47878,"url":"http://patchwork.ozlabs.org/api/people/47878/","name":"Alistair Francis","email":"alistair.francis@xilinx.com"},"content":"On Fri, Sep 22, 2017 at 10:13 AM, Philippe Mathieu-Daudé\n<f4bug@amsat.org> wrote:\n> From: Grant Likely <grant.likely@arm.com>\n>\n> There really isn't anything tdk-specific about tdk_init() other than the\n> phy id registers. The function should instead be generalized for any\n> phy, at least as far as the ID registers are concerned. For the most\n> part the read/write behaviour should be very similar across PHYs.\n>\n> This patch renames tdk_{read,write,init}() to mdio_phy_*() so it can be\n> used for any PHY.\n>\n> More work definitely needs to be done here to make it easy to override\n> the default behaviour for specific PHYs, but this at least is a\n> reasonable start.\n>\n> Signed-off-by: Grant Likely <grant.likely@arm.com>\n> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n> [PMD: just rebased]\n> ---\n>  include/hw/net/mdio.h   |  2 +-\n>  hw/net/etraxfs_eth.c    |  2 +-\n>  hw/net/mdio.c           | 14 +++++++-------\n>  hw/net/xilinx_axienet.c |  2 +-\n>  4 files changed, 10 insertions(+), 10 deletions(-)\n>\n> diff --git a/include/hw/net/mdio.h b/include/hw/net/mdio.h\n> index 7ffa4389b9..b3b4f497c0 100644\n> --- a/include/hw/net/mdio.h\n> +++ b/include/hw/net/mdio.h\n> @@ -86,7 +86,7 @@ struct qemu_mdio {\n>      struct qemu_phy *devs[32];\n>  };\n>\n> -void tdk_init(struct qemu_phy *phy);\n> +void mdio_phy_init(struct qemu_phy *phy, uint16_t id1, uint16_t id2);\n>  void mdio_attach(struct qemu_mdio *bus, struct qemu_phy *phy,\n>                   unsigned int addr);\n>  uint16_t mdio_read_req(struct qemu_mdio *bus, uint8_t addr, uint8_t req);\n> diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c\n> index f8d8f8441d..4c5415771f 100644\n> --- a/hw/net/etraxfs_eth.c\n> +++ b/hw/net/etraxfs_eth.c\n> @@ -333,7 +333,7 @@ static int fs_eth_init(SysBusDevice *sbd)\n>      qemu_format_nic_info_str(qemu_get_queue(s->nic), s->conf.macaddr.a);\n>\n>\n> -    tdk_init(&s->phy);\n> +    mdio_phy_init(&s->phy, 0x0300, 0xe400);\n>      mdio_attach(&s->mdio_bus, &s->phy, s->phyaddr);\n>      return 0;\n>  }\n> diff --git a/hw/net/mdio.c b/hw/net/mdio.c\n> index 3d70d99077..33bfbb4623 100644\n> --- a/hw/net/mdio.c\n> +++ b/hw/net/mdio.c\n> @@ -43,7 +43,7 @@\n>   * linux driver (PHYID and Diagnostics reg).\n>   * TODO: Add friendly names for the register nums.\n>   */\n> -static unsigned int tdk_read(struct qemu_phy *phy, unsigned int req)\n> +static unsigned int mdio_phy_read(struct qemu_phy *phy, unsigned int req)\n>  {\n>      int regnum;\n>      unsigned r = 0;\n> @@ -107,7 +107,7 @@ static unsigned int tdk_read(struct qemu_phy *phy, unsigned int req)\n>      return r;\n>  }\n>\n> -static void tdk_write(struct qemu_phy *phy, unsigned int req, unsigned int data)\n> +static void mdio_phy_write(struct qemu_phy *phy, unsigned int req, unsigned int data)\n>  {\n>      int regnum;\n>\n> @@ -120,18 +120,18 @@ static void tdk_write(struct qemu_phy *phy, unsigned int req, unsigned int data)\n>      }\n>  }\n>\n> -void tdk_init(struct qemu_phy *phy)\n> +void mdio_phy_init(struct qemu_phy *phy, uint16_t id1, uint16_t id2)\n>  {\n>      phy->regs[PHY_CTRL] = 0x3100;\n>      /* PHY Id. */\n> -    phy->regs[PHY_ID1] = 0x0300;\n> -    phy->regs[PHY_ID2] = 0xe400;\n> +    phy->regs[PHY_ID1] = id1;\n> +    phy->regs[PHY_ID2] = id2;\n\nThese should be set by QEMU properties instead of values to the init() function.\n\nAlistair\n\n>      /* Autonegotiation advertisement reg. */\n>      phy->regs[PHY_AUTONEG_ADV] = 0x01e1;\n>      phy->link = 1;\n>\n> -    phy->read = tdk_read;\n> -    phy->write = tdk_write;\n> +    phy->read = mdio_phy_read;\n> +    phy->write = mdio_phy_write;\n>  }\n>\n>  void mdio_attach(struct qemu_mdio *bus, struct qemu_phy *phy, unsigned int addr)\n> diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c\n> index 1e859fdaae..408cd6e675 100644\n> --- a/hw/net/xilinx_axienet.c\n> +++ b/hw/net/xilinx_axienet.c\n> @@ -791,7 +791,7 @@ static void xilinx_enet_realize(DeviceState *dev, Error **errp)\n>                            object_get_typename(OBJECT(dev)), dev->id, s);\n>      qemu_format_nic_info_str(qemu_get_queue(s->nic), s->conf.macaddr.a);\n>\n> -    tdk_init(&s->TEMAC.phy);\n> +    mdio_phy_init(&s->TEMAC.phy, 0x0300, 0xe400);\n>      mdio_attach(&s->TEMAC.mdio_bus, &s->TEMAC.phy, s->c_phyaddr);\n>\n>      s->TEMAC.parent = s;\n> --\n> 2.14.1\n>\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=xilinx.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QI63XTkC\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zrYQp3gJdz9s19\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 28 Feb 2018 09:34:25 +1100 (AEDT)","from localhost ([::1]:40471 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1eqnpF-0001Y6-P5\n\tfor incoming@patchwork.ozlabs.org; Tue, 27 Feb 2018 17:34:21 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:48180)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <alistair23@gmail.com>) id 1eqnon-0001UO-PS\n\tfor qemu-devel@nongnu.org; Tue, 27 Feb 2018 17:33:54 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <alistair23@gmail.com>) id 1eqnom-0003pD-F8\n\tfor qemu-devel@nongnu.org; Tue, 27 Feb 2018 17:33:53 -0500","from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:42092)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <alistair23@gmail.com>)\n\tid 1eqnoj-0003nA-Hr; Tue, 27 Feb 2018 17:33:49 -0500","by mail-lf0-x242.google.com with SMTP id t204so616945lff.9;\n\tTue, 27 Feb 2018 14:33:49 -0800 (PST)","by 10.46.32.215 with HTTP; Tue, 27 Feb 2018 14:33:17 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=57adKdu0hKOE4+GLSIE7Z0q25u9QsxkiN+PVgeZW+/0=;\n\tb=QI63XTkC2mBbXtYtsFaBm4EwYhDVFOaW9jSMRAS7TI28N4noH1U/kHHrnCTprBDsbD\n\tHx4Uv8WsF0L++ob0xWh0D2Ym91bAzeg97uuSqgseUpE56IlHrABoYREWRUb7EwLn/LiD\n\tLcuF8NRECjZdXcjA5gEKdmh8jX1W1H2Su2oE9bfFHkaa+73oYV196JJAvJ9eCnOv0VsG\n\tphc8flYbPQTtCMX+W8g1HBcZfd6G9/u6tYI/GqFQjAMKOWLJU6rHPDYiWT9r2Y4f6zul\n\t0wfpP500z5ihRwxZ1BWDPus6jxtoXNC+gPSzPwnPJAFVtUvYMEOpc0kNses33hde2eFm\n\tOoow==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=57adKdu0hKOE4+GLSIE7Z0q25u9QsxkiN+PVgeZW+/0=;\n\tb=nNkXNF5VYv7aiT1czLn6RPmuwRx4T6S1+c8tp02w0KHgsnJPrbnY/mNotXn23cZSri\n\twQGSDoJO+a4H5sdpAB/9tTqDXmB+E+xjQ3CHyMkkP+rzU8U3lN2Y7XSGikNrjsGOA3JK\n\tbZAeuiD5mt7NEFHiA6adxkG5/dhEriMZols4t3UoZ9XKvsYNCGu211GAxV+7oAVvehpF\n\tDUKrN64gYecvIJu9VsdjwUK9aQaDSIIoco5Jt4SIAdYoJUMY6DrUHn1rsPlfdiEzMkmD\n\tHRUnOCLISMOpGdWwBTinjKKrflJJGszrNq9g28tK69PtIQNiRB+ytyVj08ZKyqWQaE7b\n\t/5lQ==","X-Gm-Message-State":"APf1xPA35pMw2LFWlqqVNDa6bdbvju0s9pMfhW4rL+aRIq/2vmk3jw6O\n\tkqQx7oU6V58NxwU4Z96SbhBBVJ0bdSc7ejZaaJ8=","X-Google-Smtp-Source":"AG47ELsjwmYmKtOv8GyQifAT9e6W5wj5olSjVTMWcM1wva2GndV0HPFxdHrrsjcSgZ9/VoiWyOtdzBf/xFF972j7z7I=","X-Received":"by 10.46.7.80 with SMTP id i16mr8258236ljd.78.1519770828266; Tue,\n\t27 Feb 2018 14:33:48 -0800 (PST)","MIME-Version":"1.0","In-Reply-To":"<20170922171323.10348-4-f4bug@amsat.org>","References":"<20170922171323.10348-1-f4bug@amsat.org>\n\t<20170922171323.10348-4-f4bug@amsat.org>","From":"Alistair Francis <alistair.francis@xilinx.com>","Date":"Tue, 27 Feb 2018 14:33:17 -0800","X-Google-Sender-Auth":"gDRFDkh0_OFkQ9-WUXGNyVsrR8o","Message-ID":"<CAKmqyKMnvTe5xQ8vTH28voRh+K5jxjcPJ1X8MBSKX--HUhxA2g@mail.gmail.com>","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:4010:c07::242","Subject":"Re: [Qemu-devel] [PATCH v5 3/7] hw/mdio: Generalize phy\n\tinitialization routine","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>, Fam Zheng <famz@redhat.com>,\n\tJason Wang <jasowang@redhat.com>, \"qemu-devel@nongnu.org Developers\"\n\t<qemu-devel@nongnu.org>, \n\tAlistair Francis <alistair.francis@xilinx.com>, Grant Likely\n\t<grant.likely@arm.com>, qemu-arm <qemu-arm@nongnu.org>, \"Edgar E.\n\tIglesias\" <edgar.iglesias@gmail.com>, =?utf-8?q?Andreas_F=C3=A4rber?=\n\t<afaerber@suse.de>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1921931,"web_url":"http://patchwork.ozlabs.org/comment/1921931/","msgid":"<9c754e08-d7ed-bea9-cd22-92d8a57e6335@amsat.org>","list_archive_url":null,"date":"2018-05-28T03:09:34","subject":"Re: [Qemu-devel] [PATCH v5 3/7] hw/mdio: Generalize phy\n\tinitialization routine","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"Hi Alistair,\n\nOn 02/27/2018 07:33 PM, Alistair Francis wrote:\n> On Fri, Sep 22, 2017 at 10:13 AM, Philippe Mathieu-Daudé\n> <f4bug@amsat.org> wrote:\n>> From: Grant Likely <grant.likely@arm.com>\n>>\n>> There really isn't anything tdk-specific about tdk_init() other than the\n>> phy id registers. The function should instead be generalized for any\n>> phy, at least as far as the ID registers are concerned. For the most\n>> part the read/write behaviour should be very similar across PHYs.\n>>\n>> This patch renames tdk_{read,write,init}() to mdio_phy_*() so it can be\n>> used for any PHY.\n>>\n>> More work definitely needs to be done here to make it easy to override\n>> the default behaviour for specific PHYs, but this at least is a\n>> reasonable start.\n>>\n>> Signed-off-by: Grant Likely <grant.likely@arm.com>\n>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n>> [PMD: just rebased]\n>> ---\n>>  include/hw/net/mdio.h   |  2 +-\n>>  hw/net/etraxfs_eth.c    |  2 +-\n>>  hw/net/mdio.c           | 14 +++++++-------\n>>  hw/net/xilinx_axienet.c |  2 +-\n>>  4 files changed, 10 insertions(+), 10 deletions(-)\n>>\n>> diff --git a/include/hw/net/mdio.h b/include/hw/net/mdio.h\n>> index 7ffa4389b9..b3b4f497c0 100644\n>> --- a/include/hw/net/mdio.h\n>> +++ b/include/hw/net/mdio.h\n>> @@ -86,7 +86,7 @@ struct qemu_mdio {\n>>      struct qemu_phy *devs[32];\n>>  };\n>>\n>> -void tdk_init(struct qemu_phy *phy);\n>> +void mdio_phy_init(struct qemu_phy *phy, uint16_t id1, uint16_t id2);\n>>  void mdio_attach(struct qemu_mdio *bus, struct qemu_phy *phy,\n>>                   unsigned int addr);\n>>  uint16_t mdio_read_req(struct qemu_mdio *bus, uint8_t addr, uint8_t req);\n>> diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c\n>> index f8d8f8441d..4c5415771f 100644\n>> --- a/hw/net/etraxfs_eth.c\n>> +++ b/hw/net/etraxfs_eth.c\n>> @@ -333,7 +333,7 @@ static int fs_eth_init(SysBusDevice *sbd)\n>>      qemu_format_nic_info_str(qemu_get_queue(s->nic), s->conf.macaddr.a);\n>>\n>>\n>> -    tdk_init(&s->phy);\n>> +    mdio_phy_init(&s->phy, 0x0300, 0xe400);\n>>      mdio_attach(&s->mdio_bus, &s->phy, s->phyaddr);\n>>      return 0;\n>>  }\n>> diff --git a/hw/net/mdio.c b/hw/net/mdio.c\n>> index 3d70d99077..33bfbb4623 100644\n>> --- a/hw/net/mdio.c\n>> +++ b/hw/net/mdio.c\n>> @@ -43,7 +43,7 @@\n>>   * linux driver (PHYID and Diagnostics reg).\n>>   * TODO: Add friendly names for the register nums.\n>>   */\n>> -static unsigned int tdk_read(struct qemu_phy *phy, unsigned int req)\n>> +static unsigned int mdio_phy_read(struct qemu_phy *phy, unsigned int req)\n>>  {\n>>      int regnum;\n>>      unsigned r = 0;\n>> @@ -107,7 +107,7 @@ static unsigned int tdk_read(struct qemu_phy *phy, unsigned int req)\n>>      return r;\n>>  }\n>>\n>> -static void tdk_write(struct qemu_phy *phy, unsigned int req, unsigned int data)\n>> +static void mdio_phy_write(struct qemu_phy *phy, unsigned int req, unsigned int data)\n>>  {\n>>      int regnum;\n>>\n>> @@ -120,18 +120,18 @@ static void tdk_write(struct qemu_phy *phy, unsigned int req, unsigned int data)\n>>      }\n>>  }\n>>\n>> -void tdk_init(struct qemu_phy *phy)\n>> +void mdio_phy_init(struct qemu_phy *phy, uint16_t id1, uint16_t id2)\n>>  {\n>>      phy->regs[PHY_CTRL] = 0x3100;\n>>      /* PHY Id. */\n>> -    phy->regs[PHY_ID1] = 0x0300;\n>> -    phy->regs[PHY_ID2] = 0xe400;\n>> +    phy->regs[PHY_ID1] = id1;\n>> +    phy->regs[PHY_ID2] = id2;\n> \n> These should be set by QEMU properties instead of values to the init() function.\n\nI agree, but this is not (yet) a QOM'ified device.\nI believe if I start to QOM'ify it this series will finish in 1 more\nyear. This is however a nice cleanup so far, and the QOM device can come\nin a follow up series.\n\n> \n> Alistair\n> \n>>      /* Autonegotiation advertisement reg. */\n>>      phy->regs[PHY_AUTONEG_ADV] = 0x01e1;\n>>      phy->link = 1;\n>>\n>> -    phy->read = tdk_read;\n>> -    phy->write = tdk_write;\n>> +    phy->read = mdio_phy_read;\n>> +    phy->write = mdio_phy_write;\n>>  }\n>>\n>>  void mdio_attach(struct qemu_mdio *bus, struct qemu_phy *phy, unsigned int addr)\n>> diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c\n>> index 1e859fdaae..408cd6e675 100644\n>> --- a/hw/net/xilinx_axienet.c\n>> +++ b/hw/net/xilinx_axienet.c\n>> @@ -791,7 +791,7 @@ static void xilinx_enet_realize(DeviceState *dev, Error **errp)\n>>                            object_get_typename(OBJECT(dev)), dev->id, s);\n>>      qemu_format_nic_info_str(qemu_get_queue(s->nic), s->conf.macaddr.a);\n>>\n>> -    tdk_init(&s->TEMAC.phy);\n>> +    mdio_phy_init(&s->TEMAC.phy, 0x0300, 0xe400);\n>>      mdio_attach(&s->TEMAC.mdio_bus, &s->TEMAC.phy, s->c_phyaddr);\n>>\n>>      s->TEMAC.parent = s;\n>> --\n>> 2.14.1\n>>\n>>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=amsat.org","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XRSzO870\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40vML11DxDz9s0y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 28 May 2018 13:10:15 +1000 (AEST)","from localhost ([::1]:53955 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1fN8Xz-0005sJ-Tv\n\tfor incoming@patchwork.ozlabs.org; Sun, 27 May 2018 23:10:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57952)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1fN8XZ-0005sC-4o\n\tfor qemu-devel@nongnu.org; Sun, 27 May 2018 23:09:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1fN8XV-0005Uq-Vv\n\tfor qemu-devel@nongnu.org; Sun, 27 May 2018 23:09:45 -0400","from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:46771)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1fN8XV-0005UD-Qs; Sun, 27 May 2018 23:09:41 -0400","by mail-qk0-x242.google.com with SMTP id k86-v6so8211831qkh.13;\n\tSun, 27 May 2018 20:09:41 -0700 (PDT)","from [192.168.1.11] ([138.117.48.222])\n\tby smtp.gmail.com with ESMTPSA id\n\tx138-v6sm9900111qkx.15.2018.05.27.20.09.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 27 May 2018 20:09:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:openpgp:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=CvSaOZaPkTEIz7CQQMEy6B0w/s0yopidwYRw7Qki4SU=;\n\tb=XRSzO870eAdn4RWap817kuzdE45D5qq9P9Aq67T9uj5qs1ylOUCIVFrwCyPxwrXkIO\n\ti7aSjCR2wa21gQleP8aejie0JCphQGwm/tj2njvLtcKDYuTTbo2+/qhTKEAczaq13iPZ\n\tzc+0qWKJ9JVM0jy3pwOtEUvgxfSvx3aKQeJZr3h3/lYtP9K9nBg7WlY2ohwWR6lQ+Tkl\n\tQ/syl1kFtAHgHu9+vqwh+vlZDOolYW8bJrfXtT61ATfSCL2tGnUsKIJ6DgicmUJiTous\n\trs+to8enoZZqgwMfLRjKqn4hXpnXEXufS32hGiV6hY065WgTVeCkUY8P/qwcNYfNUA8n\n\tXVxQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:openpgp\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=CvSaOZaPkTEIz7CQQMEy6B0w/s0yopidwYRw7Qki4SU=;\n\tb=rjBwMBDyfaaCBiRJNyauyVtAjbRsHIg8M/2SSwN3Wp5m90OYn8MTrDhmR0YltNckDk\n\t1i29+WvPQd1+Fh+2+kihvqmWN8c5q8RrwqJFYzBMQOdxLJG+Ki++182mzQe4YAf9pSHt\n\td65Zw0qN9mSJvGrV5SkzKOc31bLTPRRaXhpIaNiufWLOGUHq3pxWoc/isCBwggWha5Fw\n\tvvUoH0xnw9HuEfJD7BlzUuIe8XtUupEigfsg1uE6WujOXlCagn9OD9FUM+CNzQZMt/Jc\n\tjDEHMNpqJ9ALU4sl2nXiRGNPcM3LrbyGUUaXhkGfEAW4lwojRbrJFyY6Z2gH76mYyWoW\n\tglAg==","X-Gm-Message-State":"ALKqPwc8FV6gHWddxu8J7g+uNLPkHFQ7mC5TuVw3IrMvqAbZm05nfxUG\n\t+ubTZ7D5iAV91OFD5rxWMYAplmRP","X-Google-Smtp-Source":"ADUXVKLcLdn44mIpW5o50LOnA/8sTkBZhzM6SC8ugntwEAMxjktHWZJCIafg3Pwkqdgy6LaGDXabag==","X-Received":"by 2002:a37:5184:: with SMTP id\n\tf126-v6mr9635195qkb.265.1527476980763; \n\tSun, 27 May 2018 20:09:40 -0700 (PDT)","To":"Alistair Francis <alistair@alistair23.me>","References":"<20170922171323.10348-1-f4bug@amsat.org>\n\t<20170922171323.10348-4-f4bug@amsat.org>\n\t<CAKmqyKMnvTe5xQ8vTH28voRh+K5jxjcPJ1X8MBSKX--HUhxA2g@mail.gmail.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>","Openpgp":"id=FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE;\n\turl=http://pgp.mit.edu/pks/lookup?op=get&search=0xE3E32C2CDEADC0DE","Message-ID":"<9c754e08-d7ed-bea9-cd22-92d8a57e6335@amsat.org>","Date":"Mon, 28 May 2018 00:09:34 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.8.0","MIME-Version":"1.0","In-Reply-To":"<CAKmqyKMnvTe5xQ8vTH28voRh+K5jxjcPJ1X8MBSKX--HUhxA2g@mail.gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::242","Subject":"Re: [Qemu-devel] [PATCH v5 3/7] hw/mdio: Generalize phy\n\tinitialization routine","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>, Fam Zheng <famz@redhat.com>,\n\tJason Wang <jasowang@redhat.com>, \"qemu-devel@nongnu.org Developers\"\n\t<qemu-devel@nongnu.org>, Grant Likely <grant.likely@secretlab.ca>,\n\tqemu-arm <qemu-arm@nongnu.org>, \"Edgar E. Iglesias\"\n\t<edgar.iglesias@gmail.com>, =?utf-8?q?Andreas_F=C3=A4rber?=\n\t<afaerber@suse.de>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]