[{"id":1773745,"web_url":"http://patchwork.ozlabs.org/comment/1773745/","msgid":"<20170922163416.GB3470@lunn.ch>","list_archive_url":null,"date":"2017-09-22T16:34:16","subject":"Re: [PATCH net-next 3/4] net: dsa: make slave close symmetrical to\n\topen","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Fri, Sep 22, 2017 at 12:17:52PM -0400, Vivien Didelot wrote:\n> The DSA slave open function configures the unicast MAC addresses on the\n> master device, enable the switch port, change its STP state, then start\n> the PHY device.\n> \n> Make the close function symmetric, by first stopping the PHY device,\n> then changing the STP state, disabling the switch port and restore the\n> master device.\n> \n> Signed-off-by: Vivien Didelot \n\nReviewed-by: Andrew Lunn \n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzJwR4QsLz9sPm\n\tfor ;\n\tSat, 23 Sep 2017 02:34:31 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752552AbdIVQeU (ORCPT );\n\tFri, 22 Sep 2017 12:34:20 -0400","from vps0.lunn.ch ([185.16.172.187]:52616 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752182AbdIVQeS (ORCPT );\n\tFri, 22 Sep 2017 12:34:18 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dvQu8-00018b-PW; Fri, 22 Sep 2017 18:34:16 +0200"],"Date":"Fri, 22 Sep 2017 18:34:16 +0200","From":"Andrew Lunn ","To":"Vivien Didelot ","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tkernel@savoirfairelinux.com, \"David S. Miller\" ,\n\tFlorian Fainelli ","Subject":"Re: [PATCH net-next 3/4] net: dsa: make slave close symmetrical to\n\topen","Message-ID":"<20170922163416.GB3470@lunn.ch>","References":"<20170922161753.19563-1-vivien.didelot@savoirfairelinux.com>\n\t<20170922161753.19563-4-vivien.didelot@savoirfairelinux.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170922161753.19563-4-vivien.didelot@savoirfairelinux.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1773785,"web_url":"http://patchwork.ozlabs.org/comment/1773785/","msgid":"<4bab03d6-40e8-1009-8f70-e39baab908f5@gmail.com>","list_archive_url":null,"date":"2017-09-22T17:15:21","subject":"Re: [PATCH net-next 3/4] net: dsa: make slave close symmetrical to\n\topen","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/22/2017 09:17 AM, Vivien Didelot wrote:\n> The DSA slave open function configures the unicast MAC addresses on the\n> master device, enable the switch port, change its STP state, then start\n> the PHY device.\n> \n> Make the close function symmetric, by first stopping the PHY device,\n> then changing the STP state, disabling the switch port and restore the\n> master device.\n> \n> Signed-off-by: Vivien Didelot \n\nReviewed-by: Florian Fainelli ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"EucntSGP\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzKqv6Z4wz9t3h\n\tfor ;\n\tSat, 23 Sep 2017 03:15:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752503AbdIVRP0 (ORCPT );\n\tFri, 22 Sep 2017 13:15:26 -0400","from mail-qk0-f172.google.com ([209.85.220.172]:48455 \"EHLO\n\tmail-qk0-f172.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752283AbdIVRPZ (ORCPT\n\t); Fri, 22 Sep 2017 13:15:25 -0400","by mail-qk0-f172.google.com with SMTP id a128so1674356qkc.5;\n\tFri, 22 Sep 2017 10:15:24 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\ta12sm253637qta.3.2017.09.22.10.15.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 10:15:23 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=783acRXn0E9VOtFQPcQAniia4MH9fvH1/ZRxFO/HAxI=;\n\tb=EucntSGPhOPPvZjva0xU+rd2XIPhnPU5Td/38Tt2Jee2F5HK/ou1+U5xt3dRVGjsnQ\n\tPZpeJyH0ejwXwQwF7noMN1bzVGIxLTx4NssBe48bI28DNCA0BBRN3CD8HIVDS39hEYb0\n\t3B8RrFjng4UbtdWt86/LbfPs+RT4/WUVtT5kseO6AX41PcKh3UhR00y3ym/791QkNe3D\n\tFm3UxCUu7o4+zSFJnFYxz/TWLVTyJeaCWxqZbpa8pNzGJWbTGuTXpz3hQFwQQ8UrFrGi\n\t73rntmVqOpMHnziUX4zmCYqiT97zrAyxRfgLARvlXMjj83CowV/H4I7pjYsygIOf9Kgs\n\tw2sw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=783acRXn0E9VOtFQPcQAniia4MH9fvH1/ZRxFO/HAxI=;\n\tb=ogxV2mhiiSFJYP3e1vN9BSHxun438kVCmZgqA1SuHOxVBspZp4i5tg6Jp1JZKtihw7\n\tzbZ/2s0yIVZPZSeSKN6BqjvjTmR+ENgENcBRRj+aK9rOTkBphaw/U5LZpDj96p2ANgOh\n\tu59GOqJUJ2TjPmOc502AFX+zBa2ok2siqVHrvD/rlj6dVKrr+cXuYxMmg30XtkzZJjPI\n\tM8Mu3jdZhj6UK6hIYOQeFe+JOmAK047SZba8C0Eb2J6tpsDS7T5kpqT50EFZWMKWLCNg\n\t+I8hJiH1BePANVwxNquvxrFk41jLuu28CNY7fiNmIyMzszhs17BAq6/wrQcFYAi3N8T7\n\t3iuw==","X-Gm-Message-State":"AHPjjUhXUkKGVVQ3LIOIbAxhpQX0Gp9aigpm8Fy/GTthZQ6s6/Z4BKbb\n\twD/BleWaqBTBrlsKe2oUGmsbA4Cx","X-Google-Smtp-Source":"AOwi7QDc0/hpItZcTIY+wNOVWqFhiTe6z0al3A6+YASq0iAwkK+HZZE+74ll1G5uQbjEh+cPLpSvhA==","X-Received":"by 10.55.18.96 with SMTP id c93mr8908817qkh.297.1506100524213;\n\tFri, 22 Sep 2017 10:15:24 -0700 (PDT)","Subject":"Re: [PATCH net-next 3/4] net: dsa: make slave close symmetrical to\n\topen","To":"Vivien Didelot ,\n\tnetdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,\n\t\"David S. Miller\" , Andrew Lunn ","References":"<20170922161753.19563-1-vivien.didelot@savoirfairelinux.com>\n\t<20170922161753.19563-4-vivien.didelot@savoirfairelinux.com>","From":"Florian Fainelli ","Message-ID":"<4bab03d6-40e8-1009-8f70-e39baab908f5@gmail.com>","Date":"Fri, 22 Sep 2017 10:15:21 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170922161753.19563-4-vivien.didelot@savoirfairelinux.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]