[{"id":1773746,"web_url":"http://patchwork.ozlabs.org/comment/1773746/","msgid":"<20170922163554.GC3470@lunn.ch>","list_archive_url":null,"date":"2017-09-22T16:35:54","subject":"Re: [PATCH net-next 4/4] net: dsa: add port enable and disable\n\thelpers","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Fri, Sep 22, 2017 at 12:17:53PM -0400, Vivien Didelot wrote:\n> Provide dsa_port_enable and dsa_port_disable helpers to respectively\n> enable and disable a switch port. This makes the dsa_port_set_state_now\n> helper static.\n> \n> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>\n\nReviewed-by: Andrew Lunn <andrew@lunn.ch>\n\n    Andrew","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzJyK0d3dz9sPm\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 23 Sep 2017 02:36:09 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752348AbdIVQf5 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 22 Sep 2017 12:35:57 -0400","from vps0.lunn.ch ([185.16.172.187]:52621 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751928AbdIVQf4 (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tFri, 22 Sep 2017 12:35:56 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dvQvi-0001AT-IW; Fri, 22 Sep 2017 18:35:54 +0200"],"Date":"Fri, 22 Sep 2017 18:35:54 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Vivien Didelot <vivien.didelot@savoirfairelinux.com>","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tkernel@savoirfairelinux.com, \"David S. Miller\" <davem@davemloft.net>,\n\tFlorian Fainelli <f.fainelli@gmail.com>","Subject":"Re: [PATCH net-next 4/4] net: dsa: add port enable and disable\n\thelpers","Message-ID":"<20170922163554.GC3470@lunn.ch>","References":"<20170922161753.19563-1-vivien.didelot@savoirfairelinux.com>\n\t<20170922161753.19563-5-vivien.didelot@savoirfairelinux.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170922161753.19563-5-vivien.didelot@savoirfairelinux.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1773786,"web_url":"http://patchwork.ozlabs.org/comment/1773786/","msgid":"<23727dc0-e9e4-2353-7cf2-92a31b6cbb7a@gmail.com>","list_archive_url":null,"date":"2017-09-22T17:16:35","subject":"Re: [PATCH net-next 4/4] net: dsa: add port enable and disable\n\thelpers","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/22/2017 09:17 AM, Vivien Didelot wrote:\n> Provide dsa_port_enable and dsa_port_disable helpers to respectively\n> enable and disable a switch port. This makes the dsa_port_set_state_now\n> helper static.\n> \n> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>\n\nReviewed-by: Florian Fainelli <f.fainelli@gmail.com>","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fpz4C+Fi\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzKsM3dYlz9sP1\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 23 Sep 2017 03:16:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752378AbdIVRQn (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 22 Sep 2017 13:16:43 -0400","from mail-qk0-f196.google.com ([209.85.220.196]:33085 \"EHLO\n\tmail-qk0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752168AbdIVRQl (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 22 Sep 2017 13:16:41 -0400","by mail-qk0-f196.google.com with SMTP id g128so1034950qke.0;\n\tFri, 22 Sep 2017 10:16:40 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tj19sm232301qtc.41.2017.09.22.10.16.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 10:16:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=IDnfpcsMMqbz9mFTea0Mr8Jp7tYsZyGjD3fSbbu3+pk=;\n\tb=fpz4C+FivhFpkm6iOjFyzJAizhCgQ6NFQs5VoVyJsP5ZXdZal6GTbKa8mv5VYCR5DP\n\t2HLugUKa+WRJEQMckLFyMjYTvOQwZKY7fjHu8c1BvxOacPhzFhAc15lmzDmyZZE/6F/g\n\tAGGIOI+HqwEYNGiSvtdgpgsSmnGSY8ZvHPiyNc68lkEBuERzz5398WS+NJtAH3AU05DY\n\tmLhJ3ETaaj/qGleSR/gTXWafLTJELwPG4KtwPqxSbz9bVSIKe0cXGSudxDYFwLESYbPL\n\t+TLvLBIVYcZFyfyH6sMuj/4omFIpa/PX8f0GTXQOtdbWV4Q9xu5i4kU8kvzkEaAeeGHe\n\tqDTg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=IDnfpcsMMqbz9mFTea0Mr8Jp7tYsZyGjD3fSbbu3+pk=;\n\tb=WOqedzO4lZSBIQxMQRWz4/esn49tGtUO0uYXG0nG7ZYwpUGb4ftXuqGSKC//WONgiI\n\t8km6Qm0v3I4CSW0HL8j464aOArsmhTz7pmmm9MOZCoq7CNGzimbCXVdyis0CLb1FFS91\n\tjCKnKED19s8mwQbfIXpOgfewuy0qItT51UzOSE5wMTOxYdMvz6w5yTck7ewlAUS2J+tz\n\t63vTkqn9uqUOvHVgZLibyF3CbgGpG4rwQGqsA7TuT3ytHAopDf/owD3NrCB7jY/iS0eP\n\t5Kpr8pVUdJP0VkEc615HqW/67NHSwqv+814mHHiDreZOYfDThxj2RyAevku5Y6mur824\n\tbN3A==","X-Gm-Message-State":"AHPjjUhWEdfphN7fnitGNqQkbbubopwtfKnDnirUjFsz8G4aj8t4Byvk\n\tZFOHLrX9VrCiwSkQ9juM9+s=","X-Google-Smtp-Source":"AOwi7QC+orWPTISUrbZIuBBPt3TyjhINCf8+UsnMvzSM0FGBbgSgraed8H5b760HRxoHags8SJ2VUQ==","X-Received":"by 10.233.239.140 with SMTP id d134mr8688797qkg.59.1506100600234;\n\tFri, 22 Sep 2017 10:16:40 -0700 (PDT)","Subject":"Re: [PATCH net-next 4/4] net: dsa: add port enable and disable\n\thelpers","To":"Vivien Didelot <vivien.didelot@savoirfairelinux.com>,\n\tnetdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,\n\t\"David S. Miller\" <davem@davemloft.net>, Andrew Lunn <andrew@lunn.ch>","References":"<20170922161753.19563-1-vivien.didelot@savoirfairelinux.com>\n\t<20170922161753.19563-5-vivien.didelot@savoirfairelinux.com>","From":"Florian Fainelli <f.fainelli@gmail.com>","Message-ID":"<23727dc0-e9e4-2353-7cf2-92a31b6cbb7a@gmail.com>","Date":"Fri, 22 Sep 2017 10:16:35 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170922161753.19563-5-vivien.didelot@savoirfairelinux.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]