[{"id":1774426,"web_url":"http://patchwork.ozlabs.org/comment/1774426/","msgid":"","list_archive_url":null,"date":"2017-09-25T05:38:16","subject":"Re: [Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 22.09.2017 18:01, Philippe Mathieu-Daudé wrote:\n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> hw/alpha/alpha_sys.h | 2 --\n> hw/alpha/pci.c | 2 ++\n> hw/alpha/typhoon.c | 2 +-\n> 3 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h\n> index b6d8369ed7..ac685c1c46 100644\n> --- a/hw/alpha/alpha_sys.h\n> +++ b/hw/alpha/alpha_sys.h\n> @@ -5,8 +5,6 @@\n> \n> #include \"target/alpha/cpu-qom.h\"\n> #include \"hw/pci/pci.h\"\n> -#include \"hw/pci/pci_host.h\"\n> -#include \"hw/ide.h\"\n> #include \"hw/i386/pc.h\"\n\nDidn't you want to remove that pc.h line according to the patch description?\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0tDX0TBSz9t4B\n\tfor ;\n\tMon, 25 Sep 2017 15:38:52 +1000 (AEST)","from localhost ([::1]:40784 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwM6U-0007ZN-6X\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 01:38:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44722)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwM61-0007YR-R6\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 01:38:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwM60-0005r9-IL\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 01:38:21 -0400","from mx1.redhat.com ([209.132.183.28]:41952)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwM60-0005qg-CI; Mon, 25 Sep 2017 01:38:20 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6A654356DB;\n\tMon, 25 Sep 2017 05:38:19 +0000 (UTC)","from [10.36.116.76] (ovpn-116-76.ams2.redhat.com [10.36.116.76])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id EADE317F3B;\n\tMon, 25 Sep 2017 05:38:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6A654356DB","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tPeter Maydell , Paolo Bonzini\n\t, Richard Henderson ","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922160111.31885-11-f4bug@amsat.org>","From":"Thomas Huth ","Message-ID":"","Date":"Mon, 25 Sep 2017 07:38:16 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922160111.31885-11-f4bug@amsat.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tMon, 25 Sep 2017 05:38:19 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1778524,"web_url":"http://patchwork.ozlabs.org/comment/1778524/","msgid":"<13c0af58-7c9e-c0b5-a1c2-62e638146b34@amsat.org>","list_archive_url":null,"date":"2017-10-02T18:52:33","subject":"Re: [Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"Hi Thomas,\n\nOn 09/25/2017 02:38 AM, Thomas Huth wrote:\n> On 22.09.2017 18:01, Philippe Mathieu-Daudé wrote:\n>> Signed-off-by: Philippe Mathieu-Daudé \n>> ---\n>> hw/alpha/alpha_sys.h | 2 --\n>> hw/alpha/pci.c | 2 ++\n>> hw/alpha/typhoon.c | 2 +-\n>> 3 files changed, 3 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h\n>> index b6d8369ed7..ac685c1c46 100644\n>> --- a/hw/alpha/alpha_sys.h\n>> +++ b/hw/alpha/alpha_sys.h\n>> @@ -5,8 +5,6 @@\n>> \n>> #include \"target/alpha/cpu-qom.h\"\n>> #include \"hw/pci/pci.h\"\n>> -#include \"hw/pci/pci_host.h\"\n>> -#include \"hw/ide.h\"\n>> #include \"hw/i386/pc.h\"\n> \n> Didn't you want to remove that pc.h line according to the patch description?\n\nNot yet :( This include is still needed for the i8259 PIC. This change \nis done in the part 2 (following series).\n\nThat said, I should improve the patch description :)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CzLAug7p\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5WX51wWtz9s7c\n\tfor ;\n\tTue, 3 Oct 2017 05:53:24 +1100 (AEDT)","from localhost ([::1]:53742 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dz5qD-0004GV-N6\n\tfor incoming@patchwork.ozlabs.org; Mon, 02 Oct 2017 14:53:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40668)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dz5pb-0004Eg-Kh\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 14:52:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dz5pa-00012m-VM\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 14:52:43 -0400","from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:43636)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dz5pV-0000uj-Jy; Mon, 02 Oct 2017 14:52:37 -0400","by mail-qt0-x243.google.com with SMTP id a43so2774877qta.0;\n\tMon, 02 Oct 2017 11:52:37 -0700 (PDT)","from [192.168.1.240] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tu51sm7454523qth.67.2017.10.02.11.52.33\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 02 Oct 2017 11:52:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=gILqjzPjlMPDiQHWVevBoetR/IF4SvWgkkuMt1/NWag=;\n\tb=CzLAug7pCbOINbb43JkRoSZRJO4Xg4O0l2q37kFS23bCrZdQKp+Q4JdtIoU1tTAcJo\n\t2qJSmTw6XvucgTaOdLF6st/GjqQ5T+1/kZbnA1NfI9tBtkovykXAge5uwrfafgV9ZGcb\n\tw+kGPV62NaT0sn58a7l8gRUEK+/Zw9GO1fUdzUDBNo1yZEGt6J4qq7PM1CD29Yotrk2e\n\tJJPIs/84PEgK7t/lOFsTTc9W1i4KeWumXuYqIr/L4BBOLvsJlGFM6CtUCHLkFnGCxB72\n\tCHx8hVmiDdU+zXiecWWJMT8MSVhJJ0vWPTS7S9QlNovMG/w+pXXKPIxXVj1yNc/Vb2hq\n\tZJcg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=gILqjzPjlMPDiQHWVevBoetR/IF4SvWgkkuMt1/NWag=;\n\tb=h3WSlql39e9ZHlZdsBcd9GCwMOdCDtkzm3hRiwGFEISFO9t8pBV+8BLD94bp8qz3tT\n\tEiOZ/VTTa1k+Dl8MwX1Nn5/b6J1qJ/00iIYJ1e/xxg3NgNsWsTzdVb4BmSfXTNFujgYj\n\t13dnFxvWUCnMAv+MF5NRj+J9GzXIB34Hla3W6VxUbeoF1uRhk1kgKSJnycQeUgNbkIX3\n\tmmmso1VqyBW1pgGW4DnX+BiZamr23Ihv/5SLobWw8nKoyyRQ0SwqSNXtFe0B9mwp957t\n\tCrfhPVYcQ8h60h3qI/5Qnbb9NAhZJYKjdNr6ZUqaNPJp5owimokTmIemwobWhY3u0e4O\n\tsRmg==","X-Gm-Message-State":"AMCzsaXkngUd3mlBHzwWAb0WyjnCZjcvghTZtg2OroVjmFtfGa3nZ3mz\n\tmdmhTsYCVm1RYjCyDqQ5ABkMt9+u","X-Google-Smtp-Source":"AOwi7QAKIrJ1lMgH86wNmDStR+pGYVxdb5YGChspx4htksQyDkrswe7ADdnK0JFfciS+tPGSbKZhuQ==","X-Received":"by 10.200.37.157 with SMTP id e29mr18819684qte.271.1506970356794;\n\tMon, 02 Oct 2017 11:52:36 -0700 (PDT)","To":"Thomas Huth , Richard Henderson ","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922160111.31885-11-f4bug@amsat.org>\n\t","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<13c0af58-7c9e-c0b5-a1c2-62e638146b34@amsat.org>","Date":"Mon, 2 Oct 2017 15:52:33 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::243","Subject":"Re: [Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency","X-BeenThere":"qemu-devel@gnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, Peter Maydell ,\n\tqemu-devel@nongnu.org, Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1778529,"web_url":"http://patchwork.ozlabs.org/comment/1778529/","msgid":"","list_archive_url":null,"date":"2017-10-02T19:03:40","subject":"Re: [Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"2017-09-22 12:01 GMT-04:00 Philippe Mathieu-Daudé :\n\n> diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h\n> index b6d8369ed7..ac685c1c46 100644\n> --- a/hw/alpha/alpha_sys.h\n> +++ b/hw/alpha/alpha_sys.h\n> @@ -5,8 +5,6 @@\n>\n> #include \"target/alpha/cpu-qom.h\"\n> #include \"hw/pci/pci.h\"\n> -#include \"hw/pci/pci_host.h\"\n> -#include \"hw/ide.h\"\n>\n\nWhy are you deleting pci/pci_host.h here?\nAlternately, why are you leaving pci/pci.h?\n\n\n> diff --git a/hw/alpha/pci.c b/hw/alpha/pci.c\n> index 8dde637bfe..c370762ea6 100644\n> --- a/hw/alpha/pci.c\n> +++ b/hw/alpha/pci.c\n> @@ -8,6 +8,8 @@\n>\n> #include \"qemu/osdep.h\"\n> #include \"qemu-common.h\"\n> +#include \"hw/pci/pci.h\"\n> +#include \"hw/pci/pci_host.h\"\n>\n\nOne way we have a double-include of pci/pci.h here,\nthe other way we shouldn't re-include either.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"OpsBUAe8\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5Wmt4LG6z9t4X\n\tfor ;\n\tTue, 3 Oct 2017 06:04:29 +1100 (AEDT)","from localhost ([::1]:53782 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dz60w-0006Ya-4k\n\tfor incoming@patchwork.ozlabs.org; Mon, 02 Oct 2017 15:04:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44605)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dz60F-0006RZ-Q1\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 15:03:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dz60E-00051R-QG\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 15:03:43 -0400","from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:49587)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dz60E-0004zb-J7\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 15:03:42 -0400","by mail-wm0-x235.google.com with SMTP id b189so8552877wmd.4\n\tfor ; Mon, 02 Oct 2017 12:03:42 -0700 (PDT)","by 10.223.136.135 with HTTP; Mon, 2 Oct 2017 12:03:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=fTwmPbYQQjxYTLKtWa77F2IWUJgLWK9IG6K+j11ZE+o=;\n\tb=OpsBUAe8Nf2EocaqD0D0wLVdlp4xjP/p/w9xSoEpxX35iBJV1Ne2lbIhumHsQ3SGc+\n\t4bJs5fUpRXWYB4DIp8xFEguKpXrKzqBQNxt46hFz2yF3p2Mk1/rydgp9gb/8tHE6Iam+\n\t/yrVvM+GI8yzpwTV2p56vcDIjnNu1GxGnV9zo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=fTwmPbYQQjxYTLKtWa77F2IWUJgLWK9IG6K+j11ZE+o=;\n\tb=PxxMiEd1qNra9y755R4bwBJRikGZgLgqQSfcdVRlI2nDzLNnn5RHYq8zjyB6zber3H\n\tAzBRbDO7qnt9D9mgMWSWu0/eZJn3v7yak7rQL7rhjZbH2aiEemNeIQ9ipwF2HFI4Yqy1\n\t8bxjK9UQ+ISEPI9G+F9oUDaQnxZBWInYd8ld3MmZmPr6dr4mZCi6x+rM2XV3ifbdsxRg\n\t8WHHqdg6AjY/a98eg03BqrpgL6PJ6OllkUGvdReqUoc8l7O8zOrczO0wS7ZKuuVBqYN0\n\tmD75Ij4bL93+5eO0hEJPGq9WYZ/T6izFtsxjaB5uh+jAnuC8q371aeQWGoKjHxMiouE5\n\te4gQ==","X-Gm-Message-State":"AMCzsaXxGmeAdrOu3jmOpX81TPW26KD3YXHWHoFsKrt0s8yv8j4LexW4\n\twiMFuAHRMvxgEBHo9sVcJs9lqeY/qDuQQZG+sb8chw==","X-Google-Smtp-Source":"AOwi7QBWr9iIfQ6tBcXqxOgkNF5o8p0er3+VkOyJeWJlffnhqKxsWEcX3/ZycBkpubS7vuRFt8njkBnyC9nbYjVu60w=","X-Received":"by 10.28.133.1 with SMTP id h1mr8159171wmd.148.1506971021430;\n\tMon, 02 Oct 2017 12:03:41 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170922160111.31885-11-f4bug@amsat.org>","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922160111.31885-11-f4bug@amsat.org>","From":"Richard Henderson ","Date":"Mon, 2 Oct 2017 15:03:40 -0400","Message-ID":"","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::235","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency","X-BeenThere":"qemu-devel@gnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Thomas Huth ,\n\tqemu-trivial@nongnu.org,\n\t\"qemu-devel@nongnu.org Developers\" ,\n\tPaolo Bonzini , Richard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1781530,"web_url":"http://patchwork.ozlabs.org/comment/1781530/","msgid":"<3ed2a5a2-e30f-d139-d5bf-e145a8480787@amsat.org>","list_archive_url":null,"date":"2017-10-06T12:27:11","subject":"Re: [Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 10/02/2017 04:03 PM, Richard Henderson wrote:\n> 2017-09-22 12:01 GMT-04:00 Philippe Mathieu-Daudé :\n> \n>> diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h\n>> index b6d8369ed7..ac685c1c46 100644\n>> --- a/hw/alpha/alpha_sys.h\n>> +++ b/hw/alpha/alpha_sys.h\n>> @@ -5,8 +5,6 @@\n>>\n>> #include \"target/alpha/cpu-qom.h\"\n>> #include \"hw/pci/pci.h\"\n>> -#include \"hw/pci/pci_host.h\"\n>> -#include \"hw/ide.h\"\n>>\n> \n> Why are you deleting pci/pci_host.h here?\n\nIndeed it is required since PCIBus is defined there.\n\n> Alternately, why are you leaving pci/pci.h?\n> \n> \n>> diff --git a/hw/alpha/pci.c b/hw/alpha/pci.c\n>> index 8dde637bfe..c370762ea6 100644\n>> --- a/hw/alpha/pci.c\n>> +++ b/hw/alpha/pci.c\n>> @@ -8,6 +8,8 @@\n>>\n>> #include \"qemu/osdep.h\"\n>> #include \"qemu-common.h\"\n>> +#include \"hw/pci/pci.h\"\n>> +#include \"hw/pci/pci_host.h\"\n>>\n> \n> One way we have a double-include of pci/pci.h here,\n> the other way we shouldn't re-include either.\n\nPlease ignore this patch.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QmsnTzkM\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y7pnD3dr5z9t4b\n\tfor ;\n\tFri, 6 Oct 2017 23:27:44 +1100 (AEDT)","from localhost ([::1]:44668 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e0RjC-0000fv-Lv\n\tfor incoming@patchwork.ozlabs.org; Fri, 06 Oct 2017 08:27:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46600)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1e0Rir-0000fl-0k\n\tfor qemu-devel@nongnu.org; Fri, 06 Oct 2017 08:27:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1e0Rim-0005GO-4R\n\tfor qemu-devel@nongnu.org; Fri, 06 Oct 2017 08:27:21 -0400","from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:37825)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1e0Ril-0005Fv-Vl; Fri, 06 Oct 2017 08:27:16 -0400","by mail-qk0-x244.google.com with SMTP id a12so9113524qka.4;\n\tFri, 06 Oct 2017 05:27:15 -0700 (PDT)","from [192.168.1.240] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\t35sm843201qtx.43.2017.10.06.05.27.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 06 Oct 2017 05:27:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:openpgp:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=3UbVle6d7XZT/5ZPOw66swkTJ4BI7ITlXbHvUB0LJ54=;\n\tb=QmsnTzkM7jBLzEjofHAhHy70TWFkqd5B8KSUjWcZ0yqZRO06MG9/RisEZOw5SSMeKu\n\tQa5NmkcDOt/sknzojPUVb+S1e1PfhLrWPieIQTJNny1Ml0wC8p96KOC74HIdz55OJaQb\n\tjVMQtDA6iS6A7rHjz8+y+VfouhMHV+0ORqFI+oF5pl35tQkF6P5LADubE4QaZT6dtWOD\n\tXDPUYCRMJXYUOdlQ4prrThTWiGmTgvNGw4KZebtoiZZk1nH3VKSycAPDPaoMBUoPy+8j\n\tUplOiR5X0QQtfloNuzux78jOVcMlzAvpjTazycZ2jmgcRrhbYjZgiXqz0EDFEAB0m3TX\n\tqC4g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:openpgp\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=3UbVle6d7XZT/5ZPOw66swkTJ4BI7ITlXbHvUB0LJ54=;\n\tb=fcIfd8JlWhya9evMClHL7bVtwKWoFqyBtgE50XW8GNu3HbxmAT9odA4REQ0xTydTU+\n\tN44EghJGDIaZYG+EH5Y9Zo3z/TtVPUFPk8PuW7gdvfYllCZn4+SE8cRyL/X3XsuNK6Y5\n\tcSSv2E36/c2fhlig3T15StvvZTyBvbhVBZmWXc3cR5ACHnogKI+bIXgSz3g5Yb/q1Z30\n\tQJQVf/nQYCzwKKvMItd9ohEw2vq5FPK5UFvPQbxqEtLyOEJ1Dv3t3XkwrOEDdtMW6n5W\n\tnQ5vjCF3JqWnV7j5q8AR0H+jkgUZs6idh9Oh4PBV6B462MqpU2XpW8yDSsfA5tB8urba\n\tZoPw==","X-Gm-Message-State":"AMCzsaUg1TVZbjYszD75Zd8UaZUMrV4biYcmpEA8SVbUz4OXOtDqPQHd\n\thl8JbGVU+mr0xQ6dBcSPhRlMJZDS","X-Google-Smtp-Source":"AOwi7QDD6JKkUBF5ShNfh7r8B8cjLxpaVElb0E3Up2cCbeW/iMK6hkxdhulPGVxykiThS7Dsy8zPkw==","X-Received":"by 10.55.217.82 with SMTP id u79mr5632260qki.106.1507292834824; \n\tFri, 06 Oct 2017 05:27:14 -0700 (PDT)","To":"Richard Henderson ","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922160111.31885-11-f4bug@amsat.org>\n\t","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Openpgp":"id=FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE;\n\turl=http://pgp.mit.edu/pks/lookup?op=get&search=0xE3E32C2CDEADC0DE","Message-ID":"<3ed2a5a2-e30f-d139-d5bf-e145a8480787@amsat.org>","Date":"Fri, 6 Oct 2017 09:27:11 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::244","Subject":"Re: [Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Thomas Huth ,\n\tqemu-trivial@nongnu.org,\n\t\"qemu-devel@nongnu.org Developers\" ,\n\tPaolo Bonzini , Richard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]