[{"id":1773852,"web_url":"http://patchwork.ozlabs.org/comment/1773852/","msgid":"<0aa179bb-7d59-bd23-2969-34c42e3167bf@reactos.org>","list_archive_url":null,"date":"2017-09-22T20:12:12","subject":"Re: [Qemu-devel] [PATCH 25/34] hw/timer/m48t59: use TYPE_M48T59_ISA,\n\tadd entries to MAINTAINERS","submitter":{"id":2909,"url":"http://patchwork.ozlabs.org/api/people/2909/","name":"Hervé Poussineau","email":"hpoussin@reactos.org"},"content":"Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit :\n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> include/hw/timer/m48t59.h | 2 ++\n> hw/ppc/prep.c | 2 +-\n> hw/timer/m48t59-isa.c | 2 +-\n> MAINTAINERS | 2 ++\n> 4 files changed, 6 insertions(+), 2 deletions(-)\n\nReviewed-by: Hervé Poussineau ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=reactos.org header.i=@reactos.org\n\theader.b=\"puwTfozV\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzPmp2T8Kz9s82\n\tfor ;\n\tSat, 23 Sep 2017 06:13:14 +1000 (AEST)","from localhost ([::1]:60851 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvUK0-0005Qt-DN\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 16:13:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33179)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvUJ9-0005Br-U9\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 16:12:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvUJ9-0005BC-54\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 16:12:19 -0400","from iserv.reactos.org ([2a01:4f8:221:4c5::3]:47149)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvUJ5-00058K-3v; Fri, 22 Sep 2017 16:12:15 -0400","from rob92-5-82-227-227-196.fbx.proxad.net ([82.227.227.196]\n\thelo=[192.168.0.35]) by iserv.reactos.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dvUJ3-0005ZY-Vh; Fri, 22 Sep 2017 20:12:14 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=reactos.org; s=25047; \n\th=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject;\n\tbh=c1SI5MCIHn1bGjKAVSR0CRRPsoj8wm5TCvg25L/9QnE=; \n\tb=puwTfozVNZepahOm/9LSvq2o6dANZZpvcp3GM0nttQBfEEkyJloYRD/Kk6JgJNXY3rGL++Avagv6xVddIOJUpoZEci8E92LpeFQ8HxF3IvjWABGVJ8cI41aBrwDQt+bWQiFbm/ZreFzstGkxnL5fnTuSDX6/LMtx43j6QhjptMA=;","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tPeter Maydell ,\n\tThomas Huth , \tPaolo Bonzini ,\n\tDavid Gibson\n\t, Alexander Graf ","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922160111.31885-3-f4bug@amsat.org>","From":"=?utf-8?q?Herv=C3=A9_Poussineau?= ","Message-ID":"<0aa179bb-7d59-bd23-2969-34c42e3167bf@reactos.org>","Date":"Fri, 22 Sep 2017 22:12:12 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170922160111.31885-3-f4bug@amsat.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]","X-Received-From":"2a01:4f8:221:4c5::3","Subject":"Re: [Qemu-devel] [PATCH 25/34] hw/timer/m48t59: use TYPE_M48T59_ISA,\n\tadd entries to MAINTAINERS","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773975,"web_url":"http://patchwork.ozlabs.org/comment/1773975/","msgid":"<20170923051109.GZ4998@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-23T05:11:09","subject":"Re: [Qemu-devel] [PATCH 25/34] hw/timer/m48t59: use TYPE_M48T59_ISA,\n\tadd entries to MAINTAINERS","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Fri, Sep 22, 2017 at 01:01:02PM -0300, Philippe Mathieu-Daudé wrote:\n> Signed-off-by: Philippe Mathieu-Daudé \n\nppc portion\n\nAcked-by: David Gibson \n\n> ---\n> include/hw/timer/m48t59.h | 2 ++\n> hw/ppc/prep.c | 2 +-\n> hw/timer/m48t59-isa.c | 2 +-\n> MAINTAINERS | 2 ++\n> 4 files changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/hw/timer/m48t59.h b/include/hw/timer/m48t59.h\n> index db5e43a8da..069bb045d7 100644\n> --- a/include/hw/timer/m48t59.h\n> +++ b/include/hw/timer/m48t59.h\n> @@ -25,6 +25,8 @@ typedef struct NvramClass {\n> void (*toggle_lock)(Nvram *obj, int lock);\n> } NvramClass;\n> \n> +#define TYPE_M48T59_ISA \"isa-m48t59\"\n> +\n> Nvram *m48t59_init_isa(ISABus *bus, uint32_t io_base, uint16_t size,\n> int base_year, int type);\n> Nvram *m48t59_init(qemu_irq IRQ, hwaddr mem_base,\n> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c\n> index 16f4537093..1f8ef4819b 100644\n> --- a/hw/ppc/prep.c\n> +++ b/hw/ppc/prep.c\n> @@ -777,7 +777,7 @@ static void ibm_40p_init(MachineState *machine)\n> /* add some more devices */\n> if (defaults_enabled()) {\n> isa_create_simple(isa_bus, TYPE_I8042);\n> - m48t59 = NVRAM(isa_create_simple(isa_bus, \"isa-m48t59\"));\n> + m48t59 = NVRAM(isa_create_simple(isa_bus, TYPE_M48T59_ISA));\n> \n> dev = DEVICE(isa_create(isa_bus, \"cs4231a\"));\n> qdev_prop_set_uint32(dev, \"iobase\", 0x830);\n> diff --git a/hw/timer/m48t59-isa.c b/hw/timer/m48t59-isa.c\n> index ea1ba703d7..077346f7ca 100644\n> --- a/hw/timer/m48t59-isa.c\n> +++ b/hw/timer/m48t59-isa.c\n> @@ -49,7 +49,7 @@ typedef struct M48txxISADeviceClass {\n> \n> static M48txxInfo m48txx_isa_info[] = {\n> {\n> - .bus_name = \"isa-m48t59\",\n> + .bus_name = TYPE_M48T59_ISA,\n> .model = 59,\n> .size = 0x2000,\n> }\n> diff --git a/MAINTAINERS b/MAINTAINERS\n> index a79723601c..3cb6bc190c 100644\n> --- a/MAINTAINERS\n> +++ b/MAINTAINERS\n> @@ -708,6 +708,8 @@ F: hw/pci-host/prep.[hc]\n> F: hw/isa/i82378.c\n> F: hw/isa/pc87312.[hc]\n> F: hw/dma/i82374.c\n> +F: hw/timer/m48t59-isa.c\n> +F: include/hw/timer/m48t59.h\n> F: pc-bios/ppc_rom.bin\n> \n> sPAPR","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"P2ZUei1a\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzf7R45t7z9t67\n\tfor ;\n\tSat, 23 Sep 2017 15:30:11 +1000 (AEST)","from localhost ([::1]:33727 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvd0z-0007KT-K8\n\tfor incoming@patchwork.ozlabs.org; Sat, 23 Sep 2017 01:30:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36101)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvd0G-0007JP-38\n\tfor qemu-devel@nongnu.org; Sat, 23 Sep 2017 01:29:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvd0F-0002AB-3o\n\tfor qemu-devel@nongnu.org; Sat, 23 Sep 2017 01:29:24 -0400","from ozlabs.org ([2401:3900:2:1::2]:36295)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvd0E-00029D-I3; Sat, 23 Sep 2017 01:29:23 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xzf6R5X29z9t43; Sat, 23 Sep 2017 15:29:19 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1506144559;\n\tbh=I4Zme4bXrGoFwWbYoGZ+DQ1HbklpbAvmPPFm3EyrFAo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=P2ZUei1a0SxUjFqNeXsFnTG9P9vA2iUvJfr4q9dF417Jt1oGlnomn8seDRWIg51BA\n\toCh3iwiaVTKAIby8vQe+J5/39qEc0LCbIyDuJ2kdy8WqRovCoKjfbv2xlIdXkl82U/\n\t3g6rRp40juThD/sFsKq2Cmv82hviDNRLVKNp6jUM=","Date":"Sat, 23 Sep 2017 15:11:09 +1000","From":"David Gibson ","To":"Philippe =?iso-8859-1?q?Mathieu-Daud=E9?= ","Message-ID":"<20170923051109.GZ4998@umbus.fritz.box>","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922160111.31885-3-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"vDpQvD79HZx/5O2q\"","Content-Disposition":"inline","In-Reply-To":"<20170922160111.31885-3-f4bug@amsat.org>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2401:3900:2:1::2","Subject":"Re: [Qemu-devel] [PATCH 25/34] hw/timer/m48t59: use TYPE_M48T59_ISA,\n\tadd entries to MAINTAINERS","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Thomas Huth ,\n\tqemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf\n\t, qemu-trivial@nongnu.org, =?iso-8859-1?q?Herv=E9?=\n\tPoussineau , \tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]