[{"id":1774423,"web_url":"http://patchwork.ozlabs.org/comment/1774423/","msgid":"<5ed69cad-69b8-888d-39e6-e99004cbe053@redhat.com>","list_archive_url":null,"date":"2017-09-25T05:34:32","subject":"Re: [Qemu-devel] [PATCH 29/34] hw/net/e1000e: use TYPE_PCI_E1000E","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 22.09.2017 18:01, Philippe Mathieu-Daudé wrote:\n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> include/hw/net/pci.h | 1 +\n> hw/net/e1000e.c | 6 +++---\n> 2 files changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/hw/net/pci.h b/include/hw/net/pci.h\n> index b24b5257a5..92111f86f3 100644\n> --- a/include/hw/net/pci.h\n> +++ b/include/hw/net/pci.h\n> @@ -14,6 +14,7 @@\n> #include \"hw/pci/pci_bus.h\"\n> \n> #define TYPE_PCI_E1000 \"e1000\"\n> +#define TYPE_PCI_E1000E \"e1000e\"\n> \n> PCIDevice *pci_nic_init_nofail(NICInfo *nd, PCIBus *rootbus,\n> const char *default_model,\n> diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c\n> index 6c42b4478c..494f8cced6 100644\n> --- a/hw/net/e1000e.c\n> +++ b/hw/net/e1000e.c\n> @@ -40,6 +40,7 @@\n> #include \"sysemu/sysemu.h\"\n> #include \"hw/pci/msi.h\"\n> #include \"hw/pci/msix.h\"\n> +#include \"hw/net/pci.h\"\n> \n> #include \"hw/net/e1000_regs.h\"\n> \n> @@ -49,8 +50,7 @@\n> #include \"trace.h\"\n> #include \"qapi/error.h\"\n> \n> -#define TYPE_E1000E \"e1000e\"\n> -#define E1000E(obj) OBJECT_CHECK(E1000EState, (obj), TYPE_E1000E)\n> +#define E1000E(obj) OBJECT_CHECK(E1000EState, (obj), TYPE_PCI_E1000E)\n> \n> typedef struct E1000EState {\n> PCIDevice parent_obj;\n> @@ -703,7 +703,7 @@ static void e1000e_instance_init(Object *obj)\n> }\n> \n> static const TypeInfo e1000e_info = {\n> - .name = TYPE_E1000E,\n> + .name = TYPE_PCI_E1000E,\n> .parent = TYPE_PCI_DEVICE,\n> .instance_size = sizeof(E1000EState),\n> .class_init = e1000e_class_init,\n> \n\nThat seems unnecessary to me, since it's not used anywhere outside of\ne1000e.c. I'd suggest to drop this patch.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0t8M5lTNz9t4B\n\tfor ;\n\tMon, 25 Sep 2017 15:35:15 +1000 (AEST)","from localhost ([::1]:40770 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwM2z-00062B-V0\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 01:35:13 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44241)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwM2X-00061x-V5\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 01:34:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwM2T-00045c-0H\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 01:34:45 -0400","from mx1.redhat.com ([209.132.183.28]:50012)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwM2S-00043c-RI; Mon, 25 Sep 2017 01:34:40 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id ABCD113A90;\n\tMon, 25 Sep 2017 05:34:39 +0000 (UTC)","from [10.36.116.76] (ovpn-116-76.ams2.redhat.com [10.36.116.76])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 4D95667C71;\n\tMon, 25 Sep 2017 05:34:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com ABCD113A90","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tPeter Maydell , Paolo Bonzini\n\t, \"Michael S. Tsirkin\" , Marcel\n\tApfelbaum , Jason Wang ","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922160111.31885-7-f4bug@amsat.org>","From":"Thomas Huth ","Message-ID":"<5ed69cad-69b8-888d-39e6-e99004cbe053@redhat.com>","Date":"Mon, 25 Sep 2017 07:34:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922160111.31885-7-f4bug@amsat.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tMon, 25 Sep 2017 05:34:39 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 29/34] hw/net/e1000e: use TYPE_PCI_E1000E","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]