[{"id":1773791,"web_url":"http://patchwork.ozlabs.org/comment/1773791/","msgid":"","list_archive_url":null,"date":"2017-09-22T17:43:29","subject":"Re: [Qemu-devel] [PATCH 23/34] hw/dma/i8257: rename DMA_init() to\n\ti8257_dma_init()","submitter":{"id":2909,"url":"http://patchwork.ozlabs.org/api/people/2909/","name":"Hervé Poussineau","email":"hpoussin@reactos.org"},"content":"Hi,\n\nLe 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit :\n> - move the header from hw/isa/ to hw/dma/\n> - add entry for i82374 in MAINTAINERS\n> - remove the old i386/pc dependency\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> include/hw/{isa/i8257.h => dma/i8257_dma.h} | 6 ++++++\n> include/hw/isa/isa.h | 2 --\n> hw/dma/i82374.c | 3 ++-\n> hw/dma/i8257.c | 4 ++--\n> hw/i386/pc.c | 3 ++-\n> hw/mips/mips_fulong2e.c | 3 ++-\n> hw/mips/mips_jazz.c | 3 ++-\n> hw/mips/mips_malta.c | 3 ++-\n> hw/sparc/sun4m.c | 4 ----\n> hw/sparc64/sun4u.c | 4 ----\n> MAINTAINERS | 2 ++\n> 11 files changed, 20 insertions(+), 17 deletions(-)\n> rename include/hw/{isa/i8257.h => dma/i8257_dma.h} (86%)\n> \n> diff --git a/include/hw/isa/i8257.h b/include/hw/dma/i8257_dma.h\n> similarity index 86%\n> rename from include/hw/isa/i8257.h\n> rename to include/hw/dma/i8257_dma.h\n> index 88a2766a3f..0041565177 100644\n> --- a/include/hw/isa/i8257.h\n> +++ b/include/hw/dma/i8257_dma.h\n> @@ -1,6 +1,10 @@\n> #ifndef HW_I8257_H\n> #define HW_I8257_H\n> \n> +#include \"hw/hw.h\"\n> +#include \"hw/isa/isa.h\"\n> +#include \"exec/ioport.h\"\n> +\n> #define TYPE_I8257 \"i8257\"\n> \n> typedef struct I8257Regs {\n> @@ -40,4 +44,6 @@ typedef struct I8257State {\n> PortioList portio_pageh;\n> } I8257State;\n> \n> +void i8257_dma_init(ISABus *bus, int high_page_enable);\n> +\n\nAs you're changing the DMA_init prototype, can you add an Error **errp parameter,\nand pass &error_abort in each caller?\n\nSee http://lists.gnu.org/archive/html/qemu-devel/2017-09/msg00262.html for more details\n\nHervé\n\n> #endif\n> diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h\n> index 95593408ef..b9dbab24b4 100644\n> --- a/include/hw/isa/isa.h\n> +++ b/include/hw/isa/isa.h\n> @@ -151,6 +151,4 @@ static inline ISABus *isa_bus_from_device(ISADevice *d)\n> return ISA_BUS(qdev_get_parent_bus(DEVICE(d)));\n> }\n> \n> -/* i8257.c */\n> -void DMA_init(ISABus *bus, int high_page_enable);\n> #endif\n> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c\n> index 6c0f975df0..4048bedcf2 100644\n> --- a/hw/dma/i82374.c\n> +++ b/hw/dma/i82374.c\n> @@ -24,6 +24,7 @@\n> \n> #include \"qemu/osdep.h\"\n> #include \"hw/isa/isa.h\"\n> +#include \"hw/dma/i8257_dma.h\"\n> \n> #define TYPE_I82374 \"i82374\"\n> #define I82374(obj) OBJECT_CHECK(I82374State, (obj), TYPE_I82374)\n> @@ -123,7 +124,7 @@ static void i82374_realize(DeviceState *dev, Error **errp)\n> portio_list_add(&s->port_list, isa_address_space_io(&s->parent_obj),\n> s->iobase);\n> \n> - DMA_init(isa_bus_from_device(ISA_DEVICE(dev)), 1);\n> + i8257_dma_init(isa_bus_from_device(ISA_DEVICE(dev)), 1);\n> memset(s->commands, 0, sizeof(s->commands));\n> }\n> \n> diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c\n> index bd23e893bf..a8f26b003b 100644\n> --- a/hw/dma/i8257.c\n> +++ b/hw/dma/i8257.c\n> @@ -24,7 +24,7 @@\n> #include \"qemu/osdep.h\"\n> #include \"hw/hw.h\"\n> #include \"hw/isa/isa.h\"\n> -#include \"hw/isa/i8257.h\"\n> +#include \"hw/dma/i8257_dma.h\"\n> #include \"qemu/main-loop.h\"\n> #include \"trace.h\"\n> \n> @@ -622,7 +622,7 @@ static void i8257_register_types(void)\n> \n> type_init(i8257_register_types)\n> \n> -void DMA_init(ISABus *bus, int high_page_enable)\n> +void i8257_dma_init(ISABus *bus, int high_page_enable)\n> {\n> ISADevice *isa1, *isa2;\n> DeviceState *d;\n> diff --git a/hw/i386/pc.c b/hw/i386/pc.c\n> index 3aa10c780b..76d4be5991 100644\n> --- a/hw/i386/pc.c\n> +++ b/hw/i386/pc.c\n> @@ -39,6 +39,7 @@\n> #include \"elf.h\"\n> #include \"multiboot.h\"\n> #include \"hw/timer/mc146818rtc.h\"\n> +#include \"hw/dma/i8257_dma.h\"\n> #include \"hw/timer/i8254.h\"\n> #include \"hw/input/i8042.h\"\n> #include \"hw/audio/pcspk.h\"\n> @@ -1582,7 +1583,7 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,\n> port92_init(port92, a20_line[1]);\n> g_free(a20_line);\n> \n> - DMA_init(isa_bus, 0);\n> + i8257_dma_init(isa_bus, 0);\n> \n> for(i = 0; i < MAX_FD; i++) {\n> fd[i] = drive_get(IF_FLOPPY, 0, i);\n> diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c\n> index a35745a407..6dc6a0ac18 100644\n> --- a/hw/mips/mips_fulong2e.c\n> +++ b/hw/mips/mips_fulong2e.c\n> @@ -22,6 +22,7 @@\n> #include \"qapi/error.h\"\n> #include \"hw/hw.h\"\n> #include \"hw/i386/pc.h\"\n> +#include \"hw/dma/i8257_dma.h\"\n> #include \"hw/char/serial.h\"\n> #include \"hw/block/fdc.h\"\n> #include \"net/net.h\"\n> @@ -365,7 +366,7 @@ static void mips_fulong2e_init(MachineState *machine)\n> \n> /* init other devices */\n> pit = i8254_pit_init(isa_bus, 0x40, 0, NULL);\n> - DMA_init(isa_bus, 0);\n> + i8257_dma_init(isa_bus, 0);\n> \n> /* Super I/O */\n> isa_create_simple(isa_bus, TYPE_I8042);\n> diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c\n> index 1bbef7eeb5..1b54602c1d 100644\n> --- a/hw/mips/mips_jazz.c\n> +++ b/hw/mips/mips_jazz.c\n> @@ -27,6 +27,7 @@\n> #include \"hw/mips/mips.h\"\n> #include \"hw/mips/cpudevs.h\"\n> #include \"hw/i386/pc.h\"\n> +#include \"hw/dma/i8257_dma.h\"\n> #include \"hw/char/serial.h\"\n> #include \"hw/isa/isa.h\"\n> #include \"hw/block/fdc.h\"\n> @@ -223,7 +224,7 @@ static void mips_jazz_init(MachineState *machine,\n> /* ISA devices */\n> i8259 = i8259_init(isa_bus, env->irq[4]);\n> isa_bus_irqs(isa_bus, i8259);\n> - DMA_init(isa_bus, 0);\n> + i8257_dma_init(isa_bus, 0);\n> pit = i8254_pit_init(isa_bus, 0x40, 0, NULL);\n> pcspk_init(isa_bus, pit);\n> \n> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c\n> index 45c7f589aa..050da36f1d 100644\n> --- a/hw/mips/mips_malta.c\n> +++ b/hw/mips/mips_malta.c\n> @@ -27,6 +27,7 @@\n> #include \"cpu.h\"\n> #include \"hw/hw.h\"\n> #include \"hw/i386/pc.h\"\n> +#include \"hw/dma/i8257_dma.h\"\n> #include \"hw/char/serial.h\"\n> #include \"hw/block/fdc.h\"\n> #include \"net/net.h\"\n> @@ -1219,7 +1220,7 @@ void mips_malta_init(MachineState *machine)\n> smbus_eeprom_init(smbus, 8, smbus_eeprom_buf, smbus_eeprom_size);\n> g_free(smbus_eeprom_buf);\n> pit = i8254_pit_init(isa_bus, 0x40, 0, NULL);\n> - DMA_init(isa_bus, 0);\n> + i8257_dma_init(isa_bus, 0);\n> \n> /* Super I/O */\n> isa_create_simple(isa_bus, TYPE_I8042);\n> diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c\n> index e1bdd4828d..a4ba3d2917 100644\n> --- a/hw/sparc/sun4m.c\n> +++ b/hw/sparc/sun4m.c\n> @@ -101,10 +101,6 @@ struct sun4m_hwdef {\n> uint8_t nvram_machine_id;\n> };\n> \n> -void DMA_init(ISABus *bus, int high_page_enable)\n> -{\n> -}\n> -\n> static void fw_cfg_boot_set(void *opaque, const char *boot_device,\n> Error **errp)\n> {\n> diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c\n> index 973daed977..fd10741607 100644\n> --- a/hw/sparc64/sun4u.c\n> +++ b/hw/sparc64/sun4u.c\n> @@ -86,10 +86,6 @@ typedef struct EbusState {\n> MemoryRegion bar1;\n> } EbusState;\n> \n> -void DMA_init(ISABus *bus, int high_page_enable)\n> -{\n> -}\n> -\n> static void fw_cfg_boot_set(void *opaque, const char *boot_device,\n> Error **errp)\n> {\n> diff --git a/MAINTAINERS b/MAINTAINERS\n> index cc1f8bb66b..a79723601c 100644\n> --- a/MAINTAINERS\n> +++ b/MAINTAINERS\n> @@ -707,6 +707,7 @@ F: hw/ppc/rs6000_mc.c\n> F: hw/pci-host/prep.[hc]\n> F: hw/isa/i82378.c\n> F: hw/isa/pc87312.[hc]\n> +F: hw/dma/i82374.c\n> F: pc-bios/ppc_rom.bin\n> \n> sPAPR\n> @@ -849,6 +850,7 @@ F: hw/misc/pc-testdev.c\n> F: hw/timer/hpet*\n> F: hw/timer/i8254*\n> F: hw/timer/mc146818rtc*\n> +F: include/hw/dma/i8257_dma.h\n> F: include/hw/i2c/pm_smbus.h\n> F: include/hw/input/i8042.h\n> F: include/hw/timer/hpet.h\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=reactos.org header.i=@reactos.org\n\theader.b=\"r16HF6sw\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzLT04ZYnz9sP1\n\tfor ;\n\tSat, 23 Sep 2017 03:44:19 +1000 (AEST)","from localhost ([::1]:60389 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvRzs-0008AZ-Pp\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 13:44:16 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42057)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvRzP-0008AA-5V\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 13:43:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvRzL-00063n-1z\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 13:43:47 -0400","from iserv.reactos.org ([2a01:4f8:221:4c5::3]:40816)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvRzK-000621-LO\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 13:43:42 -0400","from rob92-5-82-227-227-196.fbx.proxad.net ([82.227.227.196]\n\thelo=[192.168.0.35]) by iserv.reactos.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dvRzH-0000sZ-Fh; Fri, 22 Sep 2017 17:43:39 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=reactos.org; s=25047; \n\th=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject;\n\tbh=H2vcF3ERQWSAekYHFlDA7V+AU5wxG016SM4QRZ+uiGU=; \n\tb=r16HF6swF/Xqknzy2yOScKAnXt6/Q1azeglBTBSWSj7/ycuJi3DySmUpu2yvZA/NN+iHt9AOKQZMgpCTC6nm0lG9FwxBSp1Oyw2j4b4qA3TarRPuFRUnh/6B0R8F6N6hy6NHcNK90v75Uh00ETL8mAS9wELxRijIcSOCuNvRTto=;","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tPeter Maydell ,\n\tThomas Huth , \tPaolo Bonzini ,\n\t\"Michael S. Tsirkin\" , \n\tAurelien Jarno , Yongbok Kim\n\t, Richard Henderson ,\n\tDavid Gibson , Alexander Graf\n\t, \tMark Cave-Ayland ,\n\tArtyom Tarasenko ","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922160111.31885-1-f4bug@amsat.org>","From":"=?utf-8?q?Herv=C3=A9_Poussineau?= ","Message-ID":"","Date":"Fri, 22 Sep 2017 19:43:29 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170922160111.31885-1-f4bug@amsat.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]","X-Received-From":"2a01:4f8:221:4c5::3","Subject":"Re: [Qemu-devel] [PATCH 23/34] hw/dma/i8257: rename DMA_init() to\n\ti8257_dma_init()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773808,"web_url":"http://patchwork.ozlabs.org/comment/1773808/","msgid":"<400dde93-d110-ee49-b2a0-76ea633b4abe@amsat.org>","list_archive_url":null,"date":"2017-09-22T18:08:03","subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH 23/34] hw/dma/i8257: rename\n\tDMA_init() to i8257_dma_init()","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/22/2017 02:43 PM, Hervé Poussineau wrote:\n> Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit :\n[...]\n>> +void i8257_dma_init(ISABus *bus, int high_page_enable);\n>> +\n> \n> As you're changing the DMA_init prototype, can you add an Error **errp \n> parameter, and pass &error_abort in each caller?\n> \n> See http://lists.gnu.org/archive/html/qemu-devel/2017-09/msg00262.html \n> for more details\n\nIf Eduardo doesn't have a patch ready I can do it.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"kPeheBZn\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzM1P5Jhcz9sPr\n\tfor ;\n\tSat, 23 Sep 2017 04:08:57 +1000 (AEST)","from localhost ([::1]:60472 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvSNj-0008CA-RS\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 14:08:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49474)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dvSN3-0008Bx-6V\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 14:08:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dvSN0-00029d-AH\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 14:08:13 -0400","from mail-qt0-x22d.google.com ([2607:f8b0:400d:c0d::22d]:51285)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvSN0-00029X-5j; Fri, 22 Sep 2017 14:08:10 -0400","by mail-qt0-x22d.google.com with SMTP id q4so1859298qtq.8;\n\tFri, 22 Sep 2017 11:08:10 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tp23sm334441qtg.2.2017.09.22.11.08.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 11:08:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=buf8XkEjo4bJvr4sTW/j5c+A0luNS/qCa0pw4eINE9Q=;\n\tb=kPeheBZn/32lZOvFmYNUpmKzvTywGzJjQ6/cowi0k2DwfQmC728hov8gRMW6UrqGH3\n\t/7GGPoOy81SB+s5yOVV2whc7G6oJCoZc/1HdTMhtuiBfKNrtVI8vTI1bgddSR9p4lF5D\n\t+hAWOUYJb6Citm5dTh1qCqJrS8oqu+YVMEGuWmikRyoGCW3gn/BmayPNlG9EH504hJMb\n\tSkAqLiU0vyOarNGuS+ux2dxL4EdLd7LrtYDR/RocV2PHb/T90lUpASe1U462M5V/DblT\n\tY3ouRhCFWucuBSNe+RjGL1Gq/WhjvSUhrkpQY4X07fmyqs8xozHbpQq1D9Oby8uvZ/6I\n\tD6gA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=buf8XkEjo4bJvr4sTW/j5c+A0luNS/qCa0pw4eINE9Q=;\n\tb=BMqc0IKSs8Wbvx2EK6QClOEUpVA+Thd2H+p9tjnFpT1/3iS+5wmeHa4cIlhmyak7sS\n\thewpgPXUH+Hl/5i+ItgjLhsG07lbWDm0iyxSNWMmeoK3ZH5qUb2Z43a9e0SqLlqoxs8X\n\tDb89VVaZRgNBuPPS/sTue9tLTGAdBv5djTP/QGMWatAAgw/nW3FOtHyqAxILscXKWki6\n\thWBNCI6GPsUPTPTSfrs3FVVMyip5kVPWl5sdX1UcNUPLhuhbZp3/R7SNShnhrBWw86LL\n\tBZUn3j5GSARwGBjSYrtQaFDhc4faCSGc+rixgxnduHiJAhekDBKDhBHJ/DRxWim0yLpP\n\tV92Q==","X-Gm-Message-State":"AHPjjUikcl8jRYIK5J/1FSYQ7GPMuEhWt2PHxvoQnQNhcoK9fU8/Jjey\n\tQL4mvbQ6tUKF9zJe/Jq5gg3wHUQ/PGU=","X-Google-Smtp-Source":"AOwi7QBqShh9eqKibTamFvorBG4eZSe7HIP+T1NVrrygR3Kc5PD0HS8QETGbTZMKpycICDxD19dT3Q==","X-Received":"by 10.237.35.238 with SMTP id k43mr38481qtc.214.1506103689507;\n\tFri, 22 Sep 2017 11:08:09 -0700 (PDT)","To":"=?utf-8?q?Herv=C3=A9_Poussineau?= ,\n\tPeter Maydell ,\n\tThomas Huth , \tPaolo Bonzini ,\n\t\"Michael S. Tsirkin\" , \n\tAurelien Jarno , Yongbok Kim\n\t, Richard Henderson ,\n\tDavid Gibson , Alexander Graf\n\t, \tMark Cave-Ayland ,\n\tArtyom Tarasenko , \n\t\"Eduardo Otubo\\\"\" ","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922160111.31885-1-f4bug@amsat.org>\n\t","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<400dde93-d110-ee49-b2a0-76ea633b4abe@amsat.org>","Date":"Fri, 22 Sep 2017 15:08:03 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::22d","Subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH 23/34] hw/dma/i8257: rename\n\tDMA_init() to i8257_dma_init()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1781495,"web_url":"http://patchwork.ozlabs.org/comment/1781495/","msgid":"<20171006120948.GA12173@vader>","list_archive_url":null,"date":"2017-10-06T12:09:48","subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH 23/34] hw/dma/i8257: rename\n\tDMA_init() to i8257_dma_init()","submitter":{"id":71779,"url":"http://patchwork.ozlabs.org/api/people/71779/","name":"Eduardo Otubo","email":"otubo@redhat.com"},"content":"On Fri, Sep 22, 2017 at 03:08:03PM -0300, Philippe Mathieu-Daudé wrote:\n> On 09/22/2017 02:43 PM, Hervé Poussineau wrote:\n> > Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit :\n> [...]\n> > > +void i8257_dma_init(ISABus *bus, int high_page_enable);\n> > > +\n> > \n> > As you're changing the DMA_init prototype, can you add an Error **errp\n> > parameter, and pass &error_abort in each caller?\n> > \n> > See http://lists.gnu.org/archive/html/qemu-devel/2017-09/msg00262.html\n> > for more details\n> \n> If Eduardo doesn't have a patch ready I can do it.\n\nPlease go ahead.\nYou can also use my patch set (v2) for that as a base if you want.\nhttps://lists.gnu.org/archive/html/qemu-devel/2017-09/msg08007.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=otubo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y7pPW2X87z9t3m\n\tfor ;\n\tFri, 6 Oct 2017 23:10:39 +1100 (AEDT)","from localhost ([::1]:44544 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e0RSf-000290-Ce\n\tfor incoming@patchwork.ozlabs.org; Fri, 06 Oct 2017 08:10:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40385)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e0RS9-00028S-0U\n\tfor qemu-devel@nongnu.org; Fri, 06 Oct 2017 08:10:05 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e0RS4-0004Yv-W9\n\tfor qemu-devel@nongnu.org; Fri, 06 Oct 2017 08:10:04 -0400","from mx1.redhat.com ([209.132.183.28]:46882)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e0RS4-0004WZ-NP; Fri, 06 Oct 2017 08:10:00 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B77F513A42;\n\tFri, 6 Oct 2017 12:09:57 +0000 (UTC)","from vader (ovpn-117-77.ams2.redhat.com [10.36.117.77])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AEDCA6444B;\n\tFri, 6 Oct 2017 12:09:49 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B77F513A42","Date":"Fri, 6 Oct 2017 14:09:48 +0200","From":"\"Eduardo Otubo\\\"\" ","To":"Philippe =?utf-8?q?Mathieu-Daud=C3=A9?= ","Message-ID":"<20171006120948.GA12173@vader>","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922160111.31885-1-f4bug@amsat.org>\n\t\n\t<400dde93-d110-ee49-b2a0-76ea633b4abe@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<400dde93-d110-ee49-b2a0-76ea633b4abe@amsat.org>","User-Agent":"Mutt/1.8.3+47 (5f034395e53d) (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tFri, 06 Oct 2017 12:09:58 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH 23/34] hw/dma/i8257: rename\n\tDMA_init() to i8257_dma_init()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Thomas Huth ,\n\t\"Michael S. Tsirkin\" , qemu-trivial@nongnu.org, Mark\n\tCave-Ayland , Alexander Graf\n\t, qemu-devel@nongnu.org, =?utf-8?b?SGVydsOp?=\n\tPoussineau ,\n\tArtyom Tarasenko , Yongbok Kim\n\t, Paolo Bonzini ,\n\tDavid Gibson , qemu-ppc@nongnu.org,\n\tAurelien Jarno ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]