[{"id":1773854,"web_url":"http://patchwork.ozlabs.org/comment/1773854/","msgid":"<7c36f87b-78eb-2db7-679e-3ee76725e4d4@reactos.org>","list_archive_url":null,"date":"2017-09-22T20:10:48","subject":"Re: [Qemu-devel] [PATCH 22/34] hw/input/i8042: extract API from\n\thw/i386/pc.h","submitter":{"id":2909,"url":"http://patchwork.ozlabs.org/api/people/2909/","name":"Hervé Poussineau","email":"hpoussin@reactos.org"},"content":"Le 22/09/2017 à 17:40, Philippe Mathieu-Daudé a écrit :\n> - include vmmouse\n> - add entries in MAINTAINERS (pckbd.c, i8042.h)\n> \n> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n> ---\n>   include/hw/i386/pc.h     | 11 -----------\n>   include/hw/input/i8042.h | 30 ++++++++++++++++++++++++++++++\n>   hw/alpha/dp264.c         |  3 ++-\n>   hw/i386/pc.c             |  5 +++--\n>   hw/input/pckbd.c         |  2 +-\n>   hw/input/vmmouse.c       |  3 +--\n>   hw/mips/mips_fulong2e.c  |  3 ++-\n>   hw/mips/mips_jazz.c      |  1 +\n>   hw/mips/mips_malta.c     |  3 ++-\n>   hw/mips/mips_r4k.c       |  3 ++-\n>   hw/misc/vmport.c         |  1 +\n>   hw/ppc/prep.c            |  5 +++--\n>   hw/sparc64/sun4u.c       |  3 ++-\n>   hw/unicore32/puv3.c      |  1 +\n>   MAINTAINERS              |  4 +++-\n>   15 files changed, 54 insertions(+), 24 deletions(-)\n>   create mode 100644 include/hw/input/i8042.h\n\nReviewed-by: Hervé Poussineau <hpoussin@reactos.org>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=reactos.org header.i=@reactos.org\n\theader.b=\"iE2AnSll\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzPpd1sS5z9s82\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 Sep 2017 06:14:49 +1000 (AEST)","from localhost ([::1]:60862 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dvULX-0006ZW-8J\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 16:14:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60878)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <hpoussin@reactos.org>) id 1dvUHu-0004Bs-2d\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 16:11:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <hpoussin@reactos.org>) id 1dvUHt-0004XK-5M\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 16:11:02 -0400","from iserv.reactos.org ([2a01:4f8:221:4c5::3]:47029)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <hpoussin@reactos.org>)\n\tid 1dvUHn-0004TH-00; Fri, 22 Sep 2017 16:10:55 -0400","from rob92-5-82-227-227-196.fbx.proxad.net ([82.227.227.196]\n\thelo=[192.168.0.35]) by iserv.reactos.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)\n\t(envelope-from <hpoussin@reactos.org>)\n\tid 1dvUHm-0005St-14; Fri, 22 Sep 2017 20:10:54 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=reactos.org; s=25047; \n\th=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject;\n\tbh=xkC4jEfXI9ufbnbu9vPHVk5bx1Ccdy+SAP3ZeCFfjJI=; \n\tb=iE2AnSll5bRORdPy8gz+FKeTr7EVuAKBzE7Bu2xiOHF89L5punShbU5aGpovC2jHGyFd4rWZ4wWggF9dDz5vi+bEE2repadV89uG/3q7jG4kP4BVlNvxYxGSQMJPLwbsC3jT4ie7tigTtA2E8jXIUnSh2Oum74+S3JAqD445QUI=;","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>,\n\tPeter Maydell <peter.maydell@linaro.org>,\n\tThomas Huth <thuth@redhat.com>, \tPaolo Bonzini <pbonzini@redhat.com>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>, \n\tAurelien Jarno <aurelien@aurel32.net>, Yongbok Kim\n\t<yongbok.kim@imgtec.com>, Richard Henderson <rth@twiddle.net>,\n\tDavid Gibson <david@gibson.dropbear.id.au>, Alexander Graf\n\t<agraf@suse.de>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Mark Cave-Ayland\n\t<mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922154014.29350-23-f4bug@amsat.org>","From":"=?utf-8?q?Herv=C3=A9_Poussineau?= <hpoussin@reactos.org>","Message-ID":"<7c36f87b-78eb-2db7-679e-3ee76725e4d4@reactos.org>","Date":"Fri, 22 Sep 2017 22:10:48 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170922154014.29350-23-f4bug@amsat.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]","X-Received-From":"2a01:4f8:221:4c5::3","Subject":"Re: [Qemu-devel] [PATCH 22/34] hw/input/i8042: extract API from\n\thw/i386/pc.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-ppc@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1773983,"web_url":"http://patchwork.ozlabs.org/comment/1773983/","msgid":"<20170923050943.GX4998@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-23T05:09:43","subject":"Re: [Qemu-devel] [PATCH 22/34] hw/input/i8042: extract API from\n\thw/i386/pc.h","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Fri, Sep 22, 2017 at 12:40:02PM -0300, Philippe Mathieu-Daudé wrote:\n> - include vmmouse\n> - add entries in MAINTAINERS (pckbd.c, i8042.h)\n> \n> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n\nppc portions\n\nAcked-by: David Gibson <david@gibson.dropbear.id.au>\n\n> ---\n>  include/hw/i386/pc.h     | 11 -----------\n>  include/hw/input/i8042.h | 30 ++++++++++++++++++++++++++++++\n>  hw/alpha/dp264.c         |  3 ++-\n>  hw/i386/pc.c             |  5 +++--\n>  hw/input/pckbd.c         |  2 +-\n>  hw/input/vmmouse.c       |  3 +--\n>  hw/mips/mips_fulong2e.c  |  3 ++-\n>  hw/mips/mips_jazz.c      |  1 +\n>  hw/mips/mips_malta.c     |  3 ++-\n>  hw/mips/mips_r4k.c       |  3 ++-\n>  hw/misc/vmport.c         |  1 +\n>  hw/ppc/prep.c            |  5 +++--\n>  hw/sparc64/sun4u.c       |  3 ++-\n>  hw/unicore32/puv3.c      |  1 +\n>  MAINTAINERS              |  4 +++-\n>  15 files changed, 54 insertions(+), 24 deletions(-)\n>  create mode 100644 include/hw/input/i8042.h\n> \n> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h\n> index 25ba378bd8..6a2e947332 100644\n> --- a/include/hw/i386/pc.h\n> +++ b/include/hw/i386/pc.h\n> @@ -193,17 +193,6 @@ static inline void vmport_init(ISABus *bus)\n>  }\n>  \n>  void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);\n> -void vmmouse_get_data(uint32_t *data);\n> -void vmmouse_set_data(const uint32_t *data);\n> -\n> -/* pckbd.c */\n> -#define I8042_A20_LINE \"a20\"\n> -\n> -void i8042_mm_init(qemu_irq kbd_irq, qemu_irq mouse_irq,\n> -                   MemoryRegion *region, ram_addr_t size,\n> -                   hwaddr mask);\n> -void i8042_isa_mouse_fake_event(void *opaque);\n> -void i8042_setup_a20_line(ISADevice *dev, qemu_irq a20_out);\n>  \n>  /* pc.c */\n>  extern int fd_bootchk;\n> diff --git a/include/hw/input/i8042.h b/include/hw/input/i8042.h\n> new file mode 100644\n> index 0000000000..836417304b\n> --- /dev/null\n> +++ b/include/hw/input/i8042.h\n> @@ -0,0 +1,30 @@\n> +/*\n> + * QEMU PS/2 Controller\n> + *\n> + * Copyright (c) 2003 Fabrice Bellard\n> + *\n> + * This work is licensed under the terms of the GNU GPL, version 2 or later.\n> + * See the COPYING file in the top-level directory.\n> + */\n> +#ifndef HW_INPUT_I8042_H\n> +#define HW_INPUT_I8042_H\n> +\n> +#include \"hw/hw.h\"\n> +#include \"hw/isa/isa.h\"\n> +\n> +#define TYPE_I8042 \"i8042\"\n> +\n> +#define I8042_A20_LINE \"a20\"\n> +\n> +void i8042_mm_init(qemu_irq kbd_irq, qemu_irq mouse_irq,\n> +                   MemoryRegion *region, ram_addr_t size,\n> +                   hwaddr mask);\n> +void i8042_isa_mouse_fake_event(void *opaque);\n> +void i8042_setup_a20_line(ISADevice *dev, qemu_irq a20_out);\n> +\n> +#define TYPE_VMMOUSE \"vmmouse\"\n> +\n> +void vmmouse_get_data(uint32_t *data);\n> +void vmmouse_set_data(const uint32_t *data);\n> +\n> +#endif /* HW_INPUT_I8042_H */\n> diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c\n> index 1bd5243648..2253990654 100644\n> --- a/hw/alpha/dp264.c\n> +++ b/hw/alpha/dp264.c\n> @@ -19,6 +19,7 @@\n>  #include \"hw/timer/mc146818rtc.h\"\n>  #include \"hw/ide.h\"\n>  #include \"hw/timer/i8254.h\"\n> +#include \"hw/input/i8042.h\"\n>  #include \"hw/char/serial.h\"\n>  #include \"qemu/cutils.h\"\n>  \n> @@ -82,7 +83,7 @@ static void clipper_init(MachineState *machine)\n>      rtc_init(isa_bus, 1900, rtc_irq);\n>  \n>      i8254_pit_init(isa_bus, 0x40, 0, NULL);\n> -    isa_create_simple(isa_bus, \"i8042\");\n> +    isa_create_simple(isa_bus, TYPE_I8042);\n>  \n>      /* VGA setup.  Don't bother loading the bios.  */\n>      pci_vga_init(pci_bus);\n> diff --git a/hw/i386/pc.c b/hw/i386/pc.c\n> index 5cb0ae67cd..3aa10c780b 100644\n> --- a/hw/i386/pc.c\n> +++ b/hw/i386/pc.c\n> @@ -40,6 +40,7 @@\n>  #include \"multiboot.h\"\n>  #include \"hw/timer/mc146818rtc.h\"\n>  #include \"hw/timer/i8254.h\"\n> +#include \"hw/input/i8042.h\"\n>  #include \"hw/audio/pcspk.h\"\n>  #include \"hw/pci/msi.h\"\n>  #include \"hw/sysbus.h\"\n> @@ -1564,11 +1565,11 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,\n>      parallel_hds_isa_init(isa_bus, MAX_PARALLEL_PORTS);\n>  \n>      a20_line = qemu_allocate_irqs(handle_a20_line_change, first_cpu, 2);\n> -    i8042 = isa_create_simple(isa_bus, \"i8042\");\n> +    i8042 = isa_create_simple(isa_bus, TYPE_I8042);\n>      i8042_setup_a20_line(i8042, a20_line[0]);\n>      if (!no_vmport) {\n>          vmport_init(isa_bus);\n> -        vmmouse = isa_try_create(isa_bus, \"vmmouse\");\n> +        vmmouse = isa_try_create(isa_bus, TYPE_VMMOUSE);\n>      } else {\n>          vmmouse = NULL;\n>      }\n> diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c\n> index c479f827b6..f17f18e51b 100644\n> --- a/hw/input/pckbd.c\n> +++ b/hw/input/pckbd.c\n> @@ -26,6 +26,7 @@\n>  #include \"hw/isa/isa.h\"\n>  #include \"hw/i386/pc.h\"\n>  #include \"hw/input/ps2.h\"\n> +#include \"hw/input/i8042.h\"\n>  #include \"sysemu/sysemu.h\"\n>  \n>  /* debug PC keyboard */\n> @@ -480,7 +481,6 @@ void i8042_mm_init(qemu_irq kbd_irq, qemu_irq mouse_irq,\n>      qemu_register_reset(kbd_reset, s);\n>  }\n>  \n> -#define TYPE_I8042 \"i8042\"\n>  #define I8042(obj) OBJECT_CHECK(ISAKBDState, (obj), TYPE_I8042)\n>  \n>  typedef struct ISAKBDState {\n> diff --git a/hw/input/vmmouse.c b/hw/input/vmmouse.c\n> index b6d22086f4..c48c07c564 100644\n> --- a/hw/input/vmmouse.c\n> +++ b/hw/input/vmmouse.c\n> @@ -24,7 +24,7 @@\n>  #include \"qemu/osdep.h\"\n>  #include \"hw/hw.h\"\n>  #include \"ui/console.h\"\n> -#include \"hw/input/ps2.h\"\n> +#include \"hw/input/i8042.h\"\n>  #include \"hw/i386/pc.h\"\n>  #include \"hw/qdev.h\"\n>  \n> @@ -52,7 +52,6 @@\n>  #define DPRINTF(fmt, ...) do { } while (0)\n>  #endif\n>  \n> -#define TYPE_VMMOUSE \"vmmouse\"\n>  #define VMMOUSE(obj) OBJECT_CHECK(VMMouseState, (obj), TYPE_VMMOUSE)\n>  \n>  typedef struct VMMouseState\n> diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c\n> index 22e6c05fb5..a35745a407 100644\n> --- a/hw/mips/mips_fulong2e.c\n> +++ b/hw/mips/mips_fulong2e.c\n> @@ -42,6 +42,7 @@\n>  #include \"hw/isa/vt82c686.h\"\n>  #include \"hw/timer/mc146818rtc.h\"\n>  #include \"hw/timer/i8254.h\"\n> +#include \"hw/input/i8042.h\"\n>  #include \"sysemu/blockdev.h\"\n>  #include \"exec/address-spaces.h\"\n>  #include \"sysemu/qtest.h\"\n> @@ -367,7 +368,7 @@ static void mips_fulong2e_init(MachineState *machine)\n>      DMA_init(isa_bus, 0);\n>  \n>      /* Super I/O */\n> -    isa_create_simple(isa_bus, \"i8042\");\n> +    isa_create_simple(isa_bus, TYPE_I8042);\n>  \n>      rtc_init(isa_bus, 2000, NULL);\n>  \n> diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c\n> index 25f0294236..1bbef7eeb5 100644\n> --- a/hw/mips/mips_jazz.c\n> +++ b/hw/mips/mips_jazz.c\n> @@ -41,6 +41,7 @@\n>  #include \"hw/timer/i8254.h\"\n>  #include \"hw/display/vga.h\"\n>  #include \"hw/audio/pcspk.h\"\n> +#include \"hw/input/i8042.h\"\n>  #include \"sysemu/block-backend.h\"\n>  #include \"hw/sysbus.h\"\n>  #include \"exec/address-spaces.h\"\n> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c\n> index de547d732f..45c7f589aa 100644\n> --- a/hw/mips/mips_malta.c\n> +++ b/hw/mips/mips_malta.c\n> @@ -45,6 +45,7 @@\n>  #include \"hw/loader.h\"\n>  #include \"elf.h\"\n>  #include \"hw/timer/mc146818rtc.h\"\n> +#include \"hw/input/i8042.h\"\n>  #include \"hw/timer/i8254.h\"\n>  #include \"sysemu/blockdev.h\"\n>  #include \"exec/address-spaces.h\"\n> @@ -1221,7 +1222,7 @@ void mips_malta_init(MachineState *machine)\n>      DMA_init(isa_bus, 0);\n>  \n>      /* Super I/O */\n> -    isa_create_simple(isa_bus, \"i8042\");\n> +    isa_create_simple(isa_bus, TYPE_I8042);\n>  \n>      rtc_init(isa_bus, 2000, NULL);\n>      serial_hds_isa_init(isa_bus, 0, 2);\n> diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c\n> index 48fad52540..946097a31f 100644\n> --- a/hw/mips/mips_r4k.c\n> +++ b/hw/mips/mips_r4k.c\n> @@ -27,6 +27,7 @@\n>  #include \"hw/loader.h\"\n>  #include \"elf.h\"\n>  #include \"hw/timer/mc146818rtc.h\"\n> +#include \"hw/input/i8042.h\"\n>  #include \"hw/timer/i8254.h\"\n>  #include \"sysemu/block-backend.h\"\n>  #include \"exec/address-spaces.h\"\n> @@ -295,7 +296,7 @@ void mips_r4k_init(MachineState *machine)\n>                       hd[MAX_IDE_DEVS * i],\n>  \t\t     hd[MAX_IDE_DEVS * i + 1]);\n>  \n> -    isa_create_simple(isa_bus, \"i8042\");\n> +    isa_create_simple(isa_bus, TYPE_I8042);\n>  }\n>  \n>  static void mips_machine_init(MachineClass *mc)\n> diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c\n> index 165500223f..bc078eb20a 100644\n> --- a/hw/misc/vmport.c\n> +++ b/hw/misc/vmport.c\n> @@ -25,6 +25,7 @@\n>  #include \"hw/hw.h\"\n>  #include \"hw/isa/isa.h\"\n>  #include \"hw/i386/pc.h\"\n> +#include \"hw/input/i8042.h\"\n>  #include \"sysemu/hw_accel.h\"\n>  #include \"hw/qdev.h\"\n>  \n> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c\n> index 94138a4e8c..16f4537093 100644\n> --- a/hw/ppc/prep.c\n> +++ b/hw/ppc/prep.c\n> @@ -41,6 +41,7 @@\n>  #include \"hw/ide.h\"\n>  #include \"hw/loader.h\"\n>  #include \"hw/timer/mc146818rtc.h\"\n> +#include \"hw/input/i8042.h\"\n>  #include \"hw/isa/pc87312.h\"\n>  #include \"sysemu/block-backend.h\"\n>  #include \"sysemu/arch_init.h\"\n> @@ -643,7 +644,7 @@ static void ppc_prep_init(MachineState *machine)\n>                       hd[2 * i],\n>  \t\t     hd[2 * i + 1]);\n>      }\n> -    isa_create_simple(isa_bus, \"i8042\");\n> +    isa_create_simple(isa_bus, TYPE_I8042);\n>  \n>      cpu = POWERPC_CPU(first_cpu);\n>      sysctrl->reset_irq = cpu->env.irq_inputs[PPC6xx_INPUT_HRESET];\n> @@ -775,7 +776,7 @@ static void ibm_40p_init(MachineState *machine)\n>  \n>      /* add some more devices */\n>      if (defaults_enabled()) {\n> -        isa_create_simple(isa_bus, \"i8042\");\n> +        isa_create_simple(isa_bus, TYPE_I8042);\n>          m48t59 = NVRAM(isa_create_simple(isa_bus, \"isa-m48t59\"));\n>  \n>          dev = DEVICE(isa_create(isa_bus, \"cs4231a\"));\n> diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c\n> index c3280aaf38..973daed977 100644\n> --- a/hw/sparc64/sun4u.c\n> +++ b/hw/sparc64/sun4u.c\n> @@ -31,6 +31,7 @@\n>  #include \"hw/i386/pc.h\"\n>  #include \"hw/char/serial.h\"\n>  #include \"hw/timer/m48t59.h\"\n> +#include \"hw/input/i8042.h\"\n>  #include \"hw/block/fdc.h\"\n>  #include \"net/net.h\"\n>  #include \"qemu/timer.h\"\n> @@ -488,7 +489,7 @@ static void sun4uv_init(MemoryRegion *address_space_mem,\n>  \n>      pci_cmd646_ide_init(pci_bus, hd, 1);\n>  \n> -    isa_create_simple(isa_bus, \"i8042\");\n> +    isa_create_simple(isa_bus, TYPE_I8042);\n>  \n>      /* Floppy */\n>      for(i = 0; i < MAX_FD; i++) {\n> diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c\n> index 6849bac59c..cf79c89f12 100644\n> --- a/hw/unicore32/puv3.c\n> +++ b/hw/unicore32/puv3.c\n> @@ -19,6 +19,7 @@\n>  \n>  #undef DEBUG_PUV3\n>  #include \"hw/unicore32/puv3.h\"\n> +#include \"hw/input/i8042.h\"\n>  \n>  #define KERNEL_LOAD_ADDR        0x03000000\n>  #define KERNEL_MAX_SIZE         0x00800000 /* Just a guess */\n> diff --git a/MAINTAINERS b/MAINTAINERS\n> index f7d377ead9..cc1f8bb66b 100644\n> --- a/MAINTAINERS\n> +++ b/MAINTAINERS\n> @@ -834,12 +834,13 @@ F: hw/misc/sga.c\n>  PC Chipset\n>  M: Michael S. Tsirkin <mst@redhat.com>\n>  M: Paolo Bonzini <pbonzini@redhat.com>\n> -S: Support\n> +S: Supported\n>  F: hw/char/debugcon.c\n>  F: hw/char/parallel.c\n>  F: hw/char/serial*\n>  F: hw/dma/i8257*\n>  F: hw/i2c/pm_smbus.c\n> +F: hw/input/pckbd.c\n>  F: hw/intc/apic*\n>  F: hw/intc/ioapic*\n>  F: hw/intc/i8259*\n> @@ -849,6 +850,7 @@ F: hw/timer/hpet*\n>  F: hw/timer/i8254*\n>  F: hw/timer/mc146818rtc*\n>  F: include/hw/i2c/pm_smbus.h\n> +F: include/hw/input/i8042.h\n>  F: include/hw/timer/hpet.h\n>  F: include/hw/timer/i8254*\n>  F: include/hw/timer/mc146818rtc*","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"HRlNHPlM\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzfJX5Yhyz9t67\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 Sep 2017 15:38:03 +1000 (AEST)","from localhost ([::1]:33777 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dvd8b-000525-2U\n\tfor incoming@patchwork.ozlabs.org; Sat, 23 Sep 2017 01:38:01 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36122)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1dvd0H-0007Ja-Dk\n\tfor qemu-devel@nongnu.org; Sat, 23 Sep 2017 01:29:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1dvd0E-00029i-GD\n\tfor qemu-devel@nongnu.org; Sat, 23 Sep 2017 01:29:25 -0400","from ozlabs.org ([103.22.144.67]:39891)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <dgibson@ozlabs.org>)\n\tid 1dvd0D-00028y-Sc; Sat, 23 Sep 2017 01:29:22 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xzf6R2rqNz9sP1; Sat, 23 Sep 2017 15:29:19 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1506144559;\n\tbh=JRACSQkKXeA2sZ0Ywlc0bMsnWX+w9P+OA8EkbhDGxIk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HRlNHPlM89FKHHmx3KA1R+l3BuKkIKXhjMQM4MrE49n6cBxOvHQL7xWm/vsQW2xzq\n\tbsXJjsctwJ8kUdYnCHUdP4L9GQB8hrD2z6vlPaNlXnUFaZ6oqbTIFw3c+ey8U3/xX0\n\tqyl+sshd6LsmWhX3/ruJ9n/AjIfSd7Skxw5bFtEo=","Date":"Sat, 23 Sep 2017 15:09:43 +1000","From":"David Gibson <david@gibson.dropbear.id.au>","To":"Philippe =?iso-8859-1?q?Mathieu-Daud=E9?= <f4bug@amsat.org>","Message-ID":"<20170923050943.GX4998@umbus.fritz.box>","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922154014.29350-23-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"BkCcXYe/IK2urb/q\"","Content-Disposition":"inline","In-Reply-To":"<20170922154014.29350-23-f4bug@amsat.org>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [PATCH 22/34] hw/input/i8042: extract API from\n\thw/i386/pc.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>, qemu-ppc@nongnu.org, Mark\n\tCave-Ayland <mark.cave-ayland@ilande.co.uk>, Alexander Graf\n\t<agraf@suse.de>, qemu-devel@nongnu.org, =?iso-8859-1?q?Herv=E9?=\n\tPoussineau <hpoussin@reactos.org>,\n\tArtyom Tarasenko <atar4qemu@gmail.com>, Yongbok Kim\n\t<yongbok.kim@imgtec.com>, Paolo Bonzini <pbonzini@redhat.com>,\n\tGuan Xuetao <gxt@mprc.pku.edu.cn>, Aurelien Jarno <aurelien@aurel32.net>,\n\tRichard Henderson <rth@twiddle.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]