[{"id":1773730,"web_url":"http://patchwork.ozlabs.org/comment/1773730/","msgid":"","list_archive_url":null,"date":"2017-09-22T16:05:04","subject":"Re: [Qemu-devel] [PATCH 16/34] hw/tpm: remove old i386 dependency","submitter":{"id":6671,"url":"http://patchwork.ozlabs.org/api/people/6671/","name":"Stefan Berger","email":"stefanb@linux.vnet.ibm.com"},"content":"On 09/22/2017 11:39 AM, Philippe Mathieu-Daudé wrote:\n> Signed-off-by: Philippe Mathieu-Daudé \n\nReviewed-by: Stefan Berger \n\n> ---\n> hw/tpm/tpm_passthrough.c | 1 -\n> hw/tpm/tpm_tis.c | 1 -\n> 2 files changed, 2 deletions(-)\n>\n> diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c\n> index 9234eb3459..461f551a0c 100644\n> --- a/hw/tpm/tpm_passthrough.c\n> +++ b/hw/tpm/tpm_passthrough.c\n> @@ -29,7 +29,6 @@\n> #include \"sysemu/tpm_backend.h\"\n> #include \"tpm_int.h\"\n> #include \"hw/hw.h\"\n> -#include \"hw/i386/pc.h\"\n> #include \"sysemu/tpm_backend_int.h\"\n> #include \"tpm_tis.h\"\n> #include \"tpm_util.h\"\n> diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c\n> index a6440fef91..a3a93f7229 100644\n> --- a/hw/tpm/tpm_tis.c\n> +++ b/hw/tpm/tpm_tis.c\n> @@ -28,7 +28,6 @@\n> #include \"sysemu/block-backend.h\"\n> #include \"exec/address-spaces.h\"\n> #include \"hw/hw.h\"\n> -#include \"hw/i386/pc.h\"\n> #include \"hw/pci/pci_ids.h\"\n> #include \"tpm_tis.h\"\n> #include \"qapi/error.h\"","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzJZd36fvz9s7g\n\tfor ;\n\tSat, 23 Sep 2017 02:19:04 +1000 (AEST)","from localhost ([::1]:59929 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvQfL-0004D1-Vd\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 12:19:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54292)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvQS6-0001JG-4H\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:05:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvQS2-0002Kx-3X\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:05:18 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34316\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvQS1-0002KU-Ta\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:05:14 -0400","from pps.filterd (m0098419.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8MG4MGK009737\n\tfor ; Fri, 22 Sep 2017 12:05:10 -0400","from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d53j0rk0x-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 22 Sep 2017 12:05:10 -0400","from localhost\n\tby e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 22 Sep 2017 10:05:09 -0600","from b03cxnp07029.gho.boulder.ibm.com (9.17.130.16)\n\tby e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 22 Sep 2017 10:05:06 -0600","from b03ledav002.gho.boulder.ibm.com\n\t(b03ledav002.gho.boulder.ibm.com [9.17.130.233])\n\tby b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8MG51h39568754; Fri, 22 Sep 2017 09:05:05 -0700","from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 9AFF2136043;\n\tFri, 22 Sep 2017 10:05:05 -0600 (MDT)","from sbct-3.pok.ibm.com (unknown [9.47.158.153])\n\tby b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP id\n\tE0A33136040; Fri, 22 Sep 2017 10:05:04 -0600 (MDT)"],"To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tPeter Maydell , Thomas Huth ,\n\tPaolo Bonzini , Amarnath Valluri\n\t","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922154014.29350-17-f4bug@amsat.org>","From":"Stefan Berger ","Date":"Fri, 22 Sep 2017 12:05:04 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.4.0","MIME-Version":"1.0","In-Reply-To":"<20170922154014.29350-17-f4bug@amsat.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","X-TM-AS-GCONF":"00","x-cbid":"17092216-8235-0000-0000-00000C4F3486","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007778; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000231; SDB=6.00920776; UDB=6.00462704;\n\tIPR=6.00700997; \n\tBA=6.00005601; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017249;\n\tXFM=3.00000015; UTC=2017-09-22 16:05:08","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092216-8236-0000-0000-00003DC14B88","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-22_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709220227","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0b-001b2d01.pphosted.com id v8MG4MGK009737","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH 16/34] hw/tpm: remove old i386 dependency","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]