[{"id":1773773,"web_url":"http://patchwork.ozlabs.org/comment/1773773/","msgid":"<5d7ffac0-e0a9-c503-7ae5-b27ad86f4c94@gmail.com>","list_archive_url":null,"date":"2017-09-22T16:58:07","subject":"Re: [Qemu-devel] [PATCH 14/34] hw/ipmi: remove old i386 dependency","submitter":{"id":15257,"url":"http://patchwork.ozlabs.org/api/people/15257/","name":"Corey Minyard","email":"tcminyard@gmail.com"},"content":"On 09/22/2017 10:39 AM, Philippe Mathieu-Daudé wrote:\n> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n\nAs mentioned before, I applied this series and did some basic testing, so\n\nReviewed-by: Corey Minyard <cminyard@mvista.com>\nTested-by: Corey Minyard <cminyard@mvista.com>\n\n> ---\n>   hw/ipmi/isa_ipmi_bt.c  | 1 -\n>   hw/ipmi/isa_ipmi_kcs.c | 1 -\n>   2 files changed, 2 deletions(-)\n>\n> diff --git a/hw/ipmi/isa_ipmi_bt.c b/hw/ipmi/isa_ipmi_bt.c\n> index 2fcc3d2e7c..e098fd5206 100644\n> --- a/hw/ipmi/isa_ipmi_bt.c\n> +++ b/hw/ipmi/isa_ipmi_bt.c\n> @@ -26,7 +26,6 @@\n>   #include \"hw/hw.h\"\n>   #include \"hw/ipmi/ipmi.h\"\n>   #include \"hw/isa/isa.h\"\n> -#include \"hw/i386/pc.h\"\n>   \n>   /* Control register */\n>   #define IPMI_BT_CLR_WR_BIT         0\n> diff --git a/hw/ipmi/isa_ipmi_kcs.c b/hw/ipmi/isa_ipmi_kcs.c\n> index 80444977a0..689587b65d 100644\n> --- a/hw/ipmi/isa_ipmi_kcs.c\n> +++ b/hw/ipmi/isa_ipmi_kcs.c\n> @@ -26,7 +26,6 @@\n>   #include \"hw/hw.h\"\n>   #include \"hw/ipmi/ipmi.h\"\n>   #include \"hw/isa/isa.h\"\n> -#include \"hw/i386/pc.h\"\n>   \n>   #define IPMI_KCS_OBF_BIT        0\n>   #define IPMI_KCS_IBF_BIT        1","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Izk2G07T\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzKSW08pkz9s7h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 Sep 2017 02:58:49 +1000 (AEST)","from localhost ([::1]:60204 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dvRHq-0005aO-Sb\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 12:58:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52491)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <tcminyard@gmail.com>) id 1dvRHL-0005Z2-OX\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:58:16 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <tcminyard@gmail.com>) id 1dvRHH-0001Cm-Pu\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:58:15 -0400","from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:35890)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <tcminyard@gmail.com>)\n\tid 1dvRHH-0001CV-KN; Fri, 22 Sep 2017 12:58:11 -0400","by mail-pg0-x241.google.com with SMTP id d8so933189pgt.3;\n\tFri, 22 Sep 2017 09:58:11 -0700 (PDT)","from [192.168.27.3] ([47.184.168.85])\n\tby smtp.gmail.com with ESMTPSA id\n\tu192sm387477pgc.18.2017.09.22.09.58.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 09:58:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=reply-to:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding:content-language; \n\tbh=xwoExp5k9iz/pGEmAH06OI9tXno0Dm9FbaUVOlyutZk=;\n\tb=Izk2G07TG8ZleKLdizR9hiPh2dD8mqKBul1E+iw/Pffc80xTOC7Waz0y/jHFsBETNa\n\tC78o9tJjy1Iihoj+cE2HPA2OrMGKug3GKLG7Xps2IYUwjSdSIi+I/FKtGdy12mHf9pCW\n\tZuT2IcqPlGAJbs3pCDM3xp1Qguqn8pOKkMj/65EG44Jz0N3PSFPWxTij67MLHrJK43xt\n\tV2OFFZbIF0WFf3cONB/QPbGBuOvFyB2nrUPHVItvQLGPGJ69kqb8MFkgADU8THt4AzQ5\n\t+3uP1gdeEJg1ZkBZXHoVjYyA8T4fr9JKXcplH9n5MxvONmGkmEMtkz5j4SpvWmPSsCM4\n\tukYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:reply-to:subject:to:cc:references:from\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-transfer-encoding:content-language;\n\tbh=xwoExp5k9iz/pGEmAH06OI9tXno0Dm9FbaUVOlyutZk=;\n\tb=PqL4ckerBsMaTDRaS2Lt13iXBcEP3rX0WpnmUD800rKiDtLI3O8n73UILCduDrGbIT\n\tP/q58V0h2N9YOrgogO4SPcIREjzm0Lb2dj+CR8fQSvRoXMDns91ZAGpmkbEeJL1G2erW\n\tEW6eJ5r+Hrgv9MJSRMa4ozE+1eXaCZ8MjAk+gCtBOa4ZgNJDPVfsHSaBHLcDTwUpR/dx\n\tEt7De7lXQVGh2oYR1FpTS4Z4BY9MUWnRLqGnMWb0WRoTWy6v14ksCkJqkmufE6+y8qZ+\n\tj+f3CgC+Yor0eHNYAuzcxT5G+BXt12CXVzSoHSRL9Bu4Ql/DfjKh22dSG8ifJ3B1iGgD\n\t2FMA==","X-Gm-Message-State":"AHPjjUh0mu1Z9C+IWgp9/sVkQqEmIvYsR7T/qabsmVa5anu+ZbWMrK/n\n\t37RjJXpFQwBQXUAHScwCANBtdj8=","X-Google-Smtp-Source":"AOwi7QD3mdWE/gVhcjqBaKeQdI5jcTNbVSNbiofvgu0yT82Qeficz4CEQHyyEA++Q6G/T9LR4wZcUg==","X-Received":"by 10.101.69.194 with SMTP id m2mr9913966pgr.20.1506099489871;\n\tFri, 22 Sep 2017 09:58:09 -0700 (PDT)","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>,\n\tPeter Maydell <peter.maydell@linaro.org>,\n\tThomas Huth <thuth@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n\tCorey Minyard <minyard@acm.org>","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922154014.29350-15-f4bug@amsat.org>","From":"Corey Minyard <tcminyard@gmail.com>","Message-ID":"<5d7ffac0-e0a9-c503-7ae5-b27ad86f4c94@gmail.com>","Date":"Fri, 22 Sep 2017 11:58:07 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922154014.29350-15-f4bug@amsat.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","Content-Language":"en-GB","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::241","Subject":"Re: [Qemu-devel] [PATCH 14/34] hw/ipmi: remove old i386 dependency","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Reply-To":"minyard@acm.org","Cc":"qemu-trivial@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]