[{"id":1774412,"web_url":"http://patchwork.ozlabs.org/comment/1774412/","msgid":"","list_archive_url":null,"date":"2017-09-25T05:16:52","subject":"Re: [Qemu-devel] [PATCH 11/34] i386/pc: use TYPE_PORT92","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 22.09.2017 17:39, Philippe Mathieu-Daudé wrote:\n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> hw/i386/pc.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/hw/i386/pc.c b/hw/i386/pc.c\n> index 05985d4927..f116cede91 100644\n> --- a/hw/i386/pc.c\n> +++ b/hw/i386/pc.c\n> @@ -1577,7 +1577,7 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,\n> qdev_prop_set_ptr(dev, \"ps2_mouse\", i8042);\n> qdev_init_nofail(dev);\n> }\n> - port92 = isa_create_simple(isa_bus, \"port92\");\n> + port92 = isa_create_simple(isa_bus, TYPE_PORT92);\n> port92_init(port92, a20_line[1]);\n> g_free(a20_line);\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0slt1YhPz9t4B\n\tfor ;\n\tMon, 25 Sep 2017 15:17:30 +1000 (AEST)","from localhost ([::1]:40733 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwLlo-0008NY-BM\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 01:17:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41860)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwLlO-0008NT-1i\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 01:17:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwLlK-0004Hc-Uf\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 01:17:02 -0400","from mx1.redhat.com ([209.132.183.28]:56992)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwLlK-0004HL-OU; Mon, 25 Sep 2017 01:16:58 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D65F44A6E4;\n\tMon, 25 Sep 2017 05:16:57 +0000 (UTC)","from [10.36.116.76] (ovpn-116-76.ams2.redhat.com [10.36.116.76])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 27FF25C54C;\n\tMon, 25 Sep 2017 05:16:53 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D65F44A6E4","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tPeter Maydell , Paolo Bonzini\n\t, Richard Henderson , Eduardo\n\tHabkost , \t\"Michael S. Tsirkin\" ","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922154014.29350-12-f4bug@amsat.org>","From":"Thomas Huth ","Message-ID":"","Date":"Mon, 25 Sep 2017 07:16:52 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922154014.29350-12-f4bug@amsat.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 25 Sep 2017 05:16:58 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 11/34] i386/pc: use TYPE_PORT92","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]