[{"id":1774414,"web_url":"http://patchwork.ozlabs.org/comment/1774414/","msgid":"<0793731d-fc49-cf85-f15d-3f1ae8bbe0d2@redhat.com>","list_archive_url":null,"date":"2017-09-25T05:19:34","subject":"Re: [Qemu-devel] [PATCH 18/34] hw/unicore32: restrict hw addr\n\tdefines to source file","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 22.09.2017 17:39, Philippe Mathieu-Daudé wrote:\n> and drop unused #includes\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> include/hw/unicore32/puv3.h | 10 ----------\n> hw/unicore32/puv3.c | 16 ++++++++++------\n> 2 files changed, 10 insertions(+), 16 deletions(-)\n> \n> diff --git a/include/hw/unicore32/puv3.h b/include/hw/unicore32/puv3.h\n> index 5a4839f8df..f587a1f622 100644\n> --- a/include/hw/unicore32/puv3.h\n> +++ b/include/hw/unicore32/puv3.h\n> @@ -14,16 +14,6 @@\n> \n> #define PUV3_REGS_OFFSET (0x1000) /* 4K is reasonable */\n> \n> -/* PKUnity System bus (AHB): 0xc0000000 - 0xedffffff (640MB) */\n> -#define PUV3_DMA_BASE (0xc0200000) /* AHB-4 */\n> -\n> -/* PKUnity Peripheral bus (APB): 0xee000000 - 0xefffffff (128MB) */\n> -#define PUV3_GPIO_BASE (0xee500000) /* APB-5 */\n> -#define PUV3_INTC_BASE (0xee600000) /* APB-6 */\n> -#define PUV3_OST_BASE (0xee800000) /* APB-8 */\n> -#define PUV3_PM_BASE (0xeea00000) /* APB-10 */\n> -#define PUV3_PS2_BASE (0xeeb00000) /* APB-11 */\n> -\n> /* Hardware interrupts */\n> #define PUV3_IRQS_NR (32)\n> \n> diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c\n> index 504ea46211..6849bac59c 100644\n> --- a/hw/unicore32/puv3.c\n> +++ b/hw/unicore32/puv3.c\n> @@ -11,16 +11,10 @@\n> \n> #include \"qemu/osdep.h\"\n> #include \"qapi/error.h\"\n> -#include \"qemu-common.h\"\n> #include \"cpu.h\"\n> #include \"ui/console.h\"\n> -#include \"elf.h\"\n> -#include \"exec/address-spaces.h\"\n> -#include \"hw/sysbus.h\"\n> #include \"hw/boards.h\"\n> #include \"hw/loader.h\"\n> -#include \"hw/i386/pc.h\"\n> -#include \"qemu/error-report.h\"\n> #include \"sysemu/qtest.h\"\n> \n> #undef DEBUG_PUV3\n> @@ -29,6 +23,16 @@\n> #define KERNEL_LOAD_ADDR 0x03000000\n> #define KERNEL_MAX_SIZE 0x00800000 /* Just a guess */\n> \n> +/* PKUnity System bus (AHB): 0xc0000000 - 0xedffffff (640MB) */\n> +#define PUV3_DMA_BASE (0xc0200000) /* AHB-4 */\n> +\n> +/* PKUnity Peripheral bus (APB): 0xee000000 - 0xefffffff (128MB) */\n> +#define PUV3_GPIO_BASE (0xee500000) /* APB-5 */\n> +#define PUV3_INTC_BASE (0xee600000) /* APB-6 */\n> +#define PUV3_OST_BASE (0xee800000) /* APB-8 */\n> +#define PUV3_PM_BASE (0xeea00000) /* APB-10 */\n> +#define PUV3_PS2_BASE (0xeeb00000) /* APB-11 */\n> +\n> static void puv3_intc_cpu_handler(void *opaque, int irq, int level)\n> {\n> UniCore32CPU *cpu = opaque;\n> \n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0spt49Mlz9t4B\n\tfor ;\n\tMon, 25 Sep 2017 15:20:06 +1000 (AEST)","from localhost ([::1]:40739 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwLoK-0001es-ND\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 01:20:04 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42397)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwLnz-0001el-Lc\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 01:19:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwLnw-00058K-Hy\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 01:19:43 -0400","from mx1.redhat.com ([209.132.183.28]:50062)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwLnw-00056t-AE; Mon, 25 Sep 2017 01:19:40 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 29C7E356F0;\n\tMon, 25 Sep 2017 05:19:39 +0000 (UTC)","from [10.36.116.76] (ovpn-116-76.ams2.redhat.com [10.36.116.76])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 792606016F;\n\tMon, 25 Sep 2017 05:19:36 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 29C7E356F0","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tPeter Maydell , Paolo Bonzini\n\t, Guan Xuetao ","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922154014.29350-19-f4bug@amsat.org>","From":"Thomas Huth ","Message-ID":"<0793731d-fc49-cf85-f15d-3f1ae8bbe0d2@redhat.com>","Date":"Mon, 25 Sep 2017 07:19:34 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922154014.29350-19-f4bug@amsat.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tMon, 25 Sep 2017 05:19:39 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 18/34] hw/unicore32: restrict hw addr\n\tdefines to source file","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]