[{"id":1773749,"web_url":"http://patchwork.ozlabs.org/comment/1773749/","msgid":"","list_archive_url":null,"date":"2017-09-22T16:39:43","subject":"Re: [Qemu-devel] [PATCH 06/34] ppc: remove duplicated includes","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 22 September 2017 at 16:39, Philippe Mathieu-Daudé wrote:\n> applied using ./scripts/clean-includes\n>\n> not needed since 7ebaf795560\n>\n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> hw/ppc/spapr_hcall.c | 1 -\n> target/ppc/kvm.c | 3 ---\n> 2 files changed, 4 deletions(-)\n>\n> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c\n> index 57bb411394..2aeee28fe6 100644\n> --- a/hw/ppc/spapr_hcall.c\n> +++ b/hw/ppc/spapr_hcall.c\n> @@ -13,7 +13,6 @@\n> #include \"trace.h\"\n> #include \"kvm_ppc.h\"\n> #include \"hw/ppc/spapr_ovec.h\"\n> -#include \"qemu/error-report.h\"\n> #include \"mmu-book3s-v3.h\"\n>\n> struct SPRSyncState {\n> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c\n> index 1deaf106d2..c9105af393 100644\n> --- a/target/ppc/kvm.c\n> +++ b/target/ppc/kvm.c\n> @@ -47,9 +47,6 @@\n> #include \"sysemu/hostmem.h\"\n> #include \"qemu/cutils.h\"\n> #include \"qemu/mmap-alloc.h\"\n> -#if defined(TARGET_PPC64)\n> -#include \"hw/ppc/spapr_cpu_core.h\"\n> -#endif\n> #include \"elf.h\"\n> #include \"sysemu/kvm_int.h\"\n>\n> --\n\nReviewed-by: Peter Maydell \n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Ye0eTrXo\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzK460GNKz9t3h\n\tfor ;\n\tSat, 23 Sep 2017 02:41:09 +1000 (AEST)","from localhost ([::1]:60099 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvR0l-0003Fi-KJ\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 12:41:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42566)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvQzm-0002tl-Gm\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:40:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvQzl-0003K9-3p\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:40:06 -0400","from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]:50574)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvQzk-0003Jm-Ut\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:40:05 -0400","by mail-wr0-x22c.google.com with SMTP id w12so1345164wrc.7\n\tfor ; Fri, 22 Sep 2017 09:40:04 -0700 (PDT)","by 10.223.139.215 with HTTP; Fri, 22 Sep 2017 09:39:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=TeTAM8vg6XV7yWvtcYkcLvfViu0HxkEEDImtLf3FSOM=;\n\tb=Ye0eTrXokGkxeAXFDpE6Fv1YiYGr3loT7HhGuC11bsxkLvhxb346rfD2e0pPUCtTcM\n\twf3vSqJLwXnXS8R8H+E5sXC1o/qEJifUykU8oRWo3locaa7tk2jKPFIxH6pwrLkTGIyl\n\tkOsxUIB1hH8buAiPTrnb/rI/e2a774Y3i/12U=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=TeTAM8vg6XV7yWvtcYkcLvfViu0HxkEEDImtLf3FSOM=;\n\tb=fGp/r2POo6a7o4G2uq5nmuuHN7Hpppi2/bbGp+G2IEtf5xveKlSap/eXL1KfgY0tAy\n\tJdxdtiAKIzTn2iOs2dMNj8jJb4rQZ1gM8JsSlDy8cxpr9NxSN4WRCHDbfPTlr7lmnl6m\n\tkD75nYSx8I6NNIrsKx8tbM8RM41S2K13uC4ebrrlicXDWPuaxx3LcjPSQ80J++x3g6oV\n\t1ZiID5LZq9etO1hUMAlddMkVOqoUh6WAu+wIwED0b4gfhKpyYcGqYO/wgBaOlj0vtZOc\n\tJg97BOyY4WqBT17qgybMdSyt/pSXqI1t5OVVrVfdr2otqNgTcSc9v4pR7zyOQ4+J7p+2\n\tWJ/w==","X-Gm-Message-State":"AHPjjUieX+Q08Wz/6Wm6+yd5bJDYUXbsufG4JS/ztR30+NyrsQYsntRP\n\t8EcYJVV2y3CDzJEVhYqYP0qIlJhovNSERB7qbgFte19q","X-Google-Smtp-Source":"AOwi7QBo5P+Q2OpAmaKWE/7QrESyaZ1jM5+9+e4Nzdb/KPQtfUFYpBXE2ISopyRD3D92AkZuUfICiku5JGhXASALbb8=","X-Received":"by 10.223.198.202 with SMTP id c10mr5249622wrh.230.1506098403989;\n\tFri, 22 Sep 2017 09:40:03 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170922154014.29350-7-f4bug@amsat.org>","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922154014.29350-7-f4bug@amsat.org>","From":"Peter Maydell ","Date":"Fri, 22 Sep 2017 17:39:43 +0100","Message-ID":"","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::22c","Subject":"Re: [Qemu-devel] [PATCH 06/34] ppc: remove duplicated includes","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Thomas Huth , QEMU Trivial , \n\tQEMU Developers , Alexander Graf , \n\t\"qemu-ppc@nongnu.org\" ,\n\tPaolo Bonzini ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773982,"web_url":"http://patchwork.ozlabs.org/comment/1773982/","msgid":"<20170923053127.GA12504@umbus>","list_archive_url":null,"date":"2017-09-23T05:31:28","subject":"Re: [Qemu-devel] [PATCH 06/34] ppc: remove duplicated includes","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Fri, Sep 22, 2017 at 12:39:46PM -0300, Philippe Mathieu-Daudé wrote:\n> applied using ./scripts/clean-includes\n> \n> not needed since 7ebaf795560\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n\nAcked-by: David Gibson \n\n> ---\n> hw/ppc/spapr_hcall.c | 1 -\n> target/ppc/kvm.c | 3 ---\n> 2 files changed, 4 deletions(-)\n> \n> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c\n> index 57bb411394..2aeee28fe6 100644\n> --- a/hw/ppc/spapr_hcall.c\n> +++ b/hw/ppc/spapr_hcall.c\n> @@ -13,7 +13,6 @@\n> #include \"trace.h\"\n> #include \"kvm_ppc.h\"\n> #include \"hw/ppc/spapr_ovec.h\"\n> -#include \"qemu/error-report.h\"\n> #include \"mmu-book3s-v3.h\"\n> \n> struct SPRSyncState {\n> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c\n> index 1deaf106d2..c9105af393 100644\n> --- a/target/ppc/kvm.c\n> +++ b/target/ppc/kvm.c\n> @@ -47,9 +47,6 @@\n> #include \"sysemu/hostmem.h\"\n> #include \"qemu/cutils.h\"\n> #include \"qemu/mmap-alloc.h\"\n> -#if defined(TARGET_PPC64)\n> -#include \"hw/ppc/spapr_cpu_core.h\"\n> -#endif\n> #include \"elf.h\"\n> #include \"sysemu/kvm_int.h\"\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"KibyXawU\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzfGV3Lv4z9t67\n\tfor ;\n\tSat, 23 Sep 2017 15:36:18 +1000 (AEST)","from localhost ([::1]:33769 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvd6u-0003gI-IL\n\tfor incoming@patchwork.ozlabs.org; Sat, 23 Sep 2017 01:36:16 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36920)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvd2R-0000e6-NZ\n\tfor qemu-devel@nongnu.org; Sat, 23 Sep 2017 01:31:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvd2O-0003Zo-KH\n\tfor qemu-devel@nongnu.org; Sat, 23 Sep 2017 01:31:39 -0400","from ozlabs.org ([103.22.144.67]:50411)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvd2O-0003Yp-8J; Sat, 23 Sep 2017 01:31:36 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xzf920w07z9t6K; Sat, 23 Sep 2017 15:31:34 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1506144694;\n\tbh=6Fx55GnfoSv1AAyZSUireV5VKv7+k6C/Qf7TFwB1Vj4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KibyXawU3sfq/N36WPEJxtatQ9Vei8I7gLyYKnNMuRzFxn9VvCz/LKgcnbulGOD2k\n\tVgSaaWps68E7gTm9fnOUGb8pVAgAgCL7cOW7jx0izvLTD8C2F2AtsjrcztuzeCSZIp\n\t9xTAI1Cxynm+kDGaGLJzsqLtP3ezs7RlQ3SRLSVg=","Date":"Sat, 23 Sep 2017 15:31:28 +1000","From":"David Gibson ","To":"Philippe =?iso-8859-1?q?Mathieu-Daud=E9?= ","Message-ID":"<20170923053127.GA12504@umbus>","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922154014.29350-7-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ew6BAiZeqk4r7MaW\"","Content-Disposition":"inline","In-Reply-To":"<20170922154014.29350-7-f4bug@amsat.org>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [PATCH 06/34] ppc: remove duplicated includes","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Thomas Huth ,\n\tqemu-trivial@nongnu.org, qemu-devel@nongnu.org,\n\tAlexander Graf , qemu-ppc@nongnu.org,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]