[{"id":1773760,"web_url":"http://patchwork.ozlabs.org/comment/1773760/","msgid":"","list_archive_url":null,"date":"2017-09-22T16:46:59","subject":"Re: [Qemu-devel] [PATCH 09/34] misc: avoid \"include/\" in include\n\tpath","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 22 September 2017 at 16:39, Philippe Mathieu-Daudé wrote:\n> while here, remove unused #include from aspeed_smc.h\n>\n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> hw/input/adb.c | 2 +-\n> hw/ssi/aspeed_smc.c | 3 +--\n> numa.c | 1 -\n> 3 files changed, 2 insertions(+), 4 deletions(-)\n>\n> diff --git a/hw/input/adb.c b/hw/input/adb.c\n> index fcca3a8eb9..924a3f9fd5 100644\n> --- a/hw/input/adb.c\n> +++ b/hw/input/adb.c\n> @@ -24,8 +24,8 @@\n> #include \"qemu/osdep.h\"\n> #include \"hw/hw.h\"\n> #include \"hw/input/adb.h\"\n> +#include \"hw/input/adb-keys.h\"\n> #include \"ui/console.h\"\n> -#include \"include/hw/input/adb-keys.h\"\n> #include \"ui/input.h\"\n> #include \"sysemu/sysemu.h\"\n>\n> diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c\n> index cb515730c5..5059396bc6 100644\n> --- a/hw/ssi/aspeed_smc.c\n> +++ b/hw/ssi/aspeed_smc.c\n> @@ -26,8 +26,7 @@\n> #include \"hw/sysbus.h\"\n> #include \"sysemu/sysemu.h\"\n> #include \"qemu/log.h\"\n> -#include \"include/qemu/error-report.h\"\n> -#include \"exec/address-spaces.h\"\n> +#include \"qemu/error-report.h\"\n>\n> #include \"hw/ssi/aspeed_smc.h\"\n>\n> diff --git a/numa.c b/numa.c\n> index 100a67febf..ebc553b5d9 100644\n> --- a/numa.c\n> +++ b/numa.c\n> @@ -29,7 +29,6 @@\n> #include \"qemu/bitmap.h\"\n> #include \"qom/cpu.h\"\n> #include \"qemu/error-report.h\"\n> -#include \"include/exec/cpu-common.h\" /* for RAM_ADDR_FMT */\n> #include \"qapi-visit.h\"\n> #include \"qapi/opts-visitor.h\"\n> #include \"hw/boards.h\"\n> --\n> 2.14.1\n\n\"while here\" usually indicates a patch should be split.\n\nOtherwise\nReviewed-by: Peter Maydell \n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ChJ0ReQn\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzKCt1NHgz9s5L\n\tfor ;\n\tSat, 23 Sep 2017 02:47:54 +1000 (AEST)","from localhost ([::1]:60146 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvR7H-0000Rd-IB\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 12:47:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48184)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvR6n-0000OF-S3\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:47:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvR6m-0001V5-R4\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:47:21 -0400","from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:49514)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvR6m-0001Th-Ld\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:47:20 -0400","by mail-wm0-x22d.google.com with SMTP id r74so5552057wme.4\n\tfor ; Fri, 22 Sep 2017 09:47:20 -0700 (PDT)","by 10.223.139.215 with HTTP; Fri, 22 Sep 2017 09:46:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=gTVRAt4NQqktfkEpilx9AdgyzLHgGVP1+yY01swwoeA=;\n\tb=ChJ0ReQnJm0E1cPK9MPz31Eed54VYsawIGt9Tg9v70j3dUmtCLvcazRxHak9ruz2dP\n\t8tuckDY8yoaZErelhzH+pIGshfJnI87j0NMNYHAguNCsX6VQjCh9UOoPTL8wU2JDxkny\n\trN8y10WrFeHmqo6ScQrgi0m7ufANaoGVoZsLM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=gTVRAt4NQqktfkEpilx9AdgyzLHgGVP1+yY01swwoeA=;\n\tb=NDUfIaXn9BrbUWlVr1EvSbmjLkl2sVIc/71uywskBB89emW2S6f2mFqPRBzCFRywoa\n\tt1BWxqOV+kUior99P6+gmmmBOICPa/dNq0cDD3dwFj3KjS52QzWgiQ8FJxqpCeRuCrXr\n\tg5VouJSogqFYL3wYn3bsz+n8ZxY36EXEkrs/dSup4wWcvYEMf4S/eik+FQDVbFr+9mA4\n\tkVbb7aMJgUSk2c7WaAHZLL3NdTUgRxHKcBRvVeYPxB5gmUYz+//pN+U34evvo+R0nLtF\n\tjZLWHHgnpbTRTYjgSneXA2xPScto9iLjkQme8GGNYuILlbzEIHztWZ1pf678NBi9R+Xo\n\tyx1g==","X-Gm-Message-State":"AHPjjUghwQTK4KB/LtlXZshqtsQhknQOQUE9KamGHewxYbSOvEJtHHZ5\n\tTrmsSbiK0GMmEpTJMmV18q1WbuS3JekUXuNXx38PCA==","X-Google-Smtp-Source":"AOwi7QBgcoa7yxpGM4sXneG3AvpJJeupeMMBDIsatB5RS9sx2YzBtyUYjBS8AZgfZLDGAlZIT7bJvoP+eQIQv0r5PCc=","X-Received":"by 10.28.166.135 with SMTP id p129mr4656776wme.147.1506098839617;\n\tFri, 22 Sep 2017 09:47:19 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170922154014.29350-10-f4bug@amsat.org>","References":"<20170922154014.29350-1-f4bug@amsat.org>\n\t<20170922154014.29350-10-f4bug@amsat.org>","From":"Peter Maydell ","Date":"Fri, 22 Sep 2017 17:46:59 +0100","Message-ID":"","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::22d","Subject":"Re: [Qemu-devel] [PATCH 09/34] misc: avoid \"include/\" in include\n\tpath","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Thomas Huth , Eduardo Habkost ,\n\tPeter Crosthwaite ,\n\tQEMU Trivial ,\n\tQEMU Developers ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]