[{"id":1780256,"web_url":"http://patchwork.ozlabs.org/comment/1780256/","msgid":"<88468bf1-594d-9b2e-1dbe-669073e42e76@amsat.org>","list_archive_url":null,"date":"2017-10-05T03:29:07","subject":"Re: [Qemu-devel] [Qemu-arm] [PATCH 16/20] target/arm: Factor out\n\t\"get mmuidx for specified security state\"","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/22/2017 12:00 PM, Peter Maydell wrote:\n> For the SG instruction and secure function return we are going\n> to want to do memory accesses using the MMU index of the CPU\n> in secure state, even though the CPU is currently in non-secure\n> state. Write arm_v7m_mmu_idx_for_secstate() to do this job,\n> and use it in cpu_mmu_index().\n> \n> Signed-off-by: Peter Maydell \n\nReviewed-by: Philippe Mathieu-Daudé \n\n> ---\n> target/arm/cpu.h | 32 +++++++++++++++++++++-----------\n> 1 file changed, 21 insertions(+), 11 deletions(-)\n> \n> diff --git a/target/arm/cpu.h b/target/arm/cpu.h\n> index 70c1f85..89d49cd 100644\n> --- a/target/arm/cpu.h\n> +++ b/target/arm/cpu.h\n> @@ -2329,23 +2329,33 @@ static inline int arm_mmu_idx_to_el(ARMMMUIdx mmu_idx)\n> }\n> }\n> \n> +/* Return the MMU index for a v7M CPU in the specified security state */\n> +static inline ARMMMUIdx arm_v7m_mmu_idx_for_secstate(CPUARMState *env,\n> + bool secstate)\n> +{\n> + int el = arm_current_el(env);\n> + ARMMMUIdx mmu_idx;\n> +\n> + if (el == 0) {\n> + mmu_idx = secstate ? ARMMMUIdx_MSUser : ARMMMUIdx_MUser;\n> + } else {\n> + mmu_idx = secstate ? ARMMMUIdx_MSPriv : ARMMMUIdx_MPriv;\n> + }\n> +\n> + if (armv7m_nvic_neg_prio_requested(env->nvic, secstate)) {\n> + mmu_idx = secstate ? ARMMMUIdx_MSNegPri : ARMMMUIdx_MNegPri;\n> + }\n> +\n> + return mmu_idx;\n> +}\n> +\n> /* Determine the current mmu_idx to use for normal loads/stores */\n> static inline int cpu_mmu_index(CPUARMState *env, bool ifetch)\n> {\n> int el = arm_current_el(env);\n> \n> if (arm_feature(env, ARM_FEATURE_M)) {\n> - ARMMMUIdx mmu_idx;\n> -\n> - if (el == 0) {\n> - mmu_idx = env->v7m.secure ? ARMMMUIdx_MSUser : ARMMMUIdx_MUser;\n> - } else {\n> - mmu_idx = env->v7m.secure ? ARMMMUIdx_MSPriv : ARMMMUIdx_MPriv;\n> - }\n> -\n> - if (armv7m_nvic_neg_prio_requested(env->nvic, env->v7m.secure)) {\n> - mmu_idx = env->v7m.secure ? ARMMMUIdx_MSNegPri : ARMMMUIdx_MNegPri;\n> - }\n> + ARMMMUIdx mmu_idx = arm_v7m_mmu_idx_for_secstate(env, env->v7m.secure);\n> \n> return arm_to_core_mmu_idx(mmu_idx);\n> }\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"piSn7CGF\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y6ytj6y6Mz9sRq\n\tfor ;\n\tThu, 5 Oct 2017 14:29:33 +1100 (AEDT)","from localhost ([::1]:37634 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dzwqq-0005aj-4I\n\tfor incoming@patchwork.ozlabs.org; Wed, 04 Oct 2017 23:29:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40742)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dzwqY-0005aQ-7h\n\tfor qemu-devel@nongnu.org; Wed, 04 Oct 2017 23:29:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dzwqV-00080Y-5U\n\tfor qemu-devel@nongnu.org; Wed, 04 Oct 2017 23:29:14 -0400","from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:33388)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dzwqU-0007zo-WE; Wed, 04 Oct 2017 23:29:11 -0400","by mail-qk0-x244.google.com with SMTP id z12so6110765qkb.0;\n\tWed, 04 Oct 2017 20:29:10 -0700 (PDT)","from [192.168.1.240] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tu32sm11301197qte.25.2017.10.04.20.29.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 04 Oct 2017 20:29:09 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:openpgp:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=s29yJ9dwBn8mmYVoqF2awmhxX6HfkVoMCpIxQCNA1jo=;\n\tb=piSn7CGFdNQeH2YWZ5E7YsOSVo/FHUJ+v8jiBmAEewI9ad266cHcABxKT8fjcymBu1\n\tS1FhlPRB/FksdQkqggZcs3MbejJ32MDL6eaxipNs3URF2EYgDPVUaqGMjgj8FE+Eui/j\n\tbVRzyLbx4zbsYhgylqr2ilFDrAUAlYGibbRbu1TK13vBKs9IMdjlP9yGD6ijNaBT+ORv\n\tqTyY34f3MSayDNh7rncCoZSPbfRONjZeDqgzzsGeZxfYNtIvjpsdgC4LzFI3ztS2eWGU\n\tis35FVzNFdkfBuZ0ALUR0ZLidLdWHHCbZJaEI0gyo5cb7POZ2DJG2H54K8djllJXyftd\n\tdgeA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:openpgp\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=s29yJ9dwBn8mmYVoqF2awmhxX6HfkVoMCpIxQCNA1jo=;\n\tb=adaR04gopDK3z2KgUDamol+sKZsFRgV/sJYUzbOUdO7tx7o9g6VNySfl2vJrB6CPmT\n\tkbViOSPJLn+rQPnQTCjjW/C22c4tOgC3JlPn3qlUkcuYNpbZ1HLHSXF9UsGoA1AxqEkN\n\tQskL6hxvwAwcsBH9Skw/NssRfRLhp/OFZ4pZRh/n7u8IB+OHYEy/qhOfRQ1JLDqdIWQE\n\tqtEwvt7KIlTo1HtSL0vsR11B5JddaEB8xO42YaA8uCdJ9Dys9QqGqEl6w1qN9EJ5KVrS\n\tQSt8yJZUkQxOZd+9FrG2gspFRw6xSa3CojnpaR/UZ43294ExnPHdaKBvoIYMUhnx7oQZ\n\t6Bwg==","X-Gm-Message-State":"AMCzsaW9mf/f3E357xMrHuG+SdJKFTJBezBcScWi2XM/0GKUMbmlEKup\n\t7/egSF19+xpaEktQEti3vRQ=","X-Google-Smtp-Source":"AOwi7QCTdjnQO/vGS5zgnMwemri29TfCf7gvRgGfgAWKGBDzCKIrAldGyKLq4OS3F1LkEggDVG6ivg==","X-Received":"by 10.55.33.150 with SMTP id f22mr26458372qki.207.1507174150334; \n\tWed, 04 Oct 2017 20:29:10 -0700 (PDT)","To":"Peter Maydell , qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","References":"<1506092407-26985-1-git-send-email-peter.maydell@linaro.org>\n\t<1506092407-26985-17-git-send-email-peter.maydell@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Openpgp":"id=FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE;\n\turl=http://pgp.mit.edu/pks/lookup?op=get&search=0xE3E32C2CDEADC0DE","Message-ID":"<88468bf1-594d-9b2e-1dbe-669073e42e76@amsat.org>","Date":"Thu, 5 Oct 2017 00:29:07 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506092407-26985-17-git-send-email-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::244","Subject":"Re: [Qemu-devel] [Qemu-arm] [PATCH 16/20] target/arm: Factor out\n\t\"get mmuidx for specified security state\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"patches@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1780903,"web_url":"http://patchwork.ozlabs.org/comment/1780903/","msgid":"<3d5580cc-eea2-280b-5a65-0462e7af7cbd@linaro.org>","list_archive_url":null,"date":"2017-10-05T18:42:06","subject":"Re: [Qemu-devel] [PATCH 16/20] target/arm: Factor out \"get mmuidx\n\tfor specified security state\"","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/22/2017 11:00 AM, Peter Maydell wrote:\n> For the SG instruction and secure function return we are going\n> to want to do memory accesses using the MMU index of the CPU\n> in secure state, even though the CPU is currently in non-secure\n> state. Write arm_v7m_mmu_idx_for_secstate() to do this job,\n> and use it in cpu_mmu_index().\n> \n> Signed-off-by: Peter Maydell \n> ---\n> target/arm/cpu.h | 32 +++++++++++++++++++++-----------\n> 1 file changed, 21 insertions(+), 11 deletions(-)\n\nReviewed-by: Richard Henderson \n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"JgGS5xRv\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y7MBL0SPJz9t34\n\tfor ;\n\tFri, 6 Oct 2017 05:44:26 +1100 (AEDT)","from localhost ([::1]:41553 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e0B8B-0007Az-Mh\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 Oct 2017 14:44:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45970)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e0B63-0006EE-El\n\tfor qemu-devel@nongnu.org; Thu, 05 Oct 2017 14:42:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e0B61-00047q-Ll\n\tfor qemu-devel@nongnu.org; Thu, 05 Oct 2017 14:42:11 -0400","from mail-qt0-x22e.google.com ([2607:f8b0:400d:c0d::22e]:56047)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1e0B61-00047D-GY\n\tfor qemu-devel@nongnu.org; Thu, 05 Oct 2017 14:42:09 -0400","by mail-qt0-x22e.google.com with SMTP id x54so27144850qth.12\n\tfor ; Thu, 05 Oct 2017 11:42:09 -0700 (PDT)","from bigtime.twiddle.net ([2606:a000:7a4a:b100::1b])\n\tby smtp.gmail.com with ESMTPSA id\n\tc13sm8392863ywm.101.2017.10.05.11.42.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 05 Oct 2017 11:42:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=yXgbQmzU9gCa0KmxUqgpNmAWTUIE8yLqtVnRpDdlXPw=;\n\tb=JgGS5xRvOemmniMcktvo48BbpN7rYF4z9MaUJ+aPKIzT0JgxSBbkn8RzvLavoKmc9r\n\tYhbLZgWCHN89NXk80hTnYTEOAxCUuEIvJQ8ZLmCOZ/HxaKzOMC+BMO4mRP5v9wx+MY7n\n\tSTfeCpLKgjJVf4CTVWUXYhS9tuGr8rT3EvA74=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=yXgbQmzU9gCa0KmxUqgpNmAWTUIE8yLqtVnRpDdlXPw=;\n\tb=Z8n6RpAQYXLBb6G08WPo4AYdJuKHviEnITaXYbJIqcUrx3uTMH1aLxvKwdMVK6xJQx\n\t3V/MijeUWDFN0/4GhC1dq6wbdP54QGiQBPbenGUUSM9ziWUjYXKLBrl0d385vBgZEHx5\n\ta+XI7l6mfzyem89ewg/lwiaiowwWtruz2576/vJzsB4fpKP6k2Cy3PMdrF5XC5XfdxL+\n\tPIho56NIl1+Cb23r72fv9T4KrAUyuQUdADFAqBD3/8oasD6anPzAxSI0IevRCWZddhzk\n\t6rRef3lJ01QZaSkMFdUomF87Ug5n7oY8CFTrFrm8fXz2hd5r+pA9Q4InSz8hKfFB0cqi\n\tsBMQ==","X-Gm-Message-State":"AHPjjUjRIq86EUG7LBA3DE+ucXE7F5ODQUbPJZHXeqiz9Mq9rm3DXPzi\n\tFV784lw1SBSgoyjM6RzHb7OEGg==","X-Google-Smtp-Source":"AOwi7QBrRMT42Zvr/vI492EFEs5jOAb+5JUiXhSXkOhZEL3sw/+wWqAF1ezE7+YHdAyEkj2+WdJgVg==","X-Received":"by 10.13.222.131 with SMTP id h125mr21951238ywe.16.1507228928927;\n\tThu, 05 Oct 2017 11:42:08 -0700 (PDT)","To":"Peter Maydell , qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","References":"<1506092407-26985-1-git-send-email-peter.maydell@linaro.org>\n\t<1506092407-26985-17-git-send-email-peter.maydell@linaro.org>","From":"Richard Henderson ","Message-ID":"<3d5580cc-eea2-280b-5a65-0462e7af7cbd@linaro.org>","Date":"Thu, 5 Oct 2017 14:42:06 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506092407-26985-17-git-send-email-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::22e","Subject":"Re: [Qemu-devel] [PATCH 16/20] target/arm: Factor out \"get mmuidx\n\tfor specified security state\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"patches@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]