[{"id":1780780,"web_url":"http://patchwork.ozlabs.org/comment/1780780/","msgid":"<7b9b49a5-0397-14a4-01b6-c22435096684@linaro.org>","list_archive_url":null,"date":"2017-10-05T16:14:12","subject":"Re: [Qemu-devel] [PATCH 04/20] target/arm: Restore security state\n\ton exception return","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/22/2017 10:59 AM, Peter Maydell wrote:\n> Now that we can handle the CONTROL.SPSEL bit not necessarily being\n> in sync with the current stack pointer, we can restore the correct\n> security state on exception return. This happens before we start\n> to read registers off the stack frame, but after we have taken\n> possible usage faults for bad exception return magic values and\n> updated CONTROL.SPSEL.\n> \n> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>\n> ---\n>  target/arm/helper.c | 2 ++\n>  1 file changed, 2 insertions(+)\n\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\n\n\nr~","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"L1J6X0lW\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y7Hsh6Qcjz9sRm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  6 Oct 2017 03:14:47 +1100 (AEDT)","from localhost ([::1]:40723 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1e08nN-0008B8-DQ\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 Oct 2017 12:14:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41416)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1e08my-000889-PB\n\tfor qemu-devel@nongnu.org; Thu, 05 Oct 2017 12:14:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1e08mu-0000gJ-6T\n\tfor qemu-devel@nongnu.org; Thu, 05 Oct 2017 12:14:20 -0400","from mail-qt0-x22d.google.com ([2607:f8b0:400d:c0d::22d]:46915)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <richard.henderson@linaro.org>)\n\tid 1e08mu-0000fV-2A\n\tfor qemu-devel@nongnu.org; Thu, 05 Oct 2017 12:14:16 -0400","by mail-qt0-x22d.google.com with SMTP id 6so17253349qtw.3\n\tfor <qemu-devel@nongnu.org>; Thu, 05 Oct 2017 09:14:16 -0700 (PDT)","from bigtime.twiddle.net ([2606:a000:7a4a:b100::1b])\n\tby smtp.gmail.com with ESMTPSA id\n\ts38sm4296862ywa.92.2017.10.05.09.14.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 05 Oct 2017 09:14:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=AGtYHy4Qh5Pb9MEQ4J/gjCFKK6eJNZtO9DvgObvn+zw=;\n\tb=L1J6X0lWNxntTwm5+8IgnQ9L9o6mpn38bjTjldQiD4dqgKY4BZ5AOEI2QWFViCNIWM\n\tr0k5AT9yBlcDfOYB4Fe6ifp5kLMUAgYhcdNvqOQ0BNapXdnyRRFyuYFazdeD1gEKdklY\n\tHvRPbzs/iTrp+tb6cK9lGsopQ5b4UcUe4TmrA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=AGtYHy4Qh5Pb9MEQ4J/gjCFKK6eJNZtO9DvgObvn+zw=;\n\tb=pHoUyVW8h85zRnuVhyieAKbFsZGQNT6EJFok1oYHRePRg2q4+5aej5IbgsFHhKcgpN\n\tkatXtiL2smSxK04iqYXkSO50I7WrOxvU5KAWFue7QXjjRJoG30mVkBNmxiK3IxzH7zO4\n\tm+r0mb1xiz1E1F1xSUWf+XEbxYHUVOdBxLR0HYNz8Ghl8ubTSv/NJipPakpuiKFtZNd0\n\tvSX+M6RvmyZagr3ROsmQNrn2qlu8raBGR+lHjY/jq/y7c1Vo0e28NmN3D4Sw5QR58WGm\n\tVq4qp+qWKP7RZrbvBuDvv7CKf7wrdfXMW9tbzZ9pTrPPbFml3mnMEL8AZ/9iJryMuvI3\n\trI+g==","X-Gm-Message-State":"AMCzsaWLyfxaBYFIL3rD5oAR7ag/qk1/uEIyuK+bzwMbZwal7VIug8qt\n\th3xGvLGEy0UblwQmwEjBbkh2lg==","X-Google-Smtp-Source":"AOwi7QAykNG2tgx7MZIHwEwEPkBZ5DCRhpnIbkRdihOONZ+414OJF8Ze2C6EEZ4E3cot1AVhXh4Lng==","X-Received":"by 10.37.239.6 with SMTP id g6mr7005040ybd.340.1507220055479;\n\tThu, 05 Oct 2017 09:14:15 -0700 (PDT)","To":"Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","References":"<1506092407-26985-1-git-send-email-peter.maydell@linaro.org>\n\t<1506092407-26985-5-git-send-email-peter.maydell@linaro.org>","From":"Richard Henderson <richard.henderson@linaro.org>","Message-ID":"<7b9b49a5-0397-14a4-01b6-c22435096684@linaro.org>","Date":"Thu, 5 Oct 2017 12:14:12 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506092407-26985-5-git-send-email-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::22d","Subject":"Re: [Qemu-devel] [PATCH 04/20] target/arm: Restore security state\n\ton exception return","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"patches@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]