[{"id":1773946,"web_url":"http://patchwork.ozlabs.org/comment/1773946/","msgid":"","list_archive_url":null,"date":"2017-09-23T00:34:04","subject":"Re: [Qemu-devel] [PATCH 01/20] nvic: Clear the vector arrays and\n\tprigroup on reset","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/22/2017 09:59 AM, Peter Maydell wrote:\n> Reset for devices does not include an automatic clear of the\n> device state (unlike CPU state, where most of the state\n> structure is cleared to zero). Add some missing initialization\n> of NVIC state that meant that the device was left in the wrong\n> state if the guest did a warm reset.\n> \n> (In particular, since we were resetting the computed state like\n> s->exception_prio but not all the state it was computed\n> from like s->vectors[x].active, the NVIC wound up in an\n> inconsistent state that could later trigger assertion failures.)\n> \n> Signed-off-by: Peter Maydell \n> ---\n> hw/intc/armv7m_nvic.c | 5 +++++\n> 1 file changed, 5 insertions(+)\n\nReviewed-by: Richard Henderson \n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"cL2TeIph\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzWZh6B21z9sPk\n\tfor ;\n\tSat, 23 Sep 2017 10:34:51 +1000 (AEST)","from localhost ([::1]:33252 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvYP5-0002CG-J5\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 20:34:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55288)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvYOb-0002C2-DT\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 20:34:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvYOY-0004ye-99\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 20:34:13 -0400","from mail-oi0-x231.google.com ([2607:f8b0:4003:c06::231]:52038)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvYOY-0004yM-3i\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 20:34:10 -0400","by mail-oi0-x231.google.com with SMTP id f195so688760oih.8\n\tfor ; Fri, 22 Sep 2017 17:34:09 -0700 (PDT)","from bigtime.twiddle.net (162.189-204-159.bestel.com.mx.\n\t[189.204.159.162]) by smtp.gmail.com with ESMTPSA id\n\th196sm1934912oic.51.2017.09.22.17.34.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 17:34:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=Xt5nSOa96sIhvx/sbNxrIiCxPD0pgSec96Q7N5knopg=;\n\tb=cL2TeIphceJ5gm+EDBuPwOq13dPskRXtG5uB1N6TJ5DnPst62qQgLaAqtE7zsTSzKu\n\tsGTNBZTLAoieiMkNM7QjHGNMiwKbWvm4+705OD6/imgHLhfQgbjZ+bIkCIOt4zlj6JEC\n\t50MXPFe4rDxRi6zys91T7xtJuqRe2Xh85XmgA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=Xt5nSOa96sIhvx/sbNxrIiCxPD0pgSec96Q7N5knopg=;\n\tb=fNy7KB1XX/Gt2dx8dk7H3S957rpGmmKmoY3Iyf1+5DCAbvAgPcMjmEjm5GhqujX8Bj\n\tdM8gT/anNCKb4vBDZ2rgQWl7Z9ikGt5OEE1fP7Zjyc1lQ1RUkxPPHpC6hj/3Zo0kUatd\n\t42u3qgInI7WvAr93LCPQbs30gBjlpoBbLX4vf8Vfx0PGHaEC5L0b3qbFHegWPIlY/d8A\n\tGBO+tBaYklwss0bv5b8WCpMBed3Ctj/a6+e1y2g+54l1ZMqX3m/MmAcwn6wZ4BXAizn8\n\tta9EybW1xMakbVBHfj6VUhGsL6F1GAt6JFHdAD4H6+HT6g5mV3cmNm/etmpVe+FQ8Phi\n\t6MVw==","X-Gm-Message-State":"AHPjjUiprVim2NF+3iLdHNYrAlsY6LZdNXGo/Lc3AK4RBKonTvMTaaKa\n\tmLx2TBu3BSsVN1QEvq1mvIN2bA==","X-Google-Smtp-Source":"AOwi7QC2rPGqyHXDNgxFdQaWdLMTIBJX4Zk9Fub4vPeGscEhFbR0/0voJ+wGnq2D6TY9cKd+ezxnIg==","X-Received":"by 10.202.243.85 with SMTP id r82mr1143500oih.215.1506126849258; \n\tFri, 22 Sep 2017 17:34:09 -0700 (PDT)","To":"Peter Maydell , qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","References":"<1506092407-26985-1-git-send-email-peter.maydell@linaro.org>\n\t<1506092407-26985-2-git-send-email-peter.maydell@linaro.org>","From":"Richard Henderson ","Message-ID":"","Date":"Fri, 22 Sep 2017 19:34:04 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506092407-26985-2-git-send-email-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4003:c06::231","Subject":"Re: [Qemu-devel] [PATCH 01/20] nvic: Clear the vector arrays and\n\tprigroup on reset","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"patches@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]