[{"id":1773778,"web_url":"http://patchwork.ozlabs.org/comment/1773778/","msgid":"<4bb66a11-110a-562a-8e3d-8d1c7088c2bc@vivier.eu>","list_archive_url":null,"date":"2017-09-22T17:04:15","subject":"Re: [Qemu-devel] [RFC 6/6] linux-user: update default socket.h","submitter":{"id":2628,"url":"http://patchwork.ozlabs.org/api/people/2628/","name":"Laurent Vivier","email":"laurent@vivier.eu"},"content":"Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit :\n> * enable SO_REUSEPORT as a sideeffect and add SO_GET_FILTER alias\n> * make sure 64bit version for ppc is also supported\n\nAs previously TARGET_PPC64 is not needed.\n\nAnd you should move powerpc bits to linux-user/ppc/sockbits.h\n\nThanks,\nLaurent\n\n> Signed-off-by: Carlo Marcelo Arenas Belón \n> ---\n> linux-user/socket.h | 61 ++++++++++++++++++++++++++++++++++++++++++-----------\n> 1 file changed, 49 insertions(+), 12 deletions(-)\n> \n> diff --git a/linux-user/socket.h b/linux-user/socket.h\n> index 6fd486c6b1..c37c10822a 100644\n> --- a/linux-user/socket.h\n> +++ b/linux-user/socket.h\n> @@ -27,8 +27,8 @@\n> #define TARGET_SO_PRIORITY 12\n> #define TARGET_SO_LINGER 13\n> #define TARGET_SO_BSDCOMPAT 14\n> - /* To add :#define TARGET_SO_REUSEPORT 15 */\n> -#if defined(TARGET_PPC)\n> + #define TARGET_SO_REUSEPORT 15\n> +#if defined(TARGET_PPC) || defined(TARGET_PPC64)\n> #define TARGET_SO_RCVLOWAT 16\n> #define TARGET_SO_SNDLOWAT 17\n> #define TARGET_SO_RCVTIMEO 18\n> @@ -49,21 +49,58 @@\n> #define TARGET_SO_SECURITY_ENCRYPTION_TRANSPORT 23\n> #define TARGET_SO_SECURITY_ENCRYPTION_NETWORK 24\n> \n> - #define TARGET_SO_BINDTODEVICE 25\n> + #define TARGET_SO_BINDTODEVICE 25\n> \n> /* Socket filtering */\n> - #define TARGET_SO_ATTACH_FILTER 26\n> - #define TARGET_SO_DETACH_FILTER 27\n> + #define TARGET_SO_ATTACH_FILTER 26\n> + #define TARGET_SO_DETACH_FILTER 27\n> + #define TARGET_SO_GET_FILTER TARGET_SO_ATTACH_FILTER\n> \n> - #define TARGET_SO_PEERNAME 28\n> - #define TARGET_SO_TIMESTAMP 29\n> - #define TARGET_SCM_TIMESTAMP TARGET_SO_TIMESTAMP\n> + #define TARGET_SO_PEERNAME 28\n> + #define TARGET_SO_TIMESTAMP 29\n> + #define TARGET_SCM_TIMESTAMP TARGET_SO_TIMESTAMP\n> \n> - #define TARGET_SO_ACCEPTCONN 30\n> + #define TARGET_SO_ACCEPTCONN 30\n> \n> - #define TARGET_SO_PEERSEC 31\n> + #define TARGET_SO_PEERSEC 31\n> + #define TARGET_SO_PASSSEC 34\n> + #define TARGET_SO_TIMESTAMPNS 35\n> + #define TARGET_SCM_TIMESTAMPNS TARGET_SO_TIMESTAMPNS\n> +\n> + #define TARGET_SO_MARK 36\n> +\n> + #define TARGET_SO_TIMESTAMPING 37\n> + #define TARGET_SCM_TIMESTAMPING TARGET_SO_TIMESTAMPING\n> +\n> + #define TARGET_SO_PROTOCOL 38\n> + #define TARGET_SO_DOMAIN 39\n> +\n> + #define TARGET_SO_RXQ_OVFL 40\n> +\n> + #define TARGET_SO_WIFI_STATUS 41\n> + #define TARGET_SCM_WIFI_STATUS TARGET_SO_WIFI_STATUS\n> + #define TARGET_SO_PEEK_OFF 42\n> +\n> + #define TARGET_SO_NOFCS 43\n> + #define TARGET_SO_LOCK_FILTER 44\n> + #define TARGET_SO_SELECT_ERR_QUEUE 45\n> + #define TARGET_SO_BUSY_POLL 46\n> + #define TARGET_SO_MAX_PACING_RATE 47\n> + #define TARGET_SO_BPF_EXTENSIONS 48\n> + #define TARGET_SO_INCOMING_CPU 49\n> + #define TARGET_SO_ATTACH_BPF 50\n> + #define TARGET_SO_DETACH_BPF TARGET_SO_DETACH_FILTER\n> + #define TARGET_SO_ATTACH_REUSEPORT_CBPF 51\n> + #define TARGET_SO_ATTACH_REUSEPORT_EBPF 52\n> + #define TARGET_SO_CNX_ADVICE 53\n> + #define TARGET_SCM_TIMESTAMPING_OPT_STATS 54\n> + #define TARGET_SO_MEMINFO 55\n> + #define TARGET_SO_INCOMING_NAPI_ID 56\n> + #define TARGET_SO_COOKIE 57\n> + #define TARGET_SCM_TIMESTAMPING_PKTINFO 58\n> + #define TARGET_SO_PEERGROUPS 59\n> + #define TARGET_SO_ZEROCOPY 60\n> \n> - #define TARGET_SO_PASSSEC 34\n> #endif\n> \n> #ifndef ARCH_HAS_SOCKET_TYPES\n> @@ -94,6 +131,6 @@\n> };\n> \n> #define TARGET_SOCK_MAX (TARGET_SOCK_PACKET + 1)\n> - #define TARGET_SOCK_TYPE_MASK 0xf /* Covers up to TARGET_SOCK_MAX-1. */\n> + #define TARGET_SOCK_TYPE_MASK 0xf /* Covers up to TARGET_SOCK_MAX - 1. */\n> \n> #endif\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzKbm2S2rz9s7h\n\tfor ;\n\tSat, 23 Sep 2017 03:05:07 +1000 (AEST)","from localhost ([::1]:60260 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvRNw-0000SP-LB\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 13:05:04 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56601)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvRNQ-0000S1-H7\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 13:04:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvRNN-0005cO-8f\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 13:04:32 -0400","from mout.kundenserver.de ([212.227.126.135]:55965)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dvRNM-0005be-TT\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 13:04:29 -0400","from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de\n\t(mreue005 [212.227.15.167]) with ESMTPSA (Nemesis) id\n\t0MgJKE-1dhdsU48M2-00NkIN; Fri, 22 Sep 2017 19:04:17 +0200"],"To":"=?utf-8?q?Carlo_Marcelo_Arenas_Bel=C3=B3n?= ,\n\tqemu-devel@nongnu.org","References":"<20170922140237.10869-1-carenas@gmail.com>\n\t<20170922140237.10869-7-carenas@gmail.com>","From":"Laurent Vivier ","Message-ID":"<4bb66a11-110a-562a-8e3d-8d1c7088c2bc@vivier.eu>","Date":"Fri, 22 Sep 2017 19:04:15 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922140237.10869-7-carenas@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-Provags-ID":"V03:K0:gDOJFhUNfNFTvNIQpouMiN6Wt3mRD4+ysy6YCY5avtVeahYeW/9\n\tnnZ7XieMT5u2kRZZco3wPQ4wjoF2oqL3T6JZVfforHirKXsLNJSe8v6/iLx/geU2Y2wD9Ck\n\twXt2yGZ9p5qaqAEAoRcmeEGfFWpajraDktLnTPpNw2BNxP+dD+bahg9eI3rEHD4rx3Qg2F9\n\trOP/cZTyXaLLOJH7flLlw==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:7RWLfvyyyuQ=:GLG+RbNdmWT9CpqsZzzqZ/\n\tz03ctcPigKkyVBAbdZj0vmDquTvYFl/mUsuQjUTm7Mc7LXCcny3MTiESX2YCixikZ3uBBouay\n\tOtcQAlz4zrKsWq/Muckb52xdi5DQT8PUjStqCEqb8dfSa/wriaA71FfJ+BQ9n7ocW4WX5h1FP\n\tZ2ZY+2BX5y5yCPUm3OKgO84Xxnn860mhUroyTdSaaH7NhfyKwFNGfe1ds8hyBL6gLQFxuQYPS\n\t7PQGUMYNrwi8FfLrOo8bLp/lXdZQDd4z7TyjVpNAJzxDau88JNNBY4s4LBFbzpZrvc0tZgFLC\n\tisCIiuVAQ/CJAWe+Z3oE3cKX125Ip2G7EFxIwIcDhc0A5t2pNy37EkWLrrVABt+rkHERSGq0U\n\tmDWQDotgGwyPFz06pc5qysS7Lhp3cvB/uY05Mn192qu5wCiUahA/tCFRJBEy6VwyJaGU5euDt\n\tiTCK1rMF4WPdfje2MU+/7MMPw97pvRdisuAOKMzhsmMU2n+geB/naO7T8jkKdhkev6wuMy6xZ\n\tprWG2ruT3c0CMC2bYYz95ep7hefPMq+kceRl9Uf6dydOe5E9e1PGR8RDlamzWV/6Bnq+nhk6f\n\tNwms7rHXAR3Vm0NJP/durGKwwkfTcwg47biTpGYHsTF3ox83W8SmwVEhUryEhotlFcMJT11Ih\n\tnbcrg6ZRBCWczM26JbuvWLaWht3UK6Alp0lBoOY9vjfonmnkW45BnONnYg7McJ7BOuc1604Mz\n\t8EbWlfEcw1VtT8ZQ0aohv7lnNkknEZNG4t4+aokDGP3nCC0H6M741TMVxJc=","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"212.227.126.135","Subject":"Re: [Qemu-devel] [RFC 6/6] linux-user: update default socket.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"riku.voipio@iki.fi, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774676,"web_url":"http://patchwork.ozlabs.org/comment/1774676/","msgid":"","list_archive_url":null,"date":"2017-09-25T11:55:50","subject":"Re: [Qemu-devel] [RFC 6/6] linux-user: update default socket.h","submitter":{"id":72390,"url":"http://patchwork.ozlabs.org/api/people/72390/","name":"Carlo Arenas","email":"carenas@gmail.com"},"content":"On Fri, Sep 22, 2017 at 10:04 AM, Laurent Vivier wrote:\n\n> And you should move powerpc bits to linux-user/ppc/sockbits.\n\n\nPPC is IMHO a special case, since it is kept together with the generic\nheader in the linux kernel (except for a similar exception to those few\nvalues that differ) as you can see in :\n\n\nhttp://elixir.free-electrons.com/linux/latest/source/arch/powerpc/include/uapi/asm/socket.h\n\nbreaking it up into his own file will probably only make it more difficult\nto maintain\n\nCarlo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QQXq1EEN\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y12c11kjQz9sPr\n\tfor ;\n\tMon, 25 Sep 2017 21:56:17 +1000 (AEST)","from localhost ([::1]:41871 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwRzj-0001fB-DS\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 07:56:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36323)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwRzM-0001f6-SO\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:55:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwRzL-0005Hu-UR\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:55:52 -0400","from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:38002)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dwRzL-0005HX-N4\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:55:51 -0400","by mail-wm0-x242.google.com with SMTP id x17so6973372wmd.5\n\tfor ; Mon, 25 Sep 2017 04:55:51 -0700 (PDT)","by 10.80.166.150 with HTTP; Mon, 25 Sep 2017 04:55:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=4XQ+F9XduIzYpAXQ3nazIYM3Hs7n/2Iu8193sYu7uZ0=;\n\tb=QQXq1EENOlebxb+b8ysmeDemg47ES1Urce5LPMwZH89VSbbw73o/ZlR6oXZZb2nixu\n\tXOsxhBOOk0M3wrBQzC5Ma25AqMTeWXhbukgDtPd5B9fWAQfcBBIAql/kjanblj/SDCuS\n\tNQ98wPPE5zcpBlCdYS0WMw9G2mHK0KyOP+Pz2aWR8UPfQ2/GDyo+4L1xRW9c4/4ETrFa\n\tZMZK2LMLelK51Usjq+8MOaPT+54U5TbJzk9tQ4aW59X56A7irZemTjYeoj32aYXUnpmI\n\tVgSqLjPgw0msB0lidT0V1lLINj4eWE6O7Q+tIVmw4UkFp90vYwpCMptyBxMlgkLaUKgE\n\tVFXQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=4XQ+F9XduIzYpAXQ3nazIYM3Hs7n/2Iu8193sYu7uZ0=;\n\tb=dovsTndWYYJrbHKS2aiSBBN/AcIf3gm2WzQCUTrWK5wYdUqhmvd29oj+vLcd//9DlT\n\tF7QJ9qcet5h2kM8QuFfgCb0nXSf0/5yGaMKfAmHjBZZ5kKsm9jTwnF7craluNNtBVxk+\n\tirL5zVq5FOIO1BCl4A6rcmumWJWIaUcJoWp2Ou6iYMSZw1iUdqzFD8fBrMoUFd/sl6V0\n\tZKbfyOqlyCrfxX3SbW4dvVIrZY5MDaEHXzPU5KRAk1UpQmJzoKftHkHjfnz2Kpcyv6m8\n\taxlxansr5MdBg450wt17j80gsUIbXVfk1Bxe6F5nfQUFDG5fVn8fdcXRHSZzShnpJ68o\n\tef+Q==","X-Gm-Message-State":"AHPjjUg4ro7XTv8Fyl4cll+L3Nx+Z+JQUUa+1p8Oa1nCNHbm30lnjLVy\n\tcM6Sh+AV9OEXfm4wjROL0eaxkmT8G/MgXV0c0zM=","X-Google-Smtp-Source":"AOwi7QA7hMzvbEqsxb5Eq/eCOHYf68RoWQ2rWVxpa0ZcmE/BVwdSfEahVPILo/wkHqAq3sWWiMi3TypQOuldJgoAtIs=","X-Received":"by 10.80.193.130 with SMTP id m2mr13603479edf.209.1506340550548; \n\tMon, 25 Sep 2017 04:55:50 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<4bb66a11-110a-562a-8e3d-8d1c7088c2bc@vivier.eu>","References":"<20170922140237.10869-1-carenas@gmail.com>\n\t<20170922140237.10869-7-carenas@gmail.com>\n\t<4bb66a11-110a-562a-8e3d-8d1c7088c2bc@vivier.eu>","From":"Carlo Arenas ","Date":"Mon, 25 Sep 2017 04:55:50 -0700","Message-ID":"","To":"Laurent Vivier ","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::242","Content-Type":"text/plain; charset=\"UTF-8\"","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [RFC 6/6] linux-user: update default socket.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"riku.voipio@iki.fi, qemu-devel@nongnu.org, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]