[{"id":1773765,"web_url":"http://patchwork.ozlabs.org/comment/1773765/","msgid":"<3a07484c-13bc-1dab-67ba-6bbcdf2e58c2@vivier.eu>","list_archive_url":null,"date":"2017-09-22T16:51:37","subject":"Re: [Qemu-devel] [RFC 4/6] linux-user: refactor socket.h for sparc","submitter":{"id":2628,"url":"http://patchwork.ozlabs.org/api/people/2628/","name":"Laurent Vivier","email":"laurent@vivier.eu"},"content":"Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit :\n> fixes SOL_SOCKET and SO_LINGER at least\n\nAnd fix TARGET_SOCK_NONBLOCK and TARGET_SOCK_CLOEXEC values.\n\n> \n> Signed-off-by: Carlo Marcelo Arenas Belón \n> ---\n> linux-user/socket.h | 46 ++------------------\n> linux-user/sparc/sockbits.h | 104 ++++++++++++++++++++++++++++++++++++++++++++\n> 2 files changed, 107 insertions(+), 43 deletions(-)\n> create mode 100644 linux-user/sparc/sockbits.h\n> \n> diff --git a/linux-user/socket.h b/linux-user/socket.h\n> index 036270a6e4..dfa692286b 100644\n> --- a/linux-user/socket.h\n> +++ b/linux-user/socket.h\n> @@ -4,50 +4,10 @@\n> #include \"alpha/sockbits.h\"\n> #elif defined(TARGET_HPPA)\n> #include \"hppa/sockbits.h\"\n> +#elif defined(TARGET_SPARC)\n> +#include \"sparc/sockbits.h\"\n> #else\n> \n> -#if defined(TARGET_SPARC)\n> - /** sock_type - Socket types\n> - *\n> - * Please notice that for binary compat reasons SPARC has to\n> - * override the enum sock_type in include/linux/net.h, so\n> - * we define ARCH_HAS_SOCKET_TYPES here.\n> - *\n> - * @SOCK_DGRAM - datagram (conn.less) socket\n> - * @SOCK_STREAM - stream (connection) socket\n> - * @SOCK_RAW - raw socket\n> - * @SOCK_RDM - reliably-delivered message\n> - * @SOCK_SEQPACKET - sequential packet socket\n> - * @SOCK_DCCP - Datagram Congestion Control Protocol socket\n> - * @SOCK_PACKET - linux specific way of getting packets at the dev level.\n> - * For writing rarp and other similar things on the user\n> - * level.\n> - * @SOCK_CLOEXEC - sets the close-on-exec (FD_CLOEXEC) flag.\n> - * @SOCK_NONBLOCK - sets the O_NONBLOCK file status flag.\n> - */\n> -\n> - #define ARCH_HAS_SOCKET_TYPES 1\n> -\n> - enum sock_type {\n> - TARGET_SOCK_STREAM = 1,\n> - TARGET_SOCK_DGRAM = 2,\n> - TARGET_SOCK_RAW = 3,\n> - TARGET_SOCK_RDM = 4,\n> - TARGET_SOCK_SEQPACKET = 5,\n> - TARGET_SOCK_DCCP = 6,\n> - TARGET_SOCK_PACKET = 10,\n> - TARGET_SOCK_CLOEXEC = 020000000,\n> - TARGET_SOCK_NONBLOCK = 040000,\n> - };\n...\n> +enum sock_type {\n> + TARGET_SOCK_STREAM = 1,\n> + TARGET_SOCK_DGRAM = 2,\n> + TARGET_SOCK_RAW = 3,\n> + TARGET_SOCK_RDM = 4,\n> + TARGET_SOCK_SEQPACKET = 5,\n> + TARGET_SOCK_DCCP = 6,\n> + TARGET_SOCK_PACKET = 10,\n> + TARGET_SOCK_CLOEXEC = 0x400000,\n> + TARGET_SOCK_NONBLOCK = 0x4000,\n> +};\n> +\n> +#define TARGET_SOCK_MAX (TARGET_SOCK_PACKET + 1)\n> +#define TARGET_SOCK_TYPE_MASK 0xf /* Covers up to TARGET_SOCK_MAX - 1. */\n> +\n> +#define ARCH_HAS_SOCKET_TYPES 1\n> \n\nReviewed-by: Laurent Vivier ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzKK24jrjz9s7h\n\tfor ;\n\tSat, 23 Sep 2017 02:52:21 +1000 (AEST)","from localhost ([::1]:60168 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvRBa-0002e1-Vi\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 12:52:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49589)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvRBE-0002dd-Rf\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:51:58 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvRBA-00056I-Tt\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:51:56 -0400","from mout.kundenserver.de ([212.227.126.187]:50263)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dvRBA-00055r-J7\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:51:52 -0400","from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de\n\t(mreue004 [212.227.15.167]) with ESMTPSA (Nemesis) id\n\t0LaYX5-1dWV5o46mN-00mMcl; Fri, 22 Sep 2017 18:51:40 +0200"],"To":"=?utf-8?q?Carlo_Marcelo_Arenas_Bel=C3=B3n?= ,\n\tqemu-devel@nongnu.org","References":"<20170922140237.10869-1-carenas@gmail.com>\n\t<20170922140237.10869-5-carenas@gmail.com>","From":"Laurent Vivier ","Message-ID":"<3a07484c-13bc-1dab-67ba-6bbcdf2e58c2@vivier.eu>","Date":"Fri, 22 Sep 2017 18:51:37 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922140237.10869-5-carenas@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-Provags-ID":"V03:K0:xmvFXoG8c8jjUKWizPNdNont0dRe6lCjDrWOvXoGJIfsdB3u8WN\n\tTHJxQZhIzXmyO6Jk23TmkbCiqhNZ5jaKkAmtJeYDrafvNC404NTXhWZbx6RMPJqUaZteKiN\n\tIPlB/5RhExGt2oFbh9IrRIqPfa0TMAv8Om43RT4ui9Wp5jQnk0FZUqNe4gWNHL5z5i3035k\n\tp3byMw1H4RaxMDJd9Qj3g==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:m4DGXTJy0p8=:rUYnLeUfvPgkPgNLWIgdkv\n\tYjvHLHvgCQsJHauZKy5PKRhsMCLZYDmlaIfPNMBE1Qot+4WTynn0GDJr6D7y/8yIyGsB1Zbb5\n\tuUXpE6r3ai00e8CyoWIn7/q4fkdd0jYxeH7Redl9o68AcOGT2Nrcl9jZpiLivPpReNfpe6TEN\n\t9jLfa9kbaTJecK5/yS33iGdXlYDXJP6/JXNdCvRT0c25buWZLGEyRjVqmZgszbKri+WAig0WW\n\tycvEibbWo5BTx6hQDbTKlusknIMlK8XiVNJs/cV/Oqs9n4W4eCjjVKjsEDhDKohXYOT07gQqR\n\tGcWzlMU6Z+2FYYbX0FSvmvak7xiqChzhM9bCY+5v2EABNLm1yf2pTldr7KujYuSTipPPCJDnF\n\tFIXuOKASrabcW4Sdg8g7C2v0HAbv2UKYMJpRGaDdiwNnY7ltdYBSQD7Eo9XyyE5ZYVtlkFMI3\n\tBXjmfXygc6CKuJNKT96IpT+V/kma2hEZSwENpbmpqukL1Ujg7z67BldY4zvxqLffHD2Nh0Qch\n\tBvnsC1nIUHCao0Mvif89L0ooCyH9WotWwn5vLIjCfNJ5H58OVy6HYEtr697sF5UiSN9AdLOIk\n\t2UAFNOXQdMyfBa04qaj+5+F/JwRATo8QKNrtf96dZAdLcIZgLa8jZxQcQz6A75LtcEgwRizoZ\n\tkRK+u88vmudNh+NFvp8xvnHWd2fLCAR/ICu/dZDuGCTk4xOwdjgx6osNHszxgDhyRH3DXWTeL\n\tBSnK1TWB39xe1eYxDUyn2VXploIHmcstWaJmPg0YWO3CahwRRblAZ/DM+hM=","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"212.227.126.187","Subject":"Re: [Qemu-devel] [RFC 4/6] linux-user: refactor socket.h for sparc","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"riku.voipio@iki.fi, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]