[{"id":1773776,"web_url":"http://patchwork.ozlabs.org/comment/1773776/","msgid":"<57170a30-6932-a8f9-343c-1ce1f7c331b1@vivier.eu>","list_archive_url":null,"date":"2017-09-22T17:01:22","subject":"Re: [Qemu-devel] [RFC 5/6] linux-user: fix 64bit versions of sparc\n\tand mips","submitter":{"id":2628,"url":"http://patchwork.ozlabs.org/api/people/2628/","name":"Laurent Vivier","email":"laurent@vivier.eu"},"content":"Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit :\n> Signed-off-by: Carlo Marcelo Arenas Belón \n> ---\n> linux-user/mips64/sockbits.h | 1 +\n> linux-user/socket.h | 4 ++--\n> linux-user/sparc64/sockbits.h | 1 +\n\nWho includes the two new files?\n\nMoreover TARGET_MIPS/TARGET_SPARC (base arch) are always defined when\nTARGET_MIPS64/TARGET_SPARC64 (target arch) are defined.\n\nSo I think this patch is useless.\n\nThanks,\nLaurent\n\n> 3 files changed, 4 insertions(+), 2 deletions(-)\n> create mode 100644 linux-user/mips64/sockbits.h\n> create mode 100644 linux-user/sparc64/sockbits.h\n> \n> diff --git a/linux-user/mips64/sockbits.h b/linux-user/mips64/sockbits.h\n> new file mode 100644\n> index 0000000000..e6b6d31ac9\n> --- /dev/null\n> +++ b/linux-user/mips64/sockbits.h\n> @@ -0,0 +1 @@\n> +#include \"../mips/sockbits.h\"\n> diff --git a/linux-user/socket.h b/linux-user/socket.h\n> index dfa692286b..6fd486c6b1 100644\n> --- a/linux-user/socket.h\n> +++ b/linux-user/socket.h\n> @@ -1,10 +1,10 @@\n> -#if defined(TARGET_MIPS)\n> +#if defined(TARGET_MIPS) || defined(TARGET_MIPS64)\n> #include \"mips/sockbits.h\"\n> #elif defined(TARGET_ALPHA)\n> #include \"alpha/sockbits.h\"\n> #elif defined(TARGET_HPPA)\n> #include \"hppa/sockbits.h\"\n> -#elif defined(TARGET_SPARC)\n> +#elif defined(TARGET_SPARC) || defined(TARGET_SPARC64)\n> #include \"sparc/sockbits.h\"\n> #else\n> \n> diff --git a/linux-user/sparc64/sockbits.h b/linux-user/sparc64/sockbits.h\n> new file mode 100644\n> index 0000000000..658899e4d3\n> --- /dev/null\n> +++ b/linux-user/sparc64/sockbits.h\n> @@ -0,0 +1 @@\n> +#include \"../sparc/sockbits.h\"\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzKXD5FBrz9s7h\n\tfor ;\n\tSat, 23 Sep 2017 03:02:04 +1000 (AEST)","from localhost ([::1]:60239 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvRL0-0007jC-SV\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 13:02:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54574)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvRKe-0007ii-PC\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 13:01:41 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvRKa-0003Tl-R0\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 13:01:40 -0400","from mout.kundenserver.de ([212.227.126.134]:61655)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dvRKa-0003SM-HD\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 13:01:36 -0400","from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de\n\t(mreue002 [212.227.15.167]) with ESMTPSA (Nemesis) id\n\t0MfvaW-1dh5qC0VzI-00NAOb; Fri, 22 Sep 2017 19:01:24 +0200"],"To":"=?utf-8?q?Carlo_Marcelo_Arenas_Bel=C3=B3n?= ,\n\tqemu-devel@nongnu.org","References":"<20170922140237.10869-1-carenas@gmail.com>\n\t<20170922140237.10869-6-carenas@gmail.com>","From":"Laurent Vivier ","Message-ID":"<57170a30-6932-a8f9-343c-1ce1f7c331b1@vivier.eu>","Date":"Fri, 22 Sep 2017 19:01:22 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922140237.10869-6-carenas@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-Provags-ID":"V03:K0:aH6DfMj2jFe8J60t5hm/PsMatvZojC94BaBIeHCKZ2JzsdlvoVI\n\tAMEdvjeRORu+DFb9XJqqt3t67+UtBfag3Q3vcos+fAuYJQSS+8UkCNBDnZDc+lwJZ4j0OSK\n\tS1P0nrapumx7uLrTu8EzCvfliZXAOFl5zIqjBpl4fNDn5qFC8Wu1bhG9Mhlk8myDptKhMcj\n\tEHwj1hDrJcxk7DqBdJAmg==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:ZCkfbHpYRk4=:lxU4rdoE6wvaNCQy9g2z8O\n\tZQmdXSF7XuZLuxXAJbHOuh/o8C6NkuppvIw88IglscRXL2NuTi7vdtEeEgMFcUuPVEImYsCLe\n\tvDFFHZIcfRtp8+I/dzl1e/ziy4sfWp+qfwMhzjOtYk61ANdZQIhhG0cQjJ4MHZF5C6HZMiszn\n\t7XkN4V8ozlca2l67dlzvdKaaNhqKo2u4GUQ6EVqkS//2SVansmQYv2Mhpn20dj3Z+dp8S1Jhr\n\tH8UrEod5kC3+geozeJkFlnLBMtXFtTkPkUMyUU6Y+bw7KDoKzKvg//UxGxtBjszUaaioTIJDb\n\tFLh0QLM/azgyeO/KOEsez0wRlzEDcv7tDNK7gP5trhup/PJL7ooaAGhcxhqk218hb6qAC8PUB\n\tohseYJmKhk6uKiJwy1fMn6KremN+Yj2bVqKrxmF3HUdkVwXeFF8BreINw0hEXGmJ9Wseoa0Gn\n\tCPoMUEYvXfBuv11F7LOoA56pJP15tGxpFEOhgKhJdXlTXHhEBxfhz6pEooz+OdaYNHlYd03PT\n\thHQhJWh4eF0gpBEM/iiIEB7oYcBHhJlHeeVuJZz2PRgDHU1wRXwxOh9gnnhhXFzF2AIPNkqeX\n\tizDb2uVj2LsNwMEXgd787v5d6s57cx7q8mVEUTd8hBG5+/VifScY5luEWZCVBKqUZ+XGdgkQE\n\txQpYtue/C2TKCM1iEiTuUg4HmsYs9mcHbbb/ociN/zabJUR2TdI0wqKaAvAxRETZitTSR7kRT\n\tRtxvCdkk5Qrt/5vSLS4Fv1tAtR5a9fWxCe0fiDRjQChBxSDVXpIqFdcDQB4=","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"212.227.126.134","Subject":"Re: [Qemu-devel] [RFC 5/6] linux-user: fix 64bit versions of sparc\n\tand mips","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"riku.voipio@iki.fi, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774665,"web_url":"http://patchwork.ozlabs.org/comment/1774665/","msgid":"","list_archive_url":null,"date":"2017-09-25T11:44:53","subject":"Re: [Qemu-devel] [RFC 5/6] linux-user: fix 64bit versions of sparc\n\tand mips","submitter":{"id":72390,"url":"http://patchwork.ozlabs.org/api/people/72390/","name":"Carlo Arenas","email":"carenas@gmail.com"},"content":"On Fri, Sep 22, 2017 at 10:01 AM, Laurent Vivier wrote:\n\n> Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit :\n> > Signed-off-by: Carlo Marcelo Arenas Belón \n> > ---\n> > linux-user/mips64/sockbits.h | 1 +\n> > linux-user/socket.h | 4 ++--\n> > linux-user/sparc64/sockbits.h | 1 +\n>\n> Who includes the two new files?\n>\n\nNo one yet, but hopefully will make clearer to anyone looking later for\narch specific values that they were indeed equivalent to their non 64bit\nversions.\n\nIt also mimics what termbits.h is doing and so might allow in the future to\ndrop the common socket.h for an arch specific one, which will be easier to\nmaintain and keep in sync with the linux kernel.\n\n\n> Moreover TARGET_MIPS/TARGET_SPARC (base arch) are always defined when\n> TARGET_MIPS64/TARGET_SPARC64 (target arch) are defined.\n>\n> So I think this patch is useless.\n>\n\nok, glad to know I was wrong about those architectures being broken, still\nsuspect s390x is though, but don't want to address this in this series,\nlike I didn't want to include the bigger refactoring explained above.\n\nI am curious also over users of those architectures and their suggestions,\nwhich is why I sent this series as an RFC; is there a better forum for that\nsomewhere else?\n\nCarlo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"nJ7YXxMl\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y12MQ6Jncz9tX3\n\tfor ;\n\tMon, 25 Sep 2017 21:45:21 +1000 (AEST)","from localhost ([::1]:41843 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwRp9-0005P4-5V\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 07:45:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34484)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwRoo-0005Oz-6R\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:44:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwRom-0000bZ-Q1\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:44:58 -0400","from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:36255)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dwRom-0000a8-J3\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:44:56 -0400","by mail-wm0-x241.google.com with SMTP id r136so6960192wmf.3\n\tfor ; Mon, 25 Sep 2017 04:44:55 -0700 (PDT)","by 10.80.166.150 with HTTP; Mon, 25 Sep 2017 04:44:53 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=JGCySadb0SuyEvZNqJ79W8Dy0W2zompeA5idD/EoVEk=;\n\tb=nJ7YXxMlF2vCCwq3hQ41CL2LWnCXn8+pIpooZlzbLz+JglbX6IzWE6w7pM6N96eGBV\n\t3SbU4zha/dEfgqexFg6A4ueaO+PCxnILeatqCDwJfPJhZPvLaOJjLl9FQLv7GjUwbt1U\n\tYciml905xyRud1h94RgrxwQqWb6LBCsRu53M6lx9ZoYa7L8dvR8lt5u/W1SVvcQTg4pF\n\tPbxyr8/d9VNSqdTOIlrU17EQ1TTFwzF+kROHcLlXKrhjWogHqcdoN2aCngAKTVZGYPtd\n\t/c/c9ZhUboz8eKrWOkHoz0WTSpUXE4E+lT1cetGgU/V50TaKLniV0XUKf7XtC8D5B8o6\n\tnMGA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=JGCySadb0SuyEvZNqJ79W8Dy0W2zompeA5idD/EoVEk=;\n\tb=MReyPv+3+WdpdDGw0ku41KEnXXyqxXKjQprDupE7PR7KURDwrQ6i/6dKi56gmVI4oK\n\t0ZhuhbN4bkyClW518tgxJQwVhOpllG/OxzSA7pFjCO2hXnnmjsc8d2eNOtDepM8gsoAG\n\tlga5i6rKjD0K5y4iSucWGv2JIBwdrfXwS/r0vfr6QDfD1XEMA4uZGJy9WLuy12605nLu\n\tr8qcV6XHmxilkXzcVB0RBf9D0/gGgTeTrYdUpiRjvgiEqxqBEfzaxnZ35BvjneM/Jykt\n\tj4zYUqpbQe5TjyT43RC8UbPmz9vGwidlIj1xzqw2nX/7UAxkLLcAF+fjt9gQYNE4P2Ei\n\t4Qew==","X-Gm-Message-State":"AHPjjUhjWvtkGEOwtNuxnJejnVFyNq/zN4OqgCOp9zxvbBuVXoQNizwV\n\tnNSBxqhhxNKYY+84oLiffzzRUchp+zHx2vWSzCk=","X-Google-Smtp-Source":"AOwi7QCucuI+WaOi+y4BhE5qmAnIgXjqO4Xi54Cm8E3TZu/OzSKyQpTan+SgEVt0/ANDrSgYKVVmdYQs4c8j2jY9a9Y=","X-Received":"by 10.80.221.71 with SMTP id u7mr13742761edk.86.1506339894036;\n\tMon, 25 Sep 2017 04:44:54 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<57170a30-6932-a8f9-343c-1ce1f7c331b1@vivier.eu>","References":"<20170922140237.10869-1-carenas@gmail.com>\n\t<20170922140237.10869-6-carenas@gmail.com>\n\t<57170a30-6932-a8f9-343c-1ce1f7c331b1@vivier.eu>","From":"Carlo Arenas ","Date":"Mon, 25 Sep 2017 04:44:53 -0700","Message-ID":"","To":"Laurent Vivier ","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::241","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [RFC 5/6] linux-user: fix 64bit versions of sparc\n\tand mips","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"riku.voipio@iki.fi, qemu-devel@nongnu.org, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]