[{"id":1773740,"web_url":"http://patchwork.ozlabs.org/comment/1773740/","msgid":"<592fda97-f1d3-d72d-82d4-abe7c9dcfe0d@vivier.eu>","list_archive_url":null,"date":"2017-09-22T16:30:59","subject":"Re: [Qemu-devel] [RFC 2/6] linux-user: refactor socket.h for alpha","submitter":{"id":2628,"url":"http://patchwork.ozlabs.org/api/people/2628/","name":"Laurent Vivier","email":"laurent@vivier.eu"},"content":"Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit :\n> based on fresh bits from linux 4.14 and therefore enabling SO_REUSEPORT\n> as a side effect\n> \n> Signed-off-by: Carlo Marcelo Arenas Belón \n> ---\n> linux-user/alpha/sockbits.h | 104 ++++++++++++++++++++++++++++++++++++++++++++\n> linux-user/socket.h | 104 +-------------------------------------------\n> 2 files changed, 105 insertions(+), 103 deletions(-)\n> create mode 100644 linux-user/alpha/sockbits.h\n> \n> diff --git a/linux-user/alpha/sockbits.h b/linux-user/alpha/sockbits.h\n> new file mode 100644\n> index 0000000000..768579a1f7\n> --- /dev/null\n> +++ b/linux-user/alpha/sockbits.h\n> @@ -0,0 +1,104 @@\n...\n> +enum sock_type {\n> + TARGET_SOCK_STREAM = 1,\n> + TARGET_SOCK_DGRAM = 2,\n> + TARGET_SOCK_RAW = 3,\n> + TARGET_SOCK_RDM = 4,\n> + TARGET_SOCK_SEQPACKET = 5,\n> + TARGET_SOCK_DCCP = 6,\n> + TARGET_SOCK_PACKET = 10,\n> + TARGET_SOCK_CLOEXEC = 010000000,\n> + TARGET_SOCK_NONBLOCK = 0x40000000,\n\nYou change the value of TARGET_SOCK_NONBLOCK, it's correct but you\nshould say that in the commit messages.\n\n...\n> - enum sock_type {\n> - TARGET_SOCK_STREAM = 1,\n> - TARGET_SOCK_DGRAM = 2,\n> - TARGET_SOCK_RAW = 3,\n> - TARGET_SOCK_RDM = 4,\n> - TARGET_SOCK_SEQPACKET = 5,\n> - TARGET_SOCK_DCCP = 6,\n> - TARGET_SOCK_PACKET = 10,\n> - TARGET_SOCK_CLOEXEC = 010000000,\n> - TARGET_SOCK_NONBLOCK = 010000000000,\n> - };\n\nThanks,\nLaurent","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzJs835Mdz9t3h\n\tfor ;\n\tSat, 23 Sep 2017 02:31:40 +1000 (AEST)","from localhost ([::1]:60047 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvQra-0006he-Iw\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 12:31:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38981)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvQrG-0006fY-3c\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:31:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvQrC-0005zM-Un\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:31:18 -0400","from mout.kundenserver.de ([212.227.126.135]:51610)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dvQrC-0005xz-LC\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:31:14 -0400","from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de\n\t(mreue002 [212.227.15.167]) with ESMTPSA (Nemesis) id\n\t0Llv5F-1dM66R0AUL-00Zd3V; Fri, 22 Sep 2017 18:31:02 +0200"],"To":"=?utf-8?q?Carlo_Marcelo_Arenas_Bel=C3=B3n?= ,\n\tqemu-devel@nongnu.org","References":"<20170922140237.10869-1-carenas@gmail.com>\n\t<20170922140237.10869-3-carenas@gmail.com>","From":"Laurent Vivier ","Message-ID":"<592fda97-f1d3-d72d-82d4-abe7c9dcfe0d@vivier.eu>","Date":"Fri, 22 Sep 2017 18:30:59 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922140237.10869-3-carenas@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-Provags-ID":"V03:K0:+jgyPub8XKVxb3rPJd8CGP0/x5QIVPHCqFWFt9euOKAVXOUcaNz\n\tW+yNnG4nzIXC8Jq+SJxFWHGZGLpHQK3uQ2g7QgUfr81djrw/kJNIF5eM44QisqzszzBHyWf\n\tKI7d1vXcznx8Jr/b+wHYQeSVfJC2i2PYwrT2SUsp9cGaZPHbZZcp8qplE5HZyrvsZnblimp\n\tjw75X+Epb9t6zJgoz3j5w==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:QlTGgKhWbuA=:aB85SOV++KKCCoyWRr84ZR\n\t7EHqa5cIsPHq4V37NRoldBNGUUuH3Uiip4SdIGmLh6SSD0KJsFVpMzOqSl1K0aV3pPDNejm+W\n\tf0BT6Kp4cro0/E4l/2f4kg5CyXpwAHJj90Nck3OUq4Zd/be91reWmL2zWT6CItskzf05C9lfP\n\tPO5mXdHvziKv07EInB35L1TjOOcBL5923rp+Hauft9Q//zIT2eTWUphAK7VnUp0zXLwxd58jF\n\tpTA/E8UAlevgk/6TtqQTWtldjZtJznUDrLgz/SlWp2DqkN6mETcHuXKsw6M8hRiETs9eenKVP\n\tA0RaH03ZmkgtUAUU7XMEdBz/ZBUDljNfKcz+CDvmutPsQkHsePtMg0HpXEGLURz7bY041YtQA\n\tbnYL1rX3CvMnwhhQF4RAMDZ+EBhAPN+m40sXmKp84NpWlU+qrgGc/iG75zG9kZ/sLTi7k1ZNC\n\t4IEk3Gabk4IG5aBgHgu5V3F31Na5YxIqoI8r4LodIL1W/X1inGZqF76grAFWEcMr8UYoE0uyV\n\tLkfNiklagAn0ZsrZbOdMf3yv50UyeGCJ36JlvJzwkv6GDXcQRKU5mFvwiFjvS8Wjk8a23z6Vd\n\tsXNqNzJNVpTWUnYeNTT9b7RtKjKzYFAbmECHckxHABh183sWIRsJUr/Vh2yeYhe6+gwCMqASb\n\t+hD8DhH1EgGKSo/wIYOz7oAlYVyPKOxnAmSqu6VAZ5BApc+kkyOzaq6ZCqoVCIYFTEOp2rylB\n\tyHVbe197qCy9dK6jr8inK5X/Tzsh3aCn1O3lIqLAE2CUAJ4oi58yFwMG7FA=","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"212.227.126.135","Subject":"Re: [Qemu-devel] [RFC 2/6] linux-user: refactor socket.h for alpha","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"riku.voipio@iki.fi, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]