[{"id":1775404,"web_url":"http://patchwork.ozlabs.org/comment/1775404/","msgid":"<187f09ae-bb47-bf1f-3010-4260536485be@redhat.com>","list_archive_url":null,"date":"2017-09-26T12:01:22","subject":"Re: [Qemu-devel] [PATCH/RFC 1/3] s390x/ais: disable ais facility as\n\tit is broken","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 22.09.2017 10:38, Christian Borntraeger wrote:\n> The migration interface for ais was introduced with kernel 4.13\n> but the capability itself had been active since 4.12. As migration\n> support is considered necessary lets disable ais in the 2.10\n> stable version. A proper fix and re-enablement will be done\n> for qemu 2.11.\n> \n> Signed-off-by: Christian Borntraeger \n> Reviewed-by: Cornelia Huck \n> ---\n> target/s390x/kvm.c | 9 +++++++--\n> 1 file changed, 7 insertions(+), 2 deletions(-)\n> \n> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c\n> index 720cb1d..ebb75ca 100644\n> --- a/target/s390x/kvm.c\n> +++ b/target/s390x/kvm.c\n> @@ -311,8 +311,13 @@ int kvm_arch_init(MachineState *ms, KVMState *s)\n> }\n> }\n> \n> - /* Try to enable AIS facility */\n> - kvm_vm_enable_cap(s, KVM_CAP_S390_AIS, 0);\n> + /*\n> + * The migration interface for ais was introduced with kernel 4.13\n> + * but the capability itself had been active since 4.12. As migration\n> + * support is considered necessary let's disable ais in the 2.10\n> + * machine.\n> + */\n> + /* kvm_vm_enable_cap(s, KVM_CAP_S390_AIS, 0); */\n> \n> qemu_mutex_init(&qemu_sigp_mutex);\n> \n> \n\nReviewed-by: David Hildenbrand ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1fkl0dvHz9t67\n\tfor ;\n\tTue, 26 Sep 2017 22:04:15 +1000 (AEST)","from localhost ([::1]:47260 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwoaz-0006Q0-7X\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 08:04:13 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49714)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwoYO-00053C-Sl\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:01:39 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwoYL-0004Ic-SJ\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:01:32 -0400","from mx1.redhat.com ([209.132.183.28]:47416)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwoYL-0004IJ-MV\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:01:29 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6EF5F7247B;\n\tTue, 26 Sep 2017 12:01:28 +0000 (UTC)","from [10.36.117.152] (ovpn-117-152.ams2.redhat.com [10.36.117.152])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9E934784A9;\n\tTue, 26 Sep 2017 12:01:23 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6EF5F7247B","To":"Christian Borntraeger ,\n\tCornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-2-borntraeger@de.ibm.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<187f09ae-bb47-bf1f-3010-4260536485be@redhat.com>","Date":"Tue, 26 Sep 2017 14:01:22 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922083855.102341-2-borntraeger@de.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tTue, 26 Sep 2017 12:01:28 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH/RFC 1/3] s390x/ais: disable ais facility as\n\tit is broken","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tqemu-devel , Alexander Graf ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]