[{"id":1773541,"web_url":"http://patchwork.ozlabs.org/comment/1773541/","msgid":"<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-22T12:13:12","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":66825,"url":"http://patchwork.ozlabs.org/api/people/66825/","name":"Pierre Morel","email":"pmorel@linux.vnet.ibm.com"},"content":"On 22/09/2017 10:38, Christian Borntraeger wrote:\n> Instead of unconditionally enabling the KVM AIS capability\n> in the kvm arch init function, do this in the flic realize function\n> when we know if migration is available. This requires to initialize\n> flic before the CPUs.\n\nI am not sure to agree.\n\nAIS facility is used for PCI (currently only PCI)\nWe want to support PCI emulation and PCI VFIO\n\n\nNot having AIS support in the host kernel or not supporting AISM in the \nhost kernel does not affect the emulation.\nNeither virtio-pci nor TCG.\n\nThe only devices, (currently), which can not work without AIS and is not \nmigratable without AISM are PCI VFIO devices.\n\nWouldn't it be possible to just refuse to realize these devices when we \nhave no kernel support for AISM?\nAnd accept to migrate without kernel support if they are not used?\n\nPierre\n\n> \n> Signed-off-by: Christian Borntraeger \n> ---\n> hw/intc/s390_flic.c | 11 +++++++++--\n> hw/intc/s390_flic_kvm.c | 8 +++++++-\n> hw/s390x/s390-virtio-ccw.c | 8 ++++++--\n> include/hw/s390x/s390_flic.h | 1 +\n> target/s390x/cpu_models.c | 6 ++++++\n> target/s390x/kvm.c | 8 +-------\n> 6 files changed, 30 insertions(+), 12 deletions(-)\n> \n> diff --git a/hw/intc/s390_flic.c b/hw/intc/s390_flic.c\n> index 6eaf178..08040fe 100644\n> --- a/hw/intc/s390_flic.c\n> +++ b/hw/intc/s390_flic.c\n> @@ -1,7 +1,7 @@\n> /*\n> * QEMU S390x floating interrupt controller (flic)\n> *\n> - * Copyright 2014 IBM Corp.\n> + * Copyright 2014,2017 IBM Corp.\n> * Author(s): Jens Freimann \n> * Cornelia Huck \n> *\n> @@ -49,6 +49,13 @@ void s390_flic_init(void)\n> qdev_init_nofail(dev);\n> }\n> \n> +void s390_flic_enable_ais(void)\n> +{\n> + S390FLICState *fs = s390_get_flic();\n> +\n> + fs->ais_supported = true;\n> +}\n> +\n> static int qemu_s390_register_io_adapter(S390FLICState *fs, uint32_t id,\n> uint8_t isc, bool swap,\n> bool is_maskable, uint8_t flags)\n> @@ -186,7 +193,7 @@ static void s390_flic_common_realize(DeviceState *dev, Error **errp)\n> return;\n> }\n> \n> - fs->ais_supported = s390_has_feat(S390_FEAT_ADAPTER_INT_SUPPRESSION);\n> + fs->ais_supported = false;\n> }\n> \n> static void s390_flic_class_init(ObjectClass *oc, void *data)\n> diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_flic_kvm.c\n> index 7ead17a..a655567 100644\n> --- a/hw/intc/s390_flic_kvm.c\n> +++ b/hw/intc/s390_flic_kvm.c\n> @@ -1,7 +1,7 @@\n> /*\n> * QEMU S390x KVM floating interrupt controller (flic)\n> *\n> - * Copyright 2014 IBM Corp.\n> + * Copyright 2014,2017 IBM Corp.\n> * Author(s): Jens Freimann \n> * Cornelia Huck \n> *\n> @@ -557,6 +557,12 @@ static void kvm_s390_flic_realize(DeviceState *dev, Error **errp)\n> test_attr.group = KVM_DEV_FLIC_CLEAR_IO_IRQ;\n> flic_state->clear_io_supported = !ioctl(flic_state->fd,\n> KVM_HAS_DEVICE_ATTR, test_attr);\n> + /* try enable the AIS facility */\n> + test_attr.group = KVM_DEV_FLIC_AISM_ALL;\n> + if (!ioctl(flic_state->fd, KVM_HAS_DEVICE_ATTR, test_attr)) {\n> + kvm_vm_enable_cap(kvm_state, KVM_CAP_S390_AIS, 0);\n> + }\n> +\n> return;\n> fail:\n> error_propagate(errp, errp_local);\n> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> index fafbc6d..11d4dc4 100644\n> --- a/hw/s390x/s390-virtio-ccw.c\n> +++ b/hw/s390x/s390-virtio-ccw.c\n> @@ -279,11 +279,15 @@ static void ccw_init(MachineState *machine)\n> s390_sclp_init();\n> s390_memory_init(machine->ram_size);\n> \n> + /*\n> + * This might also enable some KVM features like AIS, so it must\n> + * be called before the CPU model\n> + */\n> + s390_flic_init();\n> +\n> /* init CPUs (incl. CPU model) early so s390_has_feature() works */\n> s390_init_cpus(machine);\n> \n> - s390_flic_init();\n> -\n> /* get a BUS */\n> css_bus = virtual_css_bus_init();\n> s390_init_ipl_dev(machine->kernel_filename, machine->kernel_cmdline,\n> diff --git a/include/hw/s390x/s390_flic.h b/include/hw/s390x/s390_flic.h\n> index 7aab6ef..ac4e170 100644\n> --- a/include/hw/s390x/s390_flic.h\n> +++ b/include/hw/s390x/s390_flic.h\n> @@ -90,6 +90,7 @@ void s390_flic_init(void);\n> \n> S390FLICState *s390_get_flic(void);\n> bool ais_needed(void *opaque);\n> +void s390_flic_enable_ais(void);\n> \n> #ifdef CONFIG_KVM\n> DeviceState *s390_flic_kvm_create(void);\n> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c\n> index 5169379..03ff583 100644\n> --- a/target/s390x/cpu_models.c\n> +++ b/target/s390x/cpu_models.c\n> @@ -23,6 +23,7 @@\n> #include \"qapi/qobject-input-visitor.h\"\n> #include \"qapi/qmp/qbool.h\"\n> #ifndef CONFIG_USER_ONLY\n> +#include \"hw/s390x/s390_flic.h\"\n> #include \"sysemu/arch_init.h\"\n> #endif\n> \n> @@ -901,6 +902,11 @@ static inline void apply_cpu_model(const S390CPUModel *model, Error **errp)\n> applied_model = *model;\n> }\n> }\n> +\n> + if (model &&\n> + test_bit(S390_FEAT_ADAPTER_INT_SUPPRESSION, model->features)) {\n> + s390_flic_enable_ais();\n> + }\n> #endif\n> }\n> \n> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c\n> index ebb75ca..6c5c57e 100644\n> --- a/target/s390x/kvm.c\n> +++ b/target/s390x/kvm.c\n> @@ -311,13 +311,7 @@ int kvm_arch_init(MachineState *ms, KVMState *s)\n> }\n> }\n> \n> - /*\n> - * The migration interface for ais was introduced with kernel 4.13\n> - * but the capability itself had been active since 4.12. As migration\n> - * support is considered necessary let's disable ais in the 2.10\n> - * machine.\n> - */\n> - /* kvm_vm_enable_cap(s, KVM_CAP_S390_AIS, 0); */\n> + /* The AIS enablement happens in the flic realize */\n> \n> qemu_mutex_init(&qemu_sigp_mutex);\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzC7r0KKQz9sPk\n\tfor ;\n\tFri, 22 Sep 2017 22:14:00 +1000 (AEST)","from localhost ([::1]:58534 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvMqE-0005tR-5J\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 08:13:58 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50316)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvMpk-0005rC-Cz\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 08:13:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvMpg-0002j9-Am\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 08:13:28 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:59196)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvMpg-0002hT-1X\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 08:13:24 -0400","from pps.filterd (m0098396.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8MC96me114983\n\tfor ; Fri, 22 Sep 2017 08:13:18 -0400","from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d51jt3ctw-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 22 Sep 2017 08:13:18 -0400","from localhost\n\tby e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 22 Sep 2017 13:13:15 +0100","from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)\n\tby e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tFri, 22 Sep 2017 13:13:13 +0100","from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com\n\t[9.149.105.61])\n\tby b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8MCDCR729687934; Fri, 22 Sep 2017 12:13:12 GMT","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 48F5B11C04C;\n\tFri, 22 Sep 2017 13:09:12 +0100 (BST)","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D4E3B11C04A;\n\tFri, 22 Sep 2017 13:09:11 +0100 (BST)","from [9.145.23.132] (unknown [9.145.23.132])\n\tby d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tFri, 22 Sep 2017 13:09:11 +0100 (BST)"],"To":"Christian Borntraeger ,\n\tCornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>","From":"Pierre Morel ","Date":"Fri, 22 Sep 2017 14:13:12 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922083855.102341-3-borntraeger@de.ibm.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17092212-0040-0000-0000-000003FC489F","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092212-0041-0000-0000-0000209D8863","Message-Id":"<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-22_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709220170","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v8MC96me114983","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tDavid Hildenbrand , Alexander Graf , \n\tqemu-devel ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773567,"web_url":"http://patchwork.ozlabs.org/comment/1773567/","msgid":"","list_archive_url":null,"date":"2017-09-22T12:40:31","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/22/2017 02:13 PM, Pierre Morel wrote:\n> On 22/09/2017 10:38, Christian Borntraeger wrote:\n>> Instead of unconditionally enabling the KVM AIS capability\n>> in the kvm arch init function, do this in the flic realize function\n>> when we know if migration is available. This requires to initialize\n>> flic before the CPUs.\n> \n> I am not sure to agree.\n> \n> AIS facility is used for PCI (currently only PCI)\n> We want to support PCI emulation and PCI VFIO\n> \n> \n> Not having AIS support in the host kernel or not supporting AISM in the host kernel does not affect the emulation.\n> Neither virtio-pci nor TCG.\n> The only devices, (currently), which can not work without AIS and is not migratable without AISM are PCI VFIO devices.\n\nThis patch enable the conditional enablement facility for the KVM host mask. The cpu model enablement is done\ndifferently for KVM and TCG anyway.\nRight now AIS is only enabled for KVM. For TCG AIS is not implemented at all and disabled. So for whenever this\nis fixed in TCG it can be handled then. \n\nAnd for emulated devices under KVM you still need the kernel support - otherwise migration is really broken for\nthe nimm/dimm values.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzD1T2c4yz9s9Y\n\tfor ;\n\tFri, 22 Sep 2017 22:53:33 +1000 (AEST)","from localhost ([::1]:58727 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvNSV-0001ER-GJ\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 08:53:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59386)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvNGC-0007XB-H3\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 08:40:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvNG7-0002Uy-Ay\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 08:40:48 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58588\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvNG6-0002UY-VU\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 08:40:43 -0400","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8MCdKnA056059\n\tfor ; Fri, 22 Sep 2017 08:40:39 -0400","from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d505sj8dm-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 22 Sep 2017 08:40:39 -0400","from localhost\n\tby e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 22 Sep 2017 13:40:36 +0100","from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194)\n\tby e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tFri, 22 Sep 2017 13:40:32 +0100","from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60])\n\tby b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8MCeWZW22413522; Fri, 22 Sep 2017 12:40:32 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 9B8C842049;\n\tFri, 22 Sep 2017 13:36:40 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id EDAC54203F;\n\tFri, 22 Sep 2017 13:36:39 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.145.151.184])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tFri, 22 Sep 2017 13:36:39 +0100 (BST)"],"To":"Pierre Morel ,\n\tCornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>","From":"Christian Borntraeger ","Date":"Fri, 22 Sep 2017 14:40:31 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17092212-0008-0000-0000-000004994DBE","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092212-0009-0000-0000-00001E2A8D87","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-22_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709220177","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tDavid Hildenbrand , Alexander Graf , \n\tqemu-devel ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773608,"web_url":"http://patchwork.ozlabs.org/comment/1773608/","msgid":"<20170922154920.10fd08ee.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-22T13:49:20","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Fri, 22 Sep 2017 14:40:31 +0200\nChristian Borntraeger wrote:\n\n> On 09/22/2017 02:13 PM, Pierre Morel wrote:\n> > On 22/09/2017 10:38, Christian Borntraeger wrote: \n> >> Instead of unconditionally enabling the KVM AIS capability\n> >> in the kvm arch init function, do this in the flic realize function\n> >> when we know if migration is available. This requires to initialize\n> >> flic before the CPUs. \n> > \n> > I am not sure to agree.\n> > \n> > AIS facility is used for PCI (currently only PCI)\n> > We want to support PCI emulation and PCI VFIO\n> > \n> > \n> > Not having AIS support in the host kernel or not supporting AISM in the host kernel does not affect the emulation.\n> > Neither virtio-pci nor TCG.\n> > The only devices, (currently), which can not work without AIS and is not migratable without AISM are PCI VFIO devices. \n> \n> This patch enable the conditional enablement facility for the KVM host mask. The cpu model enablement is done\n> differently for KVM and TCG anyway.\n> Right now AIS is only enabled for KVM. For TCG AIS is not implemented at all and disabled. So for whenever this\n> is fixed in TCG it can be handled then. \n\nYes, that will probably still need quite a bit of work before we are\nthere.\n\n> \n> And for emulated devices under KVM you still need the kernel support - otherwise migration is really broken for\n> the nimm/dimm values.\n\nAgreed, you need this for any pci device.\n\nI have not yet reviewed this (or tested under tcg). I'd like to hear\nDavid's opinion, though.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzFGf6Hcbz9sNw\n\tfor ;\n\tFri, 22 Sep 2017 23:50:01 +1000 (AEST)","from localhost ([::1]:59026 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvOL7-0002S7-3P\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 09:49:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50918)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvOKg-0002OI-4I\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 09:49:36 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvOKd-00032p-2B\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 09:49:30 -0400","from mx1.redhat.com ([209.132.183.28]:26032)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dvOKc-00032K-Sv\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 09:49:26 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9861F5F798;\n\tFri, 22 Sep 2017 13:49:25 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9A707600CD;\n\tFri, 22 Sep 2017 13:49:23 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9861F5F798","Date":"Fri, 22 Sep 2017 15:49:20 +0200","From":"Cornelia Huck ","To":"Christian Borntraeger ","Message-ID":"<20170922154920.10fd08ee.cohuck@redhat.com>","In-Reply-To":"","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>\n\t","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 22 Sep 2017 13:49:25 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tDavid Hildenbrand ,\n\tPierre Morel ,\n\tAlexander Graf , qemu-devel ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773624,"web_url":"http://patchwork.ozlabs.org/comment/1773624/","msgid":"","list_archive_url":null,"date":"2017-09-22T14:02:57","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":66825,"url":"http://patchwork.ozlabs.org/api/people/66825/","name":"Pierre Morel","email":"pmorel@linux.vnet.ibm.com"},"content":"On 22/09/2017 14:40, Christian Borntraeger wrote:\n> \n> \n> On 09/22/2017 02:13 PM, Pierre Morel wrote:\n>> On 22/09/2017 10:38, Christian Borntraeger wrote:\n>>> Instead of unconditionally enabling the KVM AIS capability\n>>> in the kvm arch init function, do this in the flic realize function\n>>> when we know if migration is available. This requires to initialize\n>>> flic before the CPUs.\n>>\n>> I am not sure to agree.\n>>\n>> AIS facility is used for PCI (currently only PCI)\n>> We want to support PCI emulation and PCI VFIO\n>>\n>>\n>> Not having AIS support in the host kernel or not supporting AISM in the host kernel does not affect the emulation.\n>> Neither virtio-pci nor TCG.\n>> The only devices, (currently), which can not work without AIS and is not migratable without AISM are PCI VFIO devices.\n> \n> This patch enable the conditional enablement facility for the KVM host mask. The cpu model enablement is done\n> differently for KVM and TCG anyway.\n> Right now AIS is only enabled for KVM. For TCG AIS is not implemented at all and disabled. So for whenever this\n> is fixed in TCG it can be handled then.\n> \n> And for emulated devices under KVM you still need the kernel support - otherwise migration is really broken for\n> the nimm/dimm values.\n> \n\nYes, that is right.\nI do not pretend that it is working directly.\n\nTo support AIS emulation we have some work to do there (the migration), \nin kvm_s390_inject_airq() and other functions using ais_supported, to \nuse emulated values.\n\nDon't you think that we could use emulation instead of faulting when the \nkernel can not handle values needed for pass-through?\n\nWe can fault at the moment a VFIO device is realized.\nMigration will be stopped on realizing VFIO PCI devices instead of flic.\n\nI can miss something, is there a reason not to do so?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzFgl5Mb9z9t3w\n\tfor ;\n\tSat, 23 Sep 2017 00:08:19 +1000 (AEST)","from localhost ([::1]:59098 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvOcr-0001ey-Qu\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 10:08:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53799)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvOXx-0006um-Vd\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:03:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvOXs-0001Ns-2h\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:03:14 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50474)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvOXr-0001NQ-R5\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:03:08 -0400","from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8MDrZgm047393\n\tfor ; Fri, 22 Sep 2017 10:03:03 -0400","from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d4yxb9h4h-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 22 Sep 2017 10:03:02 -0400","from localhost\n\tby e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 22 Sep 2017 15:03:00 +0100","from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)\n\tby e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tFri, 22 Sep 2017 15:02:58 +0100","from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com\n\t[9.149.105.61])\n\tby b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8ME2wY230670988; Fri, 22 Sep 2017 14:02:58 GMT","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 5F5EC11C058;\n\tFri, 22 Sep 2017 14:58:57 +0100 (BST)","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D3E1211C04A;\n\tFri, 22 Sep 2017 14:58:56 +0100 (BST)","from [9.145.23.132] (unknown [9.145.23.132])\n\tby d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tFri, 22 Sep 2017 14:58:56 +0100 (BST)"],"To":"Christian Borntraeger ,\n\tCornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>\n\t","From":"Pierre Morel ","Date":"Fri, 22 Sep 2017 16:02:57 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17092214-0040-0000-0000-000003DC5411","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092214-0041-0000-0000-000025DD936F","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-22_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709220195","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v8MDrZgm047393","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tDavid Hildenbrand , Alexander Graf , \n\tqemu-devel ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773625,"web_url":"http://patchwork.ozlabs.org/comment/1773625/","msgid":"<4a31c53b-98aa-747a-1402-1a93e74c565b@de.ibm.com>","list_archive_url":null,"date":"2017-09-22T14:07:08","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/22/2017 04:02 PM, Pierre Morel wrote:\n> On 22/09/2017 14:40, Christian Borntraeger wrote:\n>>\n>>\n>> On 09/22/2017 02:13 PM, Pierre Morel wrote:\n>>> On 22/09/2017 10:38, Christian Borntraeger wrote:\n>>>> Instead of unconditionally enabling the KVM AIS capability\n>>>> in the kvm arch init function, do this in the flic realize function\n>>>> when we know if migration is available. This requires to initialize\n>>>> flic before the CPUs.\n>>>\n>>> I am not sure to agree.\n>>>\n>>> AIS facility is used for PCI (currently only PCI)\n>>> We want to support PCI emulation and PCI VFIO\n>>>\n>>>\n>>> Not having AIS support in the host kernel or not supporting AISM in the host kernel does not affect the emulation.\n>>> Neither virtio-pci nor TCG.\n>>> The only devices, (currently), which can not work without AIS and is not migratable without AISM are PCI VFIO devices.\n>>\n>> This patch enable the conditional enablement facility for the KVM host mask. The cpu model enablement is done\n>> differently for KVM and TCG anyway.\n>> Right now AIS is only enabled for KVM. For TCG AIS is not implemented at all and disabled. So for whenever this\n>> is fixed in TCG it can be handled then.\n>>\n>> And for emulated devices under KVM you still need the kernel support - otherwise migration is really broken for\n>> the nimm/dimm values.\n>>\n> \n> Yes, that is right.\n> I do not pretend that it is working directly.\n> \n> To support AIS emulation we have some work to do there (the migration), in kvm_s390_inject_airq() and other functions using ais_supported, to use emulated values.\n> \n> Don't you think that we could use emulation instead of faulting when the kernel can not handle values needed for pass-through?\n> \n> We can fault at the moment a VFIO device is realized.\n> Migration will be stopped on realizing VFIO PCI devices instead of flic.\n> \n> I can miss something, is there a reason not to do so?\n\nThe problem is not vfio vs emulation. The problem is that for KVM the kernel is handling the interrupts.\nand it holds the state of the interrupt controller (nimm/dimm) and without an interface to read/write these, \nthe PCI core will be in a wrong state after migration regarding AIS.\n\nReally, this patch just moves the supported host kernel from >=4.12 to >=4.13. It makes absolutely no\nsense to start having a mixed interrupt stack (qemu + kernel) just to make this work on 4.12.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzFk32j8Zz9t3h\n\tfor ;\n\tSat, 23 Sep 2017 00:10:19 +1000 (AEST)","from localhost ([::1]:59106 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvOen-0003JR-Dy\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 10:10:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55431)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvObx-0001PY-Jy\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:07:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvObs-0003Rr-LN\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:07:21 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:39054)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvObs-0003RY-Bk\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:07:16 -0400","from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8ME5RQA093115\n\tfor ; Fri, 22 Sep 2017 10:07:15 -0400","from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d4yxb9wa5-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 22 Sep 2017 10:07:14 -0400","from localhost\n\tby e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 22 Sep 2017 15:07:12 +0100","from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)\n\tby e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tFri, 22 Sep 2017 15:07:09 +0100","from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com\n\t[9.149.105.232])\n\tby b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8ME79b029032654; Fri, 22 Sep 2017 14:07:09 GMT","from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id CBE0452043;\n\tFri, 22 Sep 2017 14:02:04 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.145.151.184])\n\tby d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6D0D952041; \n\tFri, 22 Sep 2017 14:02:04 +0100 (BST)"],"To":"Pierre Morel ,\n\tCornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>\n\t\n\t","From":"Christian Borntraeger ","Date":"Fri, 22 Sep 2017 16:07:08 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17092214-0012-0000-0000-0000057B5BE7","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092214-0013-0000-0000-000018F49E25","Message-Id":"<4a31c53b-98aa-747a-1402-1a93e74c565b@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-22_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709220196","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tDavid Hildenbrand , Alexander Graf , \n\tqemu-devel ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773652,"web_url":"http://patchwork.ozlabs.org/comment/1773652/","msgid":"<5cdfe359-2e78-7e2a-72c2-d3e69574288e@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-22T14:27:00","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":68297,"url":"http://patchwork.ozlabs.org/api/people/68297/","name":"Halil Pasic","email":"pasic@linux.vnet.ibm.com"},"content":"On 09/22/2017 04:07 PM, Christian Borntraeger wrote:\n> \n> \n> On 09/22/2017 04:02 PM, Pierre Morel wrote:\n>> On 22/09/2017 14:40, Christian Borntraeger wrote:\n>>>\n>>>\n>>> On 09/22/2017 02:13 PM, Pierre Morel wrote:\n>>>> On 22/09/2017 10:38, Christian Borntraeger wrote:\n>>>>> Instead of unconditionally enabling the KVM AIS capability\n>>>>> in the kvm arch init function, do this in the flic realize function\n>>>>> when we know if migration is available. This requires to initialize\n>>>>> flic before the CPUs.\n>>>>\n>>>> I am not sure to agree.\n>>>>\n>>>> AIS facility is used for PCI (currently only PCI)\n>>>> We want to support PCI emulation and PCI VFIO\n>>>>\n>>>>\n>>>> Not having AIS support in the host kernel or not supporting AISM in the host kernel does not affect the emulation.\n>>>> Neither virtio-pci nor TCG.\n>>>> The only devices, (currently), which can not work without AIS and is not migratable without AISM are PCI VFIO devices.\n>>>\n>>> This patch enable the conditional enablement facility for the KVM host mask. The cpu model enablement is done\n>>> differently for KVM and TCG anyway.\n>>> Right now AIS is only enabled for KVM. For TCG AIS is not implemented at all and disabled. So for whenever this\n>>> is fixed in TCG it can be handled then.\n>>>\n>>> And for emulated devices under KVM you still need the kernel support - otherwise migration is really broken for\n>>> the nimm/dimm values.\n>>>\n>>\n>> Yes, that is right.\n>> I do not pretend that it is working directly.\n>>\n>> To support AIS emulation we have some work to do there (the migration), in kvm_s390_inject_airq() and other functions using ais_supported, to use emulated values.\n>>\n>> Don't you think that we could use emulation instead of faulting when the kernel can not handle values needed for pass-through?\n>>\n>> We can fault at the moment a VFIO device is realized.\n>> Migration will be stopped on realizing VFIO PCI devices instead of flic.\n>>\n>> I can miss something, is there a reason not to do so?\n> \n> The problem is not vfio vs emulation. The problem is that for KVM the kernel is handling the interrupts.\n> and it holds the state of the interrupt controller (nimm/dimm) and without an interface to read/write these, \n> the PCI core will be in a wrong state after migration regarding AIS.\n> \n> Really, this patch just moves the supported host kernel from >=4.12 to >=4.13. It makes absolutely no\n> sense to start having a mixed interrupt stack (qemu + kernel) just to make this work on 4.12.\n> \n\nI tend to agree with Christian. I don't really understand Pierre's\nproposal. I'm sure a patch would help clarify things. If it's too\ncomplicated for writing up a patch, I think it's too complicated for\ndiscussing too.\n\nAbout the wrong state. Back then I did some reasoning about how bad this\nbad state actually is. In case of AIS starting with the initial state\nafter the migration might not be fatal (all cases considered). I was\nasking myself is there any problem beyond getting more irqs delivered\nthan necessary, and does that only affect the performance of the guest,\nor could it lead to correctness issues? I found the later question\ndifficult to answer.\n\nThe whole AIS stuff was a while ago. From what I see what Christian is\ntrying to do is both sane and conservative. Would need to revisit\neverything to say more.\n\nOne thing I would find very helpful is what do we expect to work and not\nwork for which version. Kind of a matrix. For instance should vfio pci\nwork for versions prior 2.11. I think in the not so distant past we\nchanged how SIC works (so it complains when we don't have ais).\n\nBtw nimm/dimm is simm/nimm. And I would really like to hear something\nform the original author(s) too.\n\nRegards,\nHalil","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzG6B3jdvz9t16\n\tfor ;\n\tSat, 23 Sep 2017 00:27:40 +1000 (AEST)","from localhost ([::1]:59188 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvOvZ-0002K2-7C\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 10:27:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35375)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvOvC-0002Jr-2h\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:27:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvOv8-0001Oy-1j\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:27:14 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40428)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvOv7-0001O6-OG\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:27:09 -0400","from pps.filterd (m0098394.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8MEPggm030666\n\tfor ; Fri, 22 Sep 2017 10:27:05 -0400","from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d51nhverh-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 22 Sep 2017 10:27:05 -0400","from localhost\n\tby e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 22 Sep 2017 15:27:03 +0100","from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)\n\tby e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tFri, 22 Sep 2017 15:27:01 +0100","from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com\n\t[9.149.105.62])\n\tby b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8MER0r823789674; Fri, 22 Sep 2017 14:27:00 GMT","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 144DFAE04D;\n\tFri, 22 Sep 2017 15:21:50 +0100 (BST)","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id A5D0FAE055;\n\tFri, 22 Sep 2017 15:21:49 +0100 (BST)","from oc3836556865.ibm.com (unknown [9.152.224.207])\n\tby d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tFri, 22 Sep 2017 15:21:49 +0100 (BST)"],"To":"Christian Borntraeger ,\n\tPierre Morel ,\n\tCornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>\n\t\n\t\n\t<4a31c53b-98aa-747a-1402-1a93e74c565b@de.ibm.com>","From":"Halil Pasic ","Date":"Fri, 22 Sep 2017 16:27:00 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<4a31c53b-98aa-747a-1402-1a93e74c565b@de.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","x-cbid":"17092214-0012-0000-0000-0000057B5D71","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092214-0013-0000-0000-000018F49FCF","Message-Id":"<5cdfe359-2e78-7e2a-72c2-d3e69574288e@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-22_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709220202","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Yi Min Zhao ,\n\tDavid Hildenbrand , Alexander Graf , \n\tqemu-devel ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773674,"web_url":"http://patchwork.ozlabs.org/comment/1773674/","msgid":"<3d27a8b0-b212-85f1-c59e-8ca9d972c476@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-22T14:38:17","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":66825,"url":"http://patchwork.ozlabs.org/api/people/66825/","name":"Pierre Morel","email":"pmorel@linux.vnet.ibm.com"},"content":"On 22/09/2017 16:07, Christian Borntraeger wrote:\n> \n> \n> On 09/22/2017 04:02 PM, Pierre Morel wrote:\n>> On 22/09/2017 14:40, Christian Borntraeger wrote:\n>>>\n>>>\n>>> On 09/22/2017 02:13 PM, Pierre Morel wrote:\n>>>> On 22/09/2017 10:38, Christian Borntraeger wrote:\n>>>>> Instead of unconditionally enabling the KVM AIS capability\n>>>>> in the kvm arch init function, do this in the flic realize function\n>>>>> when we know if migration is available. This requires to initialize\n>>>>> flic before the CPUs.\n>>>>\n>>>> I am not sure to agree.\n>>>>\n>>>> AIS facility is used for PCI (currently only PCI)\n>>>> We want to support PCI emulation and PCI VFIO\n>>>>\n>>>>\n>>>> Not having AIS support in the host kernel or not supporting AISM in the host kernel does not affect the emulation.\n>>>> Neither virtio-pci nor TCG.\n>>>> The only devices, (currently), which can not work without AIS and is not migratable without AISM are PCI VFIO devices.\n>>>\n>>> This patch enable the conditional enablement facility for the KVM host mask. The cpu model enablement is done\n>>> differently for KVM and TCG anyway.\n>>> Right now AIS is only enabled for KVM. For TCG AIS is not implemented at all and disabled. So for whenever this\n>>> is fixed in TCG it can be handled then.\n>>>\n>>> And for emulated devices under KVM you still need the kernel support - otherwise migration is really broken for\n>>> the nimm/dimm values.\n>>>\n>>\n>> Yes, that is right.\n>> I do not pretend that it is working directly.\n>>\n>> To support AIS emulation we have some work to do there (the migration), in kvm_s390_inject_airq() and other functions using ais_supported, to use emulated values.\n>>\n>> Don't you think that we could use emulation instead of faulting when the kernel can not handle values needed for pass-through?\n>>\n>> We can fault at the moment a VFIO device is realized.\n>> Migration will be stopped on realizing VFIO PCI devices instead of flic.\n>>\n>> I can miss something, is there a reason not to do so?\n> \n> The problem is not vfio vs emulation. The problem is that for KVM the kernel is handling the interrupts.\n> and it holds the state of the interrupt controller (nimm/dimm) and without an interface to read/write these,\n> the PCI core will be in a wrong state after migration regarding AIS.\n\nI am aware of this.\n\n> \n> Really, this patch just moves the supported host kernel from >=4.12 to >=4.13. It makes absolutely no\n> sense to start having a mixed interrupt stack (qemu + kernel) just to make this work on 4.12.\n> \n> \n\nIn fact it would have been for much more than just the 4.12\nBut OK, I can understand that it makes no sense to discuss this now.\nThe urgency is to fence 4.12.\nEventually, we can discuss this later.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzGM24krPz9sP1\n\tfor ;\n\tSat, 23 Sep 2017 00:38:54 +1000 (AEST)","from localhost ([::1]:59238 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvP6S-0007yo-Pt\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 10:38:52 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38947)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvP69-0007yU-Nq\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:38:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvP66-0007qW-J5\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:38:33 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51572)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvP66-0007q7-A4\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:38:30 -0400","from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8MEZEKG115629\n\tfor ; Fri, 22 Sep 2017 10:38:26 -0400","from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d53q3krbe-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 22 Sep 2017 10:38:25 -0400","from localhost\n\tby e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 22 Sep 2017 15:38:23 +0100","from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197)\n\tby e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tFri, 22 Sep 2017 15:38:19 +0100","from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com\n\t[9.149.105.61])\n\tby b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8MEcIOh21364868; Fri, 22 Sep 2017 14:38:18 GMT","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 37D0511C050;\n\tFri, 22 Sep 2017 15:34:18 +0100 (BST)","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 922FD11C04A;\n\tFri, 22 Sep 2017 15:34:17 +0100 (BST)","from [9.145.23.132] (unknown [9.145.23.132])\n\tby d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tFri, 22 Sep 2017 15:34:17 +0100 (BST)"],"To":"Christian Borntraeger ,\n\tCornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>\n\t\n\t\n\t<4a31c53b-98aa-747a-1402-1a93e74c565b@de.ibm.com>","From":"Pierre Morel ","Date":"Fri, 22 Sep 2017 16:38:17 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<4a31c53b-98aa-747a-1402-1a93e74c565b@de.ibm.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17092214-0016-0000-0000-000004EF5871","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092214-0017-0000-0000-000028299A50","Message-Id":"<3d27a8b0-b212-85f1-c59e-8ca9d972c476@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-22_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709220204","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v8MEZEKG115629","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tDavid Hildenbrand ,\n\tqemu-devel , Alexander Graf ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774608,"web_url":"http://patchwork.ozlabs.org/comment/1774608/","msgid":"<20170925120745.7326637e.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-25T10:07:45","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Fri, 22 Sep 2017 16:27:00 +0200\nHalil Pasic wrote:\n\n> One thing I would find very helpful is what do we expect to work and not\n> work for which version. Kind of a matrix. For instance should vfio pci\n> work for versions prior 2.11. I think in the not so distant past we\n> changed how SIC works (so it complains when we don't have ais).\n\nA matrix sounds like a good idea.\n\nI don't think we really ever had a setup that worked out of the box\nfor a Linux guest prior to 2.10 anyway. For added fun, it also depends\non the host kernel. And tcg won't work at all due to the pci\ninstruction not yet being wired up.\n\n> Btw nimm/dimm is simm/nimm. And I would really like to hear something\n> form the original author(s) too.\n\nSeconded.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y10Cg4VNxz9tX8\n\tfor ;\n\tMon, 25 Sep 2017 20:08:31 +1000 (AEST)","from localhost ([::1]:41572 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwQJR-0008IS-NI\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 06:08:29 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43742)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwQIv-0008Db-VX\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:07:58 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwQIr-0004tZ-M5\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:07:57 -0400","from mx1.redhat.com ([209.132.183.28]:59616)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwQIr-0004tB-G1\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:07:53 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 589002D0FA1;\n\tMon, 25 Sep 2017 10:07:52 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 699146C408;\n\tMon, 25 Sep 2017 10:07:47 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 589002D0FA1","Date":"Mon, 25 Sep 2017 12:07:45 +0200","From":"Cornelia Huck ","To":"Halil Pasic ","Message-ID":"<20170925120745.7326637e.cohuck@redhat.com>","In-Reply-To":"<5cdfe359-2e78-7e2a-72c2-d3e69574288e@linux.vnet.ibm.com>","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>\n\t\n\t\n\t<4a31c53b-98aa-747a-1402-1a93e74c565b@de.ibm.com>\n\t<5cdfe359-2e78-7e2a-72c2-d3e69574288e@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tMon, 25 Sep 2017 10:07:52 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Yi Min Zhao ,\n\tDavid Hildenbrand ,\n\tPierre Morel ,\n\tAlexander Graf , qemu-devel ,\n\tChristian Borntraeger ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774625,"web_url":"http://patchwork.ozlabs.org/comment/1774625/","msgid":"<20da1950-3aa5-c29f-3d54-4f82289f34f1@de.ibm.com>","list_archive_url":null,"date":"2017-09-25T10:12:49","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/25/2017 12:07 PM, Cornelia Huck wrote:\n> On Fri, 22 Sep 2017 16:27:00 +0200\n> Halil Pasic wrote:\n> \n>> One thing I would find very helpful is what do we expect to work and not\n>> work for which version. Kind of a matrix. For instance should vfio pci\n>> work for versions prior 2.11. I think in the not so distant past we\n>> changed how SIC works (so it complains when we don't have ais).\n> \n> A matrix sounds like a good idea.\n\nI think we do not even need a matrix, a minimum level will suffice because...\n> \n> I don't think we really ever had a setup that worked out of the box\n\nexactly: ...it never worked until 2.10 and we do not have libvirt support yet.\nNow with the fix 2.10 will also not work, so I think its fair to say\n\nPCI passthrough via VFIO will be supported for \n- KVM: host kernel >= 4.13\n- TCG: TBD\n- QEMU >= 2.11\n- libvirt TBD\n\n\n> for a Linux guest prior to 2.10 anyway. For added fun, it also depends\n> on the host kernel. And tcg won't work at all due to the pci\n> instruction not yet being wired up.\n> \n>> Btw nimm/dimm is simm/nimm. And I would really like to hear something\n\nyes, I mixed that up. Too many letters :-)\n\n>> form the original author(s) too.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y10Kc0Gyzz9tX3\n\tfor ;\n\tMon, 25 Sep 2017 20:13:29 +1000 (AEST)","from localhost ([::1]:41590 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwQOE-0001sl-In\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 06:13:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44697)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwQNs-0001sa-Rw\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:13:05 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwQNp-00073x-CY\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:13:04 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:54246)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwQNp-00073N-3O\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:13:01 -0400","from pps.filterd (m0098393.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8PAB2EY106192\n\tfor ; Mon, 25 Sep 2017 06:12:57 -0400","from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d6x8swhru-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 25 Sep 2017 06:12:56 -0400","from localhost\n\tby e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 25 Sep 2017 11:12:54 +0100","from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198)\n\tby e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tMon, 25 Sep 2017 11:12:50 +0100","from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com\n\t[9.149.105.60])\n\tby b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8PACo9717104918; Mon, 25 Sep 2017 10:12:50 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 84B3242042;\n\tMon, 25 Sep 2017 11:08:54 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2F5C342041;\n\tMon, 25 Sep 2017 11:08:54 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.56])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tMon, 25 Sep 2017 11:08:54 +0100 (BST)"],"To":"Cornelia Huck , Halil Pasic ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>\n\t\n\t\n\t<4a31c53b-98aa-747a-1402-1a93e74c565b@de.ibm.com>\n\t<5cdfe359-2e78-7e2a-72c2-d3e69574288e@linux.vnet.ibm.com>\n\t<20170925120745.7326637e.cohuck@redhat.com>","From":"Christian Borntraeger ","Date":"Mon, 25 Sep 2017 12:12:49 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170925120745.7326637e.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17092510-0040-0000-0000-000003FCCA5A","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092510-0041-0000-0000-0000209E104C","Message-Id":"<20da1950-3aa5-c29f-3d54-4f82289f34f1@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-25_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709250159","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Yi Min Zhao ,\n\tDavid Hildenbrand ,\n\tPierre Morel ,\n\tAlexander Graf , qemu-devel ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774666,"web_url":"http://patchwork.ozlabs.org/comment/1774666/","msgid":"<20170925134532.08e9e273.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-25T11:45:32","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Mon, 25 Sep 2017 12:12:49 +0200\nChristian Borntraeger wrote:\n\n> On 09/25/2017 12:07 PM, Cornelia Huck wrote:\n> > On Fri, 22 Sep 2017 16:27:00 +0200\n> > Halil Pasic wrote:\n> > \n> >> One thing I would find very helpful is what do we expect to work and not\n> >> work for which version. Kind of a matrix. For instance should vfio pci\n> >> work for versions prior 2.11. I think in the not so distant past we\n> >> changed how SIC works (so it complains when we don't have ais). \n> > \n> > A matrix sounds like a good idea. \n> \n> I think we do not even need a matrix, a minimum level will suffice because...\n> > \n> > I don't think we really ever had a setup that worked out of the box \n> \n> exactly: ...it never worked until 2.10 and we do not have libvirt support yet.\n> Now with the fix 2.10 will also not work, so I think its fair to say\n> \n> PCI passthrough via VFIO will be supported for \n> - KVM: host kernel >= 4.13\n> - TCG: TBD\n> - QEMU >= 2.11\n> - libvirt TBD\n\nMake that zpci-per-se, no?\n\nwith KVM: host kernel >= 4.13 && QEMU >= 2.11\nwith TCG: tbd, I don't think anybody has time to wire this up for 2.11\n\nApropos libvirt: How will it determine whether zpci should be\nsupported? There are some old QEMU + KVM combinations out there that\nwill have a phb (but not be usable by stock Linux guests as the feature\nbits are missing). Version fence? Check for cpu feature support?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y12Nq3zMXz9tX3\n\tfor ;\n\tMon, 25 Sep 2017 21:46:35 +1000 (AEST)","from localhost ([::1]:41850 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwRqL-00062K-Nt\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 07:46:33 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34693)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwRpY-0005pd-Qy\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:45:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwRpV-00012X-9C\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:45:44 -0400","from mx1.redhat.com ([209.132.183.28]:57816)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwRpV-00012G-1s\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:45:41 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E101E4E4C6;\n\tMon, 25 Sep 2017 11:45:39 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 744C561793;\n\tMon, 25 Sep 2017 11:45:35 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E101E4E4C6","Date":"Mon, 25 Sep 2017 13:45:32 +0200","From":"Cornelia Huck ","To":"Christian Borntraeger ","Message-ID":"<20170925134532.08e9e273.cohuck@redhat.com>","In-Reply-To":"<20da1950-3aa5-c29f-3d54-4f82289f34f1@de.ibm.com>","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>\n\t\n\t\n\t<4a31c53b-98aa-747a-1402-1a93e74c565b@de.ibm.com>\n\t<5cdfe359-2e78-7e2a-72c2-d3e69574288e@linux.vnet.ibm.com>\n\t<20170925120745.7326637e.cohuck@redhat.com>\n\t<20da1950-3aa5-c29f-3d54-4f82289f34f1@de.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 25 Sep 2017 11:45:40 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tDavid Hildenbrand ,\n\tPierre Morel ,\n\tAlexander Graf , qemu-devel ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774669,"web_url":"http://patchwork.ozlabs.org/comment/1774669/","msgid":"<4cbc3c5b-3050-2e4e-f4cd-0c92fdb8e11f@de.ibm.com>","list_archive_url":null,"date":"2017-09-25T11:47:52","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/25/2017 01:45 PM, Cornelia Huck wrote:\n> On Mon, 25 Sep 2017 12:12:49 +0200\n> Christian Borntraeger wrote:\n> \n>> On 09/25/2017 12:07 PM, Cornelia Huck wrote:\n>>> On Fri, 22 Sep 2017 16:27:00 +0200\n>>> Halil Pasic wrote:\n>>> \n>>>> One thing I would find very helpful is what do we expect to work and not\n>>>> work for which version. Kind of a matrix. For instance should vfio pci\n>>>> work for versions prior 2.11. I think in the not so distant past we\n>>>> changed how SIC works (so it complains when we don't have ais). \n>>>\n>>> A matrix sounds like a good idea. \n>>\n>> I think we do not even need a matrix, a minimum level will suffice because...\n>>>\n>>> I don't think we really ever had a setup that worked out of the box \n>>\n>> exactly: ...it never worked until 2.10 and we do not have libvirt support yet.\n>> Now with the fix 2.10 will also not work, so I think its fair to say\n>>\n>> PCI passthrough via VFIO will be supported for \n>> - KVM: host kernel >= 4.13\n>> - TCG: TBD\n>> - QEMU >= 2.11\n>> - libvirt TBD\n> \n> Make that zpci-per-se, no?\n> \n> with KVM: host kernel >= 4.13 && QEMU >= 2.11\n> with TCG: tbd, I don't think anybody has time to wire this up for 2.11\n> \n> Apropos libvirt: How will it determine whether zpci should be\n> supported? There are some old QEMU + KVM combinations out there that\n> will have a phb (but not be usable by stock Linux guests as the feature\n> bits are missing). Version fence? Check for cpu feature support?\n\nI think for multibus or something like that Boris wanted to check for a version\nanyway. So maybe 2.11 (now that 2.10 is broken regarding ais) as a minimum QEMU\nlevel would make sense.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y12RG5nm1z9tX3\n\tfor ;\n\tMon, 25 Sep 2017 21:48:42 +1000 (AEST)","from localhost ([::1]:41852 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwRsO-0006ni-UU\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 07:48:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35080)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwRs2-0006nc-Qt\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:48:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwRrz-00026L-I4\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:48:18 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:39456)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwRrs-000215-UG\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:48:15 -0400","from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8PBhfnV047325\n\tfor ; Mon, 25 Sep 2017 07:48:00 -0400","from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d6wbpq28g-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 25 Sep 2017 07:48:00 -0400","from localhost\n\tby e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 25 Sep 2017 12:47:56 +0100","from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196)\n\tby e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tMon, 25 Sep 2017 12:47:53 +0100","from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60])\n\tby b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8PBlrfX19398754; Mon, 25 Sep 2017 11:47:53 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 8D5F442045;\n\tMon, 25 Sep 2017 12:43:57 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2ADF94203F;\n\tMon, 25 Sep 2017 12:43:57 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.56])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tMon, 25 Sep 2017 12:43:57 +0100 (BST)"],"To":"Cornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>\n\t\n\t\n\t<4a31c53b-98aa-747a-1402-1a93e74c565b@de.ibm.com>\n\t<5cdfe359-2e78-7e2a-72c2-d3e69574288e@linux.vnet.ibm.com>\n\t<20170925120745.7326637e.cohuck@redhat.com>\n\t<20da1950-3aa5-c29f-3d54-4f82289f34f1@de.ibm.com>\n\t<20170925134532.08e9e273.cohuck@redhat.com>","From":"Christian Borntraeger ","Date":"Mon, 25 Sep 2017 13:47:52 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170925134532.08e9e273.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17092511-0040-0000-0000-000003FCD1EC","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092511-0041-0000-0000-0000209E182E","Message-Id":"<4cbc3c5b-3050-2e4e-f4cd-0c92fdb8e11f@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-25_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709250181","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tDavid Hildenbrand ,\n\tPierre Morel ,\n\tAlexander Graf , qemu-devel ,\n\t\"Jason J . Herne\" ,\n\tBoris Fiuczynski ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775291,"web_url":"http://patchwork.ozlabs.org/comment/1775291/","msgid":"","list_archive_url":null,"date":"2017-09-26T09:14:02","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":66807,"url":"http://patchwork.ozlabs.org/api/people/66807/","name":"Yi Min Zhao","email":"zyimin@linux.vnet.ibm.com"},"content":"在 2017/9/25 下午7:47, Christian Borntraeger 写道:\n> On 09/25/2017 01:45 PM, Cornelia Huck wrote:\n>> On Mon, 25 Sep 2017 12:12:49 +0200\n>> Christian Borntraeger wrote:\n>>\n>>> On 09/25/2017 12:07 PM, Cornelia Huck wrote:\n>>>> On Fri, 22 Sep 2017 16:27:00 +0200\n>>>> Halil Pasic wrote:\n>>>> \n>>>>> One thing I would find very helpful is what do we expect to work and not\n>>>>> work for which version. Kind of a matrix. For instance should vfio pci\n>>>>> work for versions prior 2.11. I think in the not so distant past we\n>>>>> changed how SIC works (so it complains when we don't have ais).\n>>>> A matrix sounds like a good idea.\n>>> I think we do not even need a matrix, a minimum level will suffice because...\n>>>> I don't think we really ever had a setup that worked out of the box\n>>> exactly: ...it never worked until 2.10 and we do not have libvirt support yet.\n>>> Now with the fix 2.10 will also not work, so I think its fair to say\n>>>\n>>> PCI passthrough via VFIO will be supported for\n>>> - KVM: host kernel >= 4.13\n>>> - TCG: TBD\n>>> - QEMU >= 2.11\n>>> - libvirt TBD\n>> Make that zpci-per-se, no?\n>>\n>> with KVM: host kernel >= 4.13 && QEMU >= 2.11\n>> with TCG: tbd, I don't think anybody has time to wire this up for 2.11\n>>\n>> Apropos libvirt: How will it determine whether zpci should be\n>> supported? There are some old QEMU + KVM combinations out there that\n>> will have a phb (but not be usable by stock Linux guests as the feature\n>> bits are missing). Version fence? Check for cpu feature support?\n> I think for multibus or something like that Boris wanted to check for a version\n> anyway. So maybe 2.11 (now that 2.10 is broken regarding ais) as a minimum QEMU\n> level would make sense.\n>\n>\nI think this makes sense. But I think I have to discuss this with Boris.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1ZzY65gFz9t6C\n\tfor ;\n\tTue, 26 Sep 2017 19:15:05 +1000 (AEST)","from localhost ([::1]:46315 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwlxH-0001O2-US\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 05:15:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55204)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwlwb-0001E7-IG\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 05:14:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwlwX-0002N6-73\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 05:14:21 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58226\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwlwW-0002LW-Ug\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 05:14:17 -0400","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8Q9DjGD123929\n\tfor ; Tue, 26 Sep 2017 05:14:12 -0400","from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d7e54503j-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 26 Sep 2017 05:14:12 -0400","from localhost\n\tby e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 26 Sep 2017 05:14:11 -0400","from b01cxnp23032.gho.pok.ibm.com (9.57.198.27)\n\tby e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tTue, 26 Sep 2017 05:14:08 -0400","from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com\n\t[9.57.199.110])\n\tby b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v8Q9E8QC28573808; Tue, 26 Sep 2017 09:14:08 GMT","from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 6301FAE034;\n\tTue, 26 Sep 2017 05:14:41 -0400 (EDT)","from zyimindembp.cn.ibm.com (unknown [9.115.193.51])\n\tby b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP id 069A6AE04B;\n\tTue, 26 Sep 2017 05:14:37 -0400 (EDT)"],"To":"Christian Borntraeger ,\n\tCornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>\n\t\n\t\n\t<4a31c53b-98aa-747a-1402-1a93e74c565b@de.ibm.com>\n\t<5cdfe359-2e78-7e2a-72c2-d3e69574288e@linux.vnet.ibm.com>\n\t<20170925120745.7326637e.cohuck@redhat.com>\n\t<20da1950-3aa5-c29f-3d54-4f82289f34f1@de.ibm.com>\n\t<20170925134532.08e9e273.cohuck@redhat.com>\n\t<4cbc3c5b-3050-2e4e-f4cd-0c92fdb8e11f@de.ibm.com>","From":"Yi Min Zhao ","Date":"Tue, 26 Sep 2017 17:14:02 +0800","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<4cbc3c5b-3050-2e4e-f4cd-0c92fdb8e11f@de.ibm.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","X-TM-AS-GCONF":"00","x-cbid":"17092609-0024-0000-0000-000002D849AA","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007794; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000231; SDB=6.00922551; UDB=6.00463703;\n\tIPR=6.00702693; \n\tBA=6.00005607; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017279;\n\tXFM=3.00000015; UTC=2017-09-26 09:14:10","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092609-0025-0000-0000-0000458B655D","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-26_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709260139","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v8Q9DjGD123929","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tDavid Hildenbrand ,\n\tPierre Morel ,\n\tAlexander Graf , qemu-devel ,\n\t\"Jason J . Herne\" ,\n\tBoris Fiuczynski ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775418,"web_url":"http://patchwork.ozlabs.org/comment/1775418/","msgid":"","list_archive_url":null,"date":"2017-09-26T12:23:30","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 22.09.2017 10:38, Christian Borntraeger wrote:\n> Instead of unconditionally enabling the KVM AIS capability\n> in the kvm arch init function, do this in the flic realize function\n> when we know if migration is available. This requires to initialize\n> flic before the CPUs.\n> \n> Signed-off-by: Christian Borntraeger \n> ---\n> hw/intc/s390_flic.c | 11 +++++++++--\n> hw/intc/s390_flic_kvm.c | 8 +++++++-\n> hw/s390x/s390-virtio-ccw.c | 8 ++++++--\n> include/hw/s390x/s390_flic.h | 1 +\n> target/s390x/cpu_models.c | 6 ++++++\n> target/s390x/kvm.c | 8 +-------\n> 6 files changed, 30 insertions(+), 12 deletions(-)\n> \n> diff --git a/hw/intc/s390_flic.c b/hw/intc/s390_flic.c\n> index 6eaf178..08040fe 100644\n> --- a/hw/intc/s390_flic.c\n> +++ b/hw/intc/s390_flic.c\n> @@ -1,7 +1,7 @@\n> /*\n> * QEMU S390x floating interrupt controller (flic)\n> *\n> - * Copyright 2014 IBM Corp.\n> + * Copyright 2014,2017 IBM Corp.\n> * Author(s): Jens Freimann \n> * Cornelia Huck \n> *\n> @@ -49,6 +49,13 @@ void s390_flic_init(void)\n> qdev_init_nofail(dev);\n> }\n> \n> +void s390_flic_enable_ais(void)\n> +{\n> + S390FLICState *fs = s390_get_flic();\n> +\n> + fs->ais_supported = true;\n\nCan we simply replace all ais_supported checks by\ns390_has_feat(S390_FEAT_ADAPTER_INT_SUPPRESSION) and drop ais_supported?\n\nThen, s390_flic_enable_ais() should not be needed.\n\nAs far as I understand, we will unlock kvm_vm_enable_cap(kvm_state,\nKVM_CAP_S390_AIS, 0); only if we have migration support.\n\nTherefore, CPU model init should see S390_FEAT_ADAPTER_INT_SUPPRESSION\nonly if migration support is available.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1g9Z4TXnz9tXf\n\tfor ;\n\tTue, 26 Sep 2017 22:24:01 +1000 (AEST)","from localhost ([::1]:47336 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwou6-0004Bh-Rp\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 08:23:58 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55306)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwotn-0004BR-K6\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:23:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwoti-0007r9-Lh\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:23:39 -0400","from mx1.redhat.com ([209.132.183.28]:62334)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwoti-0007qN-Ea\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:23:34 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9F3BA81DE5;\n\tTue, 26 Sep 2017 12:23:32 +0000 (UTC)","from [10.36.117.152] (ovpn-117-152.ams2.redhat.com [10.36.117.152])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E800C6F12B;\n\tTue, 26 Sep 2017 12:23:30 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9F3BA81DE5","To":"Christian Borntraeger ,\n\tCornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Tue, 26 Sep 2017 14:23:30 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922083855.102341-3-borntraeger@de.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tTue, 26 Sep 2017 12:23:32 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tqemu-devel , Alexander Graf ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775428,"web_url":"http://patchwork.ozlabs.org/comment/1775428/","msgid":"","list_archive_url":null,"date":"2017-09-26T12:29:59","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/26/2017 02:23 PM, David Hildenbrand wrote:\n> On 22.09.2017 10:38, Christian Borntraeger wrote:\n>> Instead of unconditionally enabling the KVM AIS capability\n>> in the kvm arch init function, do this in the flic realize function\n>> when we know if migration is available. This requires to initialize\n>> flic before the CPUs.\n>>\n>> Signed-off-by: Christian Borntraeger \n>> ---\n>> hw/intc/s390_flic.c | 11 +++++++++--\n>> hw/intc/s390_flic_kvm.c | 8 +++++++-\n>> hw/s390x/s390-virtio-ccw.c | 8 ++++++--\n>> include/hw/s390x/s390_flic.h | 1 +\n>> target/s390x/cpu_models.c | 6 ++++++\n>> target/s390x/kvm.c | 8 +-------\n>> 6 files changed, 30 insertions(+), 12 deletions(-)\n>>\n>> diff --git a/hw/intc/s390_flic.c b/hw/intc/s390_flic.c\n>> index 6eaf178..08040fe 100644\n>> --- a/hw/intc/s390_flic.c\n>> +++ b/hw/intc/s390_flic.c\n>> @@ -1,7 +1,7 @@\n>> /*\n>> * QEMU S390x floating interrupt controller (flic)\n>> *\n>> - * Copyright 2014 IBM Corp.\n>> + * Copyright 2014,2017 IBM Corp.\n>> * Author(s): Jens Freimann \n>> * Cornelia Huck \n>> *\n>> @@ -49,6 +49,13 @@ void s390_flic_init(void)\n>> qdev_init_nofail(dev);\n>> }\n>> \n>> +void s390_flic_enable_ais(void)\n>> +{\n>> + S390FLICState *fs = s390_get_flic();\n>> +\n>> + fs->ais_supported = true;\n> \n> Can we simply replace all ais_supported checks by\n> s390_has_feat(S390_FEAT_ADAPTER_INT_SUPPRESSION) and drop ais_supported?\n\nNo, at flic realize, the CPU model is not available yet. And if we move cpumodel\nbefore flic then we cannot check the flic attributes so the CPU will not know if\nais is available or not.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1gKJ62wkz9ryk\n\tfor ;\n\tTue, 26 Sep 2017 22:30:43 +1000 (AEST)","from localhost ([::1]:47360 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwp0Y-00076y-3z\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 08:30:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56752)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwp07-00076n-U9\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:30:17 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwp03-00040K-Tc\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:30:11 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:57311\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwp03-000406-OQ\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:30:07 -0400","from pps.filterd (m0098416.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8QCTFiZ022253\n\tfor ; Tue, 26 Sep 2017 08:30:04 -0400","from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d7p99bbh8-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 26 Sep 2017 08:30:04 -0400","from localhost\n\tby e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 26 Sep 2017 13:30:02 +0100","from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197)\n\tby e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 26 Sep 2017 13:30:00 +0100","from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com\n\t[9.149.105.61])\n\tby b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8QCTxLa16842796; Tue, 26 Sep 2017 12:29:59 GMT","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id A2DA811C050;\n\tTue, 26 Sep 2017 13:25:53 +0100 (BST)","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 64FF011C04C;\n\tTue, 26 Sep 2017 13:25:53 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.56])\n\tby d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tTue, 26 Sep 2017 13:25:53 +0100 (BST)"],"To":"David Hildenbrand , Cornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t","From":"Christian Borntraeger ","Date":"Tue, 26 Sep 2017 14:29:59 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17092612-0040-0000-0000-000003DD300E","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092612-0041-0000-0000-000025DE79F5","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-26_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709260181","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tqemu-devel , Alexander Graf ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775432,"web_url":"http://patchwork.ozlabs.org/comment/1775432/","msgid":"<5e73fb8d-c7da-712b-ab09-711a8aee7f35@redhat.com>","list_archive_url":null,"date":"2017-09-26T12:33:25","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 26.09.2017 14:29, Christian Borntraeger wrote:\n> \n> \n> On 09/26/2017 02:23 PM, David Hildenbrand wrote:\n>> On 22.09.2017 10:38, Christian Borntraeger wrote:\n>>> Instead of unconditionally enabling the KVM AIS capability\n>>> in the kvm arch init function, do this in the flic realize function\n>>> when we know if migration is available. This requires to initialize\n>>> flic before the CPUs.\n>>>\n>>> Signed-off-by: Christian Borntraeger \n>>> ---\n>>> hw/intc/s390_flic.c | 11 +++++++++--\n>>> hw/intc/s390_flic_kvm.c | 8 +++++++-\n>>> hw/s390x/s390-virtio-ccw.c | 8 ++++++--\n>>> include/hw/s390x/s390_flic.h | 1 +\n>>> target/s390x/cpu_models.c | 6 ++++++\n>>> target/s390x/kvm.c | 8 +-------\n>>> 6 files changed, 30 insertions(+), 12 deletions(-)\n>>>\n>>> diff --git a/hw/intc/s390_flic.c b/hw/intc/s390_flic.c\n>>> index 6eaf178..08040fe 100644\n>>> --- a/hw/intc/s390_flic.c\n>>> +++ b/hw/intc/s390_flic.c\n>>> @@ -1,7 +1,7 @@\n>>> /*\n>>> * QEMU S390x floating interrupt controller (flic)\n>>> *\n>>> - * Copyright 2014 IBM Corp.\n>>> + * Copyright 2014,2017 IBM Corp.\n>>> * Author(s): Jens Freimann \n>>> * Cornelia Huck \n>>> *\n>>> @@ -49,6 +49,13 @@ void s390_flic_init(void)\n>>> qdev_init_nofail(dev);\n>>> }\n>>> \n>>> +void s390_flic_enable_ais(void)\n>>> +{\n>>> + S390FLICState *fs = s390_get_flic();\n>>> +\n>>> + fs->ais_supported = true;\n>>\n>> Can we simply replace all ais_supported checks by\n>> s390_has_feat(S390_FEAT_ADAPTER_INT_SUPPRESSION) and drop ais_supported?\n> \n> No, at flic realize, the CPU model is not available yet. And if we move cpumodel\n> before flic then we cannot check the flic attributes so the CPU will not know if\n> ais is available or not.\n> \n\nWe should we need that at realize time?\n\nrealize() simply inits flic and unlocks the CPU feature if\nKVM_HAS_DEVICE_ATTR works.\n\nWhat am I missing?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1gPC74kqz9ryk\n\tfor ;\n\tTue, 26 Sep 2017 22:34:07 +1000 (AEST)","from localhost ([::1]:47368 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwp3u-00004u-4j\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 08:34:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57385)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwp3P-0008SJ-3R\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:33:39 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwp3J-0005ur-GE\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:33:35 -0400","from mx1.redhat.com ([209.132.183.28]:52332)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwp3J-0005uV-AB\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:33:29 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 56A0FC07F98B;\n\tTue, 26 Sep 2017 12:33:28 +0000 (UTC)","from [10.36.117.152] (ovpn-117-152.ams2.redhat.com [10.36.117.152])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A0B0662463;\n\tTue, 26 Sep 2017 12:33:26 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 56A0FC07F98B","To":"Christian Borntraeger ,\n\tCornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t\n\t","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<5e73fb8d-c7da-712b-ab09-711a8aee7f35@redhat.com>","Date":"Tue, 26 Sep 2017 14:33:25 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 26 Sep 2017 12:33:28 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tqemu-devel , Alexander Graf ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775433,"web_url":"http://patchwork.ozlabs.org/comment/1775433/","msgid":"","list_archive_url":null,"date":"2017-09-26T12:33:28","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/26/2017 02:29 PM, Christian Borntraeger wrote:\n> \n> \n> On 09/26/2017 02:23 PM, David Hildenbrand wrote:\n>> On 22.09.2017 10:38, Christian Borntraeger wrote:\n>>> Instead of unconditionally enabling the KVM AIS capability\n>>> in the kvm arch init function, do this in the flic realize function\n>>> when we know if migration is available. This requires to initialize\n>>> flic before the CPUs.\n>>>\n>>> Signed-off-by: Christian Borntraeger \n>>> ---\n>>> hw/intc/s390_flic.c | 11 +++++++++--\n>>> hw/intc/s390_flic_kvm.c | 8 +++++++-\n>>> hw/s390x/s390-virtio-ccw.c | 8 ++++++--\n>>> include/hw/s390x/s390_flic.h | 1 +\n>>> target/s390x/cpu_models.c | 6 ++++++\n>>> target/s390x/kvm.c | 8 +-------\n>>> 6 files changed, 30 insertions(+), 12 deletions(-)\n>>>\n>>> diff --git a/hw/intc/s390_flic.c b/hw/intc/s390_flic.c\n>>> index 6eaf178..08040fe 100644\n>>> --- a/hw/intc/s390_flic.c\n>>> +++ b/hw/intc/s390_flic.c\n>>> @@ -1,7 +1,7 @@\n>>> /*\n>>> * QEMU S390x floating interrupt controller (flic)\n>>> *\n>>> - * Copyright 2014 IBM Corp.\n>>> + * Copyright 2014,2017 IBM Corp.\n>>> * Author(s): Jens Freimann \n>>> * Cornelia Huck \n>>> *\n>>> @@ -49,6 +49,13 @@ void s390_flic_init(void)\n>>> qdev_init_nofail(dev);\n>>> }\n>>> \n>>> +void s390_flic_enable_ais(void)\n>>> +{\n>>> + S390FLICState *fs = s390_get_flic();\n>>> +\n>>> + fs->ais_supported = true;\n>>\n>> Can we simply replace all ais_supported checks by\n>> s390_has_feat(S390_FEAT_ADAPTER_INT_SUPPRESSION) and drop ais_supported?\n> \n> No, at flic realize, the CPU model is not available yet. And if we move cpumodel\n> before flic then we cannot check the flic attributes so the CPU will not know if\n> ais is available or not.\n\nHmm, let me check again. maybe we do not need that information at realize time. So yes,\nit could work out.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1gQW5wPPz9s83\n\tfor ;\n\tTue, 26 Sep 2017 22:35:15 +1000 (AEST)","from localhost ([::1]:47370 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwp4z-0000oC-UG\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 08:35:13 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57443)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwp3h-0000BO-1Y\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:33:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwp3b-00063F-0C\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:33:53 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:46356\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwp3a-00062q-PX\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:33:46 -0400","from pps.filterd (m0098413.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8QCXfiS048458\n\tfor ; Tue, 26 Sep 2017 08:33:42 -0400","from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d7p8v3k20-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 26 Sep 2017 08:33:42 -0400","from localhost\n\tby e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 26 Sep 2017 13:33:32 +0100","from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197)\n\tby e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 26 Sep 2017 13:33:29 +0100","from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com\n\t[9.149.105.61])\n\tby b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8QCXT9s18415622; Tue, 26 Sep 2017 12:33:29 GMT","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3C3C311C058;\n\tTue, 26 Sep 2017 13:29:23 +0100 (BST)","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id F31D811C050;\n\tTue, 26 Sep 2017 13:29:22 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.56])\n\tby d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tTue, 26 Sep 2017 13:29:22 +0100 (BST)"],"From":"Christian Borntraeger ","To":"David Hildenbrand , Cornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t\n\t","Date":"Tue, 26 Sep 2017 14:33:28 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17092612-0040-0000-0000-000003DD3052","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092612-0041-0000-0000-000025DE7A3F","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-26_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709260183","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tqemu-devel , Alexander Graf ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775675,"web_url":"http://patchwork.ozlabs.org/comment/1775675/","msgid":"","list_archive_url":null,"date":"2017-09-26T13:04:23","subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":72446,"url":"http://patchwork.ozlabs.org/api/people/72446/","name":"Boris Fiuczynski","email":"fiuczy@linux.vnet.ibm.com"},"content":"On 09/26/2017 11:14 AM, Yi Min Zhao wrote:\n> \n> \n> 在 2017/9/25 下午7:47, Christian Borntraeger 写道:\n>> On 09/25/2017 01:45 PM, Cornelia Huck wrote:\n>>> On Mon, 25 Sep 2017 12:12:49 +0200\n>>> Christian Borntraeger wrote:\n>>>\n>>>> On 09/25/2017 12:07 PM, Cornelia Huck wrote:\n>>>>> On Fri, 22 Sep 2017 16:27:00 +0200\n>>>>> Halil Pasic wrote:\n>>>>>> One thing I would find very helpful is what do we expect to work \n>>>>>> and not\n>>>>>> work for which version. Kind of a matrix. For instance should vfio \n>>>>>> pci\n>>>>>> work for versions prior 2.11. I think in the not so distant past we\n>>>>>> changed how SIC works (so it complains when we don't have ais).\n>>>>> A matrix sounds like a good idea.\n>>>> I think we do not even need a matrix, a minimum level will suffice \n>>>> because...\n>>>>> I don't think we really ever had a setup that worked out of the box\n>>>> exactly: ...it never worked until 2.10 and we do not have libvirt \n>>>> support yet.\n>>>> Now with the fix 2.10 will also not work, so I think its fair to say\n>>>>\n>>>> PCI passthrough via VFIO will be supported for\n>>>> - KVM: host kernel >= 4.13\n>>>> - TCG: TBD\n>>>> - QEMU >= 2.11\n>>>> - libvirt TBD\n>>> Make that zpci-per-se, no?\n>>>\n>>> with KVM: host kernel >= 4.13 && QEMU >= 2.11\n>>> with TCG: tbd, I don't think anybody has time to wire this up for 2.11\n>>>\n>>> Apropos libvirt: How will it determine whether zpci should be\n>>> supported? There are some old QEMU + KVM combinations out there that\n>>> will have a phb (but not be usable by stock Linux guests as the feature\n>>> bits are missing). Version fence? Check for cpu feature support?\n>> I think for multibus or something like that Boris wanted to check for \n>> a version\n>> anyway. So maybe 2.11 (now that 2.10 is broken regarding ais) as a \n>> minimum QEMU\n>> level would make sense.\n>>\n>>\n> I think this makes sense. But I think I have to discuss this with Boris.\nIn libvirt multibus is one of the few (very old) supports that would \nallow checking against a qemu version.\nDetection of zpci support is another matter since that capability is \ntied to the existence of the zpci object in qom. Tying the zpci \ncapability to the multibus support has its pro and cons. I have not made \nup my mind yet.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1mzT1DMhz9t3F\n\tfor ;\n\tWed, 27 Sep 2017 02:45:40 +1000 (AEST)","from localhost ([::1]:50292 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwszJ-00013D-AP\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 12:45:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39108)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwpXV-0003ZF-77\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:04:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwpXQ-0006ZX-6R\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:04:41 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:55184\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwpXQ-0006Y4-0P\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:04:36 -0400","from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8QCxOuL098922\n\tfor ; Tue, 26 Sep 2017 09:04:30 -0400","from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d7puvjp5p-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 26 Sep 2017 09:04:29 -0400","from localhost\n\tby e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 26 Sep 2017 14:04:27 +0100","from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)\n\tby e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 26 Sep 2017 14:04:24 +0100","from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com\n\t[9.149.105.62])\n\tby b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8QD4OOx22675462; Tue, 26 Sep 2017 13:04:24 GMT","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 32804AE045;\n\tTue, 26 Sep 2017 13:59:07 +0100 (BST)","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id CD565AE058;\n\tTue, 26 Sep 2017 13:59:06 +0100 (BST)","from [10.0.2.15] (unknown [9.152.222.69])\n\tby d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tTue, 26 Sep 2017 13:59:06 +0100 (BST)"],"To":"Yi Min Zhao ,\n\tChristian Borntraeger ,\n\tCornelia Huck ","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>\n\t<20170922083855.102341-3-borntraeger@de.ibm.com>\n\t<5e7ba7d5-82d4-f1e6-532a-37c2c445c227@linux.vnet.ibm.com>\n\t\n\t\n\t<4a31c53b-98aa-747a-1402-1a93e74c565b@de.ibm.com>\n\t<5cdfe359-2e78-7e2a-72c2-d3e69574288e@linux.vnet.ibm.com>\n\t<20170925120745.7326637e.cohuck@redhat.com>\n\t<20da1950-3aa5-c29f-3d54-4f82289f34f1@de.ibm.com>\n\t<20170925134532.08e9e273.cohuck@redhat.com>\n\t<4cbc3c5b-3050-2e4e-f4cd-0c92fdb8e11f@de.ibm.com>\n\t","From":"Boris Fiuczynski ","Date":"Tue, 26 Sep 2017 15:04:23 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17092613-0040-0000-0000-000003DD33A8","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092613-0041-0000-0000-000025DE7DBE","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-26_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709260189","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0b-001b2d01.pphosted.com id v8QCxOuL098922","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","X-Mailman-Approved-At":"Tue, 26 Sep 2017 12:45:01 -0400","Subject":"Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tDavid Hildenbrand ,\n\tPierre Morel ,\n\tAlexander Graf , qemu-devel ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]