[{"id":1774046,"web_url":"http://patchwork.ozlabs.org/comment/1774046/","msgid":"<83d6bda6-ec28-31bb-5594-4d7e95a3cd72@gmail.com>","list_archive_url":null,"date":"2017-09-23T17:01:25","subject":"Re: [PATCH net-next v2 2/6] rtnetlink: add helper to put master\n\tifindex","submitter":{"id":6918,"url":"http://patchwork.ozlabs.org/api/people/6918/","name":"David Ahern","email":"dsahern@gmail.com"},"content":"On 9/22/17 12:10 AM, Florian Westphal wrote:\n> rtnl_fill_ifinfo currently requires caller to hold the rtnl mutex.\n> Unfortunately the function is quite large which makes it harder to see\n> which spots need the lock, which spots assume it and which ones could do\n> without.\n> \n> Add helpers to factor out the ifindex dumping.\n> \n> One helper can use rcu to remove rtnl dependency.\n> \n> Signed-off-by: Florian Westphal \n> ---\n> net/core/rtnetlink.c | 32 +++++++++++++++++++++++++++-----\n> 1 file changed, 27 insertions(+), 5 deletions(-)\n\nReviewed-by: David Ahern ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QRjmouy2\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzxT71NC6z9tX4\n\tfor ;\n\tSun, 24 Sep 2017 03:01:31 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751409AbdIWRB2 (ORCPT );\n\tSat, 23 Sep 2017 13:01:28 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:37513 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750778AbdIWRB1 (ORCPT\n\t); Sat, 23 Sep 2017 13:01:27 -0400","by mail-pg0-f68.google.com with SMTP id v5so2444096pgn.4\n\tfor ; Sat, 23 Sep 2017 10:01:27 -0700 (PDT)","from dsa-mb.local ([2601:282:800:7292:34fb:fcb:e9c2:fef8])\n\tby smtp.googlemail.com with ESMTPSA id\n\tj14sm4361749pff.59.2017.09.23.10.01.25\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 23 Sep 2017 10:01:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=tR7UW+LFux1ZrwpmyYQAdyomQW1EIceWphutT9dk70A=;\n\tb=QRjmouy28tJ4OHGoNiW33ypjfA/uOYfixyr/w/dHTeVqYW8Lg2dC3eKKry2hnIl2Ue\n\tSZs2QR/K6vm/QwgYRLqJ8+Eb1jGgcYGC/0o8vj9UPTyYUmf5GK9As6uN3OLGZXkyGOGB\n\tnQgJYf2yaimx+dTuF78x5NKk/l3xRgMGCUk6BS1xPcf8yaX+lj4WV7LnAvL2SLwuUOG/\n\tlIVIuFchfB8fKuTRslH2kOpb1WWUMkkLSsPrbCry49Vf4EynWK1I1pDtH59egQf3mXfh\n\tjb9PTxQtQWG8ufuCrAac9rbc0q/inVIHfjKfmcD1MFyo4r1q7DzKwVyYMIE8JFDnMrk/\n\tBneg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=tR7UW+LFux1ZrwpmyYQAdyomQW1EIceWphutT9dk70A=;\n\tb=kswJNJ+Xw2i2JEE3OPdK3YUtsAwnc45FzC/61PtzvS5DTMv0VqkcwsSV9wSD/NsA6d\n\tThdZsnayPqfaHWCmSpEKMiXiFLx4c+aD7aiCk6lEv/tluH742Egsbj170jhZVUzMwyPE\n\tF8aM4ZDUOM5ycRINXNUaQbgvwPKIITh/fT048W2Q6hjRcjfdyrGTUQ/IbT1W1A1wBFbk\n\tcL0+jxoVPvUd7PbMk31V9xVN8rdYanWViYV8YMWFY6EZ5Mz8W8l1vmIBDwXdq/v5qUW3\n\tIpvgu3QIxWE8X05QqbZrEPrzY3nh6lkkcVso+5MxJB96q+RWevWs4WN+Jwi80mLqg8pF\n\tCiuw==","X-Gm-Message-State":"AHPjjUjAE2mXyVWbDtu0ycTSFPYWIl8X9bytAW7vdWuFW5C5eMAdc5Lk\n\thbPR6VT3IAzNXk8q6rHY2cBQEA==","X-Google-Smtp-Source":"AOwi7QDWVgYQmPo1WlyPcCicwyovaPDFoY1vJmjez2nEuU/9qJx6iX7oTE9Xb06AEw4vYf6MEyf76Q==","X-Received":"by 10.99.164.18 with SMTP id c18mr2571998pgf.359.1506186087015; \n\tSat, 23 Sep 2017 10:01:27 -0700 (PDT)","Subject":"Re: [PATCH net-next v2 2/6] rtnetlink: add helper to put master\n\tifindex","To":"Florian Westphal , netdev@vger.kernel.org","References":"<20170922061008.14723-1-fw@strlen.de>\n\t<20170922061008.14723-3-fw@strlen.de>","From":"David Ahern ","Message-ID":"<83d6bda6-ec28-31bb-5594-4d7e95a3cd72@gmail.com>","Date":"Sat, 23 Sep 2017 11:01:25 -0600","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922061008.14723-3-fw@strlen.de>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]