[{"id":1774045,"web_url":"http://patchwork.ozlabs.org/comment/1774045/","msgid":"<36e9825d-0c74-55fc-c4ce-6afefc6518be@gmail.com>","list_archive_url":null,"date":"2017-09-23T16:59:16","subject":"Re: [PATCH net-next v2 1/6] selftests: rtnetlink.sh: add rudimentary\n\tvrf test","submitter":{"id":6918,"url":"http://patchwork.ozlabs.org/api/people/6918/","name":"David Ahern","email":"dsahern@gmail.com"},"content":"On 9/22/17 12:10 AM, Florian Westphal wrote:\n> Cc: David Ahern \n> Signed-off-by: Florian Westphal \n> ---\n> tools/testing/selftests/net/rtnetlink.sh | 42 ++++++++++++++++++++++++++++++++\n> 1 file changed, 42 insertions(+)\n\nAcked-by: David Ahern ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"eUeXhYU3\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzxQd5Hkxz9sCZ\n\tfor ;\n\tSun, 24 Sep 2017 02:59:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751776AbdIWQ7T (ORCPT );\n\tSat, 23 Sep 2017 12:59:19 -0400","from mail-pf0-f180.google.com ([209.85.192.180]:52354 \"EHLO\n\tmail-pf0-f180.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751462AbdIWQ7S (ORCPT\n\t); Sat, 23 Sep 2017 12:59:18 -0400","by mail-pf0-f180.google.com with SMTP id p87so1911536pfj.9\n\tfor ; Sat, 23 Sep 2017 09:59:18 -0700 (PDT)","from dsa-mb.local ([2601:282:800:7292:34fb:fcb:e9c2:fef8])\n\tby smtp.googlemail.com with ESMTPSA id\n\tp20sm5051927pfl.124.2017.09.23.09.59.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 23 Sep 2017 09:59:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=36CV5gmKbTsZzphwTGFSUyUZQqrcmS4u0hctTk3ZaEI=;\n\tb=eUeXhYU3PgJ/fmfRCESwglhYJyAHZQ6g/+eHG3F79spbS8BE4+6rNhC/fiEMvbX7e9\n\t4Q7Fqw5Dh7TRrXXFAKkRkFJqFMMomHmZukhmqrNu5uQUFRIaqsunKmR7QXquUeqA6M4E\n\t/uiKdg7QqkoC8X7lZixiZWqMdlASkfFZETqWgmMT8z8zz/VoqMME3cvpz/5FkTXrpvtM\n\tFJbClBNJT/6gLO6ltZa1G8k2w4fxtPY3GdvqVR8y/lTjjSN5y17RLob1I+jmFnGGSenO\n\thQpYmkjUM8yDfJACqU/pwdGRmD6FruysVDRgSLjSNCf0zhq4bzMjo+PvBFnaIZEYw0Y0\n\tPvHg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=36CV5gmKbTsZzphwTGFSUyUZQqrcmS4u0hctTk3ZaEI=;\n\tb=GEHKj+Kj3Yv2/i8GOBniikergUXdTIR5DAEB6ZFJzS6SXD6oQwDM4/7Ai1W7bDdCcz\n\t4P7FzECXpeFtTzcr+ufzmqD5fbQD1pksBcoqvuMeeXeRas9ailPKUOEtCdteuYVGmO0a\n\tb0CrfTZq3qwLwy+/6aCTef1jBLY2qcDBfoonQTqX7MImIVVUu7Ok4Lq4tM1I6n+81bZ/\n\tx4ypGdIswwEXHHXESQq3ggsq/rU7htHWEArlFUgtuvD4PtvO6NWSVOmG6y2tBbHoWwA+\n\tApK4XqdX74B/U6pxePb8rz89WKQZ8KU29lUDcmBPiOJmZ2DX4dUax5srRFl9BPGA2RRI\n\tc0+g==","X-Gm-Message-State":"AHPjjUjj9ZS1bPNmoooZ+A+vhibj2VLqfYeJTqL4JdMyf6LJplX4r4tK\n\ti8xO4vdGf7zHdueQFUAGpvY=","X-Google-Smtp-Source":"AOwi7QCF7Cie4Q4peXDnRmgTb17PNho+vCjROY8P5b7mED4DLRV/6LFG/VL8pay8Z9kd5ZB2eehusA==","X-Received":"by 10.84.133.111 with SMTP id 102mr2677086plf.204.1506185958122; \n\tSat, 23 Sep 2017 09:59:18 -0700 (PDT)","Subject":"Re: [PATCH net-next v2 1/6] selftests: rtnetlink.sh: add rudimentary\n\tvrf test","To":"Florian Westphal , netdev@vger.kernel.org","Cc":"David Ahern ","References":"<20170922061008.14723-1-fw@strlen.de>\n\t<20170922061008.14723-2-fw@strlen.de>","From":"David Ahern ","Message-ID":"<36e9825d-0c74-55fc-c4ce-6afefc6518be@gmail.com>","Date":"Sat, 23 Sep 2017 10:59:16 -0600","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922061008.14723-2-fw@strlen.de>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1774052,"web_url":"http://patchwork.ozlabs.org/comment/1774052/","msgid":"","list_archive_url":null,"date":"2017-09-23T17:07:58","subject":"Re: [PATCH net-next v2 1/6] selftests: rtnetlink.sh: add rudimentary\n\tvrf test","submitter":{"id":6918,"url":"http://patchwork.ozlabs.org/api/people/6918/","name":"David Ahern","email":"dsahern@gmail.com"},"content":"On 9/22/17 12:10 AM, Florian Westphal wrote:\n> +kci_test_vrf()\n> +{\n> +\tvrfname=\"test-vrf\"\n> +\tret=0\n> +\n> +\tip link show type vrf 2>/dev/null\n> +\tif [ $? -ne 0 ]; then\n> +\t\techo \"SKIP: vrf: iproute2 too old\"\n> +\t\treturn 0\n> +\tfi\n> +\n> +\tip link add \"$vrfname\" type vrf table 10\n> +\tcheck_err $?\n> +\tif [ $ret -ne 0 ];then\n> +\t\techo \"FAIL: can't add vrf interface, skipping test\"\n> +\t\treturn 0\n> +\tfi\n> +\n> +\tip -br link show type vrf | grep -q \"$vrfname\"\n> +\tcheck_err $?\n> +\tif [ $ret -ne 0 ];then\n> +\t\techo \"FAIL: created vrf device not found\"\n> +\t\treturn 1\n> +\tfi\n> +\n> + ip link set dev \"$vrfname\" up\n\nBTW, if there is a v3 of this set, that ip command is shifted - uses\nspaces instead of tab.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QhkndlyX\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzxcg3mC7z9tX4\n\tfor ;\n\tSun, 24 Sep 2017 03:08:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751465AbdIWRIB (ORCPT );\n\tSat, 23 Sep 2017 13:08:01 -0400","from mail-pf0-f179.google.com ([209.85.192.179]:45708 \"EHLO\n\tmail-pf0-f179.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750778AbdIWRIA (ORCPT\n\t); Sat, 23 Sep 2017 13:08:00 -0400","by mail-pf0-f179.google.com with SMTP id z84so1924586pfi.2\n\tfor ; Sat, 23 Sep 2017 10:08:00 -0700 (PDT)","from dsa-mb.local ([2601:282:800:7292:34fb:fcb:e9c2:fef8])\n\tby smtp.googlemail.com with ESMTPSA id\n\tm24sm4956526pfj.28.2017.09.23.10.07.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 23 Sep 2017 10:07:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=2LbZxjt/4tdeWnl8BsMH+IiDEWPhC9KcFAeH4fhQxpg=;\n\tb=QhkndlyXKs1o/MKCerlpzRkeLUMFPuulyn2igBJHTq8/kyXyegrCGW7nakUBE+P9LS\n\tuRD6sEN4f6Cvf/Z1UN5dZcMhLTJzrn01nw+kpsqPGI6Syps6OMd1mkAKeKakY9epCsd9\n\t/lAL8JyJIiw23aJhokyZlmwegbV7zIwm+ybmVxbiFZJp0YcVWSBetyHQKlR+62jcaqMj\n\tBD5NxMB+9GxACZ8Qq59NIq/cl4QRoNRHJG+csLxATmxmVMsTk31taVb/KBYY4aW7bfmn\n\tMefLSpK9jWSlsoDPJt1sblLuuNeXeSwKvmVwwdIsPjAEvHm7zQb4XvZ7V95fjPsJs50u\n\toBrw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=2LbZxjt/4tdeWnl8BsMH+IiDEWPhC9KcFAeH4fhQxpg=;\n\tb=oPvJjYrovmzGTg/mNHLp3bfwsXos38s8Cgv7yR6eZTRUspOhDvQv79BG6IjeDCfGUe\n\ti8B9sN7PUw5NZx9NoxUXw3lMa59scAT+gjY+dh1Pcs1VZwMQ9fyrgzt/L6rR1N61KBQM\n\t1qzvWb1dLCzrfUAZr7KeWh3u+j6conSDaymQlYDm/Tg7I1X4ceGVkoyuulKYjbsPxEMs\n\tBXdPJXpcPjC0LbIa7MtsX8KSDQ+34J0UAaPJWmtpVNmSTkFPAs8EkfobwqrIsVBBwwQK\n\t/SilkeRYw7ms2dBFvskbJgySJJTKGwkqLhbrv0uQIdunuvfGISsegSIRCMgBKprtLlpz\n\tGVVQ==","X-Gm-Message-State":"AHPjjUiEoOrkY19oTbhyNrWSN3DA3DpH7P7onFCUQT98gdOwA9GC9kiL\n\tiCwm+lCp6Q+Ct+tObNjEiuaz/A==","X-Google-Smtp-Source":"AOwi7QD75yHxlNfzF2JBiXWtOEpgFXo8ijlcEzKykiznTjn0FdxP8yovrco1X7IA/u/5QbGhhn49cA==","X-Received":"by 10.99.191.75 with SMTP id i11mr2650626pgo.136.1506186479401; \n\tSat, 23 Sep 2017 10:07:59 -0700 (PDT)","Subject":"Re: [PATCH net-next v2 1/6] selftests: rtnetlink.sh: add rudimentary\n\tvrf test","To":"Florian Westphal , netdev@vger.kernel.org","References":"<20170922061008.14723-1-fw@strlen.de>\n\t<20170922061008.14723-2-fw@strlen.de>","From":"David Ahern ","Message-ID":"","Date":"Sat, 23 Sep 2017 11:07:58 -0600","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922061008.14723-2-fw@strlen.de>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]