[{"id":1774573,"web_url":"http://patchwork.ozlabs.org/comment/1774573/","msgid":"<063D6719AE5E284EB5DD2968C1650D6DD007F112@AcuExch.aculab.com>","date":"2017-09-25T09:30:28","subject":"RE: [PATCH v2 3/3] powerpc:selftest update memcmp_64 selftest for\n\tVMX implementation","submitter":{"id":6689,"url":"http://patchwork.ozlabs.org/api/people/6689/","name":"David Laight","email":"David.Laight@ACULAB.COM"},"content":"From: wei.guo.simon@gmail.com\n> Sent: 21 September 2017 00:35\n> This patch adjust selftest memcmp_64 so that memcmp selftest can be\n> compiled successfully.\n...\n> #define ITERATIONS 10000\n> \n> +#define LARGE_SIZE (5 * 1024)\n> +#define LARGE_ITERATIONS 1000\n...\n\nMeasuring performance by doing a lot of iterations isn't ideal\nand is pretty pointless.\nCold cache performance can be more useful.\nAlso you don't really want any dynamic branch prediction logic\ntuned to the exact test you keep doing.\n\n\tDavid","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0zP80Rn3z9sPr\n\tfor ;\n\tMon, 25 Sep 2017 19:31:40 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3y0zP76jjyzDsPl\n\tfor ;\n\tMon, 25 Sep 2017 19:31:39 +1000 (AEST)","from smtp-out4.electric.net (smtp-out4.electric.net\n\t[192.162.216.181])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3y0zMy1qqmzDr4N\n\tfor ;\n\tMon, 25 Sep 2017 19:30:34 +1000 (AEST)","from 1dwPie-0001QY-TZ by out4b.electric.net with emc1-ok (Exim\n\t4.87) (envelope-from )\n\tid 1dwPif-0001XF-TN; Mon, 25 Sep 2017 02:30:29 -0700","by emcmailer; Mon, 25 Sep 2017 02:30:29 -0700","from [156.67.243.126] (helo=AcuExch.aculab.com)\n\tby out4b.electric.net with esmtps (TLSv1:AES128-SHA:128) (Exim 4.87)\n\t(envelope-from )\n\tid 1dwPie-0001QY-TZ; Mon, 25 Sep 2017 02:30:28 -0700","from ACUEXCH.Aculab.com ([::1]) by AcuExch.aculab.com ([::1]) with\n\tmapi id 14.03.0123.003; Mon, 25 Sep 2017 10:30:29 +0100"],"Authentication-Results":"ozlabs.org;\n\tspf=softfail (mailfrom) smtp.mailfrom=aculab.com\n\t(client-ip=192.162.216.181; helo=smtp-out4.electric.net;\n\tenvelope-from=david.laight@aculab.com; receiver=)","From":"David Laight ","To":"\"'wei.guo.simon@gmail.com'\" ,\n\t\"linuxppc-dev@lists.ozlabs.org\" ","Subject":"RE: [PATCH v2 3/3] powerpc:selftest update memcmp_64 selftest for\n\tVMX implementation","Thread-Topic":"[PATCH v2 3/3] powerpc:selftest update memcmp_64 selftest for\n\tVMX implementation","Thread-Index":"AQHTM2UZaoZOqUTgfUOyn8+R0Sce6qLFWRmw","Date":"Mon, 25 Sep 2017 09:30:28 +0000","Message-ID":"<063D6719AE5E284EB5DD2968C1650D6DD007F112@AcuExch.aculab.com>","References":"<1505950480-14830-1-git-send-email-wei.guo.simon@gmail.com>\n\t<1505950480-14830-4-git-send-email-wei.guo.simon@gmail.com>","In-Reply-To":"<1505950480-14830-4-git-send-email-wei.guo.simon@gmail.com>","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.202.99.200]","Content-Type":"text/plain; charset=\"Windows-1252\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Outbound-IP":"156.67.243.126","X-Env-From":"David.Laight@ACULAB.COM","X-Proto":"esmtps","X-Revdns":"","X-HELO":"AcuExch.aculab.com","X-TLS":"TLSv1:AES128-SHA:128","X-Authenticated_ID":"","X-PolicySMART":"3396946, 3397078","X-Virus-Status":["Scanned by VirusSMART (c)","Scanned by VirusSMART (s)"],"X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"Naveen N. Rao\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1774687,"web_url":"http://patchwork.ozlabs.org/comment/1774687/","msgid":"<20170924061922.GB10899@simonLocalRHEL7.x64>","date":"2017-09-24T06:19:22","subject":"Re: [PATCH v2 3/3] powerpc:selftest update memcmp_64 selftest for\n\tVMX implementation","submitter":{"id":68632,"url":"http://patchwork.ozlabs.org/api/people/68632/","name":"Simon Guo","email":"wei.guo.simon@gmail.com"},"content":"Hi David,\nOn Mon, Sep 25, 2017 at 09:30:28AM +0000, David Laight wrote:\n> From: wei.guo.simon@gmail.com\n> > Sent: 21 September 2017 00:35\n> > This patch adjust selftest memcmp_64 so that memcmp selftest can be\n> > compiled successfully.\n> ...\n> > #define ITERATIONS 10000\n> > \n> > +#define LARGE_SIZE (5 * 1024)\n> > +#define LARGE_ITERATIONS 1000\n> ...\n> \n> Measuring performance by doing a lot of iterations isn't ideal\n> and is pretty pointless.\n> Cold cache performance can be more useful.\n> Also you don't really want any dynamic branch prediction logic\n> tuned to the exact test you keep doing.\n\nI think the (orignal) selftest aims at full coverage of functionality\ncorrectness, since each iteration generates a new data set by random.\n\nThanks,\n- Simon","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y130T4p0bz9tX3\n\tfor ;\n\tMon, 25 Sep 2017 22:14:01 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3y130T3P7XzDsNS\n\tfor ;\n\tMon, 25 Sep 2017 22:14:01 +1000 (AEST)","from mail-pf0-x22f.google.com (mail-pf0-x22f.google.com\n\t[IPv6:2607:f8b0:400e:c00::22f])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3y12y96Hb7zDsNH\n\tfor ;\n\tMon, 25 Sep 2017 22:12:01 +1000 (AEST)","by mail-pf0-x22f.google.com with SMTP id u12so3689109pfl.4\n\tfor ;\n\tMon, 25 Sep 2017 05:12:01 -0700 (PDT)","from localhost ([218.82.63.235]) by smtp.gmail.com with ESMTPSA id\n\tf2sm11029437pfg.135.2017.09.25.05.11.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 05:11:58 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IwWES2tj\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IwWES2tj\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c00::22f; helo=mail-pf0-x22f.google.com;\n\tenvelope-from=wei.guo.simon@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IwWES2tj\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=kIlVSLbRowpK+3K8jiIBZyD62/PURayHJUiwYsyBjfM=;\n\tb=IwWES2tjkEtpvMib94m5I3+OPtU3fvFV1eXdfWFiNkbYDruCfeZownP0/Sbyz0fAB9\n\tb5Q0dVKr6J/IsIWa+rKLLqN8s3+s7ynOYjbm34VOjd3QmO4maLmIXCtRdxQ6p5YvG9Ao\n\tuRG9x02cslsIwGifcXmvYO2vq4Kp0/hKD9BTsJrOrBYbxG1IQI8M1ESHq4fobY24gHz5\n\txEV0CUHj4ZNsaCd6dEgFcIFy7s+ltBrXJD8rJtTPrO+aTP4+QliL89WWA9h/7UEkNQ8r\n\tglW4gTJMo7/lRVlY3d8+KttvZBhh16xAAGf6jq+cDm/Zhnn9QDDWoYKfKqLj3HUexrkO\n\tckZA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=kIlVSLbRowpK+3K8jiIBZyD62/PURayHJUiwYsyBjfM=;\n\tb=kl/lr2cujD6ge+hGtJXqyyixZN2OMjBO711mVoskW3K7XQnMDKm4Uj+BkQqg9GFkyx\n\tVH41wznGbiB0baNBipWQCH+csdIFeoEbw+d4WQxWnS4P2kwSVBZ0eT90mAH78dIzNqsw\n\t1rHLQge8GT1uVHxwtbYdVagV8i6TVuOgpYjgSa60QwZTnL1OZmRT+mCWLtYONceZh6e1\n\tANL8bj/qjPwtETiD5I3wsOsw2L1w2iDxxmHDfJv1LkOO8/cxRBNdSkM4wwQ4R/+arNuS\n\t3/AAg1zdM6Oc4eY67xY8yRu9SbOwpRKd1kU68gF1HRanfdYvcB0cE9MLtrZRe2+DJgYA\n\tpMRg==","X-Gm-Message-State":"AHPjjUgjerEyAcmrCUYJZabnziRke1T/IRKFjYAYvz0rB2TPaiOgOLIl\n\tXIBNAUjIXg2q4N25Q1j/VqM=","X-Google-Smtp-Source":"AOwi7QBzn1Mm5r7i5YwgBm77j4BLRj6blE59Be89nnnGoXK1Y+GzJkO4eVw/Moi/4z+ct+eYIZkvgg==","X-Received":"by 10.159.208.5 with SMTP id a5mr372603plp.436.1506341519079;\n\tMon, 25 Sep 2017 05:11:59 -0700 (PDT)","Date":"Sun, 24 Sep 2017 14:19:22 +0800","From":"Simon Guo ","To":"David Laight ","Subject":"Re: [PATCH v2 3/3] powerpc:selftest update memcmp_64 selftest for\n\tVMX implementation","Message-ID":"<20170924061922.GB10899@simonLocalRHEL7.x64>","References":"<1505950480-14830-1-git-send-email-wei.guo.simon@gmail.com>\n\t<1505950480-14830-4-git-send-email-wei.guo.simon@gmail.com>\n\t<063D6719AE5E284EB5DD2968C1650D6DD007F112@AcuExch.aculab.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<063D6719AE5E284EB5DD2968C1650D6DD007F112@AcuExch.aculab.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"Naveen N. Rao\" ,\n\t\"linuxppc-dev@lists.ozlabs.org\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]