[{"id":1779284,"web_url":"http://patchwork.ozlabs.org/comment/1779284/","msgid":"<20171003215631.rc2jsf2m3qgoltsb@rob-hp-laptop>","list_archive_url":null,"date":"2017-10-03T21:56:31","subject":"Re: [PATCH v2 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Fri, Sep 22, 2017 at 11:00:26AM +0800, Sandy Huang wrote:\n> This path add support rv1108 rgb output interface driver.\n> \n> Signed-off-by: Sandy Huang \n> ---\n> Changes in v2:\n> 1. rename rockchip,rgb-mode to rgb-mode;\n\nYou can't just drop the vendor. This needs to be documented in a common \nplace that others will find and use. See panel-common.txt or \npanel-dpi.txt.\n\nAlternatively, you could just drop it and let the panel compatible imply \nwhat the mode is. \n\n\n> 2. delete reg for signle endpoint;\n> \n> .../bindings/display/rockchip/rockchip-rgb.txt | 78 ++++++++++++++++++++++\n> 1 file changed, 78 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n> \n> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n> new file mode 100644\n> index 0000000..86bd1ce\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n> @@ -0,0 +1,78 @@\n> +Rockchip RV1108 RGB interface\n> +================================\n> +\n> +Required properties:\n> +- compatible: matching the soc type:\n> +\t- \"rockchip,rv1108-rgb\";\n> +\n> +Optional properties:\n> +- pinctrl-names: must contain a \"lcdc\" entry.\n> +- pinctrl-0: pin control group to be used for this interface.\n> +\n> +Required nodes:\n> +- rgb-mode: should be \"p888\", \"p666\", \"p565\", \"s888\", \"s888-dummy\"\n> +\t- p888: output r8-g8-b8 at each dclk cycle for per-pixel\n> +\t- p666: output r6-g6-b6 at each dclk cycle for per-pixel\n> +\t- p565: output r5-g6-b5 at each dclk cycle for per-pixel\n> +\t- s888: output r8-g8-b8 in three dclk cycle for per-pixel\n> +\t- s888-dmmy: output r8-g8-b8-dummy in four dclk cycle for per-pixel\n> +\n> +The rgb has two video ports described by:\n> +\tDocumentation/devicetree/bindings/media/video-interfaces.txt\n> +Their connections are modeled using the OF graph bindings specified in\n> +\tDocumentation/devicetree/bindings/graph.txt.\n> +\n> +- video port 0 for the VOP input, the remote endpoint maybe vopb/vopl/vop\n> +- video port 1 for either a panel or subsequent encoder\n> +\n> +the panel described by:\n> +\tDocumentation/devicetree/bindings/display/panel/simple-panel.txt\n> +Panel other required properties:\n> +- ports for remote rgb output.\n> +\n> +Example:\n> +\n> +panel: panel {\n> +\tcompatible = \"auo,b101ean01\";\n> +\tenable-gpios = <&gpio7 21 GPIO_ACTIVE_HIGH>;\n> +\n> +\tports {\n> +\t\tpanel_in_rgb: endpoint {\n> +\t\t\tremote-endpoint = <&rgb_out_panel>;\n> +\t\t};\n> +\t};\n> +};\n> +\n> +For Rockchip RV1108:\n> +\n> +\trgb: rgb {\n> +\t\tcompatible = \"rockchip,rv1108-rgb\";\n> +\t\tpinctrl-names = \"lcdc\";\n> +\t\tpinctrl-0 = <&lcdc_ctl>;\n> +\t\trgb-mode = \"p888\";\n> +\n> +\t\tports {\n> +\t\t\t#address-cells = <1>;\n> +\t\t\t#size-cells = <0>;\n> +\n> +\t\t\trgb_in: port@0 {\n> +\t\t\t\treg = <0>;\n> +\t\t\t\t#address-cells = <1>;\n> +\t\t\t\t#size-cells = <0>;\n> +\n> +\t\t\t\trgb_in_vop: endpoint {\n> +\t\t\t\t\tremote-endpoint = <&vop_out_rgb>;\n> +\t\t\t\t};\n> +\t\t\t};\n> +\n> +\t\t\trgb_out: port@1 {\n> +\t\t\t\treg = <1>;\n> +\t\t\t\t#address-cells = <1>;\n> +\t\t\t\t#size-cells = <0>;\n> +\n> +\t\t\t\trgb_out_panel: endpoint {\n> +\t\t\t\t\tremote-endpoint = <&panel_in_rgb>;\n> +\t\t\t\t};\n> +\t\t\t};\n> +\t\t};\n> +\t};\n> -- \n> 2.7.4\n> \n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y6CY545LPz9t16\n\tfor ;\n\tWed, 4 Oct 2017 08:56:41 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751393AbdJCV4k (ORCPT\n\t);\n\tTue, 3 Oct 2017 17:56:40 -0400","from mail-oi0-f66.google.com ([209.85.218.66]:45025 \"EHLO\n\tmail-oi0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751132AbdJCV4j (ORCPT\n\t); Tue, 3 Oct 2017 17:56:39 -0400","by mail-oi0-f66.google.com with SMTP id s145so10909527oie.1;\n\tTue, 03 Oct 2017 14:56:38 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\th8sm7742006ote.27.2017.10.03.14.56.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 03 Oct 2017 14:56:37 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=ub2QC18+hk1K0e/klMYX4UBn2o7FUSTDqtGFpWktqtA=;\n\tb=LPLcfr0KQG6H1SE0oe/IzHLk+RIa2qRUmvNUHN2t4s6+EhJgkLagPSi/CBQWi/nt0t\n\tcAi4TF52Qn10r3glpbspPcZnpY9EGnGDRv9Cgxu5cDQKYFZVyZgeNQtintBjNBldYrp1\n\tQA+oxAY8/ZrT19NemA+ylptTn5TVtdsC+eMru6qIEGCWyzaLomSjJ5i8+7n+6o6Fb2I3\n\tOV3cpunm4W3yPwBOW7TK6hPKVErc84+vhi4s0Elh1KJ/5HDZ+G6bkCiMU8PlRzfdmWow\n\txSo5sZyrI44N7XdPbFqCfekM/B73PDWAJ8K6cLwxzNrNAh3l6+29FZSEVkTQ5fy9m3zq\n\t9epg==","X-Gm-Message-State":"AMCzsaWDQU2lNePalABBBCFtVXBCwhI6KOdZiOcrCLF0Eq6XtMAlvUDo\n\tlbPV/1vUxW51H84ONOYOXA==","X-Google-Smtp-Source":"AOwi7QDgrPTfBZcCthQ9qSiqZqrULbAGeuUswgYFhnn5gj/RQ78b0mlTzef19obZ7ipBIryky4FmlA==","X-Received":"by 10.202.90.197 with SMTP id o188mr1558833oib.2.1507067798515; \n\tTue, 03 Oct 2017 14:56:38 -0700 (PDT)","Date":"Tue, 3 Oct 2017 16:56:31 -0500","From":"Rob Herring ","To":"Sandy Huang ","Cc":"Mark Yao , David Airlie ,\n\tMark Rutland , Heiko Stuebner ,\n\tdri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH v2 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","Message-ID":"<20171003215631.rc2jsf2m3qgoltsb@rob-hp-laptop>","References":"<1506049221-117283-1-git-send-email-hjc@rock-chips.com>\n\t<1506049229-117376-1-git-send-email-hjc@rock-chips.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1506049229-117376-1-git-send-email-hjc@rock-chips.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1782583,"web_url":"http://patchwork.ozlabs.org/comment/1782583/","msgid":"<2d502a9d-e952-8afb-d2d7-45c21c36da7e@rock-chips.com>","list_archive_url":null,"date":"2017-10-09T08:06:05","subject":"Re: [PATCH v2 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","submitter":{"id":72133,"url":"http://patchwork.ozlabs.org/api/people/72133/","name":"Huang Jiachai","email":"hjc@rock-chips.com"},"content":"Hi rob,\n Thanks for your reply.\n\n在 2017/10/4 5:56, Rob Herring 写道:\n> On Fri, Sep 22, 2017 at 11:00:26AM +0800, Sandy Huang wrote:\n>> This path add support rv1108 rgb output interface driver.\n>>\n>> Signed-off-by: Sandy Huang \n>> ---\n>> Changes in v2:\n>> 1. rename rockchip,rgb-mode to rgb-mode;\n> \n> You can't just drop the vendor. This needs to be documented in a common\n> place that others will find and use. See panel-common.txt or\n> panel-dpi.txt.\n> \n> Alternatively, you could just drop it and let the panel compatible imply\n> what the mode is.\n> \n> \nok, get it, i will move the rgb-mode to panel and describe it at \npanel-rgb.txt. the patches will be send soon later.\n\n>> 2. delete reg for signle endpoint;\n>>\n>> .../bindings/display/rockchip/rockchip-rgb.txt | 78 ++++++++++++++++++++++\n>> 1 file changed, 78 insertions(+)\n>> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>>\n>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>> new file mode 100644\n>> index 0000000..86bd1ce\n>> --- /dev/null\n>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>> @@ -0,0 +1,78 @@\n>> +Rockchip RV1108 RGB interface\n>> +================================\n>> +\n>> +Required properties:\n>> +- compatible: matching the soc type:\n>> +\t- \"rockchip,rv1108-rgb\";\n>> +\n>> +Optional properties:\n>> +- pinctrl-names: must contain a \"lcdc\" entry.\n>> +- pinctrl-0: pin control group to be used for this interface.\n>> +\n>> +Required nodes:\n>> +- rgb-mode: should be \"p888\", \"p666\", \"p565\", \"s888\", \"s888-dummy\"\n>> +\t- p888: output r8-g8-b8 at each dclk cycle for per-pixel\n>> +\t- p666: output r6-g6-b6 at each dclk cycle for per-pixel\n>> +\t- p565: output r5-g6-b5 at each dclk cycle for per-pixel\n>> +\t- s888: output r8-g8-b8 in three dclk cycle for per-pixel\n>> +\t- s888-dmmy: output r8-g8-b8-dummy in four dclk cycle for per-pixel\n>> +\n>> +The rgb has two video ports described by:\n>> +\tDocumentation/devicetree/bindings/media/video-interfaces.txt\n>> +Their connections are modeled using the OF graph bindings specified in\n>> +\tDocumentation/devicetree/bindings/graph.txt.\n>> +\n>> +- video port 0 for the VOP input, the remote endpoint maybe vopb/vopl/vop\n>> +- video port 1 for either a panel or subsequent encoder\n>> +\n>> +the panel described by:\n>> +\tDocumentation/devicetree/bindings/display/panel/simple-panel.txt\n>> +Panel other required properties:\n>> +- ports for remote rgb output.\n>> +\n>> +Example:\n>> +\n>> +panel: panel {\n>> +\tcompatible = \"auo,b101ean01\";\n>> +\tenable-gpios = <&gpio7 21 GPIO_ACTIVE_HIGH>;\n>> +\n>> +\tports {\n>> +\t\tpanel_in_rgb: endpoint {\n>> +\t\t\tremote-endpoint = <&rgb_out_panel>;\n>> +\t\t};\n>> +\t};\n>> +};\n>> +\n>> +For Rockchip RV1108:\n>> +\n>> +\trgb: rgb {\n>> +\t\tcompatible = \"rockchip,rv1108-rgb\";\n>> +\t\tpinctrl-names = \"lcdc\";\n>> +\t\tpinctrl-0 = <&lcdc_ctl>;\n>> +\t\trgb-mode = \"p888\";\n>> +\n>> +\t\tports {\n>> +\t\t\t#address-cells = <1>;\n>> +\t\t\t#size-cells = <0>;\n>> +\n>> +\t\t\trgb_in: port@0 {\n>> +\t\t\t\treg = <0>;\n>> +\t\t\t\t#address-cells = <1>;\n>> +\t\t\t\t#size-cells = <0>;\n>> +\n>> +\t\t\t\trgb_in_vop: endpoint {\n>> +\t\t\t\t\tremote-endpoint = <&vop_out_rgb>;\n>> +\t\t\t\t};\n>> +\t\t\t};\n>> +\n>> +\t\t\trgb_out: port@1 {\n>> +\t\t\t\treg = <1>;\n>> +\t\t\t\t#address-cells = <1>;\n>> +\t\t\t\t#size-cells = <0>;\n>> +\n>> +\t\t\t\trgb_out_panel: endpoint {\n>> +\t\t\t\t\tremote-endpoint = <&panel_in_rgb>;\n>> +\t\t\t\t};\n>> +\t\t\t};\n>> +\t\t};\n>> +\t};\n>> -- \n>> 2.7.4\n>>\n>>\n> \n> \n> \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y9XrK4nG0z9t5x\n\tfor ;\n\tMon, 9 Oct 2017 19:06:25 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753952AbdJIIGX (ORCPT\n\t);\n\tMon, 9 Oct 2017 04:06:23 -0400","from regular1.263xmail.com ([211.150.99.135]:43961 \"EHLO\n\tregular1.263xmail.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751635AbdJIIGV (ORCPT\n\t); Mon, 9 Oct 2017 04:06:21 -0400","from hjc?rock-chips.com (unknown [192.168.167.231])\n\tby regular1.263xmail.com (Postfix) with ESMTP id 30A2F1E7EA;\n\tMon, 9 Oct 2017 16:06:14 +0800 (CST)","from [172.16.10.72] (localhost [127.0.0.1])\n\tby smtp.263.net (Postfix) with ESMTPA id 45A943C4;\n\tMon, 9 Oct 2017 16:06:04 +0800 (CST)","from [172.16.10.72] (unknown [58.22.7.114])\n\tby smtp.263.net (Postfix) whith ESMTP id 254344RE7UK;\n\tMon, 09 Oct 2017 16:06:09 +0800 (CST)"],"X-263anti-spam":"KSV:0;","X-MAIL-GRAY":"0","X-MAIL-DELIVERY":"1","X-KSVirus-check":"0","X-ABS-CHECKED":"4","X-RL-SENDER":"hjc@rock-chips.com","X-FST-TO":"sandy.huang@rock-chips.com","X-SENDER-IP":"58.22.7.114","X-LOGIN-NAME":"hjc@rock-chips.com","X-UNIQUE-TAG":"<4f193fe7cd18ec2c9b87230de13de0d6>","X-ATTACHMENT-NUM":"0","X-SENDER":"hjc@rock-chips.com","X-DNS-TYPE":"0","Subject":"Re: [PATCH v2 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","To":"Rob Herring ","Cc":"Mark Yao , David Airlie ,\n\tMark Rutland , Heiko Stuebner ,\n\tdri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org","References":"<1506049221-117283-1-git-send-email-hjc@rock-chips.com>\n\t<1506049229-117376-1-git-send-email-hjc@rock-chips.com>\n\t<20171003215631.rc2jsf2m3qgoltsb@rob-hp-laptop>","From":"Sandy Huang ","Message-ID":"<2d502a9d-e952-8afb-d2d7-45c21c36da7e@rock-chips.com>","Date":"Mon, 9 Oct 2017 16:06:05 +0800","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20171003215631.rc2jsf2m3qgoltsb@rob-hp-laptop>","Content-Type":"text/plain; charset=gbk; format=flowed","Content-Transfer-Encoding":"8bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1782800,"web_url":"http://patchwork.ozlabs.org/comment/1782800/","msgid":"","list_archive_url":null,"date":"2017-10-09T13:05:44","subject":"Re: [PATCH v2 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Mon, Oct 9, 2017 at 3:06 AM, Sandy Huang wrote:\n> Hi rob,\n> Thanks for your reply.\n>\n> 在 2017/10/4 5:56, Rob Herring 写道:\n>>\n>> On Fri, Sep 22, 2017 at 11:00:26AM +0800, Sandy Huang wrote:\n>>>\n>>> This path add support rv1108 rgb output interface driver.\n>>>\n>>> Signed-off-by: Sandy Huang \n>>> ---\n>>> Changes in v2:\n>>> 1. rename rockchip,rgb-mode to rgb-mode;\n>>\n>>\n>> You can't just drop the vendor. This needs to be documented in a common\n>> place that others will find and use. See panel-common.txt or\n>> panel-dpi.txt.\n>>\n>> Alternatively, you could just drop it and let the panel compatible imply\n>> what the mode is.\n>>\n>>\n> ok, get it, i will move the rgb-mode to panel and describe it at\n> panel-rgb.txt. the patches will be send soon later.\n\nDon't create yet another common panel file. We already have\npanel-dpi.txt which is for digital parallel interface.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y9gVg6k6Xz9tXc\n\tfor ;\n\tTue, 10 Oct 2017 00:06:35 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751711AbdJINGW convert rfc822-to-8bit (ORCPT\n\t);\n\tMon, 9 Oct 2017 09:06:22 -0400","from mail.kernel.org ([198.145.29.99]:50740 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1754399AbdJINGH (ORCPT );\n\tMon, 9 Oct 2017 09:06:07 -0400","from mail-qk0-f180.google.com (mail-qk0-f180.google.com\n\t[209.85.220.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 598BE21921;\n\tMon, 9 Oct 2017 13:06:06 +0000 (UTC)","by mail-qk0-f180.google.com with SMTP id f199so10305283qke.2;\n\tMon, 09 Oct 2017 06:06:06 -0700 (PDT)","by 10.12.130.134 with HTTP; Mon, 9 Oct 2017 06:05:44 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 598BE21921","X-Gm-Message-State":"AMCzsaXhD2h21pq2zHBgrimczMId5/KXEqf7pr0zJrtDnqlRqjyhXoSx\n\tSzFhXG0faZhDJ76gCMh4DGo79KkIB834cp8T5g==","X-Google-Smtp-Source":"AOwi7QDns0EkfjUls9ZI6LKS7RnYAs2ZqEtRAAG3xL5NNRW02Jfl0p+paQCARagS9TtWjgz/8ri2czYqI+/sRjxr2ok=","X-Received":"by 10.55.128.66 with SMTP id b63mr9386580qkd.67.1507554365564;\n\tMon, 09 Oct 2017 06:06:05 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<2d502a9d-e952-8afb-d2d7-45c21c36da7e@rock-chips.com>","References":"<1506049221-117283-1-git-send-email-hjc@rock-chips.com>\n\t<1506049229-117376-1-git-send-email-hjc@rock-chips.com>\n\t<20171003215631.rc2jsf2m3qgoltsb@rob-hp-laptop>\n\t<2d502a9d-e952-8afb-d2d7-45c21c36da7e@rock-chips.com>","From":"Rob Herring ","Date":"Mon, 9 Oct 2017 08:05:44 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v2 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","To":"Sandy Huang ","Cc":"Mark Yao , David Airlie ,\n\tMark Rutland , Heiko Stuebner ,\n\tdri-devel ,\n\t\"devicetree@vger.kernel.org\" ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"open list:ARM/Rockchip SoC...\" , \n\t\"linux-kernel@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"8BIT","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1783365,"web_url":"http://patchwork.ozlabs.org/comment/1783365/","msgid":"","list_archive_url":null,"date":"2017-10-10T01:59:24","subject":"Re: [PATCH v2 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","submitter":{"id":72133,"url":"http://patchwork.ozlabs.org/api/people/72133/","name":"Huang Jiachai","email":"hjc@rock-chips.com"},"content":"在 2017/10/9 21:05, Rob Herring 写道:\n> On Mon, Oct 9, 2017 at 3:06 AM, Sandy Huang wrote:\n>> Hi rob,\n>> Thanks for your reply.\n>>\n>> 在 2017/10/4 5:56, Rob Herring 写道:\n>>>\n>>> On Fri, Sep 22, 2017 at 11:00:26AM +0800, Sandy Huang wrote:\n>>>>\n>>>> This path add support rv1108 rgb output interface driver.\n>>>>\n>>>> Signed-off-by: Sandy Huang \n>>>> ---\n>>>> Changes in v2:\n>>>> 1. rename rockchip,rgb-mode to rgb-mode;\n>>>\n>>>\n>>> You can't just drop the vendor. This needs to be documented in a common\n>>> place that others will find and use. See panel-common.txt or\n>>> panel-dpi.txt.\n>>>\n>>> Alternatively, you could just drop it and let the panel compatible imply\n>>> what the mode is.\n>>>\n>>>\n>> ok, get it, i will move the rgb-mode to panel and describe it at\n>> panel-rgb.txt. the patches will be send soon later.\n> \n> Don't create yet another common panel file. We already have\n> panel-dpi.txt which is for digital parallel interface.\n> The panel-rgb.txt define different rgb output format and timing, this is \nthe detail info: https://patchwork.kernel.org/patch/9992241/\ndo you think this need move to panel-dpi.txt?\n> Rob\n> \n> \n> \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yB0fg2FRbz9t6C\n\tfor ;\n\tTue, 10 Oct 2017 12:59:38 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754268AbdJJB7h (ORCPT\n\t);\n\tMon, 9 Oct 2017 21:59:37 -0400","from regular1.263xmail.com ([211.150.99.140]:40097 \"EHLO\n\tregular1.263xmail.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751731AbdJJB7g (ORCPT\n\t); Mon, 9 Oct 2017 21:59:36 -0400","from hjc?rock-chips.com (unknown [192.168.167.201])\n\tby regular1.263xmail.com (Postfix) with ESMTP id 968E24B68;\n\tTue, 10 Oct 2017 09:59:27 +0800 (CST)","from [172.16.10.72] (localhost [127.0.0.1])\n\tby smtp.263.net (Postfix) with ESMTPA id 252F63BE;\n\tTue, 10 Oct 2017 09:59:24 +0800 (CST)","from [172.16.10.72] (unknown [58.22.7.114])\n\tby smtp.263.net (Postfix) whith ESMTP id 24017EX8SFM;\n\tTue, 10 Oct 2017 09:59:27 +0800 (CST)"],"X-263anti-spam":"KSV:0;","X-MAIL-GRAY":"0","X-MAIL-DELIVERY":"1","X-KSVirus-check":"0","X-ABS-CHECKED":"4","X-RL-SENDER":"hjc@rock-chips.com","X-FST-TO":"sandy.huang@rock-chips.com","X-SENDER-IP":"58.22.7.114","X-LOGIN-NAME":"hjc@rock-chips.com","X-UNIQUE-TAG":"","X-ATTACHMENT-NUM":"0","X-SENDER":"hjc@rock-chips.com","X-DNS-TYPE":"0","Subject":"Re: [PATCH v2 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","To":"Rob Herring ","Cc":"Mark Yao , David Airlie ,\n\tMark Rutland , Heiko Stuebner ,\n\tdri-devel ,\n\t\"devicetree@vger.kernel.org\" ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"open list:ARM/Rockchip SoC...\" , \n\t\"linux-kernel@vger.kernel.org\" ","References":"<1506049221-117283-1-git-send-email-hjc@rock-chips.com>\n\t<1506049229-117376-1-git-send-email-hjc@rock-chips.com>\n\t<20171003215631.rc2jsf2m3qgoltsb@rob-hp-laptop>\n\t<2d502a9d-e952-8afb-d2d7-45c21c36da7e@rock-chips.com>\n\t","From":"Sandy Huang ","Message-ID":"","Date":"Tue, 10 Oct 2017 09:59:24 +0800","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]