[{"id":1773893,"web_url":"http://patchwork.ozlabs.org/comment/1773893/","msgid":"<8C07C865-6A56-44EC-9C6E-48BAA9692184@ovn.org>","list_archive_url":null,"date":"2017-09-22T21:26:36","subject":"Re: [ovs-dev] [PATCH v4 2/3] ofp-util: Fix memory leaks on error\n\tcases in ofputil_decode_group_mod().","submitter":{"id":67602,"url":"http://patchwork.ozlabs.org/api/people/67602/","name":"Justin Pettit","email":"jpettit@ovn.org"},"content":"> On Sep 21, 2017, at 9:59 AM, Ben Pfaff wrote:\n> \n> Found by libFuzzer.\n> \n> Reported-by: Bhargava Shastry \n> Signed-off-by: Ben Pfaff \n\nAcked-by: Justin Pettit \n\n--Justin","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzRQl661mz9s9Y\n\tfor ;\n\tSat, 23 Sep 2017 07:27:43 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 72DA5B78;\n\tFri, 22 Sep 2017 21:27:12 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id DA05CB73\n\tfor ; Fri, 22 Sep 2017 21:27:10 +0000 (UTC)","from mail-pf0-f196.google.com (mail-pf0-f196.google.com\n\t[209.85.192.196])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 5E35947B\n\tfor ; Fri, 22 Sep 2017 21:27:09 +0000 (UTC)","by mail-pf0-f196.google.com with SMTP id a7so932828pfj.5\n\tfor ; Fri, 22 Sep 2017 14:27:09 -0700 (PDT)","from [10.0.1.5] ([98.234.50.139]) by smtp.gmail.com with ESMTPSA id\n\tt19sm884074pfa.73.2017.09.22.14.26.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 14:26:37 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc\n\t:content-transfer-encoding:message-id:references:to;\n\tbh=vYq/bDOEUltNLHdCR5clVQmzbhv1zkrjDPgq4MeaHIU=;\n\tb=GHrtwKzE7KzkRcRonfDvyuNuxoIuXbWJza1WuzrjUNp0KX4nDnl+1nX7FDYyXt34VY\n\thIibf0VZQU/UL3kmtBqvQwU5EBoQuKoeuqFonMpVcz8l68NcQ8JViam6tdU6pd08o7BU\n\t/2IjaLTRQvZpdo5LHnPIi5Q6bC7Z4L54kCbaWuOYjz2ZBfuoaIZ6/tJebpqFB4+xT6W/\n\tIlKIcayZqRgB/Zd0XU3xvEkv9KGO0A3voYm6eEvTs1VPkDf8TAhQYIJhoPY9oZEG9g1B\n\t5oeGutZL6/xFAdO2C6hyr8YDFMC7NKELY7xe3qjzoJUPVvqcKDwsRtqaBF54akyxMgCl\n\tdcZg==","X-Gm-Message-State":"AHPjjUjnN2a66pUsFK353zpv6Rl6mDLGzom+0sY2XGFidUOCtGDCy3XW\n\tfQQNy6iKms0nL7b1MXp77M4=","X-Google-Smtp-Source":"AOwi7QCs3dxyifORMVH5vNe6nA1/03sRS69myD9lFt+g9rFZcpZ0zqyntgePtvu7gVOt+3Qlwi/bCA==","X-Received":"by 10.84.224.136 with SMTP id s8mr393963plj.324.1506115599188;\n\tFri, 22 Sep 2017 14:26:39 -0700 (PDT)","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"Justin Pettit ","In-Reply-To":"<20170921165958.3218-3-blp@ovn.org>","Date":"Fri, 22 Sep 2017 14:26:36 -0700","Message-Id":"<8C07C865-6A56-44EC-9C6E-48BAA9692184@ovn.org>","References":"<20170921165958.3218-1-blp@ovn.org>\n\t<20170921165958.3218-3-blp@ovn.org>","To":"Ben Pfaff ","X-Mailer":"Apple Mail (2.3273)","X-Spam-Status":"No, score=0.5 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org, Bhargava Shastry ","Subject":"Re: [ovs-dev] [PATCH v4 2/3] ofp-util: Fix memory leaks on error\n\tcases in ofputil_decode_group_mod().","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1773909,"web_url":"http://patchwork.ozlabs.org/comment/1773909/","msgid":"<20170922215718.GF15629@ovn.org>","list_archive_url":null,"date":"2017-09-22T21:57:18","subject":"Re: [ovs-dev] [PATCH v4 2/3] ofp-util: Fix memory leaks on error\n\tcases in ofputil_decode_group_mod().","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Fri, Sep 22, 2017 at 02:26:36PM -0700, Justin Pettit wrote:\n> \n> > On Sep 21, 2017, at 9:59 AM, Ben Pfaff wrote:\n> > \n> > Found by libFuzzer.\n> > \n> > Reported-by: Bhargava Shastry \n> > Signed-off-by: Ben Pfaff \n> \n> Acked-by: Justin Pettit \n\nThanks, applied to master, backported as far as 2.6.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzS5569PHz9t16\n\tfor ;\n\tSat, 23 Sep 2017 07:57:29 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id B1D36ACA;\n\tFri, 22 Sep 2017 21:57:27 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 4925F8E3\n\tfor ; Fri, 22 Sep 2017 21:57:26 +0000 (UTC)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id C9B41443\n\tfor ; Fri, 22 Sep 2017 21:57:25 +0000 (UTC)","from ovn.org (unknown [208.91.2.3])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id DD7FEA80C6;\n\tFri, 22 Sep 2017 23:57:21 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.2.3","Date":"Fri, 22 Sep 2017 14:57:18 -0700","From":"Ben Pfaff ","To":"Justin Pettit ","Message-ID":"<20170922215718.GF15629@ovn.org>","References":"<20170921165958.3218-1-blp@ovn.org>\n\t<20170921165958.3218-3-blp@ovn.org>\n\t<8C07C865-6A56-44EC-9C6E-48BAA9692184@ovn.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<8C07C865-6A56-44EC-9C6E-48BAA9692184@ovn.org>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org, Bhargava Shastry ","Subject":"Re: [ovs-dev] [PATCH v4 2/3] ofp-util: Fix memory leaks on error\n\tcases in ofputil_decode_group_mod().","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1812117,"web_url":"http://patchwork.ozlabs.org/comment/1812117/","msgid":"","list_archive_url":null,"date":"2017-11-29T10:00:33","subject":"Re: [ovs-dev] [PATCH v4 2/3] ofp-util: Fix memory leaks on error\n\tcases in ofputil_decode_group_mod().","submitter":{"id":68624,"url":"http://patchwork.ozlabs.org/api/people/68624/","name":"Markos Chandras","email":"mchandras@suse.de"},"content":"On 22/09/17 22:57, Ben Pfaff wrote:\n> On Fri, Sep 22, 2017 at 02:26:36PM -0700, Justin Pettit wrote:\n>>\n>>> On Sep 21, 2017, at 9:59 AM, Ben Pfaff wrote:\n>>>\n>>> Found by libFuzzer.\n>>>\n>>> Reported-by: Bhargava Shastry \n>>> Signed-off-by: Ben Pfaff \n>>\n>> Acked-by: Justin Pettit \n> \n> Thanks, applied to master, backported as far as 2.6.\n\nHello,\n\nShould this patch be in 2.5 too given it's an LTS release?","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ymwyd6HS1z9s72\n\tfor ;\n\tWed, 29 Nov 2017 21:00:41 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 19A6FBA9;\n\tWed, 29 Nov 2017 10:00:40 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id A6224B1E\n\tfor ; Wed, 29 Nov 2017 10:00:38 +0000 (UTC)","from mx2.suse.de (mx2.suse.de [195.135.220.15])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id E6C02E4\n\tfor ; Wed, 29 Nov 2017 10:00:37 +0000 (UTC)","from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx2.suse.de (Postfix) with ESMTP id 2C014AC69;\n\tWed, 29 Nov 2017 10:00:36 +0000 (UTC)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","To":"Ben Pfaff , Justin Pettit ","References":"<20170921165958.3218-1-blp@ovn.org>\n\t<20170921165958.3218-3-blp@ovn.org>\n\t<8C07C865-6A56-44EC-9C6E-48BAA9692184@ovn.org>\n\t<20170922215718.GF15629@ovn.org>","From":"Markos Chandras ","Message-ID":"","Date":"Wed, 29 Nov 2017 10:00:33 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20170922215718.GF15629@ovn.org>","Content-Language":"en-US","X-Spam-Status":"No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED,\n\tT_RP_MATCHES_RCVD autolearn=ham version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org, Bhargava Shastry ","Subject":"Re: [ovs-dev] [PATCH v4 2/3] ofp-util: Fix memory leaks on error\n\tcases in ofputil_decode_group_mod().","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1812461,"web_url":"http://patchwork.ozlabs.org/comment/1812461/","msgid":"<20171129165150.GF13883@ovn.org>","list_archive_url":null,"date":"2017-11-29T16:51:50","subject":"Re: [ovs-dev] [PATCH v4 2/3] ofp-util: Fix memory leaks on error\n\tcases in ofputil_decode_group_mod().","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Wed, Nov 29, 2017 at 10:00:33AM +0000, Markos Chandras wrote:\n> On 22/09/17 22:57, Ben Pfaff wrote:\n> > On Fri, Sep 22, 2017 at 02:26:36PM -0700, Justin Pettit wrote:\n> >>\n> >>> On Sep 21, 2017, at 9:59 AM, Ben Pfaff wrote:\n> >>>\n> >>> Found by libFuzzer.\n> >>>\n> >>> Reported-by: Bhargava Shastry \n> >>> Signed-off-by: Ben Pfaff \n> >>\n> >> Acked-by: Justin Pettit \n> > \n> > Thanks, applied to master, backported as far as 2.6.\n> \n> Hello,\n> \n> Should this patch be in 2.5 too given it's an LTS release?\n\nI normally backport as far as a patch applies, so probably it didn't\napply to 2.5. If you can see that the memory leak is still present in\n2.5, please do feel free to fix up the patch to apply to 2.5 and submit\nit.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yn65J425qz9s5L\n\tfor ;\n\tThu, 30 Nov 2017 03:52:04 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 63C83C14;\n\tWed, 29 Nov 2017 16:52:01 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 69652BF6\n\tfor ; Wed, 29 Nov 2017 16:51:59 +0000 (UTC)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id E8CFD411\n\tfor ; Wed, 29 Nov 2017 16:51:58 +0000 (UTC)","from ovn.org (173-228-112-64.dsl.dynamic.fusionbroadband.com\n\t[173.228.112.64]) (Authenticated sender: blp@ovn.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 02BB6C5A7A;\n\tWed, 29 Nov 2017 17:51:54 +0100 (CET)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"173.228.112.64","Date":"Wed, 29 Nov 2017 08:51:50 -0800","From":"Ben Pfaff ","To":"Markos Chandras ","Message-ID":"<20171129165150.GF13883@ovn.org>","References":"<20170921165958.3218-1-blp@ovn.org>\n\t<20170921165958.3218-3-blp@ovn.org>\n\t<8C07C865-6A56-44EC-9C6E-48BAA9692184@ovn.org>\n\t<20170922215718.GF15629@ovn.org>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW\n\tautolearn=ham version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org, Bhargava Shastry ","Subject":"Re: [ovs-dev] [PATCH v4 2/3] ofp-util: Fix memory leaks on error\n\tcases in ofputil_decode_group_mod().","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]