[{"id":1773349,"web_url":"http://patchwork.ozlabs.org/comment/1773349/","msgid":"<2295e546-40b5-4805-2c7e-426fb9008aa0@denx.de>","list_archive_url":null,"date":"2017-09-22T08:11:34","subject":"Re: [U-Boot] [PATCH 1/2] configs: colibri_imx6: don't configure\n\tvideo in spl","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"On 21/09/2017 18:58, Max Krummenacher wrote:\n> The functionality is not needed in the SPL. It allows to remove\n> code conditionally in the spl case in some drivers.\n> \n> Signed-off-by: Max Krummenacher \n> ---\n> \n> include/configs/colibri_imx6.h | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/include/configs/colibri_imx6.h b/include/configs/colibri_imx6.h\n> index 5fd9aab..b02a291 100644\n> --- a/include/configs/colibri_imx6.h\n> +++ b/include/configs/colibri_imx6.h\n> @@ -94,6 +94,7 @@\n> #define CONFIG_MXC_GPIO\n> \n> /* Framebuffer and LCD */\n> +#if !defined(CONFIG_SPL_BUILD)\n> #define CONFIG_VIDEO_IPUV3\n> #define CONFIG_SYS_CONSOLE_IS_IN_ENV\n> #define CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE\n> @@ -106,6 +107,7 @@\n> #define CONFIG_CONSOLE_MUX\n> #define CONFIG_IMX_HDMI\n> #define CONFIG_IMX_VIDEO_SKIP\n> +#endif\n> \n> /* allow to overwrite serial and ethaddr */\n> #define CONFIG_ENV_OVERWRITE\n> \n\nThanks for patch !\n\nReviewed-by: Stefano Babic \n\nBest regards,\nStefano Babic","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz5mP2ZdCz9s8J\n\tfor ;\n\tFri, 22 Sep 2017 18:11:49 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 0F8D3C21FE1; Fri, 22 Sep 2017 08:11:44 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 69FB6C21E14;\n\tFri, 22 Sep 2017 08:11:42 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D0B14C21E14; Fri, 22 Sep 2017 08:11:40 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 75D8DC21E0E\n\tfor ; Fri, 22 Sep 2017 08:11:40 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xz5mC3z2Bz1qvyZ;\n\tFri, 22 Sep 2017 10:11:39 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xz5mC35vVz1qrm4;\n\tFri, 22 Sep 2017 10:11:39 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id x8DZkfJpnYZc; Fri, 22 Sep 2017 10:11:37 +0200 (CEST)","from babic.homelinux.org (host-88-217-136-221.customer.m-online.net\n\t[88.217.136.221])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tFri, 22 Sep 2017 10:11:37 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id DC9E0454052E;\n\tFri, 22 Sep 2017 10:11:36 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id EycBe4-edXOD; Fri, 22 Sep 2017 10:11:34 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id 0FFE54540472;\n\tFri, 22 Sep 2017 10:11:34 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"To":"Max Krummenacher , u-boot@lists.denx.de","References":"<1506013096-11784-1-git-send-email-max.krummenacher@toradex.com>\n\t<1506013096-11784-2-git-send-email-max.krummenacher@toradex.com>","From":"Stefano Babic ","Message-ID":"<2295e546-40b5-4805-2c7e-426fb9008aa0@denx.de>","Date":"Fri, 22 Sep 2017 10:11:34 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506013096-11784-2-git-send-email-max.krummenacher@toradex.com>","Content-Language":"de-DE","Cc":"Stefan Agner ,\n\t\"otavio @ ossystems . com . br\" ,\n\tMarcel Ziswiler ,\n\t\"jagan @ openedev . com\" ,\n\tMax Krummenacher ","Subject":"Re: [U-Boot] [PATCH 1/2] configs: colibri_imx6: don't configure\n\tvideo in spl","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]