[{"id":1774231,"web_url":"http://patchwork.ozlabs.org/comment/1774231/","msgid":"<20170924144015.GN30205@bill-the-cat>","list_archive_url":null,"date":"2017-09-24T14:40:15","subject":"Re: [U-Boot] [PATCH v2 5/5] mmc: omap_hsmmc: Fix incorrect bit\n\toperations for disabling a bit","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Thu, Sep 21, 2017 at 04:51:36PM +0200, Jean-Jacques Hiblot wrote:\n\n> From: Kishon Vijay Abraham I \n> \n> omap_hsmmc driver uses \"|\" in a couple of places for disabling a bit.\n> While it's okay to use it in \"mmc_reg_out\" (since mmc_reg_out has a\n> _mask_ argument to take care of resetting a bit), it's incorrectly used\n> for resetting flags in \"omap_hsmmc_send_cmd\".\n> \n> Fix it here by using \"&= ~()\" to reset a bit.\n> \n> Signed-off-by: Kishon Vijay Abraham I \n> Signed-off-by: Jean-Jacques Hiblot \n\nReviewed-by: Tom Rini ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"W2GeQAWC\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0VTh2TfKz9sRV\n\tfor ;\n\tMon, 25 Sep 2017 00:48:56 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1B355C220CF; Sun, 24 Sep 2017 14:44:54 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E0637C22104;\n\tSun, 24 Sep 2017 14:41:25 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 6B190C220D2; Sun, 24 Sep 2017 14:40:26 +0000 (UTC)","from mail-yw0-f169.google.com (mail-yw0-f169.google.com\n\t[209.85.161.169])\n\tby lists.denx.de (Postfix) with ESMTPS id CE4C3C220FB\n\tfor ; Sun, 24 Sep 2017 14:40:15 +0000 (UTC)","by mail-yw0-f169.google.com with SMTP id l4so3284691ywa.6\n\tfor ; Sun, 24 Sep 2017 07:40:15 -0700 (PDT)","from bill-the-cat ([2606:a000:1401:811b:9cbd:ca90:bff9:8e97])\n\tby smtp.gmail.com with ESMTPSA id\n\tm125sm1747320ywf.42.2017.09.24.07.40.13\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tSun, 24 Sep 2017 07:40:13 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=9qi8G6VqOpscWMExRNJiM8Vs997hOwyvlcAIlwo1SU8=;\n\tb=W2GeQAWCJirAxvsW2q2HWIflAXv/0GJt63S4k9nBHGLB0iUqhRHgPS1aiCN0we0WR8\n\tyunbqaP2Ji+R7XwWUH+IvWz1yD3/5UQiWBn9h9m+4R4X4uEYz+4999EooFHPh1xOu/ir\n\tcbojRamKDVkdID579JaHWGSfy+K7ic2bjyvlE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=9qi8G6VqOpscWMExRNJiM8Vs997hOwyvlcAIlwo1SU8=;\n\tb=WrblcCQAkWL473PmHwpm1fxJYXjS9rEk/3/6WUPTELTfrRkNSqh1beFUIc18QNU8tM\n\t5OhNFX043m6wps26NmxFMpA0lggXBANzcRvrPfrPTT6YUBIlvNAutOmFTdcwLdel0vw/\n\tRXDsK/M1bZBp7anCDnrDkoizpJ6NpjmF117ZX5wDE1sMKjFg2Lklvp7vhFoVA7efDQ1A\n\tlxU+H3OYoyT3RzsUlS8J9JtM+1iVxiMYOPqQefn7C9ng1unX1l3HapmZjXelDRw2k9+3\n\thwOhWvwO7K1FgxyMFDbf8ev9J9tinklHeqkQHACi54aaEWAkewUDRFzkz3gpYNFYhS9Q\n\tH+XQ==","X-Gm-Message-State":"AHPjjUiL53vnHFB1spqqtLJN995NOibI24cpAKAh82U49b+LmU4w69MI\n\tZDr6T70RsgXh0oZQBLgoi+g3dw==","X-Google-Smtp-Source":"AOwi7QA00fqK9PTqnHYgRzqCq5+3YUnU4xGTEWBMy1Dam+wW738yZ0eyNFr01FjzShB+tUPkCWhFzA==","X-Received":"by 10.129.203.12 with SMTP id q12mr2790300ywi.452.1506264014695; \n\tSun, 24 Sep 2017 07:40:14 -0700 (PDT)","Date":"Sun, 24 Sep 2017 10:40:15 -0400","From":"Tom Rini ","To":"Jean-Jacques Hiblot ","Message-ID":"<20170924144015.GN30205@bill-the-cat>","References":"<1506005496-8635-1-git-send-email-jjhiblot@ti.com>\n\t<1506005496-8635-6-git-send-email-jjhiblot@ti.com>","MIME-Version":"1.0","In-Reply-To":"<1506005496-8635-6-git-send-email-jjhiblot@ti.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"u-boot@lists.denx.de, kishon@ti.com","Subject":"Re: [U-Boot] [PATCH v2 5/5] mmc: omap_hsmmc: Fix incorrect bit\n\toperations for disabling a bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============2477181406178936925==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1842955,"web_url":"http://patchwork.ozlabs.org/comment/1842955/","msgid":"<20180119211133.GE4660@bill-the-cat>","list_archive_url":null,"date":"2018-01-19T21:11:33","subject":"Re: [U-Boot] [U-Boot, v2,\n\t5/5] mmc: omap_hsmmc: Fix incorrect bit operations for disabling a\n\tbit","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Thu, Sep 21, 2017 at 04:51:36PM +0200, Jean-Jacques Hiblot wrote:\n\n> From: Kishon Vijay Abraham I \n> \n> omap_hsmmc driver uses \"|\" in a couple of places for disabling a bit.\n> While it's okay to use it in \"mmc_reg_out\" (since mmc_reg_out has a\n> _mask_ argument to take care of resetting a bit), it's incorrectly used\n> for resetting flags in \"omap_hsmmc_send_cmd\".\n> \n> Fix it here by using \"&= ~()\" to reset a bit.\n> \n> Signed-off-by: Kishon Vijay Abraham I \n> Signed-off-by: Jean-Jacques Hiblot \n> Reviewed-by: Tom Rini \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"Z14dAEip\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3zNYff3glRz9s74\n\tfor ;\n\tSat, 20 Jan 2018 08:21:30 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 06192C21FE4; Fri, 19 Jan 2018 21:13:34 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D3107C21F3F;\n\tFri, 19 Jan 2018 21:12:43 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid E4046C21F7C; Fri, 19 Jan 2018 21:11:40 +0000 (UTC)","from mail-yw0-f178.google.com (mail-yw0-f178.google.com\n\t[209.85.161.178])\n\tby lists.denx.de (Postfix) with ESMTPS id EEC98C21F35\n\tfor ; Fri, 19 Jan 2018 21:11:36 +0000 (UTC)","by mail-yw0-f178.google.com with SMTP id b129so1129809ywa.8\n\tfor ; Fri, 19 Jan 2018 13:11:36 -0800 (PST)","from bill-the-cat (cpe-65-184-142-68.ec.res.rr.com.\n\t[65.184.142.68]) by smtp.gmail.com with ESMTPSA id\n\tk14sm3910312ywa.59.2018.01.19.13.11.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 19 Jan 2018 13:11:35 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=/u7WRqFunHQghdIQPwNQ8NtxJ1f1eRgciG4DZibNP7Q=;\n\tb=Z14dAEipKZSuIJCoK46fT0lTjGjDdGGOCB87uDI0TkmD659pxDTzPu9j2X+XgZ3Jc9\n\tifRXAmGLZMkHjXXnLMgTmiEnv1umWjP7LwVkQDkHAQT0EpfqLzjGnPJsj+AtIyda439T\n\tzoCE0SsVjnQD8I2rmKPMHDmEm7XD4y8ecd9+k=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=/u7WRqFunHQghdIQPwNQ8NtxJ1f1eRgciG4DZibNP7Q=;\n\tb=AVNchL5oBW8hrD7cvpg+dZpZdwWDan4atarjUqfFIp3zyWb1B7fvC1AeR1zi8DcjPp\n\tAxB5MvS+rKO5YfInrlLwvkW9FHjnZe77yaydRKXolNiPA6tWRPJ1O3Ddq0R4DhtcDSsf\n\tjX9KbWlOKlZ8I7kGjMd2uu9ooUM7lCMdk9hUZ5fiUUqEf6JklMTB5BegI8J8dskO4MJg\n\tCLUS57swozsybDHqoQFed304ZoZTwfh/OVgcbc1Megs9nwfLgiViI8qGEqFHDFkbFzpc\n\t6J2lNkt1hZMoc+U1Hots7McOpsx8mL+crVC3wwVuUwagWHDaxkPBa/LCMPL6O9h9+jJm\n\t4YNg==","X-Gm-Message-State":"AKwxytfEt7dQSprtSer97ydSPWw6Ge5eb0ENCPupPBgg6RuLDFZehCEG\n\tgno1/F2y5TmWpOKyNlyafVPZhA==","X-Google-Smtp-Source":"ACJfBouay9NOYH+VHI7uIGEQlBsIg/Hy3U04Ji1jgNu3K+CC58iwTmZ7NHeYmUN4Hh91A/UF8wYRXw==","X-Received":"by 10.13.219.151 with SMTP id\n\td145mr10683729ywe.291.1516396295853; \n\tFri, 19 Jan 2018 13:11:35 -0800 (PST)","Date":"Fri, 19 Jan 2018 16:11:33 -0500","From":"Tom Rini ","To":"Jean-Jacques Hiblot ","Message-ID":"<20180119211133.GE4660@bill-the-cat>","References":"<1506005496-8635-6-git-send-email-jjhiblot@ti.com>","MIME-Version":"1.0","In-Reply-To":"<1506005496-8635-6-git-send-email-jjhiblot@ti.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Cc":"u-boot@lists.denx.de, kishon@ti.com","Subject":"Re: [U-Boot] [U-Boot, v2,\n\t5/5] mmc: omap_hsmmc: Fix incorrect bit operations for disabling a\n\tbit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============0002349573909613437==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]