[{"id":1854294,"web_url":"http://patchwork.ozlabs.org/comment/1854294/","msgid":"<20180209001055.GB96047@largo.jsg.id.au>","list_archive_url":null,"date":"2018-02-09T00:10:55","subject":"Re: [U-Boot] [PATCH v2 10/26] mmc: refactor SD startup to make it\n\teasier to support new modes","submitter":{"id":69816,"url":"http://patchwork.ozlabs.org/api/people/69816/","name":"Jonathan Gray","email":"jsg@jsg.id.au"},"content":"On Thu, Sep 21, 2017 at 04:29:57PM +0200, Jean-Jacques Hiblot wrote:\n> The SDcard startup process currently handles only 2 modes. To make it\n> easier to add support for more modes, let's make the process more generic\n> and use a list of the modes to try.\n> The major functional change is that when a mode fails we try the next one.\n> Not all modes are tried, only those supported by the card and the host.\n> \n> Signed-off-by: Jean-Jacques Hiblot \n> Reviewed-by: Simon Glass \n\nThis change broke mmc with the vexpress_ca15_tc2 target and\nqemu-system-arm -M vexpress-a15.\n\ncommit d0c221fe7336fc7d9ada57d96f4a8911a3aac041\nAuthor: Jean-Jacques Hiblot \nAuthorDate: Thu Sep 21 16:29:57 2017 +0200\nCommit: Jaehoon Chung \nCommitDate: Fri Jan 12 18:11:04 2018 +0900\n\n mmc: refactor SD startup to make it easier to support new modes\n \n The SDcard startup process currently handles only 2 modes. To make it\n easier to add support for more modes, let's make the process more generic\n and use a list of the modes to try.\n The major functional change is that when a mode fails we try the next one.\n Not all modes are tried, only those supported by the card and the host.\n \n Signed-off-by: Jean-Jacques Hiblot \n Reviewed-by: Simon Glass \n\nwith a build from master e24bd1e79e223aa89854c0be95a53e2d538144a5\n\nU-Boot 2018.03-rc1-00185-g1e19c70639 (Feb 09 2018 - 11:31:54 +1300)\n\nDRAM: 1 GiB\nWARNING: Caches not enabled\nFlash: 128 MiB\nMMC: MMC: 0\n*** Warning - bad CRC, using default environment\n\nIn: serial\nOut: serial\nErr: serial\nNet: smc911x-0\nHit any key to stop autoboot: 0\n=> load mmc 0:1 ${ramdisk_addr} fdt.dtb\nunable to select a mode\nmmc_init: -524, time 23\nunable to select a mode\nmmc_init: -524, time 22\n** Bad device mmc 0 **\n=> load mmc 0:1 ${loadaddr} efi/boot/bootarm.efi\nunable to select a mode\nmmc_init: -524, time 21\nunable to select a mode\nmmc_init: -524, time 21\n** Bad device mmc 0 **\n=> bootefi ${loadaddr} ${ramdisk_addr}\n## Starting EFI application at a0008000 ...\nWARNING: using memory device/image path, this may confuse some payloads!\nScanning disks on mmc...\nunable to select a mode\nmmc_init: -524, time 21\nMMC Device 1 not found\nMMC Device 2 not found\nMMC Device 3 not found\nFound 0 disks\nWARNING: Invalid device tree, expect boot to fail\nefi_load_pe: Invalid DOS Signature","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3zcwTC5bw0z9s7M\n\tfor ;\n\tFri, 9 Feb 2018 11:11:11 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 6A70EC21E68; Fri, 9 Feb 2018 00:11:05 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 42CA4C21DA3;\n\tFri, 9 Feb 2018 00:11:02 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 460E8C21DA3; Fri, 9 Feb 2018 00:11:01 +0000 (UTC)","from lechuck.jsg.id.au (jsg.id.au [210.15.216.215])\n\tby lists.denx.de (Postfix) with ESMTPS id 3E32FC21C4F\n\tfor ; Fri, 9 Feb 2018 00:10:58 +0000 (UTC)","from largo.jsg.id.au (largo.jsg.id.au [192.168.1.43])\n\tby lechuck.jsg.id.au (OpenSMTPD) with ESMTP id d7e1ebef;\n\tFri, 9 Feb 2018 11:10:55 +1100 (AEDT)","from localhost (largo.jsg.id.au [local])\n\tby largo.jsg.id.au (OpenSMTPD) with ESMTPA id a328ac2d;\n\tFri, 9 Feb 2018 11:10:55 +1100 (AEDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED,\n\tUNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","Date":"Fri, 9 Feb 2018 11:10:55 +1100","From":"Jonathan Gray ","To":"Jean-Jacques Hiblot ","Message-ID":"<20180209001055.GB96047@largo.jsg.id.au>","References":"<1506004213-22620-1-git-send-email-jjhiblot@ti.com>\n\t<1506004213-22620-11-git-send-email-jjhiblot@ti.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1506004213-22620-11-git-send-email-jjhiblot@ti.com>","User-Agent":"Mutt/1.9.1 (2017-09-22)","Cc":"trini@konsulko.com, u-boot@lists.denx.de, kishon@ti.com","Subject":"Re: [U-Boot] [PATCH v2 10/26] mmc: refactor SD startup to make it\n\teasier to support new modes","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]