[{"id":1773610,"web_url":"http://patchwork.ozlabs.org/comment/1773610/","msgid":"","list_archive_url":null,"date":"2017-09-22T13:54:32","subject":"Re: [U-Boot] [PATCH v2 07/26] mmc: Add a function to dump the mmc\n\tcapabilities","submitter":{"id":8006,"url":"http://patchwork.ozlabs.org/api/people/8006/","name":"Jaehoon Chung","email":"jh80.chung@samsung.com"},"content":"Hi,\n\nOn 09/21/2017 11:29 PM, Jean-Jacques Hiblot wrote:\n> This adds a simple helper function to display information (bus width and\n> mode) based on a capability mask. Useful for debug.\n\nI agreed this is useful.. but there is no usage in your patch.\nHow did you use this? and Where does call this function..\n\nI think it can be used the one of mmc command. how about?\n\nBest Regards,\nJaehoon Chung\n\n> \n> Signed-off-by: Jean-Jacques Hiblot \n> ---\n> drivers/mmc/mmc.c | 24 ++++++++++++++++++++++++\n> include/mmc.h | 1 +\n> 2 files changed, 25 insertions(+)\n> \n> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c\n> index 94b3a02..0b74e78 100644\n> --- a/drivers/mmc/mmc.c\n> +++ b/drivers/mmc/mmc.c\n> @@ -1136,6 +1136,30 @@ static void mmc_set_bus_width(struct mmc *mmc, uint width)\n> \tmmc_set_ios(mmc);\n> }\n> \n> +#if CONFIG_IS_ENABLED(MMC_VERBOSE) || defined(DEBUG)\n> +/*\n> + * helper function to display the capabilities in a human\n> + * friendly manner. The capabilities include bus width and\n> + * supported modes.\n> + */\n> +void mmc_dump_capabilities(const char *text, uint caps)\n> +{\n> +\tenum bus_mode mode;\n> +\n> +\tprintf(\"%s: widths [\", text);\n> +\tif (caps & MMC_MODE_8BIT)\n> +\t\tprintf(\"8, \");\n> +\tif (caps & MMC_MODE_4BIT)\n> +\t\tprintf(\"4, \");\n> +\tprintf(\"1] modes [\");\n> +\n> +\tfor (mode = MMC_LEGACY; mode < MMC_MODES_END; mode++)\n> +\t\tif (MMC_CAP(mode) & caps)\n> +\t\t\tprintf(\"%s, \", mmc_mode_name(mode));\n> +\tprintf(\"\\b\\b]\\n\");\n> +}\n> +#endif\n> +\n> static int sd_select_bus_freq_width(struct mmc *mmc)\n> {\n> \tint err;\n> diff --git a/include/mmc.h b/include/mmc.h\n> index 76bd57a..dd83f14 100644\n> --- a/include/mmc.h\n> +++ b/include/mmc.h\n> @@ -426,6 +426,7 @@ enum bus_mode {\n> };\n> \n> const char *mmc_mode_name(enum bus_mode mode);\n> +void mmc_dump_capabilities(const char *text, uint caps);\n> \n> /*\n> * With CONFIG_DM_MMC enabled, struct mmc can be accessed from the MMC device\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzFNy70sRz9sPk\n\tfor ;\n\tFri, 22 Sep 2017 23:55:30 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 83640C2205C; Fri, 22 Sep 2017 13:55:10 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E2FBEC2205A;\n\tFri, 22 Sep 2017 13:54:46 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9623EC21FE1; Fri, 22 Sep 2017 13:54:44 +0000 (UTC)","from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33])\n\tby lists.denx.de (Postfix) with ESMTPS id 7EAA7C22024\n\tfor ; Fri, 22 Sep 2017 13:54:37 +0000 (UTC)","from epcas1p2.samsung.com (unknown [182.195.41.46])\n\tby mailout3.samsung.com (KnoxPortal) with ESMTP id\n\t20170922135433epoutp03544d609231c0a6fbde81413f81b21058~ms3y2ja6W0526705267epoutp03H;\n\tFri, 22 Sep 2017 13:54:33 +0000 (GMT)","from epsmges1p5.samsung.com (unknown [182.195.40.64]) by\n\tepcas1p2.samsung.com (KnoxPortal) with ESMTP id\n\t20170922135433epcas1p251926b40e8d658b02161014a78095f75~ms3yn6rkg2463224632epcas1p2S;\n\tFri, 22 Sep 2017 13:54:33 +0000 (GMT)","from epcas1p3.samsung.com ( [182.195.41.47]) by\n\tepsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id\n\t4B.C7.18934.91615C95; Fri, 22 Sep 2017 22:54:33 +0900 (KST)","from epsmgms2p1new.samsung.com (unknown [182.195.42.142]) by\n\tepcas1p4.samsung.com (KnoxPortal) with ESMTP id\n\t20170922135433epcas1p42e897877051d16962d7f34e4b70c4645~ms3ySRM2m1001310013epcas1p4i;\n\tFri, 22 Sep 2017 13:54:33 +0000 (GMT)","from epmmp2 ( [203.254.227.17]) by epsmgms2p1new.samsung.com\n\t(Symantec Messaging Gateway) with SMTP id 1D.32.11757.81615C95;\n\tFri, 22 Sep 2017 22:54:32 +0900 (KST)","from [10.113.62.216] by mmp2.samsung.com (Oracle Communications\n\tMessaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id\n\t<0OWO000EFPAWR980@mmp2.samsung.com>;\n\tFri, 22 Sep 2017 22:54:32 +0900 (KST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tSPF_HELO_PASS autolearn=unavailable\n\tautolearn_force=no version=3.4.0","X-AuditID":"b6c32a39-f794a6d0000049f6-89-59c51619976f","To":"Jean-Jacques Hiblot , trini@konsulko.com,\n\tkishon@ti.com, sjg@chromium.org","From":"Jaehoon Chung ","Message-id":"","Date":"Fri, 22 Sep 2017 22:54:32 +0900","User-Agent":"Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-version":"1.0","In-reply-to":"<1506004213-22620-8-git-send-email-jjhiblot@ti.com>","Content-language":"en-US","X-Brightmail-Tracker":["H4sIAAAAAAAAA02Se0hTcRTH+e3e3V3D2W1NOymkXEhQcu7OTWc1MbRYqDQalBahV72ouYfs\n\tbtLjHyPNR0Y2EWqWRRCU+aIkjTJSm6/eCZJm/pPiGGUPtLSg2nYV/O9zzu97zu98D4fEZBeJ\n\tcLLEYudsFtZEExvwB4Mx8XFbw9w5yuezcm3lqFOkfTNXT2jdj2cw7c/uB0jb5Lwv0X7pq5Wk\n\tEvrmire4/qHro0Tvfdoq0b+c7kX64fc9IoP4CLe7mGMLOVsUZymwFpZYinR0hjE3LVeTqGTi\n\tmGRtEh1lYc2cjk7PNMTtKzH5RqCjylmTw5cysDxPx6fstlkddi6q2MrbdfRRhlEpGGWSQqVS\n\tKdQJx3aqND5JHlc8d+m3pGxs4wlvtRurQDeD61AQCZQaWv51SAQOgzcznUQd2kDKqF4ES40v\n\txELwC0FfzWXxWkXP+F2Rn2VUF4KWxWBBNIPgwuW7mP9hM2WAoTYPXodIUk7lwYUqhz+NUfEw\n\t/7wtICGoHdDzczjQR0qlgHdsMpDHqe2wcuZbgEOpQ3DntxcJmk2w3DiD+zmISoUV52Mk9IwB\n\tz6ITF3gLnK2aXOVIuN/2BfPPBtQIAV29fwjBQDq8b2jCBN4M3uFuiX9OoCLgnVsn6KsRTC0/\n\tIYSgBkH/St+q+wQYqzsjEn4IgYWlerFQLIWaczJBoofl2tlV+R6YvjkhFpY1iuDzsKkBRbrW\n\t+XGt8+Ba58G1zsMNhLeiMK6MNxdxPFOmUfCsmXdYihQFVvM9FDjG2OReNPQqcwBRJKKDpcr+\n\twRyZmC3nT5oHEJAYLZe6/z7LkUkL2ZOnOJs11+YwcfwA0vj2fQkLDy2w+k7bYs9l1MlKdaLK\n\td3bJDENvkYZ2TmTLqCLWzpVyXBlnW6sTkUHhFSgTnxLrQpgfxvPR4zemrh82veYnb23ztGV9\n\tJx0DnhrVrvjm9h23q3+pP0TnPxJNGa9Np/YcP92SHzLi7bgavVce68xo/NpZujXNUxtxcaHT\n\tUZp9bV46O57VvoCltOYZb22UX5mY3L/Lc9CQkzB3tnp5OtTBV54ol7sP/LuiSVJ+onG+mGVi\n\tMRvP/gfnu928ogMAAA==","H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsVy+t9jQV0JsaORBjcP2li0nJzEZHHhaQ+b\n\txdE995gtvm3ZxmgxddJmdou3ezvZHdg8ZjdcZPHYOesuu8erA6vYPc7e2cHocfzGdqYA1igu\n\tm5TUnMyy1CJ9uwSujKcTf7EXnOKveNV+lLmBcRFPFyMnh4SAicT2y6uZQGwhgXWMEtcb+bsY\n\tuYDsB4wSK77PYgdJCAv4Sbw98AGsSEQgQeL/litsIDazgL7E89NrmCEaTjJKbGi8wwKSYBPQ\n\tkdj+7ThYA6+AncSrUzeZQWwWAVWJn40fwGxRgTCJ/ua/zBA1ghI/Jt8D6+UUcJD4OWkPYxcj\n\tB9ACdYkpU3IhdolLNLfeZIGw5SU2r3nLPIFRYBaS7lkIHbOQdMxC0rGAkWUVo2RqQXFuem6x\n\tUYFhXmq5XnFibnFpXrpecn7uJkZg6G87rNW3g/H+kvhDjAIcjEo8vDf2HY4UYk0sK67MPcQo\n\twcGsJMJ79N+RSCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8mX0zIoUE0hNLUrNTUwtSi2CyTByc\n\tUg2MPVa197oOrOJg1dr/e9fzl6/03ZqnF+vxr4pZy2F7K6/j0CJPuYnbbnO8+GuuJvzhtfLG\n\tCss6o9xK9oWR/gszbid0dSTevMMmmi53mG3H9x0HDj3jmPFW7h/b8j5Lh/d2RoY6+sYPpXll\n\tvI0npO44LZmZ9+bF09mWFTue8PlnH1717LjPxff/lViKMxINtZiLihMBmhUg/HkCAAA="],"X-CMS-MailID":"20170922135433epcas1p42e897877051d16962d7f34e4b70c4645","X-Msg-Generator":"CA","X-Sender-IP":"182.195.42.142","X-Local-Sender":"=?utf-8?b?7KCV7J6s7ZuIG1RpemVuIFBsYXRmb3JtIExhYihTL1c=?=\n\t=?utf-8?b?7IS87YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?=","X-Global-Sender":"=?utf-8?q?Jaehoon_Chung=1BTizen_Platform_Lab=2E=1BSamsun?=\n\t=?utf-8?q?g_Electronics=1BSenior_Engineer?=","X-Sender-Code":"=?utf-8?q?C10=1BTELE=1BC10V8111?=","CMS-TYPE":"101P","DLP-Filter":"Pass","X-CFilter-Loop":"Reflected","X-CMS-RootMailID":"20170921143041epcas5p1d36d51c23450af1900a065c13508d1ce","X-RootMTR":"20170921143041epcas5p1d36d51c23450af1900a065c13508d1ce","References":"<1506004213-22620-1-git-send-email-jjhiblot@ti.com>\n\t\n\t<1506004213-22620-8-git-send-email-jjhiblot@ti.com>","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH v2 07/26] mmc: Add a function to dump the mmc\n\tcapabilities","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1778208,"web_url":"http://patchwork.ozlabs.org/comment/1778208/","msgid":"<24737dcc-9710-dd0f-fdca-3f39f1474d0d@ti.com>","list_archive_url":null,"date":"2017-10-02T08:57:59","subject":"Re: [U-Boot] [PATCH v2 07/26] mmc: Add a function to dump the mmc\n\tcapabilities","submitter":{"id":70508,"url":"http://patchwork.ozlabs.org/api/people/70508/","name":"Jean-Jacques Hiblot","email":"jjhiblot@ti.com"},"content":"Hi Jaehoon,\n\n\nOn 22/09/2017 15:54, Jaehoon Chung wrote:\n> Hi,\n>\n> On 09/21/2017 11:29 PM, Jean-Jacques Hiblot wrote:\n>> This adds a simple helper function to display information (bus width and\n>> mode) based on a capability mask. Useful for debug.\n> I agreed this is useful.. but there is no usage in your patch.\n> How did you use this? and Where does call this function..\n>\n> I think it can be used the one of mmc command. how about?\nAt first I added it to \"mmc info\" but it's more for the developer than \nthe user, so I removed it from there.\nAt the moment it is not referenced anywhere the code, but I left it in \nplace because it's indeed useful when debugging the initialization.\nThinking of it I could add something right after the card capabilities \nare discovered if debug is enabled. What do you think?\n\nJean-Jacques\n\n>\n> Best Regards,\n> Jaehoon Chung\n>\n>> Signed-off-by: Jean-Jacques Hiblot \n>> ---\n>> drivers/mmc/mmc.c | 24 ++++++++++++++++++++++++\n>> include/mmc.h | 1 +\n>> 2 files changed, 25 insertions(+)\n>>\n>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c\n>> index 94b3a02..0b74e78 100644\n>> --- a/drivers/mmc/mmc.c\n>> +++ b/drivers/mmc/mmc.c\n>> @@ -1136,6 +1136,30 @@ static void mmc_set_bus_width(struct mmc *mmc, uint width)\n>> \tmmc_set_ios(mmc);\n>> }\n>> \n>> +#if CONFIG_IS_ENABLED(MMC_VERBOSE) || defined(DEBUG)\n>> +/*\n>> + * helper function to display the capabilities in a human\n>> + * friendly manner. The capabilities include bus width and\n>> + * supported modes.\n>> + */\n>> +void mmc_dump_capabilities(const char *text, uint caps)\n>> +{\n>> +\tenum bus_mode mode;\n>> +\n>> +\tprintf(\"%s: widths [\", text);\n>> +\tif (caps & MMC_MODE_8BIT)\n>> +\t\tprintf(\"8, \");\n>> +\tif (caps & MMC_MODE_4BIT)\n>> +\t\tprintf(\"4, \");\n>> +\tprintf(\"1] modes [\");\n>> +\n>> +\tfor (mode = MMC_LEGACY; mode < MMC_MODES_END; mode++)\n>> +\t\tif (MMC_CAP(mode) & caps)\n>> +\t\t\tprintf(\"%s, \", mmc_mode_name(mode));\n>> +\tprintf(\"\\b\\b]\\n\");\n>> +}\n>> +#endif\n>> +\n>> static int sd_select_bus_freq_width(struct mmc *mmc)\n>> {\n>> \tint err;\n>> diff --git a/include/mmc.h b/include/mmc.h\n>> index 76bd57a..dd83f14 100644\n>> --- a/include/mmc.h\n>> +++ b/include/mmc.h\n>> @@ -426,6 +426,7 @@ enum bus_mode {\n>> };\n>> \n>> const char *mmc_mode_name(enum bus_mode mode);\n>> +void mmc_dump_capabilities(const char *text, uint caps);\n>> \n>> /*\n>> * With CONFIG_DM_MMC enabled, struct mmc can be accessed from the MMC device\n>>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"JKL9QRHZ\";\n\tdkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5GLb3h3Qz9t4Z\n\tfor ;\n\tMon, 2 Oct 2017 19:59:19 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 34324C21EE7; Mon, 2 Oct 2017 08:59:13 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 23AA8C21CB3;\n\tMon, 2 Oct 2017 08:59:11 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 1C939C21CB3; Mon, 2 Oct 2017 08:59:10 +0000 (UTC)","from fllnx209.ext.ti.com (fllnx209.ext.ti.com [198.47.19.16])\n\tby lists.denx.de (Postfix) with ESMTPS id 6F20DC21C41\n\tfor ; Mon, 2 Oct 2017 08:59:09 +0000 (UTC)","from dlelxv90.itg.ti.com ([172.17.2.17])\n\tby fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v928w6Ox015181; \n\tMon, 2 Oct 2017 03:58:06 -0500","from DLEE101.ent.ti.com (dlee101.ent.ti.com [157.170.170.31])\n\tby dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v928w1Kf011080; \n\tMon, 2 Oct 2017 03:58:01 -0500","from DLEE107.ent.ti.com (157.170.170.37) by DLEE101.ent.ti.com\n\t(157.170.170.31) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tMon, 2 Oct 2017 03:58:01 -0500","from dflp32.itg.ti.com (10.64.6.15) by DLEE107.ent.ti.com\n\t(157.170.170.37) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Mon, 2 Oct 2017 03:58:01 -0500","from [172.22.129.181] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v928vxt4001825;\n\tMon, 2 Oct 2017 03:58:00 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1506934686;\n\tbh=oIquzhMkofp51PWCekfIiG5z8lQGlaFkiHbzMXkYNdQ=;\n\th=Subject:To:CC:References:From:Date:In-Reply-To;\n\tb=JKL9QRHZnlyageVpwONd/t7FntXqJk7414/gEJRtCFoy6inMNmgZlDfneuS1qqsr9\n\t1hZQmYkSuwUfWdVxdg4iueD4SXF8ksNV7qjpdf6+XZDKtjtU6YTripXBw0/mi4fbt+\n\txiMv0A1ViIsQTNKLe+f8AJVS9q0tTDzhiKci2axc=","To":"Jaehoon Chung , ,\n\t, ","References":"<1506004213-22620-1-git-send-email-jjhiblot@ti.com>\n\t\n\t<1506004213-22620-8-git-send-email-jjhiblot@ti.com>\n\t","From":"Jean-Jacques Hiblot ","Message-ID":"<24737dcc-9710-dd0f-fdca-3f39f1474d0d@ti.com>","Date":"Mon, 2 Oct 2017 10:57:59 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH v2 07/26] mmc: Add a function to dump the mmc\n\tcapabilities","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1782459,"web_url":"http://patchwork.ozlabs.org/comment/1782459/","msgid":"","list_archive_url":null,"date":"2017-10-09T04:48:30","subject":"Re: [U-Boot] [PATCH v2 07/26] mmc: Add a function to dump the mmc\n\tcapabilities","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2 October 2017 at 02:57, Jean-Jacques Hiblot wrote:\n> Hi Jaehoon,\n>\n>\n> On 22/09/2017 15:54, Jaehoon Chung wrote:\n>>\n>> Hi,\n>>\n>> On 09/21/2017 11:29 PM, Jean-Jacques Hiblot wrote:\n>>>\n>>> This adds a simple helper function to display information (bus width and\n>>> mode) based on a capability mask. Useful for debug.\n>>\n>> I agreed this is useful.. but there is no usage in your patch.\n>> How did you use this? and Where does call this function..\n>>\n>> I think it can be used the one of mmc command. how about?\n>\n> At first I added it to \"mmc info\" but it's more for the developer than the\n> user, so I removed it from there.\n> At the moment it is not referenced anywhere the code, but I left it in place\n> because it's indeed useful when debugging the initialization.\n> Thinking of it I could add something right after the card capabilities are\n> discovered if debug is enabled. What do you think?\n>\n> Jean-Jacques\n\nThat seems reasonable.\n\nIn any case, we cannot add dead code.\n\n- Simon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"gwL+nOfy\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"MwPziLfL\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y9Sq03wDsz9sPm\n\tfor ;\n\tMon, 9 Oct 2017 16:05:00 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 38EF4C21CA5; Mon, 9 Oct 2017 04:57:46 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5899DC21C62;\n\tMon, 9 Oct 2017 04:57:34 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 59815C21D80; Mon, 9 Oct 2017 04:48:56 +0000 (UTC)","from mail-qk0-f169.google.com (mail-qk0-f169.google.com\n\t[209.85.220.169])\n\tby lists.denx.de (Postfix) with ESMTPS id 922A7C21C4E\n\tfor ; Mon, 9 Oct 2017 04:48:52 +0000 (UTC)","by mail-qk0-f169.google.com with SMTP id n5so20288109qke.11\n\tfor ; Sun, 08 Oct 2017 21:48:52 -0700 (PDT)","by 10.200.63.170 with HTTP; Sun, 8 Oct 2017 21:48:30 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=qESs2/3WmRKYbkyDM3v99UcTQv3cqH26pzN9W+Igvnw=;\n\tb=gwL+nOfynpboFlmz3kfeN5wrbEIia7DE/CO6MMkvtLPHRN0zvRpaA/TRFwq/0/3+Ge\n\tZNZn3CVWvBH+2qdnPrvbGPv7IuSI7AoYDY9Wq/Tstyw6FqOHxZa6s4j9fDCnmz//nR9G\n\ty0xXG0Aj7stnTzAUQybNLIXBk4duocs1JIyguMAjtLmlRfL8nffDjhSQhdhaSy8BfcIv\n\tE3Ku5FIYk6mE36jXkZF+QdJAFsZetMyGpewYSX8mD6f106WHlDuCHDohXuD34gbLBRJ8\n\tO3pfKPHaWRKRiPwaWWoKqUxTQf7YQ+EdQ2NvHPMe+VOeU7LBRy4iAn9/x5RLDCdXMtp8\n\tBnDw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=qESs2/3WmRKYbkyDM3v99UcTQv3cqH26pzN9W+Igvnw=;\n\tb=MwPziLfLHkZ4eX+VZ7uSeHXJpWG2zsjsC5UtuovOIxLWGJDokIboxvsCz8wp+MUwg0\n\tbCXff7PPsI8hIkrk5E3eFmovSaVuBlR1TseraS8nSUrzcqqeCe6Dctwrp0N5eIq2jt4U\n\towibPYlGkrEsIVxU3xAzVga4MyfNazOYTz+q0="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=qESs2/3WmRKYbkyDM3v99UcTQv3cqH26pzN9W+Igvnw=;\n\tb=GZOAkEJ0eIh4FQssZwWeDX2DqvV1T2FvgsBsKRl0whTRMf0OH/TND8q7iw6yaEBHdX\n\tFH9VH3ydnvHL8m8d7swK3wNjae44rN3fajFRwPiTPsgevScJJ/vEVHmxGIQlnQRKn9Ej\n\tZNzt94s+87Liq01FCaVX6a8Pq7otRQjecNDYd2eR1DE6s3HyKVSqT3HXXxX03GmR1mWj\n\tVNClqV73T7ND/htfF5wT7Lwa1PHIrYmVl3qJ3kgvfNm00A7tiuvYM+IfIhoIyS2CPd7X\n\tfhyQiHfSPwr0+E9gwWqHg3RU3kCTH8nItXY/RkQS5vgPc/AYKJQKDH5aivuh2CtI/Gfd\n\tB8bw==","X-Gm-Message-State":"AMCzsaX0uugiABpY1UX1AC813Nl6BuWonwUIWRzbyG24N3hj84GO6tsc\n\tXSg/Qz6WHYtWjlw+Ecwcxavh7RII0oSI4p09VYG0Pg==","X-Google-Smtp-Source":"AOwi7QCV/7vV/3elq69yy1Bt8QHwn9rqiVsU5gbR1DcMTp/1lRcAZYPTBWC3ilBo77OVpqhf7yE4r/evJ78xK3Oncyc=","X-Received":"by 10.55.122.193 with SMTP id v184mr4242948qkc.317.1507524531367;\n\tSun, 08 Oct 2017 21:48:51 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<24737dcc-9710-dd0f-fdca-3f39f1474d0d@ti.com>","References":"<1506004213-22620-1-git-send-email-jjhiblot@ti.com>\n\t\n\t<1506004213-22620-8-git-send-email-jjhiblot@ti.com>\n\t\n\t<24737dcc-9710-dd0f-fdca-3f39f1474d0d@ti.com>","From":"Simon Glass ","Date":"Sun, 8 Oct 2017 22:48:30 -0600","X-Google-Sender-Auth":"2rKRGzReWikC3OCWhb-UL-BzsZk","Message-ID":"","To":"Jean-Jacques Hiblot ","Cc":"Tom Rini , U-Boot Mailing List ,\n\tKishon Vijay Abraham I ","Subject":"Re: [U-Boot] [PATCH v2 07/26] mmc: Add a function to dump the mmc\n\tcapabilities","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]