[{"id":1773221,"web_url":"http://patchwork.ozlabs.org/comment/1773221/","msgid":"<20170921.184102.278153022575280817.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-22T01:41:02","subject":"Re: [PATCH net-next 01/10] net: hns3: Support for dynamically\n\tassigning tx buffer to TC","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Yunsheng Lin \nDate: Thu, 21 Sep 2017 19:21:44 +0800\n\n> @@ -1324,23 +1324,28 @@ static int hclge_alloc_vport(struct hclge_dev *hdev)\n> \treturn 0;\n> }\n> \n> -static int hclge_cmd_alloc_tx_buff(struct hclge_dev *hdev, u16 buf_size)\n> +static int hclge_cmd_alloc_tx_buff(struct hclge_dev *hdev)\n> {\n> /* TX buffer size is unit by 128 byte */\n> #define HCLGE_BUF_SIZE_UNIT_SHIFT\t7\n> #define HCLGE_BUF_SIZE_UPDATE_EN_MSK\tBIT(15)\n> \tstruct hclge_tx_buff_alloc *req;\n> +\tstruct hclge_priv_buf *priv;\n> \tstruct hclge_desc desc;\n> +\tu32 buf_size;\n> \tint ret;\n> \tu8 i;\n> \n> \treq = (struct hclge_tx_buff_alloc *)desc.data;\n> \n> \thclge_cmd_setup_basic_desc(&desc, HCLGE_OPC_TX_BUFF_ALLOC, 0);\n> -\tfor (i = 0; i < HCLGE_TC_NUM; i++)\n> +\tfor (i = 0; i < HCLGE_TC_NUM; i++) {\n> +\t\tpriv = &hdev->priv_buf[i];\n> +\t\tbuf_size = priv->tx_buf_size;\n> \t\treq->tx_pkt_buff[i] =\n> \t\t\tcpu_to_le16((buf_size >> HCLGE_BUF_SIZE_UNIT_SHIFT) |\n> \t\t\t\t HCLGE_BUF_SIZE_UPDATE_EN_MSK);\n> +\t}\n> \n> \tret = hclge_cmd_send(&hdev->hw, &desc, 1);\n> \tif (ret) {\n\nLocal variable 'buf_size' is assigned but never used in this function.\nAnd with 'buf_size' removed, 'priv' also becomes unused.\n\nIf it gets used in a later patch, add it in that later patch.\n\nYou can also declare the variables locally in the basic block of\nthe for() loop.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyx5q1jcJz9t16\n\tfor ;\n\tFri, 22 Sep 2017 11:41:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751853AbdIVBlF (ORCPT );\n\tThu, 21 Sep 2017 21:41:05 -0400","from shards.monkeyblade.net ([184.105.139.130]:37850 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751790AbdIVBlE (ORCPT\n\t); Thu, 21 Sep 2017 21:41:04 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 9A32710318707;\n\tThu, 21 Sep 2017 18:41:03 -0700 (PDT)"],"Date":"Thu, 21 Sep 2017 18:41:02 -0700 (PDT)","Message-Id":"<20170921.184102.278153022575280817.davem@davemloft.net>","To":"linyunsheng@huawei.com","Cc":"huangdaode@hisilicon.com, xuwei5@hisilicon.com,\n\tliguozhu@hisilicon.com, Yisen.Zhuang@huawei.com,\n\tgabriele.paoloni@huawei.com, john.garry@huawei.com,\n\tlinuxarm@huawei.com, salil.mehta@huawei.com, lipeng321@huawei.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH net-next 01/10] net: hns3: Support for dynamically\n\tassigning tx buffer to TC","From":"David Miller ","In-Reply-To":"<1505992913-107256-2-git-send-email-linyunsheng@huawei.com>","References":"<1505992913-107256-1-git-send-email-linyunsheng@huawei.com>\n\t<1505992913-107256-2-git-send-email-linyunsheng@huawei.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 21 Sep 2017 18:41:04 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1773224,"web_url":"http://patchwork.ozlabs.org/comment/1773224/","msgid":"<8babe541-9409-7f66-e52b-922144c46fb0@huawei.com>","list_archive_url":null,"date":"2017-09-22T01:57:31","subject":"Re: [PATCH net-next 01/10] net: hns3: Support for dynamically\n\tassigning tx buffer to TC","submitter":{"id":71804,"url":"http://patchwork.ozlabs.org/api/people/71804/","name":"Yunsheng Lin","email":"linyunsheng@huawei.com"},"content":"Hi, David\n\nOn 2017/9/22 9:41, David Miller wrote:\n> From: Yunsheng Lin \n> Date: Thu, 21 Sep 2017 19:21:44 +0800\n> \n>> @@ -1324,23 +1324,28 @@ static int hclge_alloc_vport(struct hclge_dev *hdev)\n>> \treturn 0;\n>> }\n>> \n>> -static int hclge_cmd_alloc_tx_buff(struct hclge_dev *hdev, u16 buf_size)\n>> +static int hclge_cmd_alloc_tx_buff(struct hclge_dev *hdev)\n>> {\n>> /* TX buffer size is unit by 128 byte */\n>> #define HCLGE_BUF_SIZE_UNIT_SHIFT\t7\n>> #define HCLGE_BUF_SIZE_UPDATE_EN_MSK\tBIT(15)\n>> \tstruct hclge_tx_buff_alloc *req;\n>> +\tstruct hclge_priv_buf *priv;\n>> \tstruct hclge_desc desc;\n>> +\tu32 buf_size;\n>> \tint ret;\n>> \tu8 i;\n>> \n>> \treq = (struct hclge_tx_buff_alloc *)desc.data;\n>> \n>> \thclge_cmd_setup_basic_desc(&desc, HCLGE_OPC_TX_BUFF_ALLOC, 0);\n>> -\tfor (i = 0; i < HCLGE_TC_NUM; i++)\n>> +\tfor (i = 0; i < HCLGE_TC_NUM; i++) {\n>> +\t\tpriv = &hdev->priv_buf[i];\n>> +\t\tbuf_size = priv->tx_buf_size;\n>> \t\treq->tx_pkt_buff[i] =\n>> \t\t\tcpu_to_le16((buf_size >> HCLGE_BUF_SIZE_UNIT_SHIFT) |\n\nbuf_size is used here\n\n>> \t\t\t\t HCLGE_BUF_SIZE_UPDATE_EN_MSK);\n>> +\t}\n>> \n>> \tret = hclge_cmd_send(&hdev->hw, &desc, 1);\n>> \tif (ret) {\n> \n> Local variable 'buf_size' is assigned but never used in this function.\n> And with 'buf_size' removed, 'priv' also becomes unused.\n\n> \n> If it gets used in a later patch, add it in that later patch.\n> \n> You can also declare the variables locally in the basic block of\n> the for() loop.\n\nYou are right. Will do it if there is more comment coming, thanks for\nreviewing .\n\n> \n> .\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyxTQ2X16z9t32\n\tfor ;\n\tFri, 22 Sep 2017 11:58:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751809AbdIVB6C (ORCPT );\n\tThu, 21 Sep 2017 21:58:02 -0400","from szxga05-in.huawei.com ([45.249.212.191]:6541 \"EHLO\n\tszxga05-in.huawei.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751602AbdIVB6B (ORCPT\n\t); Thu, 21 Sep 2017 21:58:01 -0400","from 172.30.72.60 (EHLO DGGEMS412-HUB.china.huawei.com)\n\t([172.30.72.60])\n\tby dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DHU39200; Fri, 22 Sep 2017 09:57:49 +0800 (CST)","from [127.0.0.1] (10.74.191.121) by DGGEMS412-HUB.china.huawei.com\n\t(10.3.19.212) with Microsoft SMTP Server id 14.3.301.0;\n\tFri, 22 Sep 2017 09:57:43 +0800"],"Subject":"Re: [PATCH net-next 01/10] net: hns3: Support for dynamically\n\tassigning tx buffer to TC","To":"David Miller ","CC":", ,\n\t, ,\n\t, ,\n\t, ,\n\t, ,\n\t","References":"<1505992913-107256-1-git-send-email-linyunsheng@huawei.com>\n\t<1505992913-107256-2-git-send-email-linyunsheng@huawei.com>\n\t<20170921.184102.278153022575280817.davem@davemloft.net>","From":"Yunsheng Lin ","Message-ID":"<8babe541-9409-7f66-e52b-922144c46fb0@huawei.com>","Date":"Fri, 22 Sep 2017 09:57:31 +0800","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170921.184102.278153022575280817.davem@davemloft.net>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.74.191.121]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A0B0208.59C46E1D.00B9, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"31a64527706a7203c0b214a4f9e9e61f","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1773246,"web_url":"http://patchwork.ozlabs.org/comment/1773246/","msgid":"<20170921.204359.2123810326286259256.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-22T03:43:59","subject":"Re: [PATCH net-next 01/10] net: hns3: Support for dynamically\n\tassigning tx buffer to TC","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Yunsheng Lin \nDate: Fri, 22 Sep 2017 09:57:31 +0800\n\n> Hi, David\n> \n> On 2017/9/22 9:41, David Miller wrote:\n>> From: Yunsheng Lin \n>> Date: Thu, 21 Sep 2017 19:21:44 +0800\n>> \n>>> @@ -1324,23 +1324,28 @@ static int hclge_alloc_vport(struct hclge_dev *hdev)\n>>> \treturn 0;\n>>> }\n>>> \n>>> -static int hclge_cmd_alloc_tx_buff(struct hclge_dev *hdev, u16 buf_size)\n>>> +static int hclge_cmd_alloc_tx_buff(struct hclge_dev *hdev)\n>>> {\n>>> /* TX buffer size is unit by 128 byte */\n>>> #define HCLGE_BUF_SIZE_UNIT_SHIFT\t7\n>>> #define HCLGE_BUF_SIZE_UPDATE_EN_MSK\tBIT(15)\n>>> \tstruct hclge_tx_buff_alloc *req;\n>>> +\tstruct hclge_priv_buf *priv;\n>>> \tstruct hclge_desc desc;\n>>> +\tu32 buf_size;\n>>> \tint ret;\n>>> \tu8 i;\n>>> \n>>> \treq = (struct hclge_tx_buff_alloc *)desc.data;\n>>> \n>>> \thclge_cmd_setup_basic_desc(&desc, HCLGE_OPC_TX_BUFF_ALLOC, 0);\n>>> -\tfor (i = 0; i < HCLGE_TC_NUM; i++)\n>>> +\tfor (i = 0; i < HCLGE_TC_NUM; i++) {\n>>> +\t\tpriv = &hdev->priv_buf[i];\n>>> +\t\tbuf_size = priv->tx_buf_size;\n>>> \t\treq->tx_pkt_buff[i] =\n>>> \t\t\tcpu_to_le16((buf_size >> HCLGE_BUF_SIZE_UNIT_SHIFT) |\n> \n> buf_size is used here\n\nMy bad, I misread the code.\n\nThanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyzqd3Y4hz9t42\n\tfor ;\n\tFri, 22 Sep 2017 13:44:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751839AbdIVDoB (ORCPT );\n\tThu, 21 Sep 2017 23:44:01 -0400","from shards.monkeyblade.net ([184.105.139.130]:41654 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751653AbdIVDoA (ORCPT\n\t); Thu, 21 Sep 2017 23:44:00 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 9F0051031A780;\n\tThu, 21 Sep 2017 20:43:59 -0700 (PDT)"],"Date":"Thu, 21 Sep 2017 20:43:59 -0700 (PDT)","Message-Id":"<20170921.204359.2123810326286259256.davem@davemloft.net>","To":"linyunsheng@huawei.com","Cc":"huangdaode@hisilicon.com, xuwei5@hisilicon.com,\n\tliguozhu@hisilicon.com, Yisen.Zhuang@huawei.com,\n\tgabriele.paoloni@huawei.com, john.garry@huawei.com,\n\tlinuxarm@huawei.com, salil.mehta@huawei.com, lipeng321@huawei.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH net-next 01/10] net: hns3: Support for dynamically\n\tassigning tx buffer to TC","From":"David Miller ","In-Reply-To":"<8babe541-9409-7f66-e52b-922144c46fb0@huawei.com>","References":"<1505992913-107256-2-git-send-email-linyunsheng@huawei.com>\n\t<20170921.184102.278153022575280817.davem@davemloft.net>\n\t<8babe541-9409-7f66-e52b-922144c46fb0@huawei.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 21 Sep 2017 20:44:00 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]