[{"id":1772937,"web_url":"http://patchwork.ozlabs.org/comment/1772937/","msgid":"<20170921153819.GH27589@lunn.ch>","list_archive_url":null,"date":"2017-09-21T15:38:19","subject":"Re: [PATCH net 3/4] net:ethernet:aquantia: Fix transient invalid\n\tlink down/up indications","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Thu, Sep 21, 2017 at 01:53:41PM +0300, Igor Russkikh wrote:\n> Due to a bug in aquantia atlantic card firmware, it sometimes reports\n> invalid link speed bits. That caused driver to report link down events,\n> although link itself is totally fine.\n> \n> This patch ignores such out of blue readings.\n> \n> Signed-off-by: Pavel Belous <Pavel.Belous@aquantia.com>\n> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\n> ---\n>  drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c | 3 +--\n>  1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c\n> index 4f5ec9a..ab5d3cb 100644\n> --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c\n> +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c\n> @@ -351,8 +351,7 @@ int hw_atl_utils_mpi_get_link_status(struct aq_hw_s *self)\n>  \t\t\tbreak;\n>  \n>  \t\tdefault:\n> -\t\t\tlink_status->mbps = 0U;\n> -\t\t\tbreak;\n> +\t\t\treturn -1;\n\nHi Igno\n\nPlease use a proper error code.\n\n       Andrew","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xygk83gsKz9s7B\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 22 Sep 2017 01:38:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751785AbdIUPiW (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 21 Sep 2017 11:38:22 -0400","from vps0.lunn.ch ([185.16.172.187]:51427 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751739AbdIUPiV (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tThu, 21 Sep 2017 11:38:21 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dv3YR-0000SI-HX; Thu, 21 Sep 2017 17:38:19 +0200"],"Date":"Thu, 21 Sep 2017 17:38:19 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Igor Russkikh <igor.russkikh@aquantia.com>","Cc":"\"David S . Miller\" <davem@davemloft.net>, netdev@vger.kernel.org,\n\tDavid Arcari <darcari@redhat.com>,\n\tPavel Belous <Pavel.Belous@aquantia.com>,\n\tNadezhda Krupnina <Nadezhda.Krupnina@aquantia.com>,\n\tSimon Edelhaus <simon.edelhaus@aquantia.com>","Subject":"Re: [PATCH net 3/4] net:ethernet:aquantia: Fix transient invalid\n\tlink down/up indications","Message-ID":"<20170921153819.GH27589@lunn.ch>","References":"<cover.1505915085.git.igor.russkikh@aquantia.com>\n\t<6c8d54cad231f22ba46e08d3ec0fe9d6fcef7468.1505915085.git.igor.russkikh@aquantia.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<6c8d54cad231f22ba46e08d3ec0fe9d6fcef7468.1505915085.git.igor.russkikh@aquantia.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]