[{"id":1772576,"web_url":"http://patchwork.ozlabs.org/comment/1772576/","msgid":"<20170921085508.GA2028@nanopsycho>","list_archive_url":null,"date":"2017-09-21T08:55:08","subject":"Re: [PATCH net-next 3/4] cxgb4: add support to offload action vlan","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/people/15321/","name":"Jiri Pirko","email":"jiri@resnulli.us"},"content":"Thu, Sep 21, 2017 at 09:33:36AM CEST, rahul.lakkireddy@chelsio.com wrote:\n>From: Kumar Sanghvi \n>\n>Add support for offloading tc-flower flows having\n>vlan actions: pop, push and modify.\n>\n>Signed-off-by: Kumar Sanghvi \n>Signed-off-by: Rahul Lakkireddy \n>Signed-off-by: Ganesh Goudar \n>---\n> .../net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 43 ++++++++++++++++++++++\n> 1 file changed, 43 insertions(+)\n>\n>diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c\n\n[...]\n\n\n>+\t\t\tswitch (vlan_action) {\n>+\t\t\tcase TCA_VLAN_ACT_POP:\n>+\t\t\t\tbreak;\n>+\t\t\tcase TCA_VLAN_ACT_PUSH:\n>+\t\t\tcase TCA_VLAN_ACT_MODIFY:\n>+\t\t\t\tif (proto != ETH_P_8021Q) {\n>+\t\t\t\t\tnetdev_err(dev,\n>+\t\t\t\t\t\t \"%s: Unsupp. vlan proto\\n\",\n\nDon't wrap this. Also \"Unsupp.\"vs\"Unsupported\". Please be consistent.\n\n\n>+\t\t\t\t\t\t __func__);\n>+\t\t\t\t\treturn -EOPNOTSUPP;\n>+\t\t\t\t}\n>+\t\t\t\tbreak;\n>+\t\t\tdefault:\n>+\t\t\t\tnetdev_err(dev, \"%s: Unsupported vlan action\\n\",\n>+\t\t\t\t\t __func__);\n>+\t\t\t\treturn -EOPNOTSUPP;\n>+\t\t\t}\n> \t\t} else {\n> \t\t\tnetdev_err(dev, \"%s: Unsupported action\\n\", __func__);\n> \t\t\treturn -EOPNOTSUPP;\n>-- \n>2.14.1\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"JaCj+5gq\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyVn40ZCJz9t3v\n\tfor ;\n\tThu, 21 Sep 2017 18:55:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751706AbdIUIzL (ORCPT );\n\tThu, 21 Sep 2017 04:55:11 -0400","from mail-wm0-f66.google.com ([74.125.82.66]:33569 \"EHLO\n\tmail-wm0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751528AbdIUIzK (ORCPT\n\t); Thu, 21 Sep 2017 04:55:10 -0400","by mail-wm0-f66.google.com with SMTP id m127so4592116wmm.0\n\tfor ; Thu, 21 Sep 2017 01:55:10 -0700 (PDT)","from localhost (ip-89-177-125-82.net.upcbroadband.cz.\n\t[89.177.125.82]) by smtp.gmail.com with ESMTPSA id\n\tr15sm739536wrc.30.2017.09.21.01.55.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 21 Sep 2017 01:55:09 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=Lf1H1GOYO0ShCeD9wTCroHthwo1bAGeB+B1aPSVuEsM=;\n\tb=JaCj+5gq5sSGuT9HeFJCdX5jOJJgabapTlvNWZ1mrKEPGcIq+O5qT7hOziL+pjDfAD\n\tkOHimVSNmx4Fyo+Cc8/4OpgUhOf95rpIiIe6mWU5ZH9f9GikBpzgqNzzeuxrPE3yKP3i\n\trKMnqd0Af3TeLXjN68OBQlaMRlklcPd2EE5XqAztAaGOkeQx+DTaOkXDTKeTYtDOMjLj\n\tQcrxXF4P31PdQ63UlcRytOXycVjzAxmbkaCTJEBMr0WX10f3VQ8aJLMJHZoOveUSwkmd\n\tP0lpWgwJycNPyBl2V1HCisppwjlS2jtRYPVevoPCSRHOml5OC/nkoX3C+aMmEa9kj7BG\n\tz6VA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=Lf1H1GOYO0ShCeD9wTCroHthwo1bAGeB+B1aPSVuEsM=;\n\tb=LAA1AwsnghXXCNwkFh/8WXsDELKFKu2omAeJllxv7x3W2KeU23XyA+o8PhIMGnPkAK\n\tN1m9baZyK9l8/O+q92uEot7C9+W8GDTA1gelTSvsEU3rsJPldFa5Ss8sYj7iL5XghEq/\n\tvu6FZ4BRC4gh8VU9np8/cU76Ivki6EWD07rQkdY0r4OxwCNfn6Hu+T7hMqLJJE4sQJ6M\n\tA7LBiNrKVWRNjMkhpWlFxZpcFp7P1BseAgCQ9A/87YlPHc4AHQsMH6tGMeV+2IEL7pGa\n\tKitRMskzz4nkqVKe18CGED09J1Qd4KpA4BuuNMWRTBsJ8ZROstXSiUB66NSjOngApf5Y\n\tLPPA==","X-Gm-Message-State":"AHPjjUgNOw6klnjINkGX/Mu0uW4pbSR+FMbGbXoxKz32RjgUYhYc7vzO\n\tnjptNoFoSLUG3dlnpDQlCGCn5w==","X-Google-Smtp-Source":"AOwi7QCMJWA7K8CTgW3o0GvFYAwER3IZx0ckg4EnXCK+HjjQOcwYrWjRhgAGULN98G6MFc0p43ic+g==","X-Received":"by 10.28.189.7 with SMTP id n7mr289156wmf.49.1505984109705;\n\tThu, 21 Sep 2017 01:55:09 -0700 (PDT)","Date":"Thu, 21 Sep 2017 10:55:08 +0200","From":"Jiri Pirko ","To":"Rahul Lakkireddy ","Cc":"netdev@vger.kernel.org, davem@davemloft.net, kumaras@chelsio.com,\n\tganeshgr@chelsio.com, nirranjan@chelsio.com, indranil@chelsio.com","Subject":"Re: [PATCH net-next 3/4] cxgb4: add support to offload action vlan","Message-ID":"<20170921085508.GA2028@nanopsycho>","References":"\n\t<016c3bf21a7bfe45e73275d3191cf61cceffd362.1505977744.git.rahul.lakkireddy@chelsio.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<016c3bf21a7bfe45e73275d3191cf61cceffd362.1505977744.git.rahul.lakkireddy@chelsio.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1772919,"web_url":"http://patchwork.ozlabs.org/comment/1772919/","msgid":"<20170921152342.GA14071@banjo.asicdesigners.com>","list_archive_url":null,"date":"2017-09-21T15:23:45","subject":"Re: [PATCH net-next 3/4] cxgb4: add support to offload action vlan","submitter":{"id":9904,"url":"http://patchwork.ozlabs.org/api/people/9904/","name":"Kumar Sanghvi","email":"kumaras@chelsio.com"},"content":"Hi Jiri,\n\nOn Thursday, September 09/21/17, 2017 at 10:55:08 +0200, Jiri Pirko wrote:\n> Thu, Sep 21, 2017 at 09:33:36AM CEST, rahul.lakkireddy@chelsio.com wrote:\n> >From: Kumar Sanghvi \n> >\n> >Add support for offloading tc-flower flows having\n> >vlan actions: pop, push and modify.\n> >\n> >Signed-off-by: Kumar Sanghvi \n> >Signed-off-by: Rahul Lakkireddy \n> >Signed-off-by: Ganesh Goudar \n> >---\n> > .../net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 43 ++++++++++++++++++++++\n> > 1 file changed, 43 insertions(+)\n> >\n> >diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c\n> \n> [...]\n> \n> \n> >+\t\t\tswitch (vlan_action) {\n> >+\t\t\tcase TCA_VLAN_ACT_POP:\n> >+\t\t\t\tbreak;\n> >+\t\t\tcase TCA_VLAN_ACT_PUSH:\n> >+\t\t\tcase TCA_VLAN_ACT_MODIFY:\n> >+\t\t\t\tif (proto != ETH_P_8021Q) {\n> >+\t\t\t\t\tnetdev_err(dev,\n> >+\t\t\t\t\t\t \"%s: Unsupp. vlan proto\\n\",\n> \n> Don't wrap this. Also \"Unsupp.\"vs\"Unsupported\". Please be consistent.\n\nThank you for pointing this.\nI will take care of this in V2.\n\n> \n> \n> >+\t\t\t\t\t\t __func__);\n> >+\t\t\t\t\treturn -EOPNOTSUPP;\n> >+\t\t\t\t}\n> >+\t\t\t\tbreak;\n> >+\t\t\tdefault:\n> >+\t\t\t\tnetdev_err(dev, \"%s: Unsupported vlan action\\n\",\n> >+\t\t\t\t\t __func__);\n> >+\t\t\t\treturn -EOPNOTSUPP;\n> >+\t\t\t}\n> > \t\t} else {\n> > \t\t\tnetdev_err(dev, \"%s: Unsupported action\\n\", __func__);\n> > \t\t\treturn -EOPNOTSUPP;\n> >-- \n> >2.14.1\n> >","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xygPW1nKpz9t4B\n\tfor ;\n\tFri, 22 Sep 2017 01:23:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751811AbdIUPX4 (ORCPT );\n\tThu, 21 Sep 2017 11:23:56 -0400","from stargate.chelsio.com ([12.32.117.8]:22025 \"EHLO\n\tstargate.chelsio.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751787AbdIUPXy (ORCPT\n\t); Thu, 21 Sep 2017 11:23:54 -0400","from localhost (eureka2.asicdesigners.com [10.192.163.201] (may be\n\tforged))\n\tby stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id v8LFNkgk006527; \n\tThu, 21 Sep 2017 08:23:48 -0700"],"Date":"Thu, 21 Sep 2017 08:23:45 -0700","From":"Kumar Sanghvi ","To":"Jiri Pirko ","Cc":"Rahul Lakkireddy ,\n\tnetdev@vger.kernel.org, davem@davemloft.net, ganeshgr@chelsio.com,\n\tnirranjan@chelsio.com, indranil@chelsio.com","Subject":"Re: [PATCH net-next 3/4] cxgb4: add support to offload action vlan","Message-ID":"<20170921152342.GA14071@banjo.asicdesigners.com>","References":"\n\t<016c3bf21a7bfe45e73275d3191cf61cceffd362.1505977744.git.rahul.lakkireddy@chelsio.com>\n\t<20170921085508.GA2028@nanopsycho>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170921085508.GA2028@nanopsycho>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]