[{"id":1772923,"web_url":"http://patchwork.ozlabs.org/comment/1772923/","msgid":"<20170921152654.GF27589@lunn.ch>","list_archive_url":null,"date":"2017-09-21T15:26:54","subject":"Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast\n\trouting offloading logic","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> +static void mlxsw_sp_mr_route_stats_update(struct mlxsw_sp *mlxsw_sp,\n> +\t\t\t\t\t struct mlxsw_sp_mr_route *mr_route)\n> +{\n> +\tstruct mlxsw_sp_mr *mr = mlxsw_sp->mr;\n> +\tu64 packets, bytes;\n> +\n> +\tif (mr_route->route_action == MLXSW_SP_MR_ROUTE_ACTION_TRAP)\n> +\t\treturn;\n> +\n> +\tmr->mr_ops->route_stats(mlxsw_sp, mr_route->route_priv, &packets,\n> +\t\t\t\t&bytes);\n> +\n> +\tswitch (mr_route->mr_table->proto) {\n> +\tcase MLXSW_SP_L3_PROTO_IPV4:\n> +\t\tmr_route->mfc4->mfc_un.res.pkt = packets;\n> +\t\tmr_route->mfc4->mfc_un.res.bytes = bytes;\n\nWhat about wrong_if and lastuse? \n\nIs an mfc with iif on the host, not the switch, not offloaded?\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xygT15QG2z9t4P\n\tfor ;\n\tFri, 22 Sep 2017 01:27:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751826AbdIUP1A (ORCPT );\n\tThu, 21 Sep 2017 11:27:00 -0400","from vps0.lunn.ch ([185.16.172.187]:51405 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751799AbdIUP07 (ORCPT );\n\tThu, 21 Sep 2017 11:26:59 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dv3NO-00008h-Vg; Thu, 21 Sep 2017 17:26:54 +0200"],"Date":"Thu, 21 Sep 2017 17:26:54 +0200","From":"Andrew Lunn ","To":"Jiri Pirko ","Cc":"netdev@vger.kernel.org, davem@davemloft.net, yotamg@mellanox.com,\n\tidosch@mellanox.com, mlxsw@mellanox.com","Subject":"Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast\n\trouting offloading logic","Message-ID":"<20170921152654.GF27589@lunn.ch>","References":"<20170921064338.1282-1-jiri@resnulli.us>\n\t<20170921064338.1282-8-jiri@resnulli.us>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170921064338.1282-8-jiri@resnulli.us>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1773362,"web_url":"http://patchwork.ozlabs.org/comment/1773362/","msgid":"","list_archive_url":null,"date":"2017-09-22T08:36:59","subject":"Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast\n\trouting offloading logic","submitter":{"id":69965,"url":"http://patchwork.ozlabs.org/api/people/69965/","name":"Yotam Gigi","email":"yotamg@mellanox.com"},"content":"On 09/21/2017 06:26 PM, Andrew Lunn wrote:\n>> +static void mlxsw_sp_mr_route_stats_update(struct mlxsw_sp *mlxsw_sp,\n>> +\t\t\t\t\t struct mlxsw_sp_mr_route *mr_route)\n>> +{\n>> +\tstruct mlxsw_sp_mr *mr = mlxsw_sp->mr;\n>> +\tu64 packets, bytes;\n>> +\n>> +\tif (mr_route->route_action == MLXSW_SP_MR_ROUTE_ACTION_TRAP)\n>> +\t\treturn;\n>> +\n>> +\tmr->mr_ops->route_stats(mlxsw_sp, mr_route->route_priv, &packets,\n>> +\t\t\t\t&bytes);\n>> +\n>> +\tswitch (mr_route->mr_table->proto) {\n>> +\tcase MLXSW_SP_L3_PROTO_IPV4:\n>> +\t\tmr_route->mfc4->mfc_un.res.pkt = packets;\n>> +\t\tmr_route->mfc4->mfc_un.res.bytes = bytes;\n> What about wrong_if and lastuse? \n\nwronf_if is updated by ipmr as it is trapped to the CPU. We did not\naddress lastuse currently, though it can be easily addressed here.\n\n>\n> Is an mfc with iif on the host, not the switch, not offloaded?\n\n\nI am not sure I followed. What do you mean MFC with iif on the host? you mean\nMFC with iif that is an external NIC which is not part of the spectrum ASIC? in\nthis case, the route will not be offloaded and all traffic will pass in slowpath.\n\n\n>\n> Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"fYssn4mW\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=yotamg@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz6Kg6t23z9sBd\n\tfor ;\n\tFri, 22 Sep 2017 18:37:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751877AbdIVIhJ (ORCPT );\n\tFri, 22 Sep 2017 04:37:09 -0400","from mail-ve1eur01on0085.outbound.protection.outlook.com\n\t([104.47.1.85]:23720\n\t\"EHLO EUR01-VE1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751792AbdIVIhH (ORCPT );\n\tFri, 22 Sep 2017 04:37:07 -0400","from localhost.localdomain (79.181.49.40) by\n\tDB6PR0502MB2968.eurprd05.prod.outlook.com (2603:10a6:4:97::14) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11;\n\tFri, 22 Sep 2017 08:37:03 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=sx1z3tfMNmS2HRwbnjSctGTHS0xI1GQAIkF6rUGUY4A=;\n\tb=fYssn4mWegHZDFk8QQ0SOZxHHx9ScSDZYML9tuN8KOtvgNe6M3PC9k7d/e86mWkliKUBtuWlCKRPqASFmtLrjHOhLBEO2fap1mQ5ZxV7Qme8hNEt/vUWI3ywIZB2+RwDErk3fwnPOf4rdsHjkxnHwdNaVb/4m1dnDjmQYp5FLLY=","Subject":"Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast\n\trouting offloading logic","To":"Andrew Lunn , Jiri Pirko ","Cc":"netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com,\n\tmlxsw@mellanox.com","References":"<20170921064338.1282-1-jiri@resnulli.us>\n\t<20170921064338.1282-8-jiri@resnulli.us>\n\t<20170921152654.GF27589@lunn.ch>","From":"Yotam Gigi ","Message-ID":"","Date":"Fri, 22 Sep 2017 11:36:59 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170921152654.GF27589@lunn.ch>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Originating-IP":"[79.181.49.40]","X-ClientProxiedBy":"AM5PR0602CA0013.eurprd06.prod.outlook.com\n\t(2603:10a6:203:a3::23) To DB6PR0502MB2968.eurprd05.prod.outlook.com\n\t(2603:10a6:4:97::14)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"35e28391-acfe-4969-5681-08d501951ab4","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DB6PR0502MB2968; ","X-Microsoft-Exchange-Diagnostics":["1; DB6PR0502MB2968;\n\t3:zYefjAjVBo5mhM9mBBj1iC4afzhaJxxBDPCwo3IV3ycMYyX7robR/pEL2tHGJiwLqFE5scF25/B1ynUGomWzQf5NKRC43r84Yvg6w/dysQnn+hSW8G2rksE9KNJTNxt8GbTVwLiEnnjfHUhWbyFiUphUvroH4E0aKo8cAiK2TCMD7HxxilyVFcVQrvBnOdfTYLVmvA2qnEzYV1MV9uZXOP0TeqLQbVfglaUyrtbIlSRGC9HPYxcYQAP/sVcOfKmC;\n\t25:tQ+r7TbKUI+2tWPzN815wYTEheXpTUMN35u6pUjRFfVvf6IQcKyvz7Llkp6UnJgEAEKiD/l4g4EELFMBE4kQX1vPKMEgZZBU/rTDQ0Il6xp/DKLFm3QbcPX0yNkfArdzCqm7gSsGjUrtpRpLjDWjMshoPvCNknon+dEXrwkigmsn4VgD2KdqXW3+7tNlwXbAGQinhAd5Ba4+itTi8gvt4FcWgHmDge3+w2ZaQ3y2C5D0IohOmwY5YAQF+o/0Es6yhIwqCkzixtcygQ5gUCP2+jIEw99zk7PaL4zvxrO6zV+ElZNjnbaAsPK+2JG7/OCpKXWLCAhNMWuubOldIVHxRg==;\n\t31:NOrUay66sU98xVIDU7eChKumv0DA8PKmdB/RLTUS6oAx7EaCKm809KXsT141x2EM6HhRWE4wZB9BmhYGAupIze1yJ4tGlF6uuKjBiDGeDIo9AaP9/Nh9KhVBPtEynjaFa5Rh5sLoV7mlKVbHJE/usGr8rhXKUCREKfaeFcAzuiTbCIz2FkamfSIijJtgG6Lqqgsnuye+GJ1efXY9vwpin2TcA6OThoxRD6/bwYjsXkE=","1; DB6PR0502MB2968;\n\t20:yRnlTPf2ZbeQ5l8Ew8oRyQndhDiDSLQJ6LMWIxlSwcvWo1l48uj8QABZbnXTtwS2UJofjzviaIgaTfdKhAzu1xAQjWpJe5p+C24acms4OY9tQZcoXtXjBcwjYNewVfiiU67F07FZ7iQsWK9sY84jvW7ZEk+mC9XZW1KHQueHlTu3oGQAch9N9syeAiqpMOM0jp4FnDvQvZgsuxt2vo3MiCJSukbGDrSxvg5K/+Qgc8Z3TT1OWRAXyDGA2XPZ5TfRzie2XSEfwuqfiLLJUgYfUc7zuR1z0WpOSnhVrcoEYAkf81O37g+hcJy8ore2C/fJkYcfzm4+KB0UxyW+fRty8q+YGeS1Qpzb4VnpB7MPr34QqvDsLfy72qKHAapZ/6dfWF3jr9NKO/8OrfwVoiV+dwfce5j/F6OcyECNCOMjLu0wbmA8m5V4FDelGfo8Esn+ZrdzGzfME8Y3qrdAgdg4mvoYGGqJ6ZUhdD5/UudtRFNEAvWJfb/W7m3JiUCrFgQ9;\n\t4:Wj0F1hbgjGznL3pAPEngfesIamp5oj2Hb0Qg4/vx7PuhvdifpQyVTlS7qzl2tG65lwk/fBNIRXyCV796dKtSAUeqedTl4bAtESIU2+cnOPGlSV8XScn67DKQgqHXxngii7BG5BrlIRfxiGvJdp/F2KKTTGlvho+ELSbX+shNZHDvjVPMVaOzx6s1p2FYSN5ywNRfIfdTRHR06RM1W/mmImm1DzHqY94oJrcEn1PsCliXr8bc/2na4jtKlFXzhTuy","=?utf-8?q?1=3BDB6PR0502MB2968=3B23=3AUb?=\n\t=?utf-8?q?319v4iuhxLzNdRJ47HEQnGb6IjIGWBBzsG50ZTOMFcQWln4Q23SY0nFe?=\n\t=?utf-8?q?hqYE9ltZ4LfsKkJt5rNbMoD6kK/DrJpps4EE5+MMgpAxfMKtcSJSVZ0M?=\n\t=?utf-8?q?HHflN8fb8r/xRgQO5L34CX0Jiw3Y0t1l5nzqhoiJwjHWI7BpMZdNJN2+?=\n\t=?utf-8?q?5fNfJ+Rl3YD9rKitbB0aZeZ9Ubz6yVcY1ntl3QWCYytVD6bSzzKJOXD1?=\n\t=?utf-8?q?RgGFQwwDprQh9zU9Pjf5aN+SnbFtdB5HIZZKrflV4EBVrimSSQNuYCTL?=\n\t=?utf-8?q?+LZ9I2epdF3qBm0PRlJA33D/lhR4UsRKn8A02rmTyA34tGduD1jQfVl4?=\n\t=?utf-8?q?/16kqs+idtf8I8BKPY3qKJroJ8PaTyeaB235rtB0Jia7Y5fng7H2kk5Q?=\n\t=?utf-8?q?K4KSvjSW4LxYWdmCJGKyFz9s7iIoZczCZ3PmeUwSZuKIij+VmZGd5/20?=\n\t=?utf-8?q?/pqnI5uIiaudaeDiXvnRm6FjkKhxrC0wsnGAZyKUjA0W0g76LkCQbkCX?=\n\t=?utf-8?q?y7ir9Ct3PRqlGWRn1htdabsyZXeS4FY4G+1jYZ9hWJ1iuZNNqF3Qa5np?=\n\t=?utf-8?q?4LkoF5kw1gf+G9D1uZX232F9j+WSSulbiZ5lfzKLR3bIJCy3Riz17/NF?=\n\t=?utf-8?q?Q5jqwg0ibJoXm6O0JXZghcxTH06NC0jLwa1WHcelt5WppEI5hYBi5BHD?=\n\t=?utf-8?q?8PWHB522lOR29p2W3O2gavDrwr6V2Iz5bAQkpAht0cqAwlelZq57uD3x?=\n\t=?utf-8?q?qtpDxRF8fN5wE5rbVAVZ0pUeX6izANMM2LFppptycH3Uxe3O8nKIQCoI?=\n\t=?utf-8?q?NqwT+CG10z05Gw4PS2cyNDb4hcL9AnL04T38GI/3l9TTf+4haLSt3sr3?=\n\t=?utf-8?q?kMs/xsk6F04MKzz/ZwCPtrAs3r7aZPYyFmfXT0T5bt2slJbfbH3C1c+u?=\n\t=?utf-8?q?2KZqdt539Llf7OTT5sB+bKUuGCIM31nDCAs0LZI3InnIz/Z6ja7oEPPM?=\n\t=?utf-8?q?xONJ/IilIcXaBWummG4DhgR0D0c856mWXo5AkZqvao1JkTjiIfMSEtwO?=\n\t=?utf-8?q?n4GG53tAdrNUOBXFIINNUB1oKDNFu5vGlnUG5ZTNTspIP5gPDASGahc+?=\n\t=?utf-8?q?5GaEG+aNqNQrUH/Wmc2rd61UiIX5SqwT55qRtVdtrVraRTdLa6iKYSWv?=\n\t=?utf-8?q?lcXy7qeCaa9xfc//yKdt5Byx6oHO5hsr1P2gIUKymb/rreYCeNeLET9n?=\n\t=?utf-8?q?4DFswa+zHE1nKmHncSeOfMlet8++Xtsc2hRIYdT+H6N9YIBuGWLS+4Da?=\n\t=?utf-8?q?DYI28ve+HKAPO/uou2hS3OIzF0SvGNiA5Bh6MoSPr+5vSSukZ8JuYHEM?=\n\t=?utf-8?q?gguOED+L4COAoTJxrFOGlFelVmxkMt+w/vaMVU8JjHCJwrJCuC943B7K?=\n\t=?utf-8?q?B4VB3OcxMWTAdnUmyGImFPi30kE9APWLBUGQdiDixcxzKY20cFwF+9lp?=\n\t=?utf-8?q?9EjWvCkqNKBFc4xzwJzQWn4lBMlI1CgSCd5yoEXwuOSetipUI=3D?=","1; DB6PR0502MB2968;\n\t6:leJ8egaEe0w3eeRLcVVgZ+8VaeeZ0CfTt8PgOOMd63d35GibvXRmtWUvoLxBu9bP02erp2cWikFeNFtfkBlR90rcXN9xAopTG9N7cnhAmpTsSbcZJex5CXkxRiBoGWSCuj9qGbQwczk0wFzVafNfoyLmXMIgcBWa70APYdusNeWEpUDHpjMZy3uTKA40cT1T2j6vUltvzL0E0veVnR6GavtbsxcSAB2duUb9CEEDY/R6hkMgTNpp7w6LF6/6Z5UTMVMuSg78eytLZp39goNvS05ddwcYr/abf+ZqbLu4UJwLlPod2o/ABadQqMIqLiAQHOk7994OeCoa3RnGmwPP7A==;\n\t5:oGgmCHKtX4t4AT6N1pwJgyusJxTiVw7FfVol7hHO3ZVNlQ05ZKd5uE7qBzcWtUSYBKLuY32QZ1RQRz9DVurV0SzOq2Y+i8E0gNf3j51lixB6qruV9TBnJau5mNiuY6uFBBi1BJ68LN6Hf1SAPZOApQ==;\n\t24:qaxXnZoPVyfoCf3fwTgGYq1tg5b9696THxp3zhwu2j8sOlq7/WtqS3vLjZ4ivhWDW+3Mp1tYMEKmrixlkziH1bCtalnwmsGkrycu0pDrE2Y=;\n\t7:OKTER3BCgX/KQOZ3WwGSrUkHqkGxeRGXh2qrKP56J7wxXeDINguCVPjWK8KTDtFni9xcx4RiqwfWBLN+SKPLbAzM6MYz3PwcnSTqanmA2UAE04rHuOcvDZI+AQr6ZmleQhwQPlQeNRyQkaaZwjWNTqls/NQJWfVNloo4DOT5PgdevjwlupDlX4a28laTNFG3DZjciCE6FQFIyHMXmxtH+hhO7vHdz6b2NMgB/OcVzEA="],"X-MS-TrafficTypeDiagnostic":"DB6PR0502MB2968:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB6PR0502MB2968; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB6PR0502MB2968; ","X-Forefront-PRVS":"0438F90F17","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(7370300001)(4630300001)(6009001)(6069001)(39860400002)(346002)(376002)(377454003)(199003)(189002)(24454002)(83506001)(2906002)(7736002)(229853002)(478600001)(97736004)(81166006)(54356999)(76176999)(81156014)(3846002)(6512007)(6116002)(65806001)(230700001)(23676002)(65956001)(66066001)(8676002)(50986999)(50466002)(189998001)(101416001)(53936002)(33646002)(36756003)(65826007)(107886003)(25786009)(6246003)(16526017)(68736007)(47776003)(58126008)(53546010)(6486002)(5660300001)(106356001)(64126003)(7350300001)(110136005)(6506006)(2950100002)(31696002)(316002)(86362001)(305945005)(31686004)(6666003)(105586002)(4326008);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0502MB2968;\n\tH:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords;\n\tA:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"22 Sep 2017 08:37:03.8980\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB6PR0502MB2968","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1773588,"web_url":"http://patchwork.ozlabs.org/comment/1773588/","msgid":"<20170922132152.GB31634@lunn.ch>","list_archive_url":null,"date":"2017-09-22T13:21:52","subject":"Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast\n\trouting offloading logic","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Fri, Sep 22, 2017 at 11:36:59AM +0300, Yotam Gigi wrote:\n> On 09/21/2017 06:26 PM, Andrew Lunn wrote:\n> >> +static void mlxsw_sp_mr_route_stats_update(struct mlxsw_sp *mlxsw_sp,\n> >> +\t\t\t\t\t struct mlxsw_sp_mr_route *mr_route)\n> >> +{\n> >> +\tstruct mlxsw_sp_mr *mr = mlxsw_sp->mr;\n> >> +\tu64 packets, bytes;\n> >> +\n> >> +\tif (mr_route->route_action == MLXSW_SP_MR_ROUTE_ACTION_TRAP)\n> >> +\t\treturn;\n> >> +\n> >> +\tmr->mr_ops->route_stats(mlxsw_sp, mr_route->route_priv, &packets,\n> >> +\t\t\t\t&bytes);\n> >> +\n> >> +\tswitch (mr_route->mr_table->proto) {\n> >> +\tcase MLXSW_SP_L3_PROTO_IPV4:\n> >> +\t\tmr_route->mfc4->mfc_un.res.pkt = packets;\n> >> +\t\tmr_route->mfc4->mfc_un.res.bytes = bytes;\n> > What about wrong_if and lastuse? \n\nHi Yotam\n\n> wronf_if is updated by ipmr as it is trapped to the CPU.\n\nGreat.\n\n> We did not address lastuse currently, though it can be easily\n> addressed here.\n\nPlease do. I've written multicast routing daemons, where i use it to\nflush out MFCs which are no longer in use. Having it always 0 is going\nto break daemons.\n \n> > Is an mfc with iif on the host, not the switch, not offloaded?\n> \n> \n> I am not sure I followed. What do you mean MFC with iif on the host? you mean\n> MFC with iif that is an external NIC which is not part of the spectrum ASIC?\n\nYes. We probably have different perspectives on the world. To\nMellanox, everything is a switch in a box. In the DSA world, we tend\nto think of having a general purpose machine which also has a switch\nconnected. Think of a wireless access point, set top box, passenger\nentertainment system. We have applications on the general purpose\ncomputer, we have wifi interfaces, cable modems, etc. Think about all\nthe different packages in LEDE. We might have a multicast video\nstream, coming from the cable modem being sent over ports of the\nswitch to clients.\n\nSo when i look at these patches, i try to make sure the general use\ncases works, not just the plain boring Ethernet switch box use cases\n:-)\n\n> in this case, the route will not be offloaded and all traffic will\n> pass in slowpath.\n\nO.K. I was just thinking if those counters need to be +=, not =. But\neither the iif is on the host, or it is in the switch. It cannot be\nboth. So = is O.K.\n\nThanks\n\tAndrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzDfJ4Fd1z9sP1\n\tfor ;\n\tFri, 22 Sep 2017 23:22:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752052AbdIVNV5 (ORCPT );\n\tFri, 22 Sep 2017 09:21:57 -0400","from vps0.lunn.ch ([185.16.172.187]:52491 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751926AbdIVNV4 (ORCPT );\n\tFri, 22 Sep 2017 09:21:56 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dvNtw-0008Nx-SK; Fri, 22 Sep 2017 15:21:52 +0200"],"Date":"Fri, 22 Sep 2017 15:21:52 +0200","From":"Andrew Lunn ","To":"Yotam Gigi ","Cc":"Jiri Pirko , netdev@vger.kernel.org,\n\tdavem@davemloft.net, idosch@mellanox.com, mlxsw@mellanox.com","Subject":"Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast\n\trouting offloading logic","Message-ID":"<20170922132152.GB31634@lunn.ch>","References":"<20170921064338.1282-1-jiri@resnulli.us>\n\t<20170921064338.1282-8-jiri@resnulli.us>\n\t<20170921152654.GF27589@lunn.ch>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1774008,"web_url":"http://patchwork.ozlabs.org/comment/1774008/","msgid":"","list_archive_url":null,"date":"2017-09-23T09:32:11","subject":"Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast\n\trouting offloading logic","submitter":{"id":69965,"url":"http://patchwork.ozlabs.org/api/people/69965/","name":"Yotam Gigi","email":"yotamg@mellanox.com"},"content":"On 09/22/2017 04:21 PM, Andrew Lunn wrote:\n> On Fri, Sep 22, 2017 at 11:36:59AM +0300, Yotam Gigi wrote:\n>> On 09/21/2017 06:26 PM, Andrew Lunn wrote:\n>>>> +static void mlxsw_sp_mr_route_stats_update(struct mlxsw_sp *mlxsw_sp,\n>>>> +\t\t\t\t\t struct mlxsw_sp_mr_route *mr_route)\n>>>> +{\n>>>> +\tstruct mlxsw_sp_mr *mr = mlxsw_sp->mr;\n>>>> +\tu64 packets, bytes;\n>>>> +\n>>>> +\tif (mr_route->route_action == MLXSW_SP_MR_ROUTE_ACTION_TRAP)\n>>>> +\t\treturn;\n>>>> +\n>>>> +\tmr->mr_ops->route_stats(mlxsw_sp, mr_route->route_priv, &packets,\n>>>> +\t\t\t\t&bytes);\n>>>> +\n>>>> +\tswitch (mr_route->mr_table->proto) {\n>>>> +\tcase MLXSW_SP_L3_PROTO_IPV4:\n>>>> +\t\tmr_route->mfc4->mfc_un.res.pkt = packets;\n>>>> +\t\tmr_route->mfc4->mfc_un.res.bytes = bytes;\n>>> What about wrong_if and lastuse? \n> Hi Yotam\n>\n>> wronf_if is updated by ipmr as it is trapped to the CPU.\n> Great.\n>\n>> We did not address lastuse currently, though it can be easily\n>> addressed here.\n> Please do. I've written multicast routing daemons, where i use it to\n> flush out MFCs which are no longer in use. Having it always 0 is going\n> to break daemons.\n\nI will. Thanks for the feedback!\n\n> \n>>> Is an mfc with iif on the host, not the switch, not offloaded?\n>>\n>> I am not sure I followed. What do you mean MFC with iif on the host? you mean\n>> MFC with iif that is an external NIC which is not part of the spectrum ASIC?\n> Yes. We probably have different perspectives on the world. To\n> Mellanox, everything is a switch in a box. In the DSA world, we tend\n> to think of having a general purpose machine which also has a switch\n> connected. Think of a wireless access point, set top box, passenger\n> entertainment system. We have applications on the general purpose\n> computer, we have wifi interfaces, cable modems, etc. Think about all\n> the different packages in LEDE. We might have a multicast video\n> stream, coming from the cable modem being sent over ports of the\n> switch to clients.\n>\n> So when i look at these patches, i try to make sure the general use\n> cases works, not just the plain boring Ethernet switch box use cases\n> :-)\n\nSo when doing it, we did think about multi-ASIC situations, so I think it should\nfit :)\n\n>\n>> in this case, the route will not be offloaded and all traffic will\n>> pass in slowpath.\n> O.K. I was just thinking if those counters need to be +=, not =. But\n> either the iif is on the host, or it is in the switch. It cannot be\n> both. So = is O.K.\n>\n> Thanks\n> \tAndrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"ZfJhCLT3\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=yotamg@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzlW71ZQFz9t4B\n\tfor ;\n\tSat, 23 Sep 2017 19:32:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750896AbdIWJc1 (ORCPT );\n\tSat, 23 Sep 2017 05:32:27 -0400","from mail-db5eur01on0087.outbound.protection.outlook.com\n\t([104.47.2.87]:36496\n\t\"EHLO EUR01-DB5-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1750766AbdIWJcY (ORCPT );\n\tSat, 23 Sep 2017 05:32:24 -0400","from localhost.localdomain (79.181.49.40) by\n\tAM5PR0502MB2964.eurprd05.prod.outlook.com (2603:10a6:203:96::14) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7;\n\tSat, 23 Sep 2017 09:32:19 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=JeEodfE8ovV9YIRpTla1JiNVd9dAm6jxoi3cLJ/ZBCg=;\n\tb=ZfJhCLT3+o+RmA8gT+sU/vmaXpKqPFjdd7aYARRJHp3+rohf1O1n/eGLbopd7sW2yQrGuvhYxtl0IuoZY+rKIOAl4eRyNIGz6ZagmJjJ/Z4tyFJoqWStP882Og7sA3X1wrk2ViKZ9zQ54M2i233UIRPR+HM9qTOP7spEpVsW9eI=","Subject":"Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast\n\trouting offloading logic","To":"Andrew Lunn ","Cc":"Jiri Pirko , netdev@vger.kernel.org,\n\tdavem@davemloft.net, idosch@mellanox.com, mlxsw@mellanox.com","References":"<20170921064338.1282-1-jiri@resnulli.us>\n\t<20170921064338.1282-8-jiri@resnulli.us>\n\t<20170921152654.GF27589@lunn.ch>\n\t\n\t<20170922132152.GB31634@lunn.ch>","From":"Yotam Gigi ","Message-ID":"","Date":"Sat, 23 Sep 2017 12:32:11 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170922132152.GB31634@lunn.ch>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Originating-IP":"[79.181.49.40]","X-ClientProxiedBy":"HE1PR0102CA0040.eurprd01.prod.exchangelabs.com\n\t(2603:10a6:7:7d::17) To AM5PR0502MB2964.eurprd05.prod.outlook.com\n\t(2603:10a6:203:96::14)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"218f488e-95ba-4a24-e2e2-08d50265fd56","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:AM5PR0502MB2964; ","X-Microsoft-Exchange-Diagnostics":["1; AM5PR0502MB2964;\n\t3:qorOUuwYI1KG92pWXDcsOg5CpBrz7B0K0Nki2zMffvmWByrd49N16ZBjNyx7DSL0C14AS1Fl7hjlqZ1toPnboENIVmaZlsegd8t2/Td2LYsE0BhWyay6EASPnl+W9IHUe+Gf8zfgm65o+F70njtg72RvkSUSYtC8+kn7W/SH/Kc8494TI9G6J/9Mim3negppTS+tMkHPeT0LwCxOwOZ782dmvfZdmal8PJPh1L2H59m99qocMw4uwZ+CJhwVxunE;\n\t25:+AgCUtS5HtFfc1SMf5J+ke5gv/PlQ25C+AomYIVr1NYY4RobAnHdPzpOjwGb/tKQBm1GemfwZYqaYKJQocJ1Suvn8nlbx2/6ibMJjyyi3D+wMHsz3FrTpEXC0bvNMrH0y44lCJofNAF1+mcVpq0UeiKjeak1xWCWY5Vmjumm7A/CAW2QhV+ODWovs60Oag/mWqEcMX2EWIKKZ31Xv8ZocJqoiMT+lr2d3FqQS+lDmEqd5jHl/YLNCgasVpnrYkQxNNSdIY/kXbm+ixyu5h/MS20GyhAOTzH3xYF4aeHbsxaWGEOrTXeDXlOE3QnC5T12JQnMUSOSneneMisfWpWRvw==;\n\t31:ijmbqzUXvxQxKvDhlCIczojiIz0rqXfqixRgR9t4nx/MsM4qqVQs+ysi33o39XSHK+uPigx7QIGlAvPyy4A5qrkpf6GoTgm3Bez5Pgdw0ijoD/YfhxCL75POoaWSExzknV+FxavpPV4YzmzzkuT8G032+dAmtepsFCGFyJSvkXLxS13c8dzNAOWRD5WokhwwzMezG4QuVpEayUVkE8RliOtQuq0VUp+7VtgabW5RjTw=","1; AM5PR0502MB2964;\n\t20:HmfH7hLQnIrbodD9TFlXyESwDHLiB3BG0xWembPUFqvVwoqj2zpUoKXbzcuukUwfxr17Q3yXBJKtnNaBSH8h6wQmOzFYGI5/Rlh/CAAUnWITF3AXMJd/ypwgiAV97Ue3YJAYNcGARSImAfdHBc9IYyqqsXNsjvbaeMlHiLADWv15MFTbW/X1xN4vCghqFkWZeCC2QAkx9MEu5IVDODZAEFIFwgrOJ9h9HnF4d9EIJF6B17kKtRXaGhx3JwLeoNs14gLR7e3KiR2wxOgy8mn9H8ukfzEfeyHFr4ZM/wY4mSUpM30IijULP0Cq1u8maWSMec4JcyLQaf1nclalNvkvY7o0raBl1DFt05JVvqG0trysxhpQVyUrk2Grklp0jzw5UmJJJANgK0gTzbCCSrntbQigCJJ986qsQfkALry5EQAb9/OI9Wra0F30oLWo+ktoXrvSNjMbIWEQq+ATK9HXMiHjwvabKHJUMsgWhkzdXK6cawQR34hiPunlY+oFZn85;\n\t4:rB5kYvW3lmyaBydljc+UsAX0skDC03A6K4mtbhz6l6ZKSv6rpRbzjzv/VRnBAnCpYtpd63AHvZhi+aZjld4MxjR8rWi0U4SxKwlz6mkd6Rk1dcyNc8vP2Fqk9lJAPkWgFoj3i2+Ti2tXj/sOCcBtEXXKsCHdWyw8WzDDmq2YxeAmtZGLpYXDxVUMwgw096T7oYxuUPyfhETbOTm4OdMEFC4ENMT9uIboHG5i+cJgPTAc/2YL03Czuzwu46BHXZ/fGz4VlKEHqYaIk9pYKAXxFqVo7dpJ2NX2guknRm4itIs=","=?utf-8?q?1=3BAM5PR0502MB2964=3B23=3AsU?=\n\t=?utf-8?q?hx2OaST7x+UkkiXH74PO1MtmdXi76jDdXRryTxxguuABVodsqvx3kgCe?=\n\t=?utf-8?q?db/I/ppzNdJpuJ3QDgahNKuWx2MVwsMtz/DA2gK1KZLVz0W3ZPuvdPSF?=\n\t=?utf-8?q?FWrgVMaOPkKJg0XTGYf5MtYDO/BQBRZf6EqV9Ztx4ZWWx9I8tV/YY4Jj?=\n\t=?utf-8?q?T2ds77GSq4UMYEVoGcQSNJOtJq8v5VmJracNyshoyWCNzuId5c+FDDdQ?=\n\t=?utf-8?q?ijd7DG4t1GToHPwJJWPZwkAyyyUtJZ2PvrsgDWLrYuOYDb+kDRAl4r6z?=\n\t=?utf-8?q?MnhWBykz7EyJxei3K+yGDW97sNZGAT0qKiqOiG7i7ELVw6U/rrax2rR+?=\n\t=?utf-8?q?vNaRaAI6QOJqc4FELMGcEuhYmyVq8VCqyFc7OQFPs/MeqMBSIF4M0S4A?=\n\t=?utf-8?q?Ihl3Kl/fomdldZTnARZVdwl16fHXyD2mHb+ww8v4WJBH7S8jKUhAcRWY?=\n\t=?utf-8?q?szsnknykSU9PLC6vY5TtazvD8nDE8ippwv14opyQtzRCbIiOe2OmgAcH?=\n\t=?utf-8?q?SvQjw18NnldR3w1kCmJkvf9v9h/FkjS6ZV4zPafNXkpZq+I3ca9zqxI9?=\n\t=?utf-8?q?phbphGQb3Fi0FcNakUUhYHrrQ6anWnIgw9BkkVgGXxfte6J7mWQZoiGI?=\n\t=?utf-8?q?lX9HX9Ubf62Z4a+XpKobycVlLCIDzu8Iz+iforP8MksrSwCTXkupswZU?=\n\t=?utf-8?q?crPYX0uOylJVao7BNpqMYGwsfUfTuhs2T3w5CavJGq2CSG0aWU2VsEjN?=\n\t=?utf-8?q?iauDv05IkKrcn7kA7LUD5l+xr9fzO3XKhbPyKixHAZFouvqui6ZQTsso?=\n\t=?utf-8?q?EDxAgDb23rG+2CoBxIFpftQfuRn6g7F+ACKUZB8eIHDSX50Ah4pW6REh?=\n\t=?utf-8?q?z9g3CSWpBOIQkRYdCXkEYxDwaOoyJQC0iKwgXOchh214t5sVyixFxfjH?=\n\t=?utf-8?q?etVnpGzCFzyCPd2vOSvAxrCLqg0gyyE0NMJvFIbOAaGam7mpHu+AiTCL?=\n\t=?utf-8?q?4SMyt7hK/7ZdNpRpVq1ou8WpXKXgQTzVMI3xw4qBwgM3pU9/G6qvD0Z0?=\n\t=?utf-8?q?VaiWByqdi1HPAZE0lnhzJtHLooXRYl+Pu/Lcf+V2auZFGQwcmiwP8Uf3?=\n\t=?utf-8?q?CEi2I0ZQvjMMOqqsbG7kWaW44DSomaMHHFJkQV4eVCSxGP/307tDlWr2?=\n\t=?utf-8?q?3j+WCom8E+uWiyePmMRLhLtlDiI42OP4jxee3JfyGXYl34DLtK3oWDNf?=\n\t=?utf-8?q?vW8iOybbSJjNyJLWuHTTkA3jW3UL195O49jqbGDK/iv+yUR4BW0z6yLj?=\n\t=?utf-8?q?rVMBdUwIeWvXBk68prQXfs8g94G961bh3SbFl3R70r/48umeCvXMoGbA?=\n\t=?utf-8?q?/kQ3+7rmKXB08uwG43zn5O9rIz5d6PYrRo9CrkFF1nFf52RFMDLGiJKH?=\n\t=?utf-8?q?0U5FrrA+H2oZuLJaZDYgppkfZm7NKRDrSYXN+NlR9L4giWQvoUei0gYK?=\n\t=?utf-8?q?p/8gfhJnicJxoO32ymic8vXUL4dg=3D=3D?=","1; AM5PR0502MB2964;\n\t6:3/sLK0dq80p++i78eTN552MI455kxeNrYbuDQK3PxmRrIbXXDJshpTQ1Lo0od1ki+ApeQk39H3Oet/fz/RbO0HgFe4lylfALR+Rq9MHXhDkQhwtYCrD1DMJsffEqgi2xZpAKbwcu0Zm9qdPvA9NdOTV09oK+yElbon0Dfhk1T6BNkuIJi/sJMiItuNME9XuR2NyeJkzaxIxYFy5xJ/W0g3CV8MUUsQsCIIj5TTkKWJaDZ0xvG/g/U8wgv3KFoMRd2sGSBhVKXAkiMx04aZUFZSqjosobOjKidP+Dr1r+VH7WJs/n+TMu6rAgEX2YEjHjBjQy+ChfTsxrH+AfmoXgIg==;\n\t5:ljWMRt85PO1GVHyxLR33R2sy4o4srDCg6v/bWaZfmLfXqCT8basRwktwTK9dS2G9qHgmRtXfeJnW2Rjco7w18b9Mpjz9sGD461aMTLDXiFGyetbKfz3RYmHTT0yANiD5pg0voh88L6+bL/QhoZCkiw==;\n\t24:xRGEXx12p2gVpjGSvrF0+DYypMnxStVaRaLxdXascHj6HaRElTOdePP4WQjdoxIDLvyRuViFaeaRToP6sUIGEY15Ei6rW1Qktm6xuyUVEY8=;\n\t7:/V6fLBtgzvs2ZuWPBFMFLPfq+LsDqM+7BY5Ho3r5LKWWqJGXitYB2SDQe84cm8tR5wcLw3Ov81U5Lv4zFGMN4joGGNtzgYrNmAGE3HjUXh3o2gjjjWF+lYOwhcCmzrGkRQUpA0bescso3nIEfyWzgz83vvhyuMM+0J1BP4PNULg7apLO6zUVfNx5ZogDJPn602k8u5XpLBAS4ua+L1/hIFyCuau6QWEFfNuP5jXIz9k="],"X-MS-TrafficTypeDiagnostic":"AM5PR0502MB2964:","X-Exchange-Antispam-Report-Test":"UriScan:(278428928389397);","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(20161123560025)(20161123558100)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:AM5PR0502MB2964; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:AM5PR0502MB2964; ","X-Forefront-PRVS":"0439571D1D","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(6069001)(6009001)(376002)(346002)(39860400002)(189002)(24454002)(377454003)(51914003)(199003)(189998001)(31696002)(53546010)(83506001)(31686004)(97736004)(47776003)(230700001)(316002)(2950100002)(6666003)(6116002)(86362001)(6916009)(50466002)(16526017)(478600001)(23676002)(3846002)(229853002)(93886005)(66066001)(8936002)(50986999)(8676002)(65806001)(81166006)(36756003)(65956001)(58126008)(6506006)(5660300001)(76176999)(6486002)(4326008)(54356999)(25786009)(81156014)(33646002)(305945005)(53936002)(105586002)(6246003)(6512007)(106356001)(7736002)(65826007)(64126003)(68736007)(101416001)(2906002)(107886003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0502MB2964;\n\tH:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords;\n\tMX:1; A:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"23 Sep 2017 09:32:19.4637\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"a652971c-7d2e-4d9b-a6a4-d149256f461b","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM5PR0502MB2964","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1774027,"web_url":"http://patchwork.ozlabs.org/comment/1774027/","msgid":"<20170923144112.GB21228@lunn.ch>","list_archive_url":null,"date":"2017-09-23T14:41:12","subject":"Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast\n\trouting offloading logic","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> > So when i look at these patches, i try to make sure the general use\n> > cases works, not just the plain boring Ethernet switch box use cases\n> > :-)\n> \n> So when doing it, we did think about multi-ASIC situations, so I think it should\n> fit :)\n\nMaybe, maybe not. DSA is multi switch. That is what the D means,\nDistributed. All switches in a cluster are presented to the software\nstack as a single switch.\n\nIf your multi-ASIC architecture is the same, a distributed switch,\nthen you don't cover the general case. If you represent it as two\nswitches, with frames going between switches going via CPU, then yes,\nyou probably cover the general case.\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xztMS1kt3z9t4B\n\tfor ;\n\tSun, 24 Sep 2017 00:41:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750916AbdIWOlR (ORCPT );\n\tSat, 23 Sep 2017 10:41:17 -0400","from vps0.lunn.ch ([185.16.172.187]:53221 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750769AbdIWOlR (ORCPT );\n\tSat, 23 Sep 2017 10:41:17 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dvlcG-0005cE-Si; Sat, 23 Sep 2017 16:41:12 +0200"],"Date":"Sat, 23 Sep 2017 16:41:12 +0200","From":"Andrew Lunn ","To":"Yotam Gigi ","Cc":"Jiri Pirko , netdev@vger.kernel.org,\n\tdavem@davemloft.net, idosch@mellanox.com, mlxsw@mellanox.com","Subject":"Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast\n\trouting offloading logic","Message-ID":"<20170923144112.GB21228@lunn.ch>","References":"<20170921064338.1282-1-jiri@resnulli.us>\n\t<20170921064338.1282-8-jiri@resnulli.us>\n\t<20170921152654.GF27589@lunn.ch>\n\t\n\t<20170922132152.GB31634@lunn.ch>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]