[{"id":1772488,"web_url":"http://patchwork.ozlabs.org/comment/1772488/","msgid":"<20170921072737.lkk7gzgjxxigoaji@flea>","list_archive_url":null,"date":"2017-09-21T07:27:37","subject":"Re: [U-Boot] [PATCH v2 3/3] dts: sunxi: add PWM node for sun50i","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Thu, Sep 21, 2017 at 06:07:04AM +0000, Vasily Khoruzhick wrote:\n> Add PWM definition to sun50i-a64.dtsi - it's compatible with PWM found on H3\n> \n> Signed-off-by: Vasily Khoruzhick \n> ---\n> v2: - drop 'sun50i-a64-pwm' compatible string and use 'sun8i-h3-pwm' instead,\n> since A64 PWM is compatible with one on H3\n> \n> arch/arm/dts/sun50i-a64.dtsi | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/arch/arm/dts/sun50i-a64.dtsi b/arch/arm/dts/sun50i-a64.dtsi\n> index 65a344d9ce..00132855ff 100644\n> --- a/arch/arm/dts/sun50i-a64.dtsi\n> +++ b/arch/arm/dts/sun50i-a64.dtsi\n> @@ -319,6 +319,14 @@\n> \t\t\t};\n> \t\t};\n> \n> +\t\tpwm: pwm@01c21400 {\n> +\t\t\tcompatible = \"allwinner,sun8i-h3-pwm\";\n\nYou'd need both compatible. The A64 you used to have, plus that one.\n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xySr84zJ4z9s7h\n\tfor ;\n\tThu, 21 Sep 2017 17:27:51 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid CE87EC21F6B; Thu, 21 Sep 2017 07:27:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1B238C21E85;\n\tThu, 21 Sep 2017 07:27:41 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 6A977C21E85; Thu, 21 Sep 2017 07:27:39 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby lists.denx.de (Postfix) with ESMTP id 2FCA7C21E23\n\tfor ; Thu, 21 Sep 2017 07:27:38 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 398F620878; Thu, 21 Sep 2017 09:27:37 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 0FC66207EB;\n\tThu, 21 Sep 2017 09:27:37 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","Date":"Thu, 21 Sep 2017 09:27:37 +0200","From":"Maxime Ripard ","To":"Vasily Khoruzhick ","Message-ID":"<20170921072737.lkk7gzgjxxigoaji@flea>","References":"<20170921060704.19153-1-anarsoul@gmail.com>\n\t<20170921060704.19153-4-anarsoul@gmail.com>","MIME-Version":"1.0","In-Reply-To":"<20170921060704.19153-4-anarsoul@gmail.com>","User-Agent":"NeoMutt/20170914 (1.9.0)","Cc":"Andre Przywara , Jagan Teki ,\n\ticenowy@aosc.io, u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH v2 3/3] dts: sunxi: add PWM node for sun50i","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============3057430902027338440==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1773256,"web_url":"http://patchwork.ozlabs.org/comment/1773256/","msgid":"","list_archive_url":null,"date":"2017-09-22T04:45:19","subject":"Re: [U-Boot] [PATCH v2 3/3] dts: sunxi: add PWM node for sun50i","submitter":{"id":6930,"url":"http://patchwork.ozlabs.org/api/people/6930/","name":"Vasily Khoruzhick","email":"anarsoul@gmail.com"},"content":"On Thu, Sep 21, 2017 at 12:27 AM, Maxime Ripard\n wrote:\n> On Thu, Sep 21, 2017 at 06:07:04AM +0000, Vasily Khoruzhick wrote:\n>> Add PWM definition to sun50i-a64.dtsi - it's compatible with PWM found on H3\n>>\n>> Signed-off-by: Vasily Khoruzhick \n>> ---\n>> v2: - drop 'sun50i-a64-pwm' compatible string and use 'sun8i-h3-pwm' instead,\n>> since A64 PWM is compatible with one on H3\n>>\n>> arch/arm/dts/sun50i-a64.dtsi | 8 ++++++++\n>> 1 file changed, 8 insertions(+)\n>>\n>> diff --git a/arch/arm/dts/sun50i-a64.dtsi b/arch/arm/dts/sun50i-a64.dtsi\n>> index 65a344d9ce..00132855ff 100644\n>> --- a/arch/arm/dts/sun50i-a64.dtsi\n>> +++ b/arch/arm/dts/sun50i-a64.dtsi\n>> @@ -319,6 +319,14 @@\n>> };\n>> };\n>>\n>> + pwm: pwm@01c21400 {\n>> + compatible = \"allwinner,sun8i-h3-pwm\";\n>\n> You'd need both compatible. The A64 you used to have, plus that one.\n\nWhy? Hardware seems to be identical and I see a number of non-A64\ncompatibles in sun50i-a64.dtsi.\nWhat's rationale behind adding a new string?\n\n>\n> Maxime\n>\n> --\n> Maxime Ripard, Free Electrons\n> Embedded Linux and Kernel engineering\n> http://free-electrons.com","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mqAdVy0M\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz1Bm0Cjlz9sNr\n\tfor ;\n\tFri, 22 Sep 2017 14:45:51 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid AB4FBC21EB9; Fri, 22 Sep 2017 04:45:45 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 213F0C21C58;\n\tFri, 22 Sep 2017 04:45:43 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 136FCC21C58; Fri, 22 Sep 2017 04:45:41 +0000 (UTC)","from mail-io0-f195.google.com (mail-io0-f195.google.com\n\t[209.85.223.195])\n\tby lists.denx.de (Postfix) with ESMTPS id 88AD3C21C26\n\tfor ; Fri, 22 Sep 2017 04:45:40 +0000 (UTC)","by mail-io0-f195.google.com with SMTP id n69so302017ioi.3\n\tfor ; Thu, 21 Sep 2017 21:45:40 -0700 (PDT)","by 10.157.9.69 with HTTP; Thu, 21 Sep 2017 21:45:19 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=J78ssP8XqNBEIHkUfgel2dcYRu7rrWnGoQ26Y5QFRmE=;\n\tb=mqAdVy0MIN9os03pCjgdoRDBdNZEhB80t24djcIyn5maDXFASh9sY3YAHpMwaKH/Ux\n\tNqwY4KPzK9aRgy+DcfvcWXeCkNqG2gs31qsn3Dnurx2LhMMk/CqJwMjdovO+L7WdNych\n\ttsQVLmm+F+tZr6S48mEH79Zpn+chF4iiA7kjWwi3GgvtPRZ4Zo4U7HL5SHpl6lOzVdq/\n\ttNpAbTe1plZ3I40OumWN31pKV9ISJSBUWdACOHada8nA8l5A8OwFfnRcvlk+TMLzL4UT\n\tszT2jHPlKH9e/mqHNB8AOYM4N6FjYbtVPUpS+46ua2JtEcWMfSMudHLJFuGt8LSZljWs\n\tiJWQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=J78ssP8XqNBEIHkUfgel2dcYRu7rrWnGoQ26Y5QFRmE=;\n\tb=eIViybXohtSPd1ZgJ7RMRx6KGdJ6hp00C6fzlt5HRMQ8NzGFZIWOh+DOIn2h7z1+4C\n\t9Klb6JKn/8XbUfZRtC5p8jJ+RNgi2iYZ4lt1PsC0s/lCdMOXfQfI0sHjjOaJiWQpgbJW\n\tw9ORiyDh4L5xWcYujEPQy0vsJwsQjfqls65Ye6WZ07ft5Dlf4/XpopaHQLPPWGJbmw86\n\tpPpL0JXjDl3ZEl41gHMt81JmLbs8wb7J0c1F6qE3bTs60cuvGyKIF36QX0FH0/Fris2J\n\tEHwVPSFn++/9LSjShl+jmmXbH2yyXYDMNUazFhwzeK1Ck62BMoqRF1M5lfDHIFD/rGvW\n\t1+AA==","X-Gm-Message-State":"AHPjjUgCPms8cumzbBupi1KbHHFhXyVH66JEyVp5R5cusm4cElRVQWmf\n\tkFznvvYb/Knsy9wHuQNTrCbaMqmuJdl4grKX0G4=","X-Google-Smtp-Source":"AOwi7QB6xsXQ8uLqCStU6rhhjVZuEEHUYl5ExzA2YeFL1WLQ3JHR1SbTnQntj8knFo7VnuUpKahBrbX0xZO/fkikhSk=","X-Received":"by 10.202.67.6 with SMTP id q6mr5000398oia.201.1506055539477;\n\tThu, 21 Sep 2017 21:45:39 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170921072737.lkk7gzgjxxigoaji@flea>","References":"<20170921060704.19153-1-anarsoul@gmail.com>\n\t<20170921060704.19153-4-anarsoul@gmail.com>\n\t<20170921072737.lkk7gzgjxxigoaji@flea>","From":"Vasily Khoruzhick ","Date":"Thu, 21 Sep 2017 21:45:19 -0700","Message-ID":"","To":"Maxime Ripard ","Cc":"Andre Przywara , Jagan Teki ,\n\ticenowy@aosc.io, u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH v2 3/3] dts: sunxi: add PWM node for sun50i","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1773331,"web_url":"http://patchwork.ozlabs.org/comment/1773331/","msgid":"","list_archive_url":null,"date":"2017-09-22T07:49:58","subject":"Re: [U-Boot] [PATCH v2 3/3] dts: sunxi: add PWM node for sun50i","submitter":{"id":61837,"url":"http://patchwork.ozlabs.org/api/people/61837/","name":"Andre Przywara","email":"andre.przywara@arm.com"},"content":"Hi Vasily,\n\nOn 22/09/17 05:45, Vasily Khoruzhick wrote:\n> On Thu, Sep 21, 2017 at 12:27 AM, Maxime Ripard\n> wrote:\n>> On Thu, Sep 21, 2017 at 06:07:04AM +0000, Vasily Khoruzhick wrote:\n>>> Add PWM definition to sun50i-a64.dtsi - it's compatible with PWM found on H3\n>>>\n>>> Signed-off-by: Vasily Khoruzhick \n>>> ---\n>>> v2: - drop 'sun50i-a64-pwm' compatible string and use 'sun8i-h3-pwm' instead,\n>>> since A64 PWM is compatible with one on H3\n>>>\n>>> arch/arm/dts/sun50i-a64.dtsi | 8 ++++++++\n>>> 1 file changed, 8 insertions(+)\n>>>\n>>> diff --git a/arch/arm/dts/sun50i-a64.dtsi b/arch/arm/dts/sun50i-a64.dtsi\n>>> index 65a344d9ce..00132855ff 100644\n>>> --- a/arch/arm/dts/sun50i-a64.dtsi\n>>> +++ b/arch/arm/dts/sun50i-a64.dtsi\n>>> @@ -319,6 +319,14 @@\n>>> };\n>>> };\n>>>\n>>> + pwm: pwm@01c21400 {\n>>> + compatible = \"allwinner,sun8i-h3-pwm\";\n>>\n>> You'd need both compatible. The A64 you used to have, plus that one.\n> \n> Why? Hardware seems to be identical and I see a number of non-A64\n> compatibles in sun50i-a64.dtsi.\n> What's rationale behind adding a new string?\n\nTwo reasons:\n1) The DT should say what it is, namely the PWM controller in the A64 SoC.\n2) We don't know *for sure* that's really identical. It seems to be from\n*our* driver's perspective, but there might be bugs in this particular\nimplementation or some specialities. Should we discover this (in the\nfuture), we can add the special handling to the driver and bind it to\nthis compatible string. But the DT does not need any change. Which is\ngood, because it's supposed to live in the firmware.\n\nSo it should read:\n\t\t\tcompatible = \"allwinner,sun50i-a64-pwm\",\n\t\t\t\t \"allwinner,sun8i-h3-pwm\";\n\nThe DT parsing code won't find a match for the first string, but then\nfall back on trying the second (or third, ...).\n\nThe only thing that would need to be done is to add this new string to\nthe binding documentation, mainly to reserve the name.\n\nCheers,\nAndre.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz5HK2qHzz9s83\n\tfor ;\n\tFri, 22 Sep 2017 17:50:05 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid EB316C21FDA; Fri, 22 Sep 2017 07:49:55 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 9B99FC21E0E;\n\tFri, 22 Sep 2017 07:49:52 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 45CC2C21E0E; Fri, 22 Sep 2017 07:49:51 +0000 (UTC)","from foss.arm.com (foss.arm.com [217.140.101.70])\n\tby lists.denx.de (Postfix) with ESMTP id 9157BC21C8F\n\tfor ; Fri, 22 Sep 2017 07:49:50 +0000 (UTC)","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8EF2C15BE;\n\tFri, 22 Sep 2017 00:49:49 -0700 (PDT)","from [192.168.67.35] (usa-sjc-imap-foss1.foss.arm.com\n\t[10.72.51.249])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t7B0553F58C; Fri, 22 Sep 2017 00:49:48 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI\n\tautolearn=unavailable autolearn_force=no version=3.4.0","To":"Vasily Khoruzhick ,\n\tMaxime Ripard ","References":"<20170921060704.19153-1-anarsoul@gmail.com>\n\t<20170921060704.19153-4-anarsoul@gmail.com>\n\t<20170921072737.lkk7gzgjxxigoaji@flea>\n\t","From":"Andre Przywara ","Message-ID":"","Date":"Fri, 22 Sep 2017 08:49:58 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Cc":"u-boot@lists.denx.de, Jagan Teki , icenowy@aosc.io","Subject":"Re: [U-Boot] [PATCH v2 3/3] dts: sunxi: add PWM node for sun50i","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]