[{"id":1773572,"web_url":"http://patchwork.ozlabs.org/comment/1773572/","msgid":"","list_archive_url":null,"date":"2017-09-22T13:03:45","subject":"Re: [PATCH 2/2] pinctrl: single: Allow indicating loss of pin states\n\tduring low-power","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Thu, Sep 21, 2017 at 3:04 AM, Florian Fainelli wrote:\n\n> Some platforms (e.g: Broadcom STB: BMIPS_GENERIC/ARCH_BRCMSTB) will lose\n> their register contents when entering their lower power state. In such a\n> case, the pinctrl-single driver that is used will not be able to restore\n> the power states without telling the core about it and having\n> pinctrl_select_state() check for that.\n>\n> This patch adds a new optional boolean property that Device Tree can\n> define in order to obtain exactly that and having the core pinctrl code\n> take that into account.\n>\n> Signed-off-by: Florian Fainelli \n\nIf we use this per-controller approach rather than the per-state approach\nI discuss in reply to patch 1/2, we should probably make it a generic\nproperty for pin controllers and not just a pinctrl-single business.\n\nSo patch pinctrl-bindings.txt and put the code somewhere in\ncore.\n\nBut that is more of a detail, first we need to figure out how to\nhandle this business in general.\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"WtIu3f2+\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzDFL51Gzz9s9Y\n\tfor ;\n\tFri, 22 Sep 2017 23:03:49 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752013AbdIVNDr (ORCPT );\n\tFri, 22 Sep 2017 09:03:47 -0400","from mail-it0-f54.google.com ([209.85.214.54]:45152 \"EHLO\n\tmail-it0-f54.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751876AbdIVNDq (ORCPT\n\t); Fri, 22 Sep 2017 09:03:46 -0400","by mail-it0-f54.google.com with SMTP id x15so1272306itb.0\n\tfor ;\n\tFri, 22 Sep 2017 06:03:46 -0700 (PDT)","by 10.79.164.78 with HTTP; Fri, 22 Sep 2017 06:03:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=gZvcUpN2q248cWpYykTDHA+66ABZzTJNDzrN5kXTWA4=;\n\tb=WtIu3f2+6aTEF/S6yEDTvvPxf3ZnmWCM8rTnXAFsv9D6Mupnv+xogYFJXetsbELbya\n\ttrnUEFBYY6V0aUgnL8hkZIiwxgtRu/6ypAKk8kjXsaDd9JxhIlRuj1UmjW1PpbC+67lt\n\tgIX1hGhjRc1MMbHQU15eQ+14JYB+xsGmgyf1U=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=gZvcUpN2q248cWpYykTDHA+66ABZzTJNDzrN5kXTWA4=;\n\tb=uHHAt6wp3NjKY6XqECWke22HMDKR4Ae0bZhbl6vAebMpgsj1D63FYjYj2HEzU6c3Xn\n\tK9wDH8PrZWvPMxBQ5lfLKOhm3ttpyIbA4TPBRwb/3zbo44Z2EHwM/BI+THcLosiUqubS\n\tssnFte4X785J7+Rr+tdPTW2YI+jmTxynUeNyyHd+S456PyFLM/mwEtgNZSgI+346bnOA\n\t0kzOkNsuQR5gjaoWYYCDWPSNbzfD1vXaBn8oVRa7s7vLp91oLYU0CAsd0qGEMmjd3oxF\n\tzDyPzdNpq5azEGjHeOmQT0Q84u45i4JeH0VVK1zfd/GsRppkdbRI2w9EgWNeum9hY3Pp\n\tu0Xg==","X-Gm-Message-State":"AHPjjUixGf1/rewBLvDcshL8vQzlBu8mfge0vbacVdjo08Z03VA+F1/P\n\tO8CVWcim9A2LIzPfIkOEzruXf9oRACgUNP02Epe3ow==","X-Google-Smtp-Source":"AOwi7QDedJzLwxn3usISRZukmuXmqFTxdXLeXzzfj3OcyCZQao2QquFDfnDRZEbM5qre5GU8iAti2B4Rblus8c5Vwm4=","X-Received":"by 10.36.167.5 with SMTP id a5mr6055190itf.69.1506085425973; Fri,\n\t22 Sep 2017 06:03:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170921010421.7467-3-f.fainelli@gmail.com>","References":"<20170921010421.7467-1-f.fainelli@gmail.com>\n\t<20170921010421.7467-3-f.fainelli@gmail.com>","From":"Linus Walleij ","Date":"Fri, 22 Sep 2017 15:03:45 +0200","Message-ID":"","Subject":"Re: [PATCH 2/2] pinctrl: single: Allow indicating loss of pin states\n\tduring low-power","To":"Florian Fainelli ,\n\text Tony Lindgren ","Cc":"\"linux-kernel@vger.kernel.org\" ,\n\tStephen Warren ,\n\tAndy Shevchenko ,\n\tAl Cooper ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tRob Herring , Mark Rutland ,\n\tbcm-kernel-feedback-list ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1774935,"web_url":"http://patchwork.ozlabs.org/comment/1774935/","msgid":"<2905a73d-2e73-e590-12a2-f7af7ac83b9e@gmail.com>","list_archive_url":null,"date":"2017-09-25T19:15:49","subject":"Re: [PATCH 2/2] pinctrl: single: Allow indicating loss of pin states\n\tduring low-power","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/22/2017 06:03 AM, Linus Walleij wrote:\n> On Thu, Sep 21, 2017 at 3:04 AM, Florian Fainelli wrote:\n> \n>> Some platforms (e.g: Broadcom STB: BMIPS_GENERIC/ARCH_BRCMSTB) will lose\n>> their register contents when entering their lower power state. In such a\n>> case, the pinctrl-single driver that is used will not be able to restore\n>> the power states without telling the core about it and having\n>> pinctrl_select_state() check for that.\n>>\n>> This patch adds a new optional boolean property that Device Tree can\n>> define in order to obtain exactly that and having the core pinctrl code\n>> take that into account.\n>>\n>> Signed-off-by: Florian Fainelli \n> \n> If we use this per-controller approach rather than the per-state approach\n> I discuss in reply to patch 1/2, we should probably make it a generic\n> property for pin controllers and not just a pinctrl-single business.\n\nI suppose it makes sense to make this a generic pinctrl property then.\ndrivers/pinctrl/core.c does not appear to be trying to fetch any\nproperties for a pinctrl device, but that is probably not too hard to add.\n\n> \n> So patch pinctrl-bindings.txt and put the code somewhere in\n> core.\n> \n> But that is more of a detail, first we need to figure out how to\n> handle this business in general.\n\nFair enough.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Lwy57w11\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1DMY59lHz9sRq\n\tfor ;\n\tTue, 26 Sep 2017 05:16:09 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S936012AbdIYTP4 (ORCPT );\n\tMon, 25 Sep 2017 15:15:56 -0400","from mail-qk0-f193.google.com ([209.85.220.193]:34681 \"EHLO\n\tmail-qk0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S934555AbdIYTPy (ORCPT\n\t); Mon, 25 Sep 2017 15:15:54 -0400","by mail-qk0-f193.google.com with SMTP id d70so5455860qkc.1;\n\tMon, 25 Sep 2017 12:15:54 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tl89sm5678998qkh.69.2017.09.25.12.15.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 12:15:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=S/mLUDqXq72/DJi0Y7I4ZKQYwGAV8lkS/p3upN01Vek=;\n\tb=Lwy57w11Vk/LJVgnDbknf1IZ60iO6nkhdyf43N1tSAdTF3RSVlVKzsmcsKQZC13Gi8\n\t9Kiw8XA1XTyK6Fsgct/I8bgkbaCT7Cy3kFpFPJaNF7rb72pW6MYA/HEAnnN2BdjEfMkG\n\tqFZQniFoXvS0xbpB3nJl2+d8+oG0oseuzHkILt4NsequKJfxL5rEdsujr6OMBXB4TffH\n\tvPdjUeXxi7l7pbfyaNTkRdXtXc1bf0kIdKN4isBB+R7PXB8O38c9bag2a+H0ltxhGxnd\n\tsUopAknNUUoK+3uUFumXmuVQN6golXYox+f1o+5/QyHt8MlQ1E2o9anespzklF+LtVfZ\n\tRquQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=S/mLUDqXq72/DJi0Y7I4ZKQYwGAV8lkS/p3upN01Vek=;\n\tb=qJ3ylcChrO3AL874HUiwuku8N8Og0LoGL/Y+/nPilBFbr2GoZiKax7F2Gs+BZEJ0QW\n\tWMJOWzEgCgvrprbz+L+OLY28cGudzvJttMd/LWDyq2BYS+M0uY9PXl8jYsBTxM76+XZ9\n\tjj5SNYLXJtG4SbS/KQeP7obaQbltwXWuVkihC2I+XEWA1zbYhMhuq6vAafhnebl5pQZa\n\tFXLiAPRQo9BEJwUE2clLcZxyxAo+CFXKiVo4U19nhxqOca5+1N+5uJf3MlQirBaeKZyl\n\tvzRf1sIFnazlx3GHUZMHxsSagXqnBjWeOZsMiEDZLum2izvWnnPtSTd5j5c0i6Zxtj6d\n\tfOUw==","X-Gm-Message-State":"AHPjjUjr66xg04Uf0GJzaEDFFl9v/pvUJjMFQETM8oO1AFtFqT2KMTs1\n\tIHVselRUdTkS0Q3WJfygc94=","X-Google-Smtp-Source":"AOwi7QAS8Woy3TTYDdcjw5/RL5u2hoIq5FavyrGCcmLfj3NSnYzimqNsh0lCM7e9t7I2UN+5SwSTZg==","X-Received":"by 10.55.134.68 with SMTP id i65mr12037668qkd.192.1506366954059; \n\tMon, 25 Sep 2017 12:15:54 -0700 (PDT)","Subject":"Re: [PATCH 2/2] pinctrl: single: Allow indicating loss of pin states\n\tduring low-power","To":"Linus Walleij ,\n\tFlorian Fainelli ,\n\text Tony Lindgren ","Cc":"\"linux-kernel@vger.kernel.org\" ,\n\tStephen Warren ,\n\tAndy Shevchenko ,\n\tAl Cooper ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tRob Herring , Mark Rutland ,\n\tbcm-kernel-feedback-list ","References":"<20170921010421.7467-1-f.fainelli@gmail.com>\n\t<20170921010421.7467-3-f.fainelli@gmail.com>\n\t","From":"Florian Fainelli ","Message-ID":"<2905a73d-2e73-e590-12a2-f7af7ac83b9e@gmail.com>","Date":"Mon, 25 Sep 2017 12:15:49 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]