[{"id":1778936,"web_url":"http://patchwork.ozlabs.org/comment/1778936/","msgid":"<20171003125940.6d5fyhwx2lkzxn67@dhcp22.suse.cz>","date":"2017-10-03T12:59:40","subject":"Re: [PATCH v9 04/12] sparc64: simplify vmemmap_populate","submitter":{"id":66979,"url":"http://patchwork.ozlabs.org/api/people/66979/","name":"Michal Hocko","email":"mhocko@kernel.org"},"content":"On Wed 20-09-17 16:17:06, Pavel Tatashin wrote:\n> Remove duplicating code by using common functions\n> vmemmap_pud_populate and vmemmap_pgd_populate.\n> \n> Signed-off-by: Pavel Tatashin \n> Reviewed-by: Steven Sistare \n> Reviewed-by: Daniel Jordan \n> Reviewed-by: Bob Picco \n> Acked-by: David S. Miller \n\nAcked-by: Michal Hocko \n\n> ---\n> arch/sparc/mm/init_64.c | 23 ++++++-----------------\n> 1 file changed, 6 insertions(+), 17 deletions(-)\n> \n> diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c\n> index 310c6754bcaa..99aea4d15a5f 100644\n> --- a/arch/sparc/mm/init_64.c\n> +++ b/arch/sparc/mm/init_64.c\n> @@ -2651,30 +2651,19 @@ int __meminit vmemmap_populate(unsigned long vstart, unsigned long vend,\n> \tvstart = vstart & PMD_MASK;\n> \tvend = ALIGN(vend, PMD_SIZE);\n> \tfor (; vstart < vend; vstart += PMD_SIZE) {\n> -\t\tpgd_t *pgd = pgd_offset_k(vstart);\n> +\t\tpgd_t *pgd = vmemmap_pgd_populate(vstart, node);\n> \t\tunsigned long pte;\n> \t\tpud_t *pud;\n> \t\tpmd_t *pmd;\n> \n> -\t\tif (pgd_none(*pgd)) {\n> -\t\t\tpud_t *new = vmemmap_alloc_block(PAGE_SIZE, node);\n> +\t\tif (!pgd)\n> +\t\t\treturn -ENOMEM;\n> \n> -\t\t\tif (!new)\n> -\t\t\t\treturn -ENOMEM;\n> -\t\t\tpgd_populate(&init_mm, pgd, new);\n> -\t\t}\n> -\n> -\t\tpud = pud_offset(pgd, vstart);\n> -\t\tif (pud_none(*pud)) {\n> -\t\t\tpmd_t *new = vmemmap_alloc_block(PAGE_SIZE, node);\n> -\n> -\t\t\tif (!new)\n> -\t\t\t\treturn -ENOMEM;\n> -\t\t\tpud_populate(&init_mm, pud, new);\n> -\t\t}\n> +\t\tpud = vmemmap_pud_populate(pgd, vstart, node);\n> +\t\tif (!pud)\n> +\t\t\treturn -ENOMEM;\n> \n> \t\tpmd = pmd_offset(pud, vstart);\n> -\n> \t\tpte = pmd_val(*pmd);\n> \t\tif (!(pte & _PAGE_VALID)) {\n> \t\t\tvoid *block = vmemmap_alloc_block(PMD_SIZE, node);\n> -- \n> 2.14.1","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5zgH1rRXz9s03\n\tfor ;\n\tWed, 4 Oct 2017 00:01:15 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3y5zgH1460zDql8\n\tfor ;\n\tWed, 4 Oct 2017 00:01:15 +1100 (AEDT)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\t(using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3y5zdX07XFzDqNm\n\tfor ;\n\tTue, 3 Oct 2017 23:59:44 +1100 (AEDT)","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id F0CBBAD6D;\n\tTue, 3 Oct 2017 12:59:40 +0000 (UTC)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=kernel.org\n\t(client-ip=195.135.220.15; helo=mx1.suse.de;\n\tenvelope-from=mhocko@kernel.org; receiver=)","X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","Date":"Tue, 3 Oct 2017 14:59:40 +0200","From":"Michal Hocko ","To":"Pavel Tatashin ","Subject":"Re: [PATCH v9 04/12] sparc64: simplify vmemmap_populate","Message-ID":"<20171003125940.6d5fyhwx2lkzxn67@dhcp22.suse.cz>","References":"<20170920201714.19817-1-pasha.tatashin@oracle.com>\n\t<20170920201714.19817-5-pasha.tatashin@oracle.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170920201714.19817-5-pasha.tatashin@oracle.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mark.rutland@arm.com, linux-s390@vger.kernel.org,\n\tard.biesheuvel@linaro.org, \n\tmgorman@techsingularity.net, sam@ravnborg.org, borntraeger@de.ibm.com,\n\twill.deacon@arm.com, x86@kernel.org, heiko.carstens@de.ibm.com,\n\tlinux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,\n\tdaniel.m.jordan@oracle.com, linux-mm@kvack.org,\n\tsteven.sistare@oracle.com, willy@infradead.org, catalin.marinas@arm.com,\n\tsparclinux@vger.kernel.org, \n\tbob.picco@oracle.com, linuxppc-dev@lists.ozlabs.org,\n\tdavem@davemloft.net, linux-arm-kernel@lists.infradead.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1779073,"web_url":"http://patchwork.ozlabs.org/comment/1779073/","msgid":"<8104d3da-7905-e888-eb6a-223ecf237ca1@oracle.com>","date":"2017-10-03T15:20:53","subject":"Re: [PATCH v9 04/12] sparc64: simplify vmemmap_populate","submitter":{"id":71010,"url":"http://patchwork.ozlabs.org/api/people/71010/","name":"Pavel Tatashin","email":"pasha.tatashin@oracle.com"},"content":"> \n> Acked-by: Michal Hocko \n\nThank you,\nPasha","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y62qL46bWz9sPk\n\tfor ;\n\tWed, 4 Oct 2017 02:23:26 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3y62qL2dFJzDql4\n\tfor ;\n\tWed, 4 Oct 2017 02:23:26 +1100 (AEDT)","from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3y62nf3sx9zDql4\n\tfor ;\n\tWed, 4 Oct 2017 02:21:58 +1100 (AEDT)","from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id v93FKvvT002318\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 3 Oct 2017 15:20:57 GMT","from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n\tby aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv93FKver017219\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 3 Oct 2017 15:20:57 GMT","from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25])\n\tby aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv93FKuJQ004042; Tue, 3 Oct 2017 15:20:56 GMT","from [192.168.1.10] (/98.216.35.41)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Tue, 03 Oct 2017 15:20:56 +0000"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=oracle.com\n\t(client-ip=141.146.126.69; helo=aserp1040.oracle.com;\n\tenvelope-from=pasha.tatashin@oracle.com; receiver=)","Subject":"Re: [PATCH v9 04/12] sparc64: simplify vmemmap_populate","To":"Michal Hocko ","References":"<20170920201714.19817-1-pasha.tatashin@oracle.com>\n\t<20170920201714.19817-5-pasha.tatashin@oracle.com>\n\t<20171003125940.6d5fyhwx2lkzxn67@dhcp22.suse.cz>","From":"Pasha Tatashin ","Message-ID":"<8104d3da-7905-e888-eb6a-223ecf237ca1@oracle.com>","Date":"Tue, 3 Oct 2017 11:20:53 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20171003125940.6d5fyhwx2lkzxn67@dhcp22.suse.cz>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Source-IP":"aserv0022.oracle.com [141.146.126.234]","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mark.rutland@arm.com, linux-s390@vger.kernel.org,\n\tard.biesheuvel@linaro.org, \n\tmgorman@techsingularity.net, sam@ravnborg.org, borntraeger@de.ibm.com,\n\twill.deacon@arm.com, x86@kernel.org, heiko.carstens@de.ibm.com,\n\tlinux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,\n\tdaniel.m.jordan@oracle.com, linux-mm@kvack.org,\n\tsteven.sistare@oracle.com, willy@infradead.org, catalin.marinas@arm.com,\n\tsparclinux@vger.kernel.org, \n\tbob.picco@oracle.com, linuxppc-dev@lists.ozlabs.org,\n\tdavem@davemloft.net, linux-arm-kernel@lists.infradead.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]